)]}'
{"/COMMIT_MSG":[{"author":{"_account_id":17716,"name":"Luz Cazares","email":"luz.cazares@intel.com","username":"luzcazares"},"change_message_id":"bb82f8f03e4dd1ae263b0ed3a7a22f42a7ebfd87","unresolved":false,"context_lines":[{"line_number":10,"context_line":"to be updated. The following patch updates the Neutron subnetpool"},{"line_number":11,"context_line":"test case to be in sync with the requirements targetted in [1]."},{"line_number":12,"context_line":""},{"line_number":13,"context_line":"[1]: https://review.openstack.org/447983"},{"line_number":14,"context_line":""},{"line_number":15,"context_line":"Change-Id: Ic053b8b10de32ca798b61c3af92ece0a6959835d"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":3,"id":"1a1ced50_f83cdec9","line":13,"range":{"start_line":13,"start_character":5,"end_line":13,"end_character":40},"updated":"2017-03-21 17:21:17.000000000","message":"Make it depends-on","commit_id":"eeb5ccb5dc7f34494e051c504a6468a6ab3aace0"},{"author":{"_account_id":5689,"name":"Masayuki Igawa","email":"masayuki@igawa.io","username":"igawa"},"change_message_id":"399905214fa832d30805582bc7b64cd7aeec6226","unresolved":false,"context_lines":[{"line_number":10,"context_line":"to be updated. The following patch updates the Neutron subnetpool"},{"line_number":11,"context_line":"test case to be in sync with the requirements targetted in [1]."},{"line_number":12,"context_line":""},{"line_number":13,"context_line":"[1]: https://review.openstack.org/447983"},{"line_number":14,"context_line":""},{"line_number":15,"context_line":"Change-Id: Ic053b8b10de32ca798b61c3af92ece0a6959835d"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":4,"id":"1a1ced50_9dd025f8","line":13,"updated":"2017-03-22 06:22:11.000000000","message":"If this change is needed for the neutron patch, why don\u0027t you put a \"Depends-On\" for it?\nAnd I think we prefer a Change-Id rather than gerrit URL.","commit_id":"80a9007f6a9071176dacfa2b805af348dc39b85f"}],"tempest/api/network/test_subnetpools_extensions.py":[{"author":{"_account_id":7350,"name":"Jordan Pittier","email":"jordan.pittier@gmail.com","username":"JordanP"},"change_message_id":"acb635be7d0bfbb08a1aebfb2fecf7d555a2efae","unresolved":false,"context_lines":[{"line_number":51,"context_line":"    def test_create_list_show_update_delete_subnetpools(self):"},{"line_number":52,"context_line":"        subnetpool_name \u003d data_utils.rand_name(\u0027subnetpools\u0027)"},{"line_number":53,"context_line":"        # create subnet pool"},{"line_number":54,"context_line":"        prefix \u003dPREFI_LENGTH"},{"line_number":55,"context_line":"        body \u003d self.subnetpools_client.create_subnetpool(name\u003dsubnetpool_name,"},{"line_number":56,"context_line":"                                                         prefixes\u003dprefix)"},{"line_number":57,"context_line":"        subnetpool_id \u003d body[\"subnetpool\"][\"id\"]"}],"source_content_type":"text/x-python","patch_set":1,"id":"1a1ced50_32d2295d","line":54,"updated":"2017-03-21 10:50:29.000000000","message":"typo. It\u0027s usually best practice to read one\u0027s entire commit before doing \"git review\". This save time for reviewers.","commit_id":"e21bd5b53a51f6d6839cb958ab3dfabaf81c5c70"},{"author":{"_account_id":17776,"name":"Reedip","email":"reedip.banerjee@gmail.com","username":"Reedip"},"change_message_id":"ffe2c35bf64985919e38980c748cf5303a6b5f63","unresolved":false,"context_lines":[{"line_number":51,"context_line":"    def test_create_list_show_update_delete_subnetpools(self):"},{"line_number":52,"context_line":"        subnetpool_name \u003d data_utils.rand_name(\u0027subnetpools\u0027)"},{"line_number":53,"context_line":"        # create subnet pool"},{"line_number":54,"context_line":"        prefix \u003dPREFI_LENGTH"},{"line_number":55,"context_line":"        body \u003d self.subnetpools_client.create_subnetpool(name\u003dsubnetpool_name,"},{"line_number":56,"context_line":"                                                         prefixes\u003dprefix)"},{"line_number":57,"context_line":"        subnetpool_id \u003d body[\"subnetpool\"][\"id\"]"}],"source_content_type":"text/x-python","patch_set":1,"id":"1a1ced50_0bc7b864","line":54,"in_reply_to":"1a1ced50_32d2295d","updated":"2017-09-20 09:41:41.000000000","message":"Yup, you are right...\nAnd since this was a small change, this should not have happened...","commit_id":"e21bd5b53a51f6d6839cb958ab3dfabaf81c5c70"},{"author":{"_account_id":17716,"name":"Luz Cazares","email":"luz.cazares@intel.com","username":"luzcazares"},"change_message_id":"bb82f8f03e4dd1ae263b0ed3a7a22f42a7ebfd87","unresolved":false,"context_lines":[{"line_number":52,"context_line":"        # create subnet pool"},{"line_number":53,"context_line":"        prefix \u003d PREFIX_LENGTH"},{"line_number":54,"context_line":"        body \u003d self.subnetpools_client.create_subnetpool(name\u003dsubnetpool_name,"},{"line_number":55,"context_line":"                                                         prefixes\u003dprefix)"},{"line_number":56,"context_line":"        subnetpool_id \u003d body[\"subnetpool\"][\"id\"]"},{"line_number":57,"context_line":"        self.addCleanup(test_utils.call_and_ignore_notfound_exc,"},{"line_number":58,"context_line":"                        self.subnetpools_client.delete_subnetpool,"}],"source_content_type":"text/x-python","patch_set":3,"id":"1a1ced50_d829e238","line":55,"range":{"start_line":55,"start_character":57,"end_line":55,"end_character":65},"updated":"2017-03-21 17:21:17.000000000","message":"prefixes parameter is different from default_prefixlen\nhttps://developer.openstack.org/api-ref/networking/v2/?expanded\u003dcreate-subnet-pool-detail#create-subnet-pool","commit_id":"eeb5ccb5dc7f34494e051c504a6468a6ab3aace0"},{"author":{"_account_id":5689,"name":"Masayuki Igawa","email":"masayuki@igawa.io","username":"igawa"},"change_message_id":"399905214fa832d30805582bc7b64cd7aeec6226","unresolved":false,"context_lines":[{"line_number":52,"context_line":"        prefix \u003d config.CONF.network.default_network"},{"line_number":53,"context_line":"        body \u003d self.subnetpools_client.create_subnetpool(name\u003dsubnetpool_name,"},{"line_number":54,"context_line":"                                                         prefixes\u003dprefix,"},{"line_number":55,"context_line":"                                                         default_prefixlen\u003d8)"},{"line_number":56,"context_line":"        subnetpool_id \u003d body[\"subnetpool\"][\"id\"]"},{"line_number":57,"context_line":"        self.addCleanup(test_utils.call_and_ignore_notfound_exc,"},{"line_number":58,"context_line":"                        self.subnetpools_client.delete_subnetpool,"}],"source_content_type":"text/x-python","patch_set":4,"id":"1a1ced50_bdd96124","line":55,"updated":"2017-03-22 06:22:11.000000000","message":"I think it would be good to add a \"NOTE\" to explain the reason why we need to specify this \u0027default_prefixlen\u003d8\u0027 here. Otherwise, we might be confused with this parameter and this magic number.","commit_id":"80a9007f6a9071176dacfa2b805af348dc39b85f"},{"author":{"_account_id":1921,"name":"Andrea Frittoli","email":"andrea.frittoli@gmail.com","username":"andrea-frittoli"},"change_message_id":"81fb56fe99e539e12c35b8b9ab1abff975dea373","unresolved":false,"context_lines":[{"line_number":20,"context_line":"from tempest.lib import exceptions as lib_exc"},{"line_number":21,"context_line":"from tempest import test"},{"line_number":22,"context_line":""},{"line_number":23,"context_line":"CONF \u003d config.CONF"},{"line_number":24,"context_line":""},{"line_number":25,"context_line":""},{"line_number":26,"context_line":"class SubnetPoolsTestJSON(base.BaseNetworkTest):"}],"source_content_type":"text/x-python","patch_set":5,"id":"ffe62b97_7ed99581","side":"PARENT","line":23,"range":{"start_line":23,"start_character":0,"end_line":23,"end_character":18},"updated":"2017-03-24 12:36:06.000000000","message":"Removing this is an unrelated change.\nBesides all of our tests use this, so I\u0027d rather keep it for consistency.","commit_id":"24f5751aa6daf177514817ba706b90b59aaf6b04"},{"author":{"_account_id":1921,"name":"Andrea Frittoli","email":"andrea.frittoli@gmail.com","username":"andrea-frittoli"},"change_message_id":"81fb56fe99e539e12c35b8b9ab1abff975dea373","unresolved":false,"context_lines":[{"line_number":52,"context_line":"        prefix \u003d config.CONF.network.default_network"},{"line_number":53,"context_line":"        # NOTE : Modification in Neutron now requires DefaultPrefixLength to"},{"line_number":54,"context_line":"        # be greater than the subnetpool prefix, therefore the"},{"line_number":55,"context_line":"        # DefaultPrefixLenght is set to 8"},{"line_number":56,"context_line":"        body \u003d self.subnetpools_client.create_subnetpool(name\u003dsubnetpool_name,"},{"line_number":57,"context_line":"                                                         prefixes\u003dprefix,"},{"line_number":58,"context_line":"                                                         default_prefixlen\u003d8)"}],"source_content_type":"text/x-python","patch_set":5,"id":"ffe62b97_be139d0d","line":55,"range":{"start_line":55,"start_character":7,"end_line":55,"end_character":41},"updated":"2017-03-24 12:36:06.000000000","message":"Can you elaborate on where number 8 comes from?","commit_id":"8e0ee2c460b61fde459d5bf6a370c647b87c6fd7"},{"author":{"_account_id":8556,"name":"Ghanshyam Maan","display_name":"Ghanshyam Maan","email":"gmaan.os14@gmail.com","username":"ghanshyam"},"change_message_id":"716eab5eec0390bc3830adfaa27ebb16e0844b3d","unresolved":false,"context_lines":[{"line_number":57,"context_line":"        # DefaultPrefixLenght is set to 8"},{"line_number":58,"context_line":"        body \u003d self.subnetpools_client.create_subnetpool(name\u003dsubnetpool_name,"},{"line_number":59,"context_line":"                                                         prefixes\u003dprefix,"},{"line_number":60,"context_line":"                                                         default_prefixlen\u003d8)"},{"line_number":61,"context_line":"        subnetpool_id \u003d body[\"subnetpool\"][\"id\"]"},{"line_number":62,"context_line":"        self.addCleanup(test_utils.call_and_ignore_notfound_exc,"},{"line_number":63,"context_line":"                        self.subnetpools_client.delete_subnetpool,"}],"source_content_type":"text/x-python","patch_set":7,"id":"ffe62b97_56cff428","line":60,"range":{"start_line":60,"start_character":56,"end_line":60,"end_character":76},"updated":"2017-03-30 10:16:18.000000000","message":"as per API guide, default value itself is 8 for IPv4.","commit_id":"93b5dca885f5ad29362ddf150c0b3c2af931e2a8"}]}
