)]}'
{"tempest/api/volume/test_volumes_list.py":[{"author":{"_account_id":23186,"name":"Felipe Monteiro","email":"felipe.carneiro.monteiro@gmail.com","username":"felipe.monteiro"},"change_message_id":"80a006b49bd5cc8239d64cb8ecf79f39b18da31e","unresolved":false,"context_lines":[{"line_number":364,"context_line":"        marker \u003d random.choice(self.volume_id_list)"},{"line_number":365,"context_line":""},{"line_number":366,"context_line":"        # Though Cinder volumes are returned sorted by ID by default"},{"line_number":367,"context_line":"        # this is implicit. Let make this explicit in case Cinder"},{"line_number":368,"context_line":"        # folks change their minds."},{"line_number":369,"context_line":"        params \u003d {\u0027marker\u0027: marker, \u0027sort\u0027: \u0027id:asc\u0027}"},{"line_number":370,"context_line":""}],"source_content_type":"text/x-python","patch_set":3,"id":"bff0334d_f3faa1ba","line":367,"range":{"start_line":367,"start_character":28,"end_line":367,"end_character":31},"updated":"2017-04-12 19:27:39.000000000","message":"Two options:\n1) Let\u0027s\n2) Remove \"Let\" and capitalize \"Make\"","commit_id":"fb35d22a7ace125c9f84addf291ef00376fc2900"}],"tempest/api/volume/v2/test_volumes_list.py":[{"author":{"_account_id":20190,"name":"zhufl","email":"zhu.fanglei@zte.com.cn","username":"zhufl"},"change_message_id":"dc95b5e83a7cb26a600980e687283ac51b9cc984","unresolved":false,"context_lines":[{"line_number":193,"context_line":""},{"line_number":194,"context_line":"        # Verify that all the fetched volumes have an ID greater than marker"},{"line_number":195,"context_line":"        for volume in vol_with_marker:"},{"line_number":196,"context_line":"            self.assertGreater(volume[\u0027id\u0027], random_volume_id)"}],"source_content_type":"text/x-python","patch_set":1,"id":"ffe62b97_62d0ebca","line":196,"range":{"start_line":196,"start_character":12,"end_line":196,"end_character":62},"updated":"2017-03-24 02:20:53.000000000","message":"This may miss the situation that \"all ids \u003c\u003d marker shouldn\u0027t appear in the result\"","commit_id":"cc1735a0b7e7d43ceb74b899450502ef87893264"},{"author":{"_account_id":7350,"name":"Jordan Pittier","email":"jordan.pittier@gmail.com","username":"JordanP"},"change_message_id":"697cb616c1b8c9a14c283925ed97f8728963139f","unresolved":false,"context_lines":[{"line_number":193,"context_line":""},{"line_number":194,"context_line":"        # Verify that all the fetched volumes have an ID greater than marker"},{"line_number":195,"context_line":"        for volume in vol_with_marker:"},{"line_number":196,"context_line":"            self.assertGreater(volume[\u0027id\u0027], random_volume_id)"}],"source_content_type":"text/x-python","patch_set":1,"id":"ffe62b97_d03bf399","line":196,"range":{"start_line":196,"start_character":12,"end_line":196,"end_character":62},"in_reply_to":"ffe62b97_222423c6","updated":"2017-03-24 10:31:11.000000000","message":"I did test that extensively (I ran the test 10 times, with not only 3 created volumes in resource_setup but 10). It passed. \n\nCan you try to explain the issue with an example ? Like give a value for \"random_volume_id\" and the 3 volumes IDs that would cause a problem.","commit_id":"cc1735a0b7e7d43ceb74b899450502ef87893264"},{"author":{"_account_id":20190,"name":"zhufl","email":"zhu.fanglei@zte.com.cn","username":"zhufl"},"change_message_id":"61a74de0d04db04c40792d4d1e911dc0634487b6","unresolved":false,"context_lines":[{"line_number":193,"context_line":""},{"line_number":194,"context_line":"        # Verify that all the fetched volumes have an ID greater than marker"},{"line_number":195,"context_line":"        for volume in vol_with_marker:"},{"line_number":196,"context_line":"            self.assertGreater(volume[\u0027id\u0027], random_volume_id)"}],"source_content_type":"text/x-python","patch_set":1,"id":"ffe62b97_222423c6","line":196,"range":{"start_line":196,"start_character":12,"end_line":196,"end_character":62},"in_reply_to":"ffe62b97_62d0ebca","updated":"2017-03-24 02:27:58.000000000","message":"sorry for the misstatement, I mean, all ids \u003e marker should appear in the result, but if only part of such ids appear in the result, current code won\u0027t find it.","commit_id":"cc1735a0b7e7d43ceb74b899450502ef87893264"},{"author":{"_account_id":5689,"name":"Masayuki Igawa","email":"masayuki@igawa.io","username":"igawa"},"change_message_id":"a1efef87ba0edb467738bce709f7edb2834f3a17","unresolved":false,"context_lines":[{"line_number":55,"context_line":"            params \u003d {\u0027limit\u0027: limit,"},{"line_number":56,"context_line":"                      \u0027status\u0027: status,"},{"line_number":57,"context_line":"                      \u0027sort_dir\u0027: sort_dir,"},{"line_number":58,"context_line":"                      \u0027sort_key\u0027: sort_key"},{"line_number":59,"context_line":"                      }"},{"line_number":60,"context_line":"            fetched_volume \u003d self.volumes_client.list_volumes("},{"line_number":61,"context_line":"                detail\u003dTrue, params\u003dparams)[\u0027volumes\u0027]"}],"source_content_type":"text/x-python","patch_set":2,"id":"ffe62b97_fd40d537","line":58,"updated":"2017-03-27 05:52:22.000000000","message":"I\u0027m confused here. These \u0027sort_dir\u0027 and \u0027sort_key\u0027 are for v3 api, right?","commit_id":"02bb319c762877109b9ca6a2cd327b4426ccf8d2"},{"author":{"_account_id":1921,"name":"Andrea Frittoli","email":"andrea.frittoli@gmail.com","username":"andrea-frittoli"},"change_message_id":"e1e761e93d6a4549ebd16d91128375063daeaf81","unresolved":false,"context_lines":[{"line_number":55,"context_line":"            params \u003d {\u0027limit\u0027: limit,"},{"line_number":56,"context_line":"                      \u0027status\u0027: status,"},{"line_number":57,"context_line":"                      \u0027sort_dir\u0027: sort_dir,"},{"line_number":58,"context_line":"                      \u0027sort_key\u0027: sort_key"},{"line_number":59,"context_line":"                      }"},{"line_number":60,"context_line":"            fetched_volume \u003d self.volumes_client.list_volumes("},{"line_number":61,"context_line":"                detail\u003dTrue, params\u003dparams)[\u0027volumes\u0027]"}],"source_content_type":"text/x-python","patch_set":2,"id":"9ff52f3f_91133a67","line":58,"in_reply_to":"ffe62b97_ec7e34ae","updated":"2017-04-13 11:10:50.000000000","message":"Heh good catch, thank you","commit_id":"02bb319c762877109b9ca6a2cd327b4426ccf8d2"},{"author":{"_account_id":7350,"name":"Jordan Pittier","email":"jordan.pittier@gmail.com","username":"JordanP"},"change_message_id":"0423af819e62dab91868f8675fe1f03f7f68141b","unresolved":false,"context_lines":[{"line_number":55,"context_line":"            params \u003d {\u0027limit\u0027: limit,"},{"line_number":56,"context_line":"                      \u0027status\u0027: status,"},{"line_number":57,"context_line":"                      \u0027sort_dir\u0027: sort_dir,"},{"line_number":58,"context_line":"                      \u0027sort_key\u0027: sort_key"},{"line_number":59,"context_line":"                      }"},{"line_number":60,"context_line":"            fetched_volume \u003d self.volumes_client.list_volumes("},{"line_number":61,"context_line":"                detail\u003dTrue, params\u003dparams)[\u0027volumes\u0027]"}],"source_content_type":"text/x-python","patch_set":2,"id":"ffe62b97_ec7e34ae","line":58,"in_reply_to":"ffe62b97_fd40d537","updated":"2017-03-30 12:16:23.000000000","message":"No, sort_dir and sort_key are deprecated. The prefered way is to use \"sort\u003dkey:dir\" form. https://github.com/openstack/cinder/blob/6a0351ac47ae656fdf3e76c3d59df89042c068c4/cinder/api/common.py#L191","commit_id":"02bb319c762877109b9ca6a2cd327b4426ccf8d2"},{"author":{"_account_id":5689,"name":"Masayuki Igawa","email":"masayuki@igawa.io","username":"igawa"},"change_message_id":"a1efef87ba0edb467738bce709f7edb2834f3a17","unresolved":false,"context_lines":[{"line_number":180,"context_line":"    def test_volume_list_with_detail_param_marker(self):"},{"line_number":181,"context_line":"        # Choosing a random volume from a list of volumes for \u0027marker\u0027"},{"line_number":182,"context_line":"        # parameter"},{"line_number":183,"context_line":"        marker \u003d random.choice(self.volume_id_list)"},{"line_number":184,"context_line":""},{"line_number":185,"context_line":"        # Though Cinder volumes are returned sorted by ID by default"},{"line_number":186,"context_line":"        # this is implicit. Let make this explicit in case Cinder"}],"source_content_type":"text/x-python","patch_set":2,"id":"ffe62b97_dd3bd1c5","line":183,"updated":"2017-03-27 05:52:22.000000000","message":"I\u0027m actually unsure that why we use random.choice here. I feel this makes this test unstable. So I prefer to use a fixed number here like this:\n\n marker \u003d self.volume_id_list[-2]\n\nBut we can make it in a following patch.","commit_id":"02bb319c762877109b9ca6a2cd327b4426ccf8d2"},{"author":{"_account_id":1921,"name":"Andrea Frittoli","email":"andrea.frittoli@gmail.com","username":"andrea-frittoli"},"change_message_id":"139e05be690204e0e248bbd21714cf0dbb534490","unresolved":false,"context_lines":[{"line_number":180,"context_line":"    def test_volume_list_with_detail_param_marker(self):"},{"line_number":181,"context_line":"        # Choosing a random volume from a list of volumes for \u0027marker\u0027"},{"line_number":182,"context_line":"        # parameter"},{"line_number":183,"context_line":"        marker \u003d random.choice(self.volume_id_list)"},{"line_number":184,"context_line":""},{"line_number":185,"context_line":"        # Though Cinder volumes are returned sorted by ID by default"},{"line_number":186,"context_line":"        # this is implicit. Let make this explicit in case Cinder"}],"source_content_type":"text/x-python","patch_set":2,"id":"ffe62b97_2db7ab3c","line":183,"in_reply_to":"ffe62b97_4f72274b","updated":"2017-03-29 12:22:13.000000000","message":"This will test more cases across multiple runs, but it also affects reproducibility negatively. I would also be in slight more favour for a fixed choice, like a volume ID in the middle of the list or so.","commit_id":"02bb319c762877109b9ca6a2cd327b4426ccf8d2"},{"author":{"_account_id":20190,"name":"zhufl","email":"zhu.fanglei@zte.com.cn","username":"zhufl"},"change_message_id":"a0035b617a0cb8e5d5ff57282e6a91754a120f27","unresolved":false,"context_lines":[{"line_number":180,"context_line":"    def test_volume_list_with_detail_param_marker(self):"},{"line_number":181,"context_line":"        # Choosing a random volume from a list of volumes for \u0027marker\u0027"},{"line_number":182,"context_line":"        # parameter"},{"line_number":183,"context_line":"        marker \u003d random.choice(self.volume_id_list)"},{"line_number":184,"context_line":""},{"line_number":185,"context_line":"        # Though Cinder volumes are returned sorted by ID by default"},{"line_number":186,"context_line":"        # this is implicit. Let make this explicit in case Cinder"}],"source_content_type":"text/x-python","patch_set":2,"id":"ffe62b97_4f72274b","line":183,"in_reply_to":"ffe62b97_dd3bd1c5","updated":"2017-03-28 08:16:39.000000000","message":"I think to use a random value is not a bad idea. :)\nIt shouldn\u0027t make testcase \"unstable\"(if so, there must be something wrong with the system).\nAnd ramdom value can be used to test \"boundary value\", otherwise we will need more testcases/teststeps to cover it.","commit_id":"02bb319c762877109b9ca6a2cd327b4426ccf8d2"}]}