)]}'
{"tempest/api/compute/volumes/test_attach_volume.py":[{"author":{"_account_id":17716,"name":"Luz Cazares","email":"luz.cazares@intel.com","username":"luzcazares"},"change_message_id":"a4296a1e8798c752f19fdcd41ba5a1ca7e9c76d0","unresolved":false,"context_lines":[{"line_number":68,"context_line":""},{"line_number":69,"context_line":"        # NOTE(andreaf) Create one remote client used throughout the test."},{"line_number":70,"context_line":"        # It doesn\u0027t attempt to connect until validate_authentication"},{"line_number":71,"context_line":"        # or exec_command are invoked."},{"line_number":72,"context_line":"        if CONF.validation.run_validation:"},{"line_number":73,"context_line":"            linux_client \u003d remote_client.RemoteClient("},{"line_number":74,"context_line":"                self.get_server_ip(server),"}],"source_content_type":"text/x-python","patch_set":2,"id":"ffe62b97_fec6ba16","line":71,"range":{"start_line":71,"start_character":36,"end_line":71,"end_character":38},"updated":"2017-03-24 17:02:37.000000000","message":"add linux_client\u003dNone to prevent exeption \"referenced before assignment\" on LN87 when not validating","commit_id":"18721f0d23562cacba73367afccde0d217008427"},{"author":{"_account_id":1921,"name":"Andrea Frittoli","email":"andrea.frittoli@gmail.com","username":"andrea-frittoli"},"change_message_id":"da8b9c38ec623a942917a4187764bfaf120ec99a","unresolved":false,"context_lines":[{"line_number":68,"context_line":""},{"line_number":69,"context_line":"        # NOTE(andreaf) Create one remote client used throughout the test."},{"line_number":70,"context_line":"        # It doesn\u0027t attempt to connect until validate_authentication"},{"line_number":71,"context_line":"        # or exec_command are invoked."},{"line_number":72,"context_line":"        if CONF.validation.run_validation:"},{"line_number":73,"context_line":"            linux_client \u003d remote_client.RemoteClient("},{"line_number":74,"context_line":"                self.get_server_ip(server),"}],"source_content_type":"text/x-python","patch_set":2,"id":"ffe62b97_875d767a","line":71,"in_reply_to":"ffe62b97_52bd92b5","updated":"2017-03-29 11:55:35.000000000","message":"Yeah it\u0027s better to check config each time.","commit_id":"18721f0d23562cacba73367afccde0d217008427"},{"author":{"_account_id":13252,"name":"Dr. Jens Harbott","display_name":"Jens Harbott (frickler)","email":"frickler@offenerstapel.de","username":"jrosenboom"},"change_message_id":"d9be64a02a1ce9466af8b18963be11c7a8ca5a1d","unresolved":false,"context_lines":[{"line_number":68,"context_line":""},{"line_number":69,"context_line":"        # NOTE(andreaf) Create one remote client used throughout the test."},{"line_number":70,"context_line":"        # It doesn\u0027t attempt to connect until validate_authentication"},{"line_number":71,"context_line":"        # or exec_command are invoked."},{"line_number":72,"context_line":"        if CONF.validation.run_validation:"},{"line_number":73,"context_line":"            linux_client \u003d remote_client.RemoteClient("},{"line_number":74,"context_line":"                self.get_server_ip(server),"}],"source_content_type":"text/x-python","patch_set":2,"id":"ffe62b97_52bd92b5","line":71,"in_reply_to":"ffe62b97_fec6ba16","updated":"2017-03-24 18:51:13.000000000","message":"I rather moved back to using the original if statement again, hope Andrea agrees.","commit_id":"18721f0d23562cacba73367afccde0d217008427"},{"author":{"_account_id":17716,"name":"Luz Cazares","email":"luz.cazares@intel.com","username":"luzcazares"},"change_message_id":"a4296a1e8798c752f19fdcd41ba5a1ca7e9c76d0","unresolved":false,"context_lines":[{"line_number":85,"context_line":"        # NOTE(andreaf) When ssh validation is on, we need to ensure the"},{"line_number":86,"context_line":"        # ssh key has been injected in the guest before we power cycle"},{"line_number":87,"context_line":"        if linux_client:"},{"line_number":88,"context_line":"            linux_client.validate_authentication()"},{"line_number":89,"context_line":""},{"line_number":90,"context_line":"        self.servers_client.stop_server(server[\u0027id\u0027])"},{"line_number":91,"context_line":"        waiters.wait_for_server_status(self.servers_client, server[\u0027id\u0027],"}],"source_content_type":"text/x-python","patch_set":2,"id":"ffe62b97_9ea32e50","line":88,"range":{"start_line":88,"start_character":12,"end_line":88,"end_character":50},"updated":"2017-03-24 17:02:37.000000000","message":"can this be moved to LN80 - within CONF.validation.run_validation \"if statement\"","commit_id":"18721f0d23562cacba73367afccde0d217008427"},{"author":{"_account_id":13252,"name":"Dr. Jens Harbott","display_name":"Jens Harbott (frickler)","email":"frickler@offenerstapel.de","username":"jrosenboom"},"change_message_id":"d9be64a02a1ce9466af8b18963be11c7a8ca5a1d","unresolved":false,"context_lines":[{"line_number":85,"context_line":"        # NOTE(andreaf) When ssh validation is on, we need to ensure the"},{"line_number":86,"context_line":"        # ssh key has been injected in the guest before we power cycle"},{"line_number":87,"context_line":"        if linux_client:"},{"line_number":88,"context_line":"            linux_client.validate_authentication()"},{"line_number":89,"context_line":""},{"line_number":90,"context_line":"        self.servers_client.stop_server(server[\u0027id\u0027])"},{"line_number":91,"context_line":"        waiters.wait_for_server_status(self.servers_client, server[\u0027id\u0027],"}],"source_content_type":"text/x-python","patch_set":2,"id":"ffe62b97_52947237","line":88,"in_reply_to":"ffe62b97_9ea32e50","updated":"2017-03-24 18:51:13.000000000","message":"Done","commit_id":"18721f0d23562cacba73367afccde0d217008427"},{"author":{"_account_id":1921,"name":"Andrea Frittoli","email":"andrea.frittoli@gmail.com","username":"andrea-frittoli"},"change_message_id":"da8b9c38ec623a942917a4187764bfaf120ec99a","unresolved":false,"context_lines":[{"line_number":85,"context_line":"        # NOTE(andreaf) When ssh validation is on, we need to ensure the"},{"line_number":86,"context_line":"        # ssh key has been injected in the guest before we power cycle"},{"line_number":87,"context_line":"        if linux_client:"},{"line_number":88,"context_line":"            linux_client.validate_authentication()"},{"line_number":89,"context_line":""},{"line_number":90,"context_line":"        self.servers_client.stop_server(server[\u0027id\u0027])"},{"line_number":91,"context_line":"        waiters.wait_for_server_status(self.servers_client, server[\u0027id\u0027],"}],"source_content_type":"text/x-python","patch_set":2,"id":"ffe62b97_2747cabe","line":88,"range":{"start_line":88,"start_character":12,"end_line":88,"end_character":50},"in_reply_to":"ffe62b97_9ea32e50","updated":"2017-03-29 11:55:35.000000000","message":"The reason I didn\u0027t validate immediately was that while the guest boots we can create the VM instead of waiting for the boot to complete and then create the volume. \nNot a big deal, only a few seconds of difference possibly.","commit_id":"18721f0d23562cacba73367afccde0d217008427"}]}