)]}'
{"tempest/common/utils/linux/remote_client.py":[{"author":{"_account_id":20190,"name":"zhufl","email":"zhu.fanglei@zte.com.cn","username":"zhufl"},"change_message_id":"ef5b7e321f06932e665d5db02550bef0f8b33e04","unresolved":false,"context_lines":[{"line_number":62,"context_line":"                # Show header line too"},{"line_number":63,"context_line":"                selected.append(l)"},{"line_number":64,"context_line":"            # lsblk lists disk type in a column right-aligned with TYPE"},{"line_number":65,"context_line":"            elif pos is not None and pos \u003e 0 and l[pos:pos + 4] \u003d\u003d \"disk\":"},{"line_number":66,"context_line":"                selected.append(l)"},{"line_number":67,"context_line":""},{"line_number":68,"context_line":"        if selected:"}],"source_content_type":"text/x-python","patch_set":1,"id":"ffe62b97_3d9f5d04","line":65,"range":{"start_line":65,"start_character":17,"end_line":65,"end_character":32},"updated":"2017-03-27 06:22:24.000000000","message":"I don\u0027t get why this is added? it seems if pos is not None then it must be \u003e0","commit_id":"0a5d6061084c2ffccb4a0831405f0eea8ad0fb6b"},{"author":{"_account_id":5689,"name":"Masayuki Igawa","email":"masayuki@igawa.io","username":"igawa"},"change_message_id":"d7b5abc764fb3a308c3a6d866f7a61bbe66f072a","unresolved":false,"context_lines":[{"line_number":62,"context_line":"                # Show header line too"},{"line_number":63,"context_line":"                selected.append(l)"},{"line_number":64,"context_line":"            # lsblk lists disk type in a column right-aligned with TYPE"},{"line_number":65,"context_line":"            elif pos is not None and pos \u003e 0 and l[pos:pos + 4] \u003d\u003d \"disk\":"},{"line_number":66,"context_line":"                selected.append(l)"},{"line_number":67,"context_line":""},{"line_number":68,"context_line":"        if selected:"}],"source_content_type":"text/x-python","patch_set":1,"id":"ffe62b97_8f6efa2c","line":65,"updated":"2017-03-28 02:02:44.000000000","message":"I was thinking if the output doesn\u0027t have \u0027TYPE\u0027 column, pos is None. So, \u0027pos \u003e 0\u0027 raise a TypeError: \"\u0027\u003e\u0027 not supported between instances of \u0027NoneType\u0027 and \u0027int\u0027\". So I added this just to avoid it.","commit_id":"0a5d6061084c2ffccb4a0831405f0eea8ad0fb6b"},{"author":{"_account_id":1921,"name":"Andrea Frittoli","email":"andrea.frittoli@gmail.com","username":"andrea-frittoli"},"change_message_id":"975822669ec0c3532190d307a28b8436db90ae6f","unresolved":false,"context_lines":[{"line_number":62,"context_line":"                # Show header line too"},{"line_number":63,"context_line":"                selected.append(l)"},{"line_number":64,"context_line":"            # lsblk lists disk type in a column right-aligned with TYPE"},{"line_number":65,"context_line":"            elif pos is not None and pos \u003e 0 and l[pos:pos + 4] \u003d\u003d \"disk\":"},{"line_number":66,"context_line":"                selected.append(l)"},{"line_number":67,"context_line":""},{"line_number":68,"context_line":"        if selected:"}],"source_content_type":"text/x-python","patch_set":1,"id":"ffe62b97_0e085ad7","line":65,"in_reply_to":"ffe62b97_72d95df1","updated":"2017-03-29 14:16:07.000000000","message":"heh I guess this is a bit more readable","commit_id":"0a5d6061084c2ffccb4a0831405f0eea8ad0fb6b"},{"author":{"_account_id":20190,"name":"zhufl","email":"zhu.fanglei@zte.com.cn","username":"zhufl"},"change_message_id":"5247412785440f306377c0de32815496843e7f2f","unresolved":false,"context_lines":[{"line_number":62,"context_line":"                # Show header line too"},{"line_number":63,"context_line":"                selected.append(l)"},{"line_number":64,"context_line":"            # lsblk lists disk type in a column right-aligned with TYPE"},{"line_number":65,"context_line":"            elif pos is not None and pos \u003e 0 and l[pos:pos + 4] \u003d\u003d \"disk\":"},{"line_number":66,"context_line":"                selected.append(l)"},{"line_number":67,"context_line":""},{"line_number":68,"context_line":"        if selected:"}],"source_content_type":"text/x-python","patch_set":1,"id":"ffe62b97_72d95df1","line":65,"in_reply_to":"ffe62b97_8f6efa2c","updated":"2017-03-28 02:44:00.000000000","message":"oh, I see.\nthen how about set pos\u0027s original value to -1? then the code can be:\n        pos \u003d -1\n        for l in output.splitlines():\n            if pos \u003c 0 and l.find(\"TYPE\") \u003e 0:\n                pos \u003d l.find(\"TYPE\")\n                # Show header line too\n                selected.append(l)\n            # lsblk lists disk type in a column right-aligned with TYPE\n            elif pos \u003e 0 and l[pos:pos + 4] \u003d\u003d \"disk\":","commit_id":"0a5d6061084c2ffccb4a0831405f0eea8ad0fb6b"},{"author":{"_account_id":1921,"name":"Andrea Frittoli","email":"andrea.frittoli@gmail.com","username":"andrea-frittoli"},"change_message_id":"975822669ec0c3532190d307a28b8436db90ae6f","unresolved":false,"context_lines":[{"line_number":68,"context_line":"        if selected:"},{"line_number":69,"context_line":"            return \"\\n\".join(selected)"},{"line_number":70,"context_line":"        else:"},{"line_number":71,"context_line":"            msg \u003d \"\u0027TYPE\u0027 column is requred but the output doesn\u0027t have it: \""},{"line_number":72,"context_line":"            raise tempest.lib.exceptions.TempestException(msg + output)"},{"line_number":73,"context_line":""},{"line_number":74,"context_line":"    def get_boot_time(self):"}],"source_content_type":"text/x-python","patch_set":1,"id":"ffe62b97_b38439d4","line":71,"range":{"start_line":71,"start_character":0,"end_line":71,"end_character":77},"updated":"2017-03-29 14:16:07.000000000","message":"NIT: I think the command would be useful, e.g.:\n\nCould not find a  \u0027TYPE\u0027 column in the output of {command}. Output: {output}.","commit_id":"0a5d6061084c2ffccb4a0831405f0eea8ad0fb6b"},{"author":{"_account_id":1921,"name":"Andrea Frittoli","email":"andrea.frittoli@gmail.com","username":"andrea-frittoli"},"change_message_id":"975822669ec0c3532190d307a28b8436db90ae6f","unresolved":false,"context_lines":[{"line_number":68,"context_line":"        if selected:"},{"line_number":69,"context_line":"            return \"\\n\".join(selected)"},{"line_number":70,"context_line":"        else:"},{"line_number":71,"context_line":"            msg \u003d \"\u0027TYPE\u0027 column is requred but the output doesn\u0027t have it: \""},{"line_number":72,"context_line":"            raise tempest.lib.exceptions.TempestException(msg + output)"},{"line_number":73,"context_line":""},{"line_number":74,"context_line":"    def get_boot_time(self):"}],"source_content_type":"text/x-python","patch_set":1,"id":"ffe62b97_73c91157","line":71,"range":{"start_line":71,"start_character":36,"end_line":71,"end_character":43},"updated":"2017-03-29 14:16:07.000000000","message":"required","commit_id":"0a5d6061084c2ffccb4a0831405f0eea8ad0fb6b"}]}