)]}'
{"/COMMIT_MSG":[{"author":{"_account_id":5689,"name":"Masayuki Igawa","email":"masayuki@igawa.io","username":"igawa"},"change_message_id":"b8d9ff691516d20e408c873a2c83ead45977e0f1","unresolved":false,"context_lines":[{"line_number":7,"context_line":"Glance - Add list filter by propery"},{"line_number":8,"context_line":""},{"line_number":9,"context_line":"Glance list command supports filter by property."},{"line_number":10,"context_line":""},{"line_number":11,"context_line":"Test steps:"},{"line_number":12,"context_line":"- Create a shared image with random property key\u003dvalue"},{"line_number":13,"context_line":"- List images with the property values"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":1,"id":"ffe62b97_9b97f245","line":10,"updated":"2017-03-30 03:19:11.000000000","message":"I actually couldn\u0027t find the \u0027property\u0027 parameter in the API doc[1]. So I\u0027m worried about this is a really stable interface parameter or not. Do you know about it?\nAnd, could you add the reason why you want to add this test? I actually don\u0027t understand the importance of the \u0027property\u0027 parameter. Commit messages are really important, so we have a document[2] for it.\n\n[1] https://developer.openstack.org/api-ref/image/v2/index.html?expanded\u003dcreate-an-image-detail#create-an-image\n[2] https://wiki.openstack.org/wiki/GitCommitMessages#Information_in_commit_messages","commit_id":"e36800bfaa81ad9366a326db19b8f9999ba3fb70"},{"author":{"_account_id":11075,"name":"Benny Kopilov","email":"bkopilov@redhat.com","username":"bkopilov"},"change_message_id":"eb4938f77b4c75b3a19f959821e27a0a82bfc4b2","unresolved":false,"context_lines":[{"line_number":7,"context_line":"Glance - Add list filter by propery"},{"line_number":8,"context_line":""},{"line_number":9,"context_line":"Glance list command supports filter by property."},{"line_number":10,"context_line":""},{"line_number":11,"context_line":"Test steps:"},{"line_number":12,"context_line":"- Create a shared image with random property key\u003dvalue"},{"line_number":13,"context_line":"- List images with the property values"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":1,"id":"ffe62b97_51cca933","line":10,"in_reply_to":"ffe62b97_9b97f245","updated":"2017-03-30 05:11:13.000000000","message":"Hi , \nPlease look at :\nhttps://docs.openstack.org/admin-guide/common/cli-manage-images.html\n\nhttps://docs.openstack.org/cli-reference/glance-property-keys.html\n\n\nThe proprety keys can be used for types of flags , i decided to make it random key and value.\n\nLet me know what do you think ?\n\nBenny","commit_id":"e36800bfaa81ad9366a326db19b8f9999ba3fb70"}],"tempest/api/image/v2/test_images.py":[{"author":{"_account_id":20190,"name":"zhufl","email":"zhu.fanglei@zte.com.cn","username":"zhufl"},"change_message_id":"124cf834bfa6bb7cf23277cc08d10e5667028776","unresolved":false,"context_lines":[{"line_number":157,"context_line":"        size \u003d random.randint(1024, 4096)"},{"line_number":158,"context_line":"        image_file \u003d six.BytesIO(data_utils.random_bytes(size))"},{"line_number":159,"context_line":"        tags \u003d [data_utils.rand_name(\u0027tag\u0027), data_utils.rand_name(\u0027tag\u0027)]"},{"line_number":160,"context_line":"        cls.property_keys \u003d \"%s\u003d%s\" % (data_utils.rand_name(\u0027property\u0027),"},{"line_number":161,"context_line":"                                       data_utils.rand_name(\u0027val\u0027))"},{"line_number":162,"context_line":"        image \u003d cls.create_image(container_format\u003dcontainer_format,"},{"line_number":163,"context_line":"                                 disk_format\u003ddisk_format,"},{"line_number":164,"context_line":"                                 visibility\u003d\u0027private\u0027,"}],"source_content_type":"text/x-python","patch_set":1,"id":"ffe62b97_d469c724","line":161,"range":{"start_line":160,"start_character":0,"end_line":161,"end_character":67},"updated":"2017-03-30 05:56:04.000000000","message":"maybe you can simply use property_keys \u003d \"key\u003dvalue\"","commit_id":"e36800bfaa81ad9366a326db19b8f9999ba3fb70"},{"author":{"_account_id":20190,"name":"zhufl","email":"zhu.fanglei@zte.com.cn","username":"zhufl"},"change_message_id":"124cf834bfa6bb7cf23277cc08d10e5667028776","unresolved":false,"context_lines":[{"line_number":235,"context_line":""},{"line_number":236,"context_line":"    @decorators.idempotent_id(\u0027e4b4ec17-8b5a-427d-874a-6878fff94d0c\u0027)"},{"line_number":237,"context_line":"    def test_list_images_param_property(self):"},{"line_number":238,"context_line":"        params \u003d {\"property\": self.property_keys}"},{"line_number":239,"context_line":"        self._list_by_param_value_and_assert(params)"},{"line_number":240,"context_line":""},{"line_number":241,"context_line":"    @decorators.idempotent_id(\u00274ad8c157-971a-4ba8-aa84-ed61154b1e7f\u0027)"}],"source_content_type":"text/x-python","patch_set":1,"id":"ffe62b97_b41f63b5","line":238,"range":{"start_line":238,"start_character":30,"end_line":238,"end_character":48},"updated":"2017-03-30 05:56:04.000000000","message":"image[\u0027property\u0027]","commit_id":"e36800bfaa81ad9366a326db19b8f9999ba3fb70"},{"author":{"_account_id":1921,"name":"Andrea Frittoli","email":"andrea.frittoli@gmail.com","username":"andrea-frittoli"},"change_message_id":"e8c32f8cd7f72e784a305ce5f8aec91511c70fd6","unresolved":false,"context_lines":[{"line_number":234,"context_line":""},{"line_number":235,"context_line":"    @decorators.idempotent_id(\u0027e4b4ec17-8b5a-427d-874a-6878fff94d0c\u0027)"},{"line_number":236,"context_line":"    def test_list_images_param_property(self):"},{"line_number":237,"context_line":"        params \u003d {\"property\": self.test_data[\u0027property\u0027]}"},{"line_number":238,"context_line":"        self._list_by_param_value_and_assert(params)"},{"line_number":239,"context_line":""},{"line_number":240,"context_line":"    @decorators.idempotent_id(\u00274ad8c157-971a-4ba8-aa84-ed61154b1e7f\u0027)"}],"source_content_type":"text/x-python","patch_set":2,"id":"ffe62b97_09094a30","line":237,"range":{"start_line":237,"start_character":30,"end_line":237,"end_character":56},"updated":"2017-03-30 11:57:09.000000000","message":"I\u0027m not sure about this. self.test_data is returned by the API, and you use that as expected result. I think you should use the property_keys as initially set in the _create_standard_image method.","commit_id":"9cc0b883169d20bada577bb002181983f98f87d8"},{"author":{"_account_id":11075,"name":"Benny Kopilov","email":"bkopilov@redhat.com","username":"bkopilov"},"change_message_id":"9b1f4ce720ce6065d4790bcf31d4aa2927f288ce","unresolved":false,"context_lines":[{"line_number":234,"context_line":""},{"line_number":235,"context_line":"    @decorators.idempotent_id(\u0027e4b4ec17-8b5a-427d-874a-6878fff94d0c\u0027)"},{"line_number":236,"context_line":"    def test_list_images_param_property(self):"},{"line_number":237,"context_line":"        params \u003d {\"property\": self.test_data[\u0027property\u0027]}"},{"line_number":238,"context_line":"        self._list_by_param_value_and_assert(params)"},{"line_number":239,"context_line":""},{"line_number":240,"context_line":"    @decorators.idempotent_id(\u00274ad8c157-971a-4ba8-aa84-ed61154b1e7f\u0027)"}],"source_content_type":"text/x-python","patch_set":2,"id":"ffe62b97_8c9e88b6","line":237,"range":{"start_line":237,"start_character":30,"end_line":237,"end_character":56},"in_reply_to":"ffe62b97_09094a30","updated":"2017-03-30 11:58:58.000000000","message":"ok , fixing","commit_id":"9cc0b883169d20bada577bb002181983f98f87d8"},{"author":{"_account_id":7350,"name":"Jordan Pittier","email":"jordan.pittier@gmail.com","username":"JordanP"},"change_message_id":"0a7f5a5e8328d08255a0e26578d90c9a16457b51","unresolved":false,"context_lines":[{"line_number":157,"context_line":"        size \u003d random.randint(1024, 4096)"},{"line_number":158,"context_line":"        image_file \u003d six.BytesIO(data_utils.random_bytes(size))"},{"line_number":159,"context_line":"        tags \u003d [data_utils.rand_name(\u0027tag\u0027), data_utils.rand_name(\u0027tag\u0027)]"},{"line_number":160,"context_line":"        cls.property_keys \u003d \"key\u003dvalue\""},{"line_number":161,"context_line":"        image \u003d cls.create_image(container_format\u003dcontainer_format,"},{"line_number":162,"context_line":"                                 disk_format\u003ddisk_format,"},{"line_number":163,"context_line":"                                 visibility\u003d\u0027private\u0027,"}],"source_content_type":"text/x-python","patch_set":3,"id":"dfeb2761_272510ac","line":160,"updated":"2017-04-03 08:58:12.000000000","message":"The introduction of a new class variable for this is suboptimal.\n\nChange _create_standard_image so that it accepts a kwargs and pass \u0027property\u003d\"key\u003dvalue\"\u0027 from the caller method (i.e test_list_images_param_property)","commit_id":"4ab3dd70f09e0755ede5184881bb1f804366b5aa"},{"author":{"_account_id":20190,"name":"zhufl","email":"zhu.fanglei@zte.com.cn","username":"zhufl"},"change_message_id":"2a6cbcd83dbf54f2ff1a36a4e4b2fea253881ee5","unresolved":false,"context_lines":[{"line_number":234,"context_line":""},{"line_number":235,"context_line":"    @decorators.idempotent_id(\u0027e4b4ec17-8b5a-427d-874a-6878fff94d0c\u0027)"},{"line_number":236,"context_line":"    def test_list_images_param_property(self):"},{"line_number":237,"context_line":"        params \u003d {\"property\": self.property_keys}"},{"line_number":238,"context_line":"        self._list_by_param_value_and_assert(params)"},{"line_number":239,"context_line":""},{"line_number":240,"context_line":"    @decorators.idempotent_id(\u00274ad8c157-971a-4ba8-aa84-ed61154b1e7f\u0027)"}],"source_content_type":"text/x-python","patch_set":3,"id":"dfeb2761_79e9c27e","line":237,"range":{"start_line":237,"start_character":30,"end_line":237,"end_character":48},"updated":"2017-03-31 00:46:41.000000000","message":"@Andrea I have slightly different opinion:)\nthis will test \"list images by filter of property is correct\", but not \"image creating is correct\", \n    i.e., if image[\u0027property\u0027]\u003d\u003d\u0027xxx\u0027, then if we filter by property\u003d\u0027xxx\u0027, we expect image is returned.\n    All testcases in ListUserImagesTest have this assumption that we won\u0027t care whether image creating is correct\n    (i.e, we won\u0027t care if we create image with property\u003d\u0027xxx\u0027 but eventually get image[\u0027property\u0027]\u003d\u0027yyy\u0027)","commit_id":"4ab3dd70f09e0755ede5184881bb1f804366b5aa"},{"author":{"_account_id":7350,"name":"Jordan Pittier","email":"jordan.pittier@gmail.com","username":"JordanP"},"change_message_id":"0a7f5a5e8328d08255a0e26578d90c9a16457b51","unresolved":false,"context_lines":[{"line_number":234,"context_line":""},{"line_number":235,"context_line":"    @decorators.idempotent_id(\u0027e4b4ec17-8b5a-427d-874a-6878fff94d0c\u0027)"},{"line_number":236,"context_line":"    def test_list_images_param_property(self):"},{"line_number":237,"context_line":"        params \u003d {\"property\": self.property_keys}"},{"line_number":238,"context_line":"        self._list_by_param_value_and_assert(params)"},{"line_number":239,"context_line":""},{"line_number":240,"context_line":"    @decorators.idempotent_id(\u00274ad8c157-971a-4ba8-aa84-ed61154b1e7f\u0027)"}],"source_content_type":"text/x-python","patch_set":3,"id":"dfeb2761_873e1dd8","line":237,"range":{"start_line":237,"start_character":30,"end_line":237,"end_character":48},"in_reply_to":"dfeb2761_79e9c27e","updated":"2017-04-03 08:58:12.000000000","message":"I might be missing something but this test doesn\u0027t filter anything because all the images are created with property\u003d\u0027key\u003dvalue\u0027","commit_id":"4ab3dd70f09e0755ede5184881bb1f804366b5aa"}]}