)]}'
{"tempest/api/volume/admin/test_volumes_backup.py":[{"author":{"_account_id":8556,"name":"Ghanshyam Maan","display_name":"Ghanshyam Maan","email":"gmaan.os14@gmail.com","username":"ghanshyam"},"change_message_id":"8f7fec002d88d216de0f3bce21cbeb86f47b387c","unresolved":false,"context_lines":[{"line_number":130,"context_line":"        backup \u003d self.create_backup(backup_client\u003dself.admin_backups_client,"},{"line_number":131,"context_line":"                                    volume_id\u003dvolume[\u0027id\u0027],"},{"line_number":132,"context_line":"                                    name\u003dbackup_name)"},{"line_number":133,"context_line":"        self.assertEqual(backup_name, backup[\u0027name\u0027])"},{"line_number":134,"context_line":"        # Reset backup status to error"},{"line_number":135,"context_line":"        self.admin_backups_client.reset_backup_status(backup_id\u003dbackup[\u0027id\u0027],"},{"line_number":136,"context_line":"                                                      status\u003d\"error\")"}],"source_content_type":"text/x-python","patch_set":1,"id":"dfeb2761_e9a7374f","side":"PARENT","line":133,"range":{"start_line":133,"start_character":8,"end_line":133,"end_character":53},"updated":"2017-03-31 08:00:50.000000000","message":"but there is no harm of doing that. I do not like to remove such checks which does not harm anything.","commit_id":"e8afb8c2c5f948ee45e1c7edab4d82516920bd9a"},{"author":{"_account_id":20190,"name":"zhufl","email":"zhu.fanglei@zte.com.cn","username":"zhufl"},"change_message_id":"23e9d958e5f594283b57fcb7eaa82b4e4ef19598","unresolved":false,"context_lines":[{"line_number":130,"context_line":"        backup \u003d self.create_backup(backup_client\u003dself.admin_backups_client,"},{"line_number":131,"context_line":"                                    volume_id\u003dvolume[\u0027id\u0027],"},{"line_number":132,"context_line":"                                    name\u003dbackup_name)"},{"line_number":133,"context_line":"        self.assertEqual(backup_name, backup[\u0027name\u0027])"},{"line_number":134,"context_line":"        # Reset backup status to error"},{"line_number":135,"context_line":"        self.admin_backups_client.reset_backup_status(backup_id\u003dbackup[\u0027id\u0027],"},{"line_number":136,"context_line":"                                                      status\u003d\"error\")"}],"source_content_type":"text/x-python","patch_set":1,"id":"dfeb2761_247ae623","side":"PARENT","line":133,"range":{"start_line":133,"start_character":8,"end_line":133,"end_character":53},"in_reply_to":"dfeb2761_e9a7374f","updated":"2017-03-31 08:26:32.000000000","message":"ah, I just think it is not needed to do the duplicated check...\nbut ok to keep it for now","commit_id":"e8afb8c2c5f948ee45e1c7edab4d82516920bd9a"}],"tempest/api/volume/base.py":[{"author":{"_account_id":8556,"name":"Ghanshyam Maan","display_name":"Ghanshyam Maan","email":"gmaan.os14@gmail.com","username":"ghanshyam"},"change_message_id":"8f7fec002d88d216de0f3bce21cbeb86f47b387c","unresolved":false,"context_lines":[{"line_number":129,"context_line":"        \"\"\"Wrapper utility that returns a test backup.\"\"\""},{"line_number":130,"context_line":"        if backup_client is None:"},{"line_number":131,"context_line":"            backup_client \u003d self.backups_client"},{"line_number":132,"context_line":"        if \u0027name\u0027 not in kwargs:"},{"line_number":133,"context_line":"            name \u003d data_utils.rand_name(self.__class__.__name__ + \u0027-Backup\u0027)"},{"line_number":134,"context_line":"            kwargs[\u0027name\u0027] \u003d name"},{"line_number":135,"context_line":""},{"line_number":136,"context_line":"        backup \u003d backup_client.create_backup("},{"line_number":137,"context_line":"            volume_id\u003dvolume_id, **kwargs)[\u0027backup\u0027]"}],"source_content_type":"text/x-python","patch_set":1,"id":"dfeb2761_e98e17cf","line":134,"range":{"start_line":132,"start_character":0,"end_line":134,"end_character":33},"updated":"2017-03-31 08:00:50.000000000","message":"few tests did not mentioned the name and api-ref said it is mandatory attribute in request. But from code it seems like optional.\n\napi-ref bug - https://bugs.launchpad.net/cinder/+bug/1678005\n\n- https://developer.openstack.org/api-ref/block-storage/v2/?expanded\u003dcreate-backup-detail\n\n- https://github.com/openstack/cinder/blob/master/cinder/api/contrib/backups.py#L139","commit_id":"e730fc21fe4e83542f8da404c54983d39514b75c"},{"author":{"_account_id":20190,"name":"zhufl","email":"zhu.fanglei@zte.com.cn","username":"zhufl"},"change_message_id":"23e9d958e5f594283b57fcb7eaa82b4e4ef19598","unresolved":false,"context_lines":[{"line_number":129,"context_line":"        \"\"\"Wrapper utility that returns a test backup.\"\"\""},{"line_number":130,"context_line":"        if backup_client is None:"},{"line_number":131,"context_line":"            backup_client \u003d self.backups_client"},{"line_number":132,"context_line":"        if \u0027name\u0027 not in kwargs:"},{"line_number":133,"context_line":"            name \u003d data_utils.rand_name(self.__class__.__name__ + \u0027-Backup\u0027)"},{"line_number":134,"context_line":"            kwargs[\u0027name\u0027] \u003d name"},{"line_number":135,"context_line":""},{"line_number":136,"context_line":"        backup \u003d backup_client.create_backup("},{"line_number":137,"context_line":"            volume_id\u003dvolume_id, **kwargs)[\u0027backup\u0027]"}],"source_content_type":"text/x-python","patch_set":1,"id":"dfeb2761_2469c624","line":134,"range":{"start_line":132,"start_character":0,"end_line":134,"end_character":33},"in_reply_to":"dfeb2761_e98e17cf","updated":"2017-03-31 08:26:32.000000000","message":"Thanks for the detailed info.\nHere I want to add random name in order that testcases not caring about name can automatically\nget a random name, thus to make code simple and clean.","commit_id":"e730fc21fe4e83542f8da404c54983d39514b75c"}]}