)]}'
{"/COMMIT_MSG":[{"author":{"_account_id":5689,"name":"Masayuki Igawa","email":"masayuki@igawa.io","username":"igawa"},"change_message_id":"a9bf3ae42aa65397341df1f693f907396f4aeb31","unresolved":false,"context_lines":[{"line_number":4,"context_line":"Commit:     Liang Hao \u003clianghao@cmss.chinamobile.com\u003e"},{"line_number":5,"context_line":"CommitDate: 2017-04-01 14:13:05 +0000"},{"line_number":6,"context_line":""},{"line_number":7,"context_line":"Update security_group of the server to empty"},{"line_number":8,"context_line":""},{"line_number":9,"context_line":"Change-Id: I39e272f7b7655a9821cc5ff9e5701f9da80c9bd4"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":4,"id":"dfeb2761_f816b0f1","line":7,"updated":"2017-04-03 04:59:56.000000000","message":"We already have some tests which use remove_security_group(). So why do we need this test, too? Could you please describe the difference and reason in the commit message?","commit_id":"399503e5ef44c8702cb371315e7ff388f0d9188c"},{"author":{"_account_id":5689,"name":"Masayuki Igawa","email":"masayuki@igawa.io","username":"igawa"},"change_message_id":"fcd37e329eb211974b2d5a046f04ef587336e70d","unresolved":false,"context_lines":[{"line_number":8,"context_line":""},{"line_number":9,"context_line":"If you omit the attribute of security_groups, the API creates the server"},{"line_number":10,"context_line":"in the default security group,but openstack can accept to"},{"line_number":11,"context_line":"update server security to empty,so we add the test."},{"line_number":12,"context_line":""},{"line_number":13,"context_line":"Change-Id: I39e272f7b7655a9821cc5ff9e5701f9da80c9bd4"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":5,"id":"dfeb2761_29dee310","line":11,"updated":"2017-04-04 02:53:00.000000000","message":"yeah, openstack can accept this, but I\u0027m wondering this is really important or basic use case for you? Or did you face an issue similar/regarding to this before?","commit_id":"e97d7dc1c300224ff99d75e4116f7c399562dab2"}],"tempest/api/compute/servers/test_server_actions.py":[{"author":{"_account_id":1921,"name":"Andrea Frittoli","email":"andrea.frittoli@gmail.com","username":"andrea-frittoli"},"change_message_id":"27d93df6c476203b853673693033562fb6f16ff8","unresolved":false,"context_lines":[{"line_number":146,"context_line":"        self._test_reboot_server(\u0027SOFT\u0027)"},{"line_number":147,"context_line":""},{"line_number":148,"context_line":"    @decorators.idempotent_id(\u00271d1c9104-1b0a-11e7-a3d4-fa163e65f5ce\u0027)"},{"line_number":149,"context_line":"    def test_remove_server_default_security_groups(self):"},{"line_number":150,"context_line":"        server \u003d self.client.show_server(self.server_id)[\u0027server\u0027]"},{"line_number":151,"context_line":""},{"line_number":152,"context_line":"        # Remove default Security group"}],"source_content_type":"text/x-python","patch_set":12,"id":"bff0334d_e877e7d3","line":149,"range":{"start_line":149,"start_character":27,"end_line":149,"end_character":50},"updated":"2017-04-07 13:05:09.000000000","message":"Also as I understood the aim of this test is to verify that all security groups can be removed from a test, and it\u0027s not specific to the default one, so I think the name here is misleading.\nIn many cases the default SG just happens to be the only SG for the server.","commit_id":"21897bfdf5c76d0f915f6b61f5b99c2bcf76a526"},{"author":{"_account_id":1921,"name":"Andrea Frittoli","email":"andrea.frittoli@gmail.com","username":"andrea-frittoli"},"change_message_id":"27d93df6c476203b853673693033562fb6f16ff8","unresolved":false,"context_lines":[{"line_number":147,"context_line":""},{"line_number":148,"context_line":"    @decorators.idempotent_id(\u00271d1c9104-1b0a-11e7-a3d4-fa163e65f5ce\u0027)"},{"line_number":149,"context_line":"    def test_remove_server_default_security_groups(self):"},{"line_number":150,"context_line":"        server \u003d self.client.show_server(self.server_id)[\u0027server\u0027]"},{"line_number":151,"context_line":""},{"line_number":152,"context_line":"        # Remove default Security group"},{"line_number":153,"context_line":"        self.client.remove_security_group("}],"source_content_type":"text/x-python","patch_set":12,"id":"bff0334d_681bd780","line":150,"range":{"start_line":150,"start_character":8,"end_line":150,"end_character":66},"updated":"2017-04-07 13:05:09.000000000","message":"I think this test should create it\u0027s own server, possibly by specifying a known security group, and then remove it.","commit_id":"21897bfdf5c76d0f915f6b61f5b99c2bcf76a526"},{"author":{"_account_id":1921,"name":"Andrea Frittoli","email":"andrea.frittoli@gmail.com","username":"andrea-frittoli"},"change_message_id":"14671fc26bd5ec38403f262ed9004f3677c3e016","unresolved":false,"context_lines":[{"line_number":147,"context_line":""},{"line_number":148,"context_line":"    @decorators.idempotent_id(\u00271d1c9104-1b0a-11e7-a3d4-fa163e65f5ce\u0027)"},{"line_number":149,"context_line":"    def test_remove_server_default_security_groups(self):"},{"line_number":150,"context_line":"        server \u003d self.client.show_server(self.server_id)[\u0027server\u0027]"},{"line_number":151,"context_line":""},{"line_number":152,"context_line":"        # Remove default Security group"},{"line_number":153,"context_line":"        self.client.remove_security_group("}],"source_content_type":"text/x-python","patch_set":12,"id":"bff0334d_a31d8067","line":150,"range":{"start_line":150,"start_character":8,"end_line":150,"end_character":66},"in_reply_to":"bff0334d_681bd780","updated":"2017-04-07 13:07:13.000000000","message":"Heh, ok, addressed by the next patch-set already.","commit_id":"21897bfdf5c76d0f915f6b61f5b99c2bcf76a526"},{"author":{"_account_id":20190,"name":"zhufl","email":"zhu.fanglei@zte.com.cn","username":"zhufl"},"change_message_id":"931ccdec13ebe46829593d37cc875d808b4d38ad","unresolved":false,"context_lines":[{"line_number":150,"context_line":"        server \u003d self.client.show_server(self.server_id)[\u0027server\u0027]"},{"line_number":151,"context_line":""},{"line_number":152,"context_line":"        # Remove default Security group"},{"line_number":153,"context_line":"        self.client.remove_security_group("},{"line_number":154,"context_line":"            server[\u0027id\u0027], name\u003dserver[\u0027security_groups\u0027][0][\u0027name\u0027])"},{"line_number":155,"context_line":""},{"line_number":156,"context_line":"        # Verify default Security group"}],"source_content_type":"text/x-python","patch_set":12,"id":"bff0334d_e91a627b","line":153,"range":{"start_line":153,"start_character":20,"end_line":153,"end_character":41},"updated":"2017-04-07 02:14:47.000000000","message":"Will this affect other testcases? At least it changes something than before.","commit_id":"21897bfdf5c76d0f915f6b61f5b99c2bcf76a526"},{"author":{"_account_id":20190,"name":"zhufl","email":"zhu.fanglei@zte.com.cn","username":"zhufl"},"change_message_id":"25966cf9b682f1a1adad21ce9442496286b42f42","unresolved":false,"context_lines":[{"line_number":150,"context_line":"        server \u003d self.client.show_server(self.server_id)[\u0027server\u0027]"},{"line_number":151,"context_line":""},{"line_number":152,"context_line":"        # Remove default Security group"},{"line_number":153,"context_line":"        self.client.remove_security_group("},{"line_number":154,"context_line":"            server[\u0027id\u0027], name\u003dserver[\u0027security_groups\u0027][0][\u0027name\u0027])"},{"line_number":155,"context_line":""},{"line_number":156,"context_line":"        # Verify default Security group"}],"source_content_type":"text/x-python","patch_set":12,"id":"bff0334d_e4bcc7dd","line":153,"range":{"start_line":153,"start_character":20,"end_line":153,"end_character":41},"in_reply_to":"bff0334d_24c06f7b","updated":"2017-04-07 02:38:48.000000000","message":"Is there any way to add back the security group with addCleanup? If so, maybe we can save the cost for creating a new server","commit_id":"21897bfdf5c76d0f915f6b61f5b99c2bcf76a526"},{"author":{"_account_id":20190,"name":"zhufl","email":"zhu.fanglei@zte.com.cn","username":"zhufl"},"change_message_id":"6880298dd83831eb19e612f5373608d6a51f3577","unresolved":false,"context_lines":[{"line_number":150,"context_line":"        server \u003d self.client.show_server(self.server_id)[\u0027server\u0027]"},{"line_number":151,"context_line":""},{"line_number":152,"context_line":"        # Remove default Security group"},{"line_number":153,"context_line":"        self.client.remove_security_group("},{"line_number":154,"context_line":"            server[\u0027id\u0027], name\u003dserver[\u0027security_groups\u0027][0][\u0027name\u0027])"},{"line_number":155,"context_line":""},{"line_number":156,"context_line":"        # Verify default Security group"}],"source_content_type":"text/x-python","patch_set":12,"id":"bff0334d_44adb32f","line":153,"range":{"start_line":153,"start_character":20,"end_line":153,"end_character":41},"in_reply_to":"bff0334d_24f4ef85","updated":"2017-04-07 03:01:13.000000000","message":"or, will you consider add some lines in test_server_security_groups?\njust before https://github.com/openstack/tempest/blob/b960e490dbb673edb63180997b1bcdab96ddba69/tempest/api/compute/security_groups/test_security_groups.py#L99","commit_id":"21897bfdf5c76d0f915f6b61f5b99c2bcf76a526"},{"author":{"_account_id":20190,"name":"zhufl","email":"zhu.fanglei@zte.com.cn","username":"zhufl"},"change_message_id":"fb3d3298ed9b32a9cc70268123000e371093c954","unresolved":false,"context_lines":[{"line_number":150,"context_line":"        server \u003d self.client.show_server(self.server_id)[\u0027server\u0027]"},{"line_number":151,"context_line":""},{"line_number":152,"context_line":"        # Remove default Security group"},{"line_number":153,"context_line":"        self.client.remove_security_group("},{"line_number":154,"context_line":"            server[\u0027id\u0027], name\u003dserver[\u0027security_groups\u0027][0][\u0027name\u0027])"},{"line_number":155,"context_line":""},{"line_number":156,"context_line":"        # Verify default Security group"}],"source_content_type":"text/x-python","patch_set":12,"id":"bff0334d_2aea79ab","line":153,"range":{"start_line":153,"start_character":20,"end_line":153,"end_character":41},"in_reply_to":"bff0334d_2a0cb939","updated":"2017-04-07 03:35:31.000000000","message":"I do not object to adding a new test for this, actually to put some lines in current test is just to save the excuting time.\nBut I think api/compute/security_groups/test_security_groups.py is more suitable for this.","commit_id":"21897bfdf5c76d0f915f6b61f5b99c2bcf76a526"},{"author":{"_account_id":1921,"name":"Andrea Frittoli","email":"andrea.frittoli@gmail.com","username":"andrea-frittoli"},"change_message_id":"27d93df6c476203b853673693033562fb6f16ff8","unresolved":false,"context_lines":[{"line_number":150,"context_line":"        server \u003d self.client.show_server(self.server_id)[\u0027server\u0027]"},{"line_number":151,"context_line":""},{"line_number":152,"context_line":"        # Remove default Security group"},{"line_number":153,"context_line":"        self.client.remove_security_group("},{"line_number":154,"context_line":"            server[\u0027id\u0027], name\u003dserver[\u0027security_groups\u0027][0][\u0027name\u0027])"},{"line_number":155,"context_line":""},{"line_number":156,"context_line":"        # Verify default Security group"}],"source_content_type":"text/x-python","patch_set":12,"id":"bff0334d_e804874c","line":153,"range":{"start_line":153,"start_character":20,"end_line":153,"end_character":41},"in_reply_to":"bff0334d_2aea79ab","updated":"2017-04-07 13:05:09.000000000","message":"I disagree on this last comment. nova security group tests are for the nova security group API. Adding / removing a security group from a test is an action of the servers API, so it should be tested in here.\n\nThis test should not change a server which is used by other tests.","commit_id":"21897bfdf5c76d0f915f6b61f5b99c2bcf76a526"},{"author":{"_account_id":21897,"name":"lianghao","email":"lianghao@cmss.chinamobile.com","username":"cloud-liang"},"change_message_id":"c4b8f81c6484369cd311f6cdfba2328be77bcd78","unresolved":false,"context_lines":[{"line_number":150,"context_line":"        server \u003d self.client.show_server(self.server_id)[\u0027server\u0027]"},{"line_number":151,"context_line":""},{"line_number":152,"context_line":"        # Remove default Security group"},{"line_number":153,"context_line":"        self.client.remove_security_group("},{"line_number":154,"context_line":"            server[\u0027id\u0027], name\u003dserver[\u0027security_groups\u0027][0][\u0027name\u0027])"},{"line_number":155,"context_line":""},{"line_number":156,"context_line":"        # Verify default Security group"}],"source_content_type":"text/x-python","patch_set":12,"id":"bff0334d_2a0cb939","line":153,"range":{"start_line":153,"start_character":20,"end_line":153,"end_character":41},"in_reply_to":"bff0334d_44adb32f","updated":"2017-04-07 03:07:39.000000000","message":"Hi zhufl,thanks for you suggestions.\nBut I think that is not good.","commit_id":"21897bfdf5c76d0f915f6b61f5b99c2bcf76a526"},{"author":{"_account_id":21897,"name":"lianghao","email":"lianghao@cmss.chinamobile.com","username":"cloud-liang"},"change_message_id":"5f64a4f3e58534e0a2180ae1132a9c8cb2759241","unresolved":false,"context_lines":[{"line_number":150,"context_line":"        server \u003d self.client.show_server(self.server_id)[\u0027server\u0027]"},{"line_number":151,"context_line":""},{"line_number":152,"context_line":"        # Remove default Security group"},{"line_number":153,"context_line":"        self.client.remove_security_group("},{"line_number":154,"context_line":"            server[\u0027id\u0027], name\u003dserver[\u0027security_groups\u0027][0][\u0027name\u0027])"},{"line_number":155,"context_line":""},{"line_number":156,"context_line":"        # Verify default Security group"}],"source_content_type":"text/x-python","patch_set":12,"id":"bff0334d_24f4ef85","line":153,"range":{"start_line":153,"start_character":20,"end_line":153,"end_character":41},"in_reply_to":"bff0334d_e4bcc7dd","updated":"2017-04-07 02:50:46.000000000","message":"Add back the security group is difficult,because there is many security groups named default in the environment.\nIn test_server_actions.py,there are many test case which create a new server,like below\n def test_create_with_existing_server_name(self):\n        # Creating a server with a name that already exists is allowed\n\n        # TODO(sdague): clear out try, we do cleanup one layer up\n        server_name \u003d data_utils.rand_name(\n            self.__class__.__name__ + \u0027-server\u0027)\n        server \u003d self.create_test_server(name\u003dserver_name,\n                                         wait_until\u003d\u0027ACTIVE\u0027)","commit_id":"21897bfdf5c76d0f915f6b61f5b99c2bcf76a526"},{"author":{"_account_id":21897,"name":"lianghao","email":"lianghao@cmss.chinamobile.com","username":"cloud-liang"},"change_message_id":"7542ed75d1d63c83f72757d16d3cb85766d069da","unresolved":false,"context_lines":[{"line_number":150,"context_line":"        server \u003d self.client.show_server(self.server_id)[\u0027server\u0027]"},{"line_number":151,"context_line":""},{"line_number":152,"context_line":"        # Remove default Security group"},{"line_number":153,"context_line":"        self.client.remove_security_group("},{"line_number":154,"context_line":"            server[\u0027id\u0027], name\u003dserver[\u0027security_groups\u0027][0][\u0027name\u0027])"},{"line_number":155,"context_line":""},{"line_number":156,"context_line":"        # Verify default Security group"}],"source_content_type":"text/x-python","patch_set":12,"id":"bff0334d_24c06f7b","line":153,"range":{"start_line":153,"start_character":20,"end_line":153,"end_character":41},"in_reply_to":"bff0334d_e91a627b","updated":"2017-04-07 02:29:41.000000000","message":"Hi zhufl,I am not sure.\nIn case of uncertainly situation,I will create a new server for test.\nwhat about your idea ?","commit_id":"21897bfdf5c76d0f915f6b61f5b99c2bcf76a526"}],"tempest/api/compute/servers/test_server_rescue.py":[{"author":{"_account_id":5689,"name":"Masayuki Igawa","email":"masayuki@igawa.io","username":"igawa"},"change_message_id":"c3479e0945d6650176093c16cdef02ae80ead987","unresolved":false,"context_lines":[{"line_number":128,"context_line":""},{"line_number":129,"context_line":"        # Verify default Security group"},{"line_number":130,"context_line":"        server \u003d self.servers_client.show_server(server[\u0027id\u0027])[\u0027server\u0027]"},{"line_number":131,"context_line":"        self.assertFalse(\u0027security_groups\u0027 in server)"}],"source_content_type":"text/x-python","patch_set":10,"id":"dfeb2761_d2613707","line":131,"updated":"2017-04-05 04:22:35.000000000","message":"+1 to zhufl","commit_id":"091dedf6eb684c22c2946c0ef829859b232669e1"},{"author":{"_account_id":20190,"name":"zhufl","email":"zhu.fanglei@zte.com.cn","username":"zhufl"},"change_message_id":"925597b58d82df271d57b0d8f9a763fe11536867","unresolved":false,"context_lines":[{"line_number":128,"context_line":""},{"line_number":129,"context_line":"        # Verify default Security group"},{"line_number":130,"context_line":"        server \u003d self.servers_client.show_server(server[\u0027id\u0027])[\u0027server\u0027]"},{"line_number":131,"context_line":"        self.assertFalse(\u0027security_groups\u0027 in server)"}],"source_content_type":"text/x-python","patch_set":10,"id":"dfeb2761_979041ef","line":131,"range":{"start_line":131,"start_character":13,"end_line":131,"end_character":24},"updated":"2017-04-05 03:15:25.000000000","message":"nit: assertNotIn can have more friendly error info","commit_id":"091dedf6eb684c22c2946c0ef829859b232669e1"},{"author":{"_account_id":21897,"name":"lianghao","email":"lianghao@cmss.chinamobile.com","username":"cloud-liang"},"change_message_id":"467836956ec78b6305bf43e9e13e68aaed81baa7","unresolved":false,"context_lines":[{"line_number":128,"context_line":""},{"line_number":129,"context_line":"        # Verify default Security group"},{"line_number":130,"context_line":"        server \u003d self.servers_client.show_server(server[\u0027id\u0027])[\u0027server\u0027]"},{"line_number":131,"context_line":"        self.assertFalse(\u0027security_groups\u0027 in server)"}],"source_content_type":"text/x-python","patch_set":10,"id":"dfeb2761_0db41ef1","line":131,"range":{"start_line":131,"start_character":13,"end_line":131,"end_character":24},"in_reply_to":"dfeb2761_979041ef","updated":"2017-04-05 04:59:53.000000000","message":"Hi zhufl,thanks for your suggestions,have modified.","commit_id":"091dedf6eb684c22c2946c0ef829859b232669e1"},{"author":{"_account_id":21897,"name":"lianghao","email":"lianghao@cmss.chinamobile.com","username":"cloud-liang"},"change_message_id":"467836956ec78b6305bf43e9e13e68aaed81baa7","unresolved":false,"context_lines":[{"line_number":128,"context_line":""},{"line_number":129,"context_line":"        # Verify default Security group"},{"line_number":130,"context_line":"        server \u003d self.servers_client.show_server(server[\u0027id\u0027])[\u0027server\u0027]"},{"line_number":131,"context_line":"        self.assertFalse(\u0027security_groups\u0027 in server)"}],"source_content_type":"text/x-python","patch_set":10,"id":"dfeb2761_4da346b3","line":131,"in_reply_to":"dfeb2761_d2613707","updated":"2017-04-05 04:59:53.000000000","message":"Hi Masayuki Igawa,thanks for your suggestions,have modified.","commit_id":"091dedf6eb684c22c2946c0ef829859b232669e1"},{"author":{"_account_id":1921,"name":"Andrea Frittoli","email":"andrea.frittoli@gmail.com","username":"andrea-frittoli"},"change_message_id":"953f3735f2d57cbced030fcb70e219b889548174","unresolved":false,"context_lines":[{"line_number":120,"context_line":"        # Delete Security group"},{"line_number":121,"context_line":"        self.servers_client.remove_security_group(self.server_id,"},{"line_number":122,"context_line":"                                                  name\u003dself.sg_name)"},{"line_number":123,"context_line":""},{"line_number":124,"context_line":"        server \u003d self.servers_client.show_server(self.server_id)[\u0027server\u0027]"},{"line_number":125,"context_line":"        # Remove default Security group"},{"line_number":126,"context_line":"        self.servers_client.remove_security_group("},{"line_number":127,"context_line":"            server[\u0027id\u0027], name\u003dserver[\u0027security_groups\u0027][0][\u0027name\u0027])"},{"line_number":128,"context_line":""},{"line_number":129,"context_line":"        # Verify default Security group"},{"line_number":130,"context_line":"        server \u003d self.servers_client.show_server(server[\u0027id\u0027])[\u0027server\u0027]"},{"line_number":131,"context_line":"        self.assertNotIn(\u0027security_groups\u0027, server)"}],"source_content_type":"text/x-python","patch_set":11,"id":"bff0334d_034b3a84","line":131,"range":{"start_line":123,"start_character":0,"end_line":131,"end_character":51},"updated":"2017-04-06 14:55:05.000000000","message":"TBH I don\u0027t think this belongs here. This test is specific to rescued VMs.\n\nAdd/remove of security groups from a server is an action in the servers API.\nSo test_server_actions is probably the right place.","commit_id":"f2fbae9a5fc9367d579cf4bfe4b5c2aa0870ca5c"}],"tempest/api/compute/servers/test_servers.py":[{"author":{"_account_id":5689,"name":"Masayuki Igawa","email":"masayuki@igawa.io","username":"igawa"},"change_message_id":"fcd37e329eb211974b2d5a046f04ef587336e70d","unresolved":false,"context_lines":[{"line_number":81,"context_line":"        self.assertEqual(key_name, server[\u0027key_name\u0027])"},{"line_number":82,"context_line":""},{"line_number":83,"context_line":"    @decorators.idempotent_id(\u00279765c060-16ab-11e7-a72e-fa163e4fa634\u0027)"},{"line_number":84,"context_line":"    def create_server_set_security_group_empty(self):"},{"line_number":85,"context_line":"        # create server"},{"line_number":86,"context_line":"        server \u003d self.create_test_server(wait_until\u003d\u0027ACTIVE\u0027)"},{"line_number":87,"context_line":"        # set security_group of the server to empty"}],"source_content_type":"text/x-python","patch_set":5,"id":"dfeb2761_09e1dfd0","line":84,"updated":"2017-04-04 02:53:00.000000000","message":"The method name should start with \u0027test_\u0027, otherwise this doesn\u0027t run.","commit_id":"e97d7dc1c300224ff99d75e4116f7c399562dab2"},{"author":{"_account_id":21897,"name":"lianghao","email":"lianghao@cmss.chinamobile.com","username":"cloud-liang"},"change_message_id":"bbeaca3a5865889ea5c41bb558f42fc7892c0cc8","unresolved":false,"context_lines":[{"line_number":81,"context_line":"        self.assertEqual(key_name, server[\u0027key_name\u0027])"},{"line_number":82,"context_line":""},{"line_number":83,"context_line":"    @decorators.idempotent_id(\u00279765c060-16ab-11e7-a72e-fa163e4fa634\u0027)"},{"line_number":84,"context_line":"    def create_server_set_security_group_empty(self):"},{"line_number":85,"context_line":"        # create server"},{"line_number":86,"context_line":"        server \u003d self.create_test_server(wait_until\u003d\u0027ACTIVE\u0027)"},{"line_number":87,"context_line":"        # set security_group of the server to empty"}],"source_content_type":"text/x-python","patch_set":5,"id":"dfeb2761_c93e57d9","line":84,"in_reply_to":"dfeb2761_09e1dfd0","updated":"2017-04-04 03:36:36.000000000","message":"Hi Masayuki Igawa,thanks for your suggestion,I have modified.","commit_id":"e97d7dc1c300224ff99d75e4116f7c399562dab2"},{"author":{"_account_id":8556,"name":"Ghanshyam Maan","display_name":"Ghanshyam Maan","email":"gmaan.os14@gmail.com","username":"ghanshyam"},"change_message_id":"66ab8ef312039d23c6db3513432bb1c478336f08","unresolved":false,"context_lines":[{"line_number":85,"context_line":"        server \u003d self.client.show_server(server[\u0027id\u0027])[\u0027server\u0027]"},{"line_number":86,"context_line":"        self.assertEqual(key_name, server[\u0027key_name\u0027])"},{"line_number":87,"context_line":""},{"line_number":88,"context_line":"    @decorators.idempotent_id(\u00279765c060-16ab-11e7-a72e-fa163e4fa634\u0027)"},{"line_number":89,"context_line":"    def test_create_server_update_security_group_empty(self):"},{"line_number":90,"context_line":"        # create server"},{"line_number":91,"context_line":"        server \u003d self.create_test_server(wait_until\u003d\u0027ACTIVE\u0027)"},{"line_number":92,"context_line":"        # update security_group of the server to empty"},{"line_number":93,"context_line":"        self.admin_servers_client.remove_security_group("},{"line_number":94,"context_line":"            server[\u0027id\u0027], name\u003dserver[\u0027security_groups\u0027][0][\u0027name\u0027])"},{"line_number":95,"context_line":"        server \u003d self.client.show_server(server[\u0027id\u0027])[\u0027server\u0027]"},{"line_number":96,"context_line":"        self.assertFalse(\u0027security_groups\u0027 in server)"},{"line_number":97,"context_line":""},{"line_number":98,"context_line":"    def _update_server_name(self, server_id, status, prefix_name\u003d\u0027server\u0027):"},{"line_number":99,"context_line":"        # The server name should be changed to the provided value"}],"source_content_type":"text/x-python","patch_set":7,"id":"dfeb2761_d6a4abbb","line":96,"range":{"start_line":88,"start_character":0,"end_line":96,"end_character":53},"updated":"2017-04-04 11:04:19.000000000","message":"remove security group is being tested in 2 place actually\n\n- https://github.com/openstack/tempest/blob/6533dd857adb86e81bd2a1b1a9b5516a2efa7761/tempest/scenario/test_minimum_basic.py#L81\n\n- https://github.com/openstack/tempest/blob/b960e490dbb673edb63180997b1bcdab96ddba69/tempest/api/compute/servers/test_server_rescue.py#L121\n\nI do not think we need to ad separate tests. if you want to confirm there is no security group after deleting the one you can just modify either one of the exitsing test to perform the check.","commit_id":"7338b2206f8137bca2006eb85ddc45ba42bb357e"}]}