)]}'
{"releasenotes/notes/bp-list-show-all-server-migration-types-9b98bfa3ed985d57.yaml":[{"author":{"_account_id":23186,"name":"Felipe Monteiro","email":"felipe.carneiro.monteiro@gmail.com","username":"felipe.monteiro"},"change_message_id":"419a408781273337233ecac7a3e321c81c159807","unresolved":false,"context_lines":[{"line_number":5,"context_line":"    the compute servers_client library."},{"line_number":6,"context_line":"    Add validation schema for the compute list server migrations"},{"line_number":7,"context_line":"    and show server migration APIs."},{"line_number":8,"context_line":"    Add tempest tests for list server migrations in compute APIs."}],"source_content_type":"text/x-yaml","patch_set":17,"id":"3f1d235d_1022b5b9","line":8,"range":{"start_line":8,"start_character":4,"end_line":8,"end_character":65},"updated":"2017-07-06 23:25:56.000000000","message":"Not sure if this should be included in release notes.","commit_id":"f9d07da9eb7af621243d93426bbb2f94f7e0481a"},{"author":{"_account_id":7634,"name":"Takashi Natsume","email":"takanattie@gmail.com","username":"natsumet"},"change_message_id":"ff872ba6fd2d55273ce96aa377f4ac7b7f129912","unresolved":false,"context_lines":[{"line_number":5,"context_line":"    the compute servers_client library."},{"line_number":6,"context_line":"    Add validation schema for the compute list server migrations"},{"line_number":7,"context_line":"    and show server migration APIs."},{"line_number":8,"context_line":"    Add tempest tests for list server migrations in compute APIs."}],"source_content_type":"text/x-yaml","patch_set":17,"id":"1f1a1f67_932ad88d","line":8,"range":{"start_line":8,"start_character":4,"end_line":8,"end_character":65},"in_reply_to":"3f1d235d_1022b5b9","updated":"2017-07-14 16:41:56.000000000","message":"Done","commit_id":"f9d07da9eb7af621243d93426bbb2f94f7e0481a"}],"tempest/api/compute/admin/test_migrations.py":[{"author":{"_account_id":23186,"name":"Felipe Monteiro","email":"felipe.carneiro.monteiro@gmail.com","username":"felipe.monteiro"},"change_message_id":"ecbb92c816b096534fa53a190bcb35ee47b0fac3","unresolved":false,"context_lines":[{"line_number":138,"context_line":"        self._test_cold_migrate_server(revert\u003dTrue)"},{"line_number":139,"context_line":""},{"line_number":140,"context_line":""},{"line_number":141,"context_line":"class MigrationsAdminTestV247(base.BaseV2ComputeAdminTest):"},{"line_number":142,"context_line":"    min_microversion \u003d \u00272.47\u0027"},{"line_number":143,"context_line":"    max_microversion \u003d \u0027latest\u0027"},{"line_number":144,"context_line":""}],"source_content_type":"text/x-python","patch_set":7,"id":"df140735_d307e281","line":141,"range":{"start_line":141,"start_character":6,"end_line":141,"end_character":29},"updated":"2017-06-02 22:58:46.000000000","message":"MigrationsV247AdminTest\n\n^ That\u0027s the general naming pattern I\u0027ve observed Tempest versioned tests, e.g.: https://github.com/openstack/tempest/blob/23aa354f178878ee4d5385db7ce51999726ef8b4/tempest/api/compute/keypairs/test_keypairs_v22.py#L20","commit_id":"c165f06395717c479804fb2e713bcc8c9d382a3a"},{"author":{"_account_id":7634,"name":"Takashi Natsume","email":"takanattie@gmail.com","username":"natsumet"},"change_message_id":"c4ab8cce604c97c07473299f24ae871cf8444e62","unresolved":false,"context_lines":[{"line_number":138,"context_line":"        self._test_cold_migrate_server(revert\u003dTrue)"},{"line_number":139,"context_line":""},{"line_number":140,"context_line":""},{"line_number":141,"context_line":"class MigrationsAdminTestV247(base.BaseV2ComputeAdminTest):"},{"line_number":142,"context_line":"    min_microversion \u003d \u00272.47\u0027"},{"line_number":143,"context_line":"    max_microversion \u003d \u0027latest\u0027"},{"line_number":144,"context_line":""}],"source_content_type":"text/x-python","patch_set":7,"id":"df140735_e0b9d478","line":141,"range":{"start_line":141,"start_character":6,"end_line":141,"end_character":29},"in_reply_to":"df140735_d307e281","updated":"2017-06-05 03:46:11.000000000","message":"Done","commit_id":"c165f06395717c479804fb2e713bcc8c9d382a3a"},{"author":{"_account_id":8556,"name":"Ghanshyam Maan","display_name":"Ghanshyam Maan","email":"gmaan.os14@gmail.com","username":"ghanshyam"},"change_message_id":"dd4b449648a8bb9b9c356d79a73ee9caad7e5767","unresolved":false,"context_lines":[{"line_number":140,"context_line":""},{"line_number":141,"context_line":"class MigrationsV254AdminTest(base.BaseV2ComputeAdminTest):"},{"line_number":142,"context_line":"    min_microversion \u003d \u00272.54\u0027"},{"line_number":143,"context_line":"    max_microversion \u003d \u0027latest\u0027"},{"line_number":144,"context_line":""},{"line_number":145,"context_line":"    @decorators.idempotent_id(\u0027b5fad5a2-6d8b-4a19-8922-0939d804a631\u0027)"},{"line_number":146,"context_line":"    def test_list_server_migrations(self):"}],"source_content_type":"text/x-python","patch_set":26,"id":"7f515b1d_806e31c7","line":143,"range":{"start_line":143,"start_character":30,"end_line":143,"end_character":31},"updated":"2017-10-04 13:36:07.000000000","message":"need test for show migration also. can we add show migration inside _test_cold_migrate_server ? \nwe can use compare_version_header_to_response() [1] to check the type is returned correctly. \n\n.. 1 https://github.com/openstack/tempest/blob/master/tempest/lib/common/api_version_utils.py#L125","commit_id":"1ed4743ed9eceba0393e05865c66c674a94ef77d"},{"author":{"_account_id":7634,"name":"Takashi Natsume","email":"takanattie@gmail.com","username":"natsumet"},"change_message_id":"e9940f16261bb50b86eaa6449c30a8b939aa13da","unresolved":false,"context_lines":[{"line_number":140,"context_line":""},{"line_number":141,"context_line":"class MigrationsV254AdminTest(base.BaseV2ComputeAdminTest):"},{"line_number":142,"context_line":"    min_microversion \u003d \u00272.54\u0027"},{"line_number":143,"context_line":"    max_microversion \u003d \u0027latest\u0027"},{"line_number":144,"context_line":""},{"line_number":145,"context_line":"    @decorators.idempotent_id(\u0027b5fad5a2-6d8b-4a19-8922-0939d804a631\u0027)"},{"line_number":146,"context_line":"    def test_list_server_migrations(self):"}],"source_content_type":"text/x-python","patch_set":26,"id":"5f4e5783_9fe76113","line":143,"range":{"start_line":143,"start_character":30,"end_line":143,"end_character":31},"in_reply_to":"7f515b1d_806e31c7","updated":"2017-10-13 05:16:49.000000000","message":"See commit message.\nListing/showing a server being resized has some difficulties.\nIt is a timing issue.\nSo test listing server migrations with a server not being resized.","commit_id":"1ed4743ed9eceba0393e05865c66c674a94ef77d"},{"author":{"_account_id":8556,"name":"Ghanshyam Maan","display_name":"Ghanshyam Maan","email":"gmaan.os14@gmail.com","username":"ghanshyam"},"change_message_id":"dd4b449648a8bb9b9c356d79a73ee9caad7e5767","unresolved":false,"context_lines":[{"line_number":145,"context_line":"    @decorators.idempotent_id(\u0027b5fad5a2-6d8b-4a19-8922-0939d804a631\u0027)"},{"line_number":146,"context_line":"    def test_list_server_migrations(self):"},{"line_number":147,"context_line":"        server \u003d self.create_test_server(networks\u003d\u0027none\u0027, wait_until\u003d\"ACTIVE\")"},{"line_number":148,"context_line":"        self.admin_servers_client.list_server_migrations("},{"line_number":149,"context_line":"            server_id\u003dserver[\u0027id\u0027])"}],"source_content_type":"text/x-python","patch_set":26,"id":"7f515b1d_40db997c","line":149,"range":{"start_line":148,"start_character":8,"end_line":149,"end_character":35},"updated":"2017-10-04 13:36:07.000000000","message":"this is like checking the empty list which is not checking schema also. can we add this list check in  _test_cold_migrate_server? like i commented for show migration testing.","commit_id":"1ed4743ed9eceba0393e05865c66c674a94ef77d"},{"author":{"_account_id":7634,"name":"Takashi Natsume","email":"takanattie@gmail.com","username":"natsumet"},"change_message_id":"e9940f16261bb50b86eaa6449c30a8b939aa13da","unresolved":false,"context_lines":[{"line_number":145,"context_line":"    @decorators.idempotent_id(\u0027b5fad5a2-6d8b-4a19-8922-0939d804a631\u0027)"},{"line_number":146,"context_line":"    def test_list_server_migrations(self):"},{"line_number":147,"context_line":"        server \u003d self.create_test_server(networks\u003d\u0027none\u0027, wait_until\u003d\"ACTIVE\")"},{"line_number":148,"context_line":"        self.admin_servers_client.list_server_migrations("},{"line_number":149,"context_line":"            server_id\u003dserver[\u0027id\u0027])"}],"source_content_type":"text/x-python","patch_set":26,"id":"5f4e5783_5ff1e9cc","line":149,"range":{"start_line":148,"start_character":8,"end_line":149,"end_character":35},"in_reply_to":"7f515b1d_40db997c","updated":"2017-10-13 05:16:49.000000000","message":"ditto","commit_id":"1ed4743ed9eceba0393e05865c66c674a94ef77d"},{"author":{"_account_id":6167,"name":"Ken\u0027ichi Ohmichi","email":"ken1ohmichi@gmail.com","username":"oomichi"},"change_message_id":"d1bb55e9aa312c5e4996b54fbaff9c6f4dc3e28a","unresolved":false,"context_lines":[{"line_number":154,"context_line":"    max_microversion \u003d \u0027latest\u0027"},{"line_number":155,"context_line":""},{"line_number":156,"context_line":"    @decorators.idempotent_id(\u0027b5fad5a2-6d8b-4a19-8922-0939d804a631\u0027)"},{"line_number":157,"context_line":"    def test_list_server_migrations(self):"},{"line_number":158,"context_line":"        server \u003d self.create_test_server(networks\u003d\u0027none\u0027, wait_until\u003d\"ACTIVE\")"},{"line_number":159,"context_line":"        self.admin_servers_client.list_server_migrations("},{"line_number":160,"context_line":"            server_id\u003dserver[\u0027id\u0027])"}],"source_content_type":"text/x-python","patch_set":41,"id":"df87a7cf_5934ab4a","line":157,"range":{"start_line":157,"start_character":0,"end_line":157,"end_character":42},"updated":"2017-12-14 20:01:20.000000000","message":"Could you put a NOTE which explains what is different from the previous version to avoid we need to see Nova microversion history later.","commit_id":"222dcd287bd335e48d3fb3f8022a865a79596fcc"},{"author":{"_account_id":7634,"name":"Takashi Natsume","email":"takanattie@gmail.com","username":"natsumet"},"change_message_id":"d9f9b4cf0976c644cadd44f69f123345e9c01b8b","unresolved":false,"context_lines":[{"line_number":154,"context_line":"    max_microversion \u003d \u0027latest\u0027"},{"line_number":155,"context_line":""},{"line_number":156,"context_line":"    @decorators.idempotent_id(\u0027b5fad5a2-6d8b-4a19-8922-0939d804a631\u0027)"},{"line_number":157,"context_line":"    def test_list_server_migrations(self):"},{"line_number":158,"context_line":"        server \u003d self.create_test_server(networks\u003d\u0027none\u0027, wait_until\u003d\"ACTIVE\")"},{"line_number":159,"context_line":"        self.admin_servers_client.list_server_migrations("},{"line_number":160,"context_line":"            server_id\u003dserver[\u0027id\u0027])"}],"source_content_type":"text/x-python","patch_set":41,"id":"df87a7cf_743936d5","line":157,"range":{"start_line":157,"start_character":0,"end_line":157,"end_character":42},"in_reply_to":"df87a7cf_5934ab4a","updated":"2017-12-18 06:59:55.000000000","message":"Done","commit_id":"222dcd287bd335e48d3fb3f8022a865a79596fcc"}],"tempest/lib/api_schema/response/compute/v2_49/servers.py":[{"author":{"_account_id":9569,"name":"Sergey Nikitin","email":"nikitinserv@gmail.com","username":"snikitin"},"change_message_id":"e2018f348fc39bb970fb47bc71c8b6594a134342","unresolved":false,"context_lines":[{"line_number":110,"context_line":""},{"line_number":111,"context_line":"# To pass the validation check in creating a server"},{"line_number":112,"context_line":"# for the list server migration test."},{"line_number":113,"context_line":"get_server \u003d copy.deepcopy(servers247.get_server)"}],"source_content_type":"text/x-python","patch_set":9,"id":"bf091321_3969f9bd","line":113,"updated":"2017-06-08 08:49:03.000000000","message":"Maybe you should get \u0027get_server\u0027 from servers248? I know version 2.48 doesn\u0027t add anything into v2.47 schema but I think that linear dependency than tree dependency.","commit_id":"422cd7daba60c61f2ee8124ae8c14e6e23b60446"},{"author":{"_account_id":7634,"name":"Takashi Natsume","email":"takanattie@gmail.com","username":"natsumet"},"change_message_id":"0b5af77edab75f6a3a05ecc8e030714bf8af98ab","unresolved":false,"context_lines":[{"line_number":110,"context_line":""},{"line_number":111,"context_line":"# To pass the validation check in creating a server"},{"line_number":112,"context_line":"# for the list server migration test."},{"line_number":113,"context_line":"get_server \u003d copy.deepcopy(servers247.get_server)"}],"source_content_type":"text/x-python","patch_set":9,"id":"7f231b9d_feee8eb2","line":113,"in_reply_to":"bf091321_3969f9bd","updated":"2017-06-13 07:03:42.000000000","message":"Done","commit_id":"422cd7daba60c61f2ee8124ae8c14e6e23b60446"}],"tempest/lib/api_schema/response/compute/v2_50/servers.py":[{"author":{"_account_id":20190,"name":"zhufl","email":"zhu.fanglei@zte.com.cn","username":"zhufl"},"change_message_id":"55789d947696cae2d336007c49a11e9fceaa1c89","unresolved":false,"context_lines":[{"line_number":108,"context_line":"    }"},{"line_number":109,"context_line":"}"},{"line_number":110,"context_line":""},{"line_number":111,"context_line":"# To pass the validation check in creating a server"},{"line_number":112,"context_line":"# for the list server migration test."},{"line_number":113,"context_line":"get_server \u003d copy.deepcopy(servers248.get_server)"}],"source_content_type":"text/x-python","patch_set":17,"id":"3f1d235d_ac3b25cf","line":113,"range":{"start_line":111,"start_character":0,"end_line":113,"end_character":49},"updated":"2017-07-12 06:28:33.000000000","message":"I wonder what is this for? seems can be removed","commit_id":"f9d07da9eb7af621243d93426bbb2f94f7e0481a"},{"author":{"_account_id":7634,"name":"Takashi Natsume","email":"takanattie@gmail.com","username":"natsumet"},"change_message_id":"ff872ba6fd2d55273ce96aa377f4ac7b7f129912","unresolved":false,"context_lines":[{"line_number":108,"context_line":"    }"},{"line_number":109,"context_line":"}"},{"line_number":110,"context_line":""},{"line_number":111,"context_line":"# To pass the validation check in creating a server"},{"line_number":112,"context_line":"# for the list server migration test."},{"line_number":113,"context_line":"get_server \u003d copy.deepcopy(servers248.get_server)"}],"source_content_type":"text/x-python","patch_set":17,"id":"1f1a1f67_28a5ceb5","line":113,"range":{"start_line":111,"start_character":0,"end_line":113,"end_character":49},"in_reply_to":"3f1d235d_ac3b25cf","updated":"2017-07-14 16:41:56.000000000","message":"It is necessary.\n\nIn test_list_server_migrations, create_test_server is called.\nA waiter calls show_server. So get_server schema is required in show_server.\n\nhttps://review.openstack.org/#/c/452650/17/tempest/api/compute/admin/test_migrations.py@147\n\nhttps://github.com/openstack/tempest/blob/b43a16db0a87b3f99683d26b2079de379a6ef8db/tempest/common/compute.py#L187\nhttps://github.com/openstack/tempest/blob/b43a16db0a87b3f99683d26b2079de379a6ef8db/tempest/common/waiters.py#L40\nhttps://github.com/openstack/tempest/blob/b43a16db0a87b3f99683d26b2079de379a6ef8db/tempest/lib/services/compute/servers_client.py#L134","commit_id":"f9d07da9eb7af621243d93426bbb2f94f7e0481a"}],"tempest/lib/api_schema/response/compute/v2_54/servers.py":[{"author":{"_account_id":8556,"name":"Ghanshyam Maan","display_name":"Ghanshyam Maan","email":"gmaan.os14@gmail.com","username":"ghanshyam"},"change_message_id":"dd4b449648a8bb9b9c356d79a73ee9caad7e5767","unresolved":false,"context_lines":[{"line_number":15,"context_line":"import copy"},{"line_number":16,"context_line":""},{"line_number":17,"context_line":"from tempest.lib.api_schema.response.compute.v2_48 import servers as servers248"},{"line_number":18,"context_line":""},{"line_number":19,"context_line":""},{"line_number":20,"context_line":"list_server_migrations \u003d {"},{"line_number":21,"context_line":"    \u0027status_code\u0027: [200],"}],"source_content_type":"text/x-python","patch_set":26,"id":"7f515b1d_a0636db1","line":18,"range":{"start_line":18,"start_character":0,"end_line":18,"end_character":0},"updated":"2017-10-04 13:36:07.000000000","message":"as you have added service client method which can be used for any microversion, you need to add these schema in compute/2_1/ also. same schema with \u0027type\u0027 and \u0027status\u0027 change.","commit_id":"1ed4743ed9eceba0393e05865c66c674a94ef77d"},{"author":{"_account_id":7634,"name":"Takashi Natsume","email":"takanattie@gmail.com","username":"natsumet"},"change_message_id":"e9940f16261bb50b86eaa6449c30a8b939aa13da","unresolved":false,"context_lines":[{"line_number":15,"context_line":"import copy"},{"line_number":16,"context_line":""},{"line_number":17,"context_line":"from tempest.lib.api_schema.response.compute.v2_48 import servers as servers248"},{"line_number":18,"context_line":""},{"line_number":19,"context_line":""},{"line_number":20,"context_line":"list_server_migrations \u003d {"},{"line_number":21,"context_line":"    \u0027status_code\u0027: [200],"}],"source_content_type":"text/x-python","patch_set":26,"id":"5f4e5783_d3b6f2fa","line":18,"range":{"start_line":18,"start_character":0,"end_line":18,"end_character":0},"in_reply_to":"7f515b1d_a0636db1","updated":"2017-10-13 05:16:49.000000000","message":"server migration function has been added in 2.23.\nSo add schema to 2.23.","commit_id":"1ed4743ed9eceba0393e05865c66c674a94ef77d"},{"author":{"_account_id":8556,"name":"Ghanshyam Maan","display_name":"Ghanshyam Maan","email":"gmaan.os14@gmail.com","username":"ghanshyam"},"change_message_id":"dd4b449648a8bb9b9c356d79a73ee9caad7e5767","unresolved":false,"context_lines":[{"line_number":54,"context_line":"                        \u0027disk_total_bytes\u0027, \u0027id\u0027, \u0027memory_processed_bytes\u0027,"},{"line_number":55,"context_line":"                        \u0027memory_remaining_bytes\u0027, \u0027memory_total_bytes\u0027,"},{"line_number":56,"context_line":"                        \u0027server_uuid\u0027, \u0027source_compute\u0027, \u0027source_node\u0027,"},{"line_number":57,"context_line":"                        \u0027type\u0027, \u0027updated_at\u0027"},{"line_number":58,"context_line":"                    ]"},{"line_number":59,"context_line":"                }"},{"line_number":60,"context_line":"            }"}],"source_content_type":"text/x-python","patch_set":26,"id":"7f515b1d_ca29eaf2","line":57,"range":{"start_line":57,"start_character":25,"end_line":57,"end_character":29},"updated":"2017-10-04 13:36:07.000000000","message":"this seems not required from current nova change. But I think it should be returned always. i gave comment in nova change. \n\nhttps://review.openstack.org/#/c/459483/33/nova/api/openstack/compute/server_migrations.py L59","commit_id":"1ed4743ed9eceba0393e05865c66c674a94ef77d"},{"author":{"_account_id":7634,"name":"Takashi Natsume","email":"takanattie@gmail.com","username":"natsumet"},"change_message_id":"e9940f16261bb50b86eaa6449c30a8b939aa13da","unresolved":false,"context_lines":[{"line_number":54,"context_line":"                        \u0027disk_total_bytes\u0027, \u0027id\u0027, \u0027memory_processed_bytes\u0027,"},{"line_number":55,"context_line":"                        \u0027memory_remaining_bytes\u0027, \u0027memory_total_bytes\u0027,"},{"line_number":56,"context_line":"                        \u0027server_uuid\u0027, \u0027source_compute\u0027, \u0027source_node\u0027,"},{"line_number":57,"context_line":"                        \u0027type\u0027, \u0027updated_at\u0027"},{"line_number":58,"context_line":"                    ]"},{"line_number":59,"context_line":"                }"},{"line_number":60,"context_line":"            }"}],"source_content_type":"text/x-python","patch_set":26,"id":"5f4e5783_b3e016fc","line":57,"range":{"start_line":57,"start_character":25,"end_line":57,"end_character":29},"in_reply_to":"7f515b1d_ca29eaf2","updated":"2017-10-13 05:16:49.000000000","message":"In latest patch set, it is required.","commit_id":"1ed4743ed9eceba0393e05865c66c674a94ef77d"}],"tempest/lib/api_schema/response/compute/v2_61/servers.py":[{"author":{"_account_id":8556,"name":"Ghanshyam Maan","display_name":"Ghanshyam Maan","email":"gmaan.os14@gmail.com","username":"ghanshyam"},"change_message_id":"59c118920fdf703fc8348aa6d6f3a6a0cc498d00","unresolved":false,"context_lines":[{"line_number":47,"context_line":"    \u0027properties\u0027].pop(\u0027status\u0027)"},{"line_number":48,"context_line":"show_server_migration[\u0027response_body\u0027][\u0027properties\u0027][\u0027migration\u0027]["},{"line_number":49,"context_line":"    \u0027required\u0027].remove(\u0027status\u0027)"},{"line_number":50,"context_line":""},{"line_number":51,"context_line":"# To pass the validation check in creating a server"},{"line_number":52,"context_line":"# for the list server migration test."},{"line_number":53,"context_line":"get_server \u003d copy.deepcopy(servers248.get_server)"}],"source_content_type":"text/x-python","patch_set":51,"id":"3fa0c359_5ba91879","line":50,"range":{"start_line":50,"start_character":0,"end_line":50,"end_character":0},"updated":"2018-02-06 08:28:01.000000000","message":"we need all these schema as raw but it is same for other also so it is ok as of now.","commit_id":"52b9a6a8265d95124630081b1d1dc494e539566f"}],"tempest/lib/services/compute/servers_client.py":[{"author":{"_account_id":23186,"name":"Felipe Monteiro","email":"felipe.carneiro.monteiro@gmail.com","username":"felipe.monteiro"},"change_message_id":"191f828d031487a2d1e75e0410417f908a1d4cd2","unresolved":false,"context_lines":[{"line_number":887,"context_line":"    def show_server_migration(self, server_id, migration_id):"},{"line_number":888,"context_line":"        \"\"\"SHow the given server migration."},{"line_number":889,"context_line":""},{"line_number":890,"context_line":"        For a full list of available parameters, please refer to the official"},{"line_number":891,"context_line":"        API reference:"},{"line_number":892,"context_line":"        https://developer.openstack.org/api-ref/compute/#server-migrations-servers-migrations"},{"line_number":893,"context_line":"        \"\"\""},{"line_number":894,"context_line":"        schema \u003d self.get_schema(self.schema_versions_info)"}],"source_content_type":"text/x-python","patch_set":11,"id":"5f201791_2363a444","line":891,"range":{"start_line":890,"start_character":8,"end_line":891,"end_character":22},"updated":"2017-06-23 16:18:40.000000000","message":"If there aren\u0027t additional parameters, then this could be rephrased to something like:\n\nFor more information, please refer to the official API reference.","commit_id":"4c47cea3138ec183e9d87593636c0f79c7a94f29"},{"author":{"_account_id":7634,"name":"Takashi Natsume","email":"takanattie@gmail.com","username":"natsumet"},"change_message_id":"700643b2bb51f21799371a71bd95ceef926bc17c","unresolved":false,"context_lines":[{"line_number":887,"context_line":"    def show_server_migration(self, server_id, migration_id):"},{"line_number":888,"context_line":"        \"\"\"SHow the given server migration."},{"line_number":889,"context_line":""},{"line_number":890,"context_line":"        For a full list of available parameters, please refer to the official"},{"line_number":891,"context_line":"        API reference:"},{"line_number":892,"context_line":"        https://developer.openstack.org/api-ref/compute/#server-migrations-servers-migrations"},{"line_number":893,"context_line":"        \"\"\""},{"line_number":894,"context_line":"        schema \u003d self.get_schema(self.schema_versions_info)"}],"source_content_type":"text/x-python","patch_set":11,"id":"3f1d235d_4a2cdc46","line":891,"range":{"start_line":890,"start_character":8,"end_line":891,"end_character":22},"in_reply_to":"5f201791_2363a444","updated":"2017-06-29 11:50:49.000000000","message":"Done","commit_id":"4c47cea3138ec183e9d87593636c0f79c7a94f29"},{"author":{"_account_id":20190,"name":"zhufl","email":"zhu.fanglei@zte.com.cn","username":"zhufl"},"change_message_id":"55789d947696cae2d336007c49a11e9fceaa1c89","unresolved":false,"context_lines":[{"line_number":881,"context_line":""},{"line_number":882,"context_line":"        resp, body \u003d self.get(url)"},{"line_number":883,"context_line":"        body \u003d json.loads(body)"},{"line_number":884,"context_line":"        self.validate_response(_schema, resp, body)"},{"line_number":885,"context_line":"        return rest_client.ResponseBody(resp, body)"},{"line_number":886,"context_line":""},{"line_number":887,"context_line":"    def show_server_migration(self, server_id, migration_id):"}],"source_content_type":"text/x-python","patch_set":17,"id":"3f1d235d_4129fa98","line":884,"range":{"start_line":884,"start_character":8,"end_line":884,"end_character":51},"updated":"2017-07-12 06:28:33.000000000","message":"how about put it directly:\nself.validate_response(schema.list_server_migrations, resp, body)","commit_id":"f9d07da9eb7af621243d93426bbb2f94f7e0481a"},{"author":{"_account_id":7634,"name":"Takashi Natsume","email":"takanattie@gmail.com","username":"natsumet"},"change_message_id":"ff872ba6fd2d55273ce96aa377f4ac7b7f129912","unresolved":false,"context_lines":[{"line_number":881,"context_line":""},{"line_number":882,"context_line":"        resp, body \u003d self.get(url)"},{"line_number":883,"context_line":"        body \u003d json.loads(body)"},{"line_number":884,"context_line":"        self.validate_response(_schema, resp, body)"},{"line_number":885,"context_line":"        return rest_client.ResponseBody(resp, body)"},{"line_number":886,"context_line":""},{"line_number":887,"context_line":"    def show_server_migration(self, server_id, migration_id):"}],"source_content_type":"text/x-python","patch_set":17,"id":"1f1a1f67_ae556bc8","line":884,"range":{"start_line":884,"start_character":8,"end_line":884,"end_character":51},"in_reply_to":"3f1d235d_4129fa98","updated":"2017-07-14 16:41:56.000000000","message":"Done","commit_id":"f9d07da9eb7af621243d93426bbb2f94f7e0481a"},{"author":{"_account_id":20190,"name":"zhufl","email":"zhu.fanglei@zte.com.cn","username":"zhufl"},"change_message_id":"55789d947696cae2d336007c49a11e9fceaa1c89","unresolved":false,"context_lines":[{"line_number":888,"context_line":"        \"\"\"Show the given server migration."},{"line_number":889,"context_line":""},{"line_number":890,"context_line":"        For more information, please refer to the official API reference:"},{"line_number":891,"context_line":"        https://developer.openstack.org/api-ref/compute/#server-migrations-servers-migrations"},{"line_number":892,"context_line":"        \"\"\""},{"line_number":893,"context_line":"        schema \u003d self.get_schema(self.schema_versions_info)"},{"line_number":894,"context_line":"        _schema \u003d schema.show_server_migration"}],"source_content_type":"text/x-python","patch_set":17,"id":"3f1d235d_ec08fd28","line":891,"range":{"start_line":891,"start_character":8,"end_line":891,"end_character":93},"updated":"2017-07-12 06:28:33.000000000","message":"this should be:\nhttps://developer.openstack.org/api-ref/compute/#show-migration-details","commit_id":"f9d07da9eb7af621243d93426bbb2f94f7e0481a"},{"author":{"_account_id":7634,"name":"Takashi Natsume","email":"takanattie@gmail.com","username":"natsumet"},"change_message_id":"ff872ba6fd2d55273ce96aa377f4ac7b7f129912","unresolved":false,"context_lines":[{"line_number":888,"context_line":"        \"\"\"Show the given server migration."},{"line_number":889,"context_line":""},{"line_number":890,"context_line":"        For more information, please refer to the official API reference:"},{"line_number":891,"context_line":"        https://developer.openstack.org/api-ref/compute/#server-migrations-servers-migrations"},{"line_number":892,"context_line":"        \"\"\""},{"line_number":893,"context_line":"        schema \u003d self.get_schema(self.schema_versions_info)"},{"line_number":894,"context_line":"        _schema \u003d schema.show_server_migration"}],"source_content_type":"text/x-python","patch_set":17,"id":"1f1a1f67_8ed62ff1","line":891,"range":{"start_line":891,"start_character":8,"end_line":891,"end_character":93},"in_reply_to":"3f1d235d_ec08fd28","updated":"2017-07-14 16:41:56.000000000","message":"Done","commit_id":"f9d07da9eb7af621243d93426bbb2f94f7e0481a"},{"author":{"_account_id":20190,"name":"zhufl","email":"zhu.fanglei@zte.com.cn","username":"zhufl"},"change_message_id":"55789d947696cae2d336007c49a11e9fceaa1c89","unresolved":false,"context_lines":[{"line_number":895,"context_line":"        resp, body \u003d self.get(\u0027servers/%s/migrations/%s\u0027 % ("},{"line_number":896,"context_line":"            server_id, migration_id))"},{"line_number":897,"context_line":"        body \u003d json.loads(body)"},{"line_number":898,"context_line":"        self.validate_response(_schema, resp, body)"},{"line_number":899,"context_line":"        return rest_client.ResponseBody(resp, body)"}],"source_content_type":"text/x-python","patch_set":17,"id":"3f1d235d_011d4272","line":898,"range":{"start_line":898,"start_character":8,"end_line":898,"end_character":51},"updated":"2017-07-12 06:28:33.000000000","message":"ditto","commit_id":"f9d07da9eb7af621243d93426bbb2f94f7e0481a"},{"author":{"_account_id":7634,"name":"Takashi Natsume","email":"takanattie@gmail.com","username":"natsumet"},"change_message_id":"ff872ba6fd2d55273ce96aa377f4ac7b7f129912","unresolved":false,"context_lines":[{"line_number":895,"context_line":"        resp, body \u003d self.get(\u0027servers/%s/migrations/%s\u0027 % ("},{"line_number":896,"context_line":"            server_id, migration_id))"},{"line_number":897,"context_line":"        body \u003d json.loads(body)"},{"line_number":898,"context_line":"        self.validate_response(_schema, resp, body)"},{"line_number":899,"context_line":"        return rest_client.ResponseBody(resp, body)"}],"source_content_type":"text/x-python","patch_set":17,"id":"1f1a1f67_4e6497b9","line":898,"range":{"start_line":898,"start_character":8,"end_line":898,"end_character":51},"in_reply_to":"3f1d235d_011d4272","updated":"2017-07-14 16:41:56.000000000","message":"Done","commit_id":"f9d07da9eb7af621243d93426bbb2f94f7e0481a"}],"tempest/tests/lib/services/compute/test_servers_client.py":[{"author":{"_account_id":8556,"name":"Ghanshyam Maan","display_name":"Ghanshyam Maan","email":"gmaan.os14@gmail.com","username":"ghanshyam"},"change_message_id":"dd4b449648a8bb9b9c356d79a73ee9caad7e5767","unresolved":false,"context_lines":[{"line_number":1107,"context_line":"            status\u003d204,"},{"line_number":1108,"context_line":"            )"},{"line_number":1109,"context_line":""},{"line_number":1110,"context_line":"    @mock.patch.object(base_compute_client, \u0027COMPUTE_MICROVERSION\u0027,"},{"line_number":1111,"context_line":"                       new_callable\u003dmock.PropertyMock(return_value\u003d\u00272.54\u0027))"},{"line_number":1112,"context_line":"    def test_list_server_migrations(self, _):"},{"line_number":1113,"context_line":"        self.check_service_client_function("},{"line_number":1114,"context_line":"            self.client.list_server_migrations,"},{"line_number":1115,"context_line":"            \u0027tempest.lib.common.rest_client.RestClient.get\u0027,"},{"line_number":1116,"context_line":"            self.FAKE_SERVER_MIGRATIONS,"},{"line_number":1117,"context_line":"            status\u003d200,"},{"line_number":1118,"context_line":"            server_id\u003dself.server_id)"},{"line_number":1119,"context_line":""},{"line_number":1120,"context_line":"    @mock.patch.object(base_compute_client, \u0027COMPUTE_MICROVERSION\u0027,"},{"line_number":1121,"context_line":"                       new_callable\u003dmock.PropertyMock(return_value\u003d\u00272.54\u0027))"},{"line_number":1122,"context_line":"    def test_show_server_migration(self, _):"},{"line_number":1123,"context_line":"        self.check_service_client_function("},{"line_number":1124,"context_line":"            self.client.show_server_migration,"},{"line_number":1125,"context_line":"            \u0027tempest.lib.common.rest_client.RestClient.get\u0027,"},{"line_number":1126,"context_line":"            self.FAKE_SERVER_MIGRATION,"},{"line_number":1127,"context_line":"            status\u003d200,"},{"line_number":1128,"context_line":"            server_id\u003dself.server_id,"},{"line_number":1129,"context_line":"            migration_id\u003dself.MIGRATION_ID)"},{"line_number":1130,"context_line":""},{"line_number":1131,"context_line":""},{"line_number":1132,"context_line":"class TestServersClientMinV26(base.BaseServiceTest):"}],"source_content_type":"text/x-python","patch_set":26,"id":"7f515b1d_2a651ee2","line":1129,"range":{"start_line":1110,"start_character":0,"end_line":1129,"end_character":43},"updated":"2017-10-04 13:36:07.000000000","message":"can we test with bytes_body\u003d true and false like done in other list/show tests.","commit_id":"1ed4743ed9eceba0393e05865c66c674a94ef77d"},{"author":{"_account_id":7634,"name":"Takashi Natsume","email":"takanattie@gmail.com","username":"natsumet"},"change_message_id":"e9940f16261bb50b86eaa6449c30a8b939aa13da","unresolved":false,"context_lines":[{"line_number":1107,"context_line":"            status\u003d204,"},{"line_number":1108,"context_line":"            )"},{"line_number":1109,"context_line":""},{"line_number":1110,"context_line":"    @mock.patch.object(base_compute_client, \u0027COMPUTE_MICROVERSION\u0027,"},{"line_number":1111,"context_line":"                       new_callable\u003dmock.PropertyMock(return_value\u003d\u00272.54\u0027))"},{"line_number":1112,"context_line":"    def test_list_server_migrations(self, _):"},{"line_number":1113,"context_line":"        self.check_service_client_function("},{"line_number":1114,"context_line":"            self.client.list_server_migrations,"},{"line_number":1115,"context_line":"            \u0027tempest.lib.common.rest_client.RestClient.get\u0027,"},{"line_number":1116,"context_line":"            self.FAKE_SERVER_MIGRATIONS,"},{"line_number":1117,"context_line":"            status\u003d200,"},{"line_number":1118,"context_line":"            server_id\u003dself.server_id)"},{"line_number":1119,"context_line":""},{"line_number":1120,"context_line":"    @mock.patch.object(base_compute_client, \u0027COMPUTE_MICROVERSION\u0027,"},{"line_number":1121,"context_line":"                       new_callable\u003dmock.PropertyMock(return_value\u003d\u00272.54\u0027))"},{"line_number":1122,"context_line":"    def test_show_server_migration(self, _):"},{"line_number":1123,"context_line":"        self.check_service_client_function("},{"line_number":1124,"context_line":"            self.client.show_server_migration,"},{"line_number":1125,"context_line":"            \u0027tempest.lib.common.rest_client.RestClient.get\u0027,"},{"line_number":1126,"context_line":"            self.FAKE_SERVER_MIGRATION,"},{"line_number":1127,"context_line":"            status\u003d200,"},{"line_number":1128,"context_line":"            server_id\u003dself.server_id,"},{"line_number":1129,"context_line":"            migration_id\u003dself.MIGRATION_ID)"},{"line_number":1130,"context_line":""},{"line_number":1131,"context_line":""},{"line_number":1132,"context_line":"class TestServersClientMinV26(base.BaseServiceTest):"}],"source_content_type":"text/x-python","patch_set":26,"id":"5f4e5783_b31136af","line":1129,"range":{"start_line":1110,"start_character":0,"end_line":1129,"end_character":43},"in_reply_to":"7f515b1d_2a651ee2","updated":"2017-10-13 05:16:49.000000000","message":"Done","commit_id":"1ed4743ed9eceba0393e05865c66c674a94ef77d"}]}
