)]}'
{"/COMMIT_MSG":[{"author":{"_account_id":23186,"name":"Felipe Monteiro","email":"felipe.carneiro.monteiro@gmail.com","username":"felipe.monteiro"},"change_message_id":"6196843f973b787e5d8461dae476b5d21e946791","unresolved":false,"context_lines":[{"line_number":6,"context_line":""},{"line_number":7,"context_line":"Add params to upload_volume command"},{"line_number":8,"context_line":""},{"line_number":9,"context_line":"Update \"test_volume_upload\" testcase to verify container-format"},{"line_number":10,"context_line":"and disk-format params."},{"line_number":11,"context_line":""},{"line_number":12,"context_line":"Change-Id: I305dff1eed42724462e2694ee5449ccbd51b0731"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":13,"id":"7f287b81_14c3315f","line":9,"range":{"start_line":9,"start_character":47,"end_line":9,"end_character":63},"updated":"2017-08-27 22:16:25.000000000","message":"I believe this is no longer true.","commit_id":"0f28d0550c1fabd7187540f6b95724ea2dcc712e"},{"author":{"_account_id":19262,"name":"Liron Kuchlani","email":"lkuchlan@redhat.com","username":"lkuchlan"},"change_message_id":"a10b40a956cf3db06c7fd3211863fa0656ea97bf","unresolved":false,"context_lines":[{"line_number":6,"context_line":""},{"line_number":7,"context_line":"Add params to upload_volume command"},{"line_number":8,"context_line":""},{"line_number":9,"context_line":"Update \"test_volume_upload\" testcase to verify container-format"},{"line_number":10,"context_line":"and disk-format params."},{"line_number":11,"context_line":""},{"line_number":12,"context_line":"Change-Id: I305dff1eed42724462e2694ee5449ccbd51b0731"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":13,"id":"7f287b81_4c624db0","line":9,"range":{"start_line":9,"start_character":47,"end_line":9,"end_character":63},"in_reply_to":"7f287b81_14c3315f","updated":"2017-08-28 05:06:50.000000000","message":"Right, thanks","commit_id":"0f28d0550c1fabd7187540f6b95724ea2dcc712e"}],"tempest/api/volume/test_volumes_actions.py":[{"author":{"_account_id":5689,"name":"Masayuki Igawa","email":"masayuki@igawa.io","username":"igawa"},"change_message_id":"ad18cf35ffdbbbd42349b1348908e5e50ee90e2b","unresolved":false,"context_lines":[{"line_number":119,"context_line":"        image_name \u003d data_utils.rand_name(self.__class__.__name__ + \u0027-Image\u0027)"},{"line_number":120,"context_line":"        body \u003d self.client.upload_volume("},{"line_number":121,"context_line":"            self.volume[\u0027id\u0027], image_name\u003dimage_name,"},{"line_number":122,"context_line":"            container_format\u003d\u0027bare\u0027, disk_format\u003d\u0027qcow2\u0027)["},{"line_number":123,"context_line":"            \u0027os-volume_upload_image\u0027]"},{"line_number":124,"context_line":"        image_id \u003d body[\"image_id\"]"},{"line_number":125,"context_line":"        self.addCleanup(test_utils.call_and_ignore_notfound_exc,"}],"source_content_type":"text/x-python","patch_set":1,"id":"dfeb2761_2c15d19c","line":122,"updated":"2017-04-04 04:33:19.000000000","message":"Why did you remove CONF.volume.disk_format? I think this change just removes flexibility.","commit_id":"1e6a9951481642443c8cb8125a3b1125e8610a0b"},{"author":{"_account_id":19262,"name":"Liron Kuchlani","email":"lkuchlan@redhat.com","username":"lkuchlan"},"change_message_id":"b500fa72112b05578e10b80c1cb1264346535324","unresolved":false,"context_lines":[{"line_number":119,"context_line":"        image_name \u003d data_utils.rand_name(self.__class__.__name__ + \u0027-Image\u0027)"},{"line_number":120,"context_line":"        body \u003d self.client.upload_volume("},{"line_number":121,"context_line":"            self.volume[\u0027id\u0027], image_name\u003dimage_name,"},{"line_number":122,"context_line":"            container_format\u003d\u0027bare\u0027, disk_format\u003d\u0027qcow2\u0027)["},{"line_number":123,"context_line":"            \u0027os-volume_upload_image\u0027]"},{"line_number":124,"context_line":"        image_id \u003d body[\"image_id\"]"},{"line_number":125,"context_line":"        self.addCleanup(test_utils.call_and_ignore_notfound_exc,"}],"source_content_type":"text/x-python","patch_set":1,"id":"dfeb2761_8c04d84b","line":122,"in_reply_to":"dfeb2761_2c15d19c","updated":"2017-04-04 08:39:32.000000000","message":"Hi Masayuki,\nThanks for your comment,\nI did it because by default when uploading a volume to an\nimage the disk format is raw and CONF.volume.disk_format\nis also raw, so just to be sure disk_format parameter is \nwork I put other type.","commit_id":"1e6a9951481642443c8cb8125a3b1125e8610a0b"},{"author":{"_account_id":6167,"name":"Ken\u0027ichi Ohmichi","email":"ken1ohmichi@gmail.com","username":"oomichi"},"change_message_id":"443110a0b59a79832379598e524d0269d3d95760","unresolved":false,"context_lines":[{"line_number":120,"context_line":"        else:"},{"line_number":121,"context_line":"            show_image \u003d self.images_client.show_image(image_id)"},{"line_number":122,"context_line":""},{"line_number":123,"context_line":"        image_info \u003d show_image"},{"line_number":124,"context_line":""},{"line_number":125,"context_line":"        self.assertEqual(\u0027bare\u0027, image_info[\u0027container_format\u0027])"},{"line_number":126,"context_line":"        self.assertEqual(\u0027qcow2\u0027, image_info[\u0027disk_format\u0027])"}],"source_content_type":"text/x-python","patch_set":7,"id":"1f1a1f67_87e071fc","line":123,"updated":"2017-07-13 21:29:46.000000000","message":"nit: Why should we rename here? How about using image_info at line 119 and 121 directly?","commit_id":"a9fc0b5d46696d2a3b720265a6c1ea1df97a2aab"},{"author":{"_account_id":5689,"name":"Masayuki Igawa","email":"masayuki@igawa.io","username":"igawa"},"change_message_id":"95ae472473874a0409a7a84e5cba03bbedf43af6","unresolved":false,"context_lines":[{"line_number":120,"context_line":"        else:"},{"line_number":121,"context_line":"            show_image \u003d self.images_client.show_image(image_id)"},{"line_number":122,"context_line":""},{"line_number":123,"context_line":"        image_info \u003d show_image"},{"line_number":124,"context_line":""},{"line_number":125,"context_line":"        self.assertEqual(\u0027bare\u0027, image_info[\u0027container_format\u0027])"},{"line_number":126,"context_line":"        self.assertEqual(\u0027qcow2\u0027, image_info[\u0027disk_format\u0027])"}],"source_content_type":"text/x-python","patch_set":7,"id":"1f1a1f67_10ddb06f","line":123,"updated":"2017-07-14 02:43:15.000000000","message":"yeah, this line can be removed.","commit_id":"a9fc0b5d46696d2a3b720265a6c1ea1df97a2aab"},{"author":{"_account_id":19262,"name":"Liron Kuchlani","email":"lkuchlan@redhat.com","username":"lkuchlan"},"change_message_id":"adf27c47e8dfa1413baa44f02c84df504fc63c5f","unresolved":false,"context_lines":[{"line_number":120,"context_line":"        else:"},{"line_number":121,"context_line":"            show_image \u003d self.images_client.show_image(image_id)"},{"line_number":122,"context_line":""},{"line_number":123,"context_line":"        image_info \u003d show_image"},{"line_number":124,"context_line":""},{"line_number":125,"context_line":"        self.assertEqual(\u0027bare\u0027, image_info[\u0027container_format\u0027])"},{"line_number":126,"context_line":"        self.assertEqual(\u0027qcow2\u0027, image_info[\u0027disk_format\u0027])"}],"source_content_type":"text/x-python","patch_set":7,"id":"1f1a1f67_ff8f7420","line":123,"in_reply_to":"1f1a1f67_10ddb06f","updated":"2017-07-16 04:46:28.000000000","message":"Done","commit_id":"a9fc0b5d46696d2a3b720265a6c1ea1df97a2aab"},{"author":{"_account_id":19262,"name":"Liron Kuchlani","email":"lkuchlan@redhat.com","username":"lkuchlan"},"change_message_id":"adf27c47e8dfa1413baa44f02c84df504fc63c5f","unresolved":false,"context_lines":[{"line_number":120,"context_line":"        else:"},{"line_number":121,"context_line":"            show_image \u003d self.images_client.show_image(image_id)"},{"line_number":122,"context_line":""},{"line_number":123,"context_line":"        image_info \u003d show_image"},{"line_number":124,"context_line":""},{"line_number":125,"context_line":"        self.assertEqual(\u0027bare\u0027, image_info[\u0027container_format\u0027])"},{"line_number":126,"context_line":"        self.assertEqual(\u0027qcow2\u0027, image_info[\u0027disk_format\u0027])"}],"source_content_type":"text/x-python","patch_set":7,"id":"1f1a1f67_1f73504f","line":123,"in_reply_to":"1f1a1f67_87e071fc","updated":"2017-07-16 04:46:28.000000000","message":"Done","commit_id":"a9fc0b5d46696d2a3b720265a6c1ea1df97a2aab"},{"author":{"_account_id":23186,"name":"Felipe Monteiro","email":"felipe.carneiro.monteiro@gmail.com","username":"felipe.monteiro"},"change_message_id":"de2c51bae211b3f5cd06878b3ae8a1722547c8d3","unresolved":false,"context_lines":[{"line_number":119,"context_line":"            image_info \u003d common_image.get_image_meta_from_headers(resp)"},{"line_number":120,"context_line":"        else:"},{"line_number":121,"context_line":"            image_info \u003d self.images_client.show_image(image_id)"},{"line_number":122,"context_line":""},{"line_number":123,"context_line":"        self.assertEqual(\u0027bare\u0027, image_info[\u0027container_format\u0027])"},{"line_number":124,"context_line":"        self.assertEqual(\u0027qcow2\u0027, image_info[\u0027disk_format\u0027])"},{"line_number":125,"context_line":""}],"source_content_type":"text/x-python","patch_set":8,"id":"1f1a1f67_0c544b20","line":122,"updated":"2017-07-16 23:45:38.000000000","message":"nit: Since image_name is used on L106 why not do:\n\n    self.assertEqual(image_name, image_info[\u0027image_name\u0027])\n\nhttps://developer.openstack.org/api-ref/block-storage/v3/index.html?expanded\u003dupload-volume-to-image-detail#id121","commit_id":"1d4ce5c75c4a46d4eeea1f0d8a74873bd6dbec8c"},{"author":{"_account_id":19262,"name":"Liron Kuchlani","email":"lkuchlan@redhat.com","username":"lkuchlan"},"change_message_id":"0a47daa90c92873d3830d70ace0eef96ea739bc6","unresolved":false,"context_lines":[{"line_number":119,"context_line":"            image_info \u003d common_image.get_image_meta_from_headers(resp)"},{"line_number":120,"context_line":"        else:"},{"line_number":121,"context_line":"            image_info \u003d self.images_client.show_image(image_id)"},{"line_number":122,"context_line":""},{"line_number":123,"context_line":"        self.assertEqual(\u0027bare\u0027, image_info[\u0027container_format\u0027])"},{"line_number":124,"context_line":"        self.assertEqual(\u0027qcow2\u0027, image_info[\u0027disk_format\u0027])"},{"line_number":125,"context_line":""}],"source_content_type":"text/x-python","patch_set":8,"id":"1f1a1f67_5d0c2b40","line":122,"in_reply_to":"1f1a1f67_0c544b20","updated":"2017-07-17 04:50:02.000000000","message":"Right, thanks","commit_id":"1d4ce5c75c4a46d4eeea1f0d8a74873bd6dbec8c"},{"author":{"_account_id":6167,"name":"Ken\u0027ichi Ohmichi","email":"ken1ohmichi@gmail.com","username":"oomichi"},"change_message_id":"1d5f643d9f14e931aceab1e1b905d35c46dcfdb2","unresolved":false,"context_lines":[{"line_number":105,"context_line":"        image_name \u003d data_utils.rand_name(self.__class__.__name__ + \u0027-Image\u0027)"},{"line_number":106,"context_line":"        body \u003d self.volumes_client.upload_volume("},{"line_number":107,"context_line":"            self.volume[\u0027id\u0027], image_name\u003dimage_name, container_format\u003d\u0027bare\u0027,"},{"line_number":108,"context_line":"            disk_format\u003d\u0027qcow2\u0027)[\u0027os-volume_upload_image\u0027]"},{"line_number":109,"context_line":"        image_id \u003d body[\"image_id\"]"},{"line_number":110,"context_line":"        self.addCleanup(test_utils.call_and_ignore_notfound_exc,"},{"line_number":111,"context_line":"                        self.images_client.delete_image,"}],"source_content_type":"text/x-python","patch_set":10,"id":"1f1a1f67_ec089d92","line":108,"range":{"start_line":108,"start_character":12,"end_line":108,"end_character":31},"updated":"2017-07-19 02:13:59.000000000","message":"This patch removes a single place which refers CONF.volume.disk_format and makes the option meaningless.\n\nHow about just keeping this option without static \u0027qcow2\u0027 and verifying it with assertEqual()?\nThat said it would not necessary to pass container_format at this time.","commit_id":"4eabcb3270151baffa615ee33f49c20f94844f3f"},{"author":{"_account_id":19262,"name":"Liron Kuchlani","email":"lkuchlan@redhat.com","username":"lkuchlan"},"change_message_id":"54e50f56ea8c3351589775edcdb08b4b0f20b105","unresolved":false,"context_lines":[{"line_number":105,"context_line":"        image_name \u003d data_utils.rand_name(self.__class__.__name__ + \u0027-Image\u0027)"},{"line_number":106,"context_line":"        body \u003d self.volumes_client.upload_volume("},{"line_number":107,"context_line":"            self.volume[\u0027id\u0027], image_name\u003dimage_name, container_format\u003d\u0027bare\u0027,"},{"line_number":108,"context_line":"            disk_format\u003d\u0027qcow2\u0027)[\u0027os-volume_upload_image\u0027]"},{"line_number":109,"context_line":"        image_id \u003d body[\"image_id\"]"},{"line_number":110,"context_line":"        self.addCleanup(test_utils.call_and_ignore_notfound_exc,"},{"line_number":111,"context_line":"                        self.images_client.delete_image,"}],"source_content_type":"text/x-python","patch_set":10,"id":"1f1a1f67_5cc85a72","line":108,"range":{"start_line":108,"start_character":12,"end_line":108,"end_character":31},"in_reply_to":"1f1a1f67_ec089d92","updated":"2017-07-19 06:03:51.000000000","message":"Thanks for your comment,\nDone","commit_id":"4eabcb3270151baffa615ee33f49c20f94844f3f"},{"author":{"_account_id":6167,"name":"Ken\u0027ichi Ohmichi","email":"ken1ohmichi@gmail.com","username":"oomichi"},"change_message_id":"1d5f643d9f14e931aceab1e1b905d35c46dcfdb2","unresolved":false,"context_lines":[{"line_number":121,"context_line":"            image_info \u003d self.images_client.show_image(image_id)"},{"line_number":122,"context_line":""},{"line_number":123,"context_line":"        self.assertEqual(image_name, image_info[\u0027name\u0027])"},{"line_number":124,"context_line":"        self.assertEqual(\u0027bare\u0027, image_info[\u0027container_format\u0027])"},{"line_number":125,"context_line":"        self.assertEqual(\u0027qcow2\u0027, image_info[\u0027disk_format\u0027])"},{"line_number":126,"context_line":""},{"line_number":127,"context_line":"    @decorators.idempotent_id(\u002792c4ef64-51b2-40c0-9f7e-4749fbaaba33\u0027)"},{"line_number":128,"context_line":"    def test_reserve_unreserve_volume(self):"}],"source_content_type":"text/x-python","patch_set":10,"id":"1f1a1f67_8c01296d","line":125,"range":{"start_line":124,"start_character":0,"end_line":125,"end_character":60},"updated":"2017-07-19 02:13:59.000000000","message":"Please see the above comment.","commit_id":"4eabcb3270151baffa615ee33f49c20f94844f3f"},{"author":{"_account_id":19262,"name":"Liron Kuchlani","email":"lkuchlan@redhat.com","username":"lkuchlan"},"change_message_id":"54e50f56ea8c3351589775edcdb08b4b0f20b105","unresolved":false,"context_lines":[{"line_number":121,"context_line":"            image_info \u003d self.images_client.show_image(image_id)"},{"line_number":122,"context_line":""},{"line_number":123,"context_line":"        self.assertEqual(image_name, image_info[\u0027name\u0027])"},{"line_number":124,"context_line":"        self.assertEqual(\u0027bare\u0027, image_info[\u0027container_format\u0027])"},{"line_number":125,"context_line":"        self.assertEqual(\u0027qcow2\u0027, image_info[\u0027disk_format\u0027])"},{"line_number":126,"context_line":""},{"line_number":127,"context_line":"    @decorators.idempotent_id(\u002792c4ef64-51b2-40c0-9f7e-4749fbaaba33\u0027)"},{"line_number":128,"context_line":"    def test_reserve_unreserve_volume(self):"}],"source_content_type":"text/x-python","patch_set":10,"id":"1f1a1f67_3cc35e59","line":125,"range":{"start_line":124,"start_character":0,"end_line":125,"end_character":60},"in_reply_to":"1f1a1f67_8c01296d","updated":"2017-07-19 06:03:51.000000000","message":"Done","commit_id":"4eabcb3270151baffa615ee33f49c20f94844f3f"},{"author":{"_account_id":6167,"name":"Ken\u0027ichi Ohmichi","email":"ken1ohmichi@gmail.com","username":"oomichi"},"change_message_id":"c07f047902cd5e0c7d998751ab941e3222fdb44f","unresolved":false,"context_lines":[{"line_number":105,"context_line":"        image_name \u003d data_utils.rand_name(self.__class__.__name__ + \u0027-Image\u0027)"},{"line_number":106,"context_line":"        body \u003d self.volumes_client.upload_volume("},{"line_number":107,"context_line":"            self.volume[\u0027id\u0027], image_name\u003dimage_name,"},{"line_number":108,"context_line":"            disk_format\u003d\u0027qcow2\u0027)[\u0027os-volume_upload_image\u0027]"},{"line_number":109,"context_line":"        image_id \u003d body[\"image_id\"]"},{"line_number":110,"context_line":"        self.addCleanup(test_utils.call_and_ignore_notfound_exc,"},{"line_number":111,"context_line":"                        self.images_client.delete_image,"}],"source_content_type":"text/x-python","patch_set":12,"id":"7f287b81_48d6f529","line":108,"range":{"start_line":108,"start_character":12,"end_line":108,"end_character":31},"updated":"2017-08-24 16:49:05.000000000","message":"The previous comment of PS10 is not applied to this part, could you check the comment again?","commit_id":"76099b52966ede5437429d614679c401b6a9096d"},{"author":{"_account_id":19262,"name":"Liron Kuchlani","email":"lkuchlan@redhat.com","username":"lkuchlan"},"change_message_id":"67f9f91d89cc3b87dca7f2d148245c64482fda01","unresolved":false,"context_lines":[{"line_number":105,"context_line":"        image_name \u003d data_utils.rand_name(self.__class__.__name__ + \u0027-Image\u0027)"},{"line_number":106,"context_line":"        body \u003d self.volumes_client.upload_volume("},{"line_number":107,"context_line":"            self.volume[\u0027id\u0027], image_name\u003dimage_name,"},{"line_number":108,"context_line":"            disk_format\u003d\u0027qcow2\u0027)[\u0027os-volume_upload_image\u0027]"},{"line_number":109,"context_line":"        image_id \u003d body[\"image_id\"]"},{"line_number":110,"context_line":"        self.addCleanup(test_utils.call_and_ignore_notfound_exc,"},{"line_number":111,"context_line":"                        self.images_client.delete_image,"}],"source_content_type":"text/x-python","patch_set":12,"id":"7f287b81_1b2da4fd","line":108,"range":{"start_line":108,"start_character":12,"end_line":108,"end_character":31},"in_reply_to":"7f287b81_48d6f529","updated":"2017-08-27 07:51:43.000000000","message":"Done","commit_id":"76099b52966ede5437429d614679c401b6a9096d"},{"author":{"_account_id":20190,"name":"zhufl","email":"zhu.fanglei@zte.com.cn","username":"zhufl"},"change_message_id":"c0e479cb770972ddf10741d5ad68369dddd9c8e7","unresolved":false,"context_lines":[{"line_number":114,"context_line":"        waiters.wait_for_volume_resource_status(self.volumes_client,"},{"line_number":115,"context_line":"                                                self.volume[\u0027id\u0027], \u0027available\u0027)"},{"line_number":116,"context_line":""},{"line_number":117,"context_line":"        if isinstance(self.images_client, images_v1_client.ImagesClient):"},{"line_number":118,"context_line":"            resp \u003d self.images_client.check_image(image_id)"},{"line_number":119,"context_line":"            image_info \u003d common_image.get_image_meta_from_headers(resp)"},{"line_number":120,"context_line":"        else:"},{"line_number":121,"context_line":"            image_info \u003d self.images_client.show_image(image_id)"},{"line_number":122,"context_line":""},{"line_number":123,"context_line":"        self.assertEqual(image_name, image_info[\u0027name\u0027])"},{"line_number":124,"context_line":"        self.assertEqual(CONF.volume.disk_format, image_info[\u0027disk_format\u0027])"}],"source_content_type":"text/x-python","patch_set":14,"id":"7f287b81_2c8021c0","line":121,"range":{"start_line":117,"start_character":0,"end_line":121,"end_character":64},"updated":"2017-08-28 05:54:34.000000000","message":"volume testcases now only use image v2,\nhttps://github.com/openstack/tempest/blob/99e6d1acf78e248837863df93ff1c409a3b34fe9/tempest/api/volume/base.py#L70","commit_id":"7e35050afc08cec2613b9ee4446132a897740cde"},{"author":{"_account_id":19262,"name":"Liron Kuchlani","email":"lkuchlan@redhat.com","username":"lkuchlan"},"change_message_id":"07b310b79c7d4166c95588a4f5ddf663c5c11586","unresolved":false,"context_lines":[{"line_number":114,"context_line":"        waiters.wait_for_volume_resource_status(self.volumes_client,"},{"line_number":115,"context_line":"                                                self.volume[\u0027id\u0027], \u0027available\u0027)"},{"line_number":116,"context_line":""},{"line_number":117,"context_line":"        if isinstance(self.images_client, images_v1_client.ImagesClient):"},{"line_number":118,"context_line":"            resp \u003d self.images_client.check_image(image_id)"},{"line_number":119,"context_line":"            image_info \u003d common_image.get_image_meta_from_headers(resp)"},{"line_number":120,"context_line":"        else:"},{"line_number":121,"context_line":"            image_info \u003d self.images_client.show_image(image_id)"},{"line_number":122,"context_line":""},{"line_number":123,"context_line":"        self.assertEqual(image_name, image_info[\u0027name\u0027])"},{"line_number":124,"context_line":"        self.assertEqual(CONF.volume.disk_format, image_info[\u0027disk_format\u0027])"}],"source_content_type":"text/x-python","patch_set":14,"id":"7f287b81_8c7ef5ac","line":121,"range":{"start_line":117,"start_character":0,"end_line":121,"end_character":64},"in_reply_to":"7f287b81_2c8021c0","updated":"2017-08-28 06:11:19.000000000","message":"Thanks I updated the testcase","commit_id":"7e35050afc08cec2613b9ee4446132a897740cde"}]}