)]}'
{"tempest/api/identity/admin/v3/test_domain_configuration.py":[{"author":{"_account_id":20190,"name":"zhufl","email":"zhu.fanglei@zte.com.cn","username":"zhufl"},"change_message_id":"b61de7c080e4cac15966c671714b20004cabcd52","unresolved":false,"context_lines":[{"line_number":22,"context_line":"from tempest.lib import decorators"},{"line_number":23,"context_line":"from tempest.lib import exceptions as lib_exc"},{"line_number":24,"context_line":""},{"line_number":25,"context_line":"CONF \u003d config.CONF"},{"line_number":26,"context_line":""},{"line_number":27,"context_line":""},{"line_number":28,"context_line":"class DomainConfigurationTestJSON(base.BaseIdentityV3AdminTest):"}],"source_content_type":"text/x-python","patch_set":1,"id":"dfeb2761_73d82c7a","line":25,"range":{"start_line":25,"start_character":0,"end_line":25,"end_character":18},"updated":"2017-04-05 07:25:39.000000000","message":"this is not used","commit_id":"191930b2ac8ae16afc0c02579ca2c2de9315cba0"},{"author":{"_account_id":23186,"name":"Felipe Monteiro","email":"felipe.carneiro.monteiro@gmail.com","username":"felipe.monteiro"},"change_message_id":"103956f080c3f293ab13875a1a8f0e4144305579","unresolved":false,"context_lines":[{"line_number":22,"context_line":"from tempest.lib import decorators"},{"line_number":23,"context_line":"from tempest.lib import exceptions as lib_exc"},{"line_number":24,"context_line":""},{"line_number":25,"context_line":"CONF \u003d config.CONF"},{"line_number":26,"context_line":""},{"line_number":27,"context_line":""},{"line_number":28,"context_line":"class DomainConfigurationTestJSON(base.BaseIdentityV3AdminTest):"}],"source_content_type":"text/x-python","patch_set":1,"id":"bff0334d_e6689a22","line":25,"range":{"start_line":25,"start_character":0,"end_line":25,"end_character":18},"in_reply_to":"dfeb2761_73d82c7a","updated":"2017-04-05 13:53:49.000000000","message":"Done","commit_id":"191930b2ac8ae16afc0c02579ca2c2de9315cba0"},{"author":{"_account_id":20190,"name":"zhufl","email":"zhu.fanglei@zte.com.cn","username":"zhufl"},"change_message_id":"b61de7c080e4cac15966c671714b20004cabcd52","unresolved":false,"context_lines":[{"line_number":73,"context_line":"        return config"},{"line_number":74,"context_line":""},{"line_number":75,"context_line":"    @decorators.idempotent_id(\u002742e5205f-a515-4ddb-8f37-67933ec174f2\u0027)"},{"line_number":76,"context_line":"    def test_show_default_config_settings(self):"},{"line_number":77,"context_line":"        config \u003d self.client.show_default_config_settings()[\u0027config\u0027]"},{"line_number":78,"context_line":"        self.assertIsInstance(config, dict)"},{"line_number":79,"context_line":""}],"source_content_type":"text/x-python","patch_set":1,"id":"dfeb2761_f30b1c27","line":76,"range":{"start_line":76,"start_character":4,"end_line":76,"end_character":48},"updated":"2017-04-05 07:25:39.000000000","message":"this testcase only includes one api calling, so maybe it needn\u0027t be in Tempest?","commit_id":"191930b2ac8ae16afc0c02579ca2c2de9315cba0"},{"author":{"_account_id":23186,"name":"Felipe Monteiro","email":"felipe.carneiro.monteiro@gmail.com","username":"felipe.monteiro"},"change_message_id":"103956f080c3f293ab13875a1a8f0e4144305579","unresolved":false,"context_lines":[{"line_number":73,"context_line":"        return config"},{"line_number":74,"context_line":""},{"line_number":75,"context_line":"    @decorators.idempotent_id(\u002742e5205f-a515-4ddb-8f37-67933ec174f2\u0027)"},{"line_number":76,"context_line":"    def test_show_default_config_settings(self):"},{"line_number":77,"context_line":"        config \u003d self.client.show_default_config_settings()[\u0027config\u0027]"},{"line_number":78,"context_line":"        self.assertIsInstance(config, dict)"},{"line_number":79,"context_line":""}],"source_content_type":"text/x-python","patch_set":1,"id":"bff0334d_2687a2da","line":76,"range":{"start_line":76,"start_character":4,"end_line":76,"end_character":48},"in_reply_to":"dfeb2761_f30b1c27","updated":"2017-04-05 13:53:49.000000000","message":"Done: I combined it with test below.","commit_id":"191930b2ac8ae16afc0c02579ca2c2de9315cba0"},{"author":{"_account_id":20190,"name":"zhufl","email":"zhu.fanglei@zte.com.cn","username":"zhufl"},"change_message_id":"b61de7c080e4cac15966c671714b20004cabcd52","unresolved":false,"context_lines":[{"line_number":96,"context_line":"                \u0027identity\u0027, config_opt_name)[\u0027config\u0027]"},{"line_number":97,"context_line":"            self.assertIn(config_opt_name, retrieved_config_opt)"},{"line_number":98,"context_line":""},{"line_number":99,"context_line":"        ldap_config \u003d self.client.show_default_group_config(\u0027ldap\u0027)["},{"line_number":100,"context_line":"            \u0027config\u0027]"},{"line_number":101,"context_line":""},{"line_number":102,"context_line":"        self.assertIsInstance(ldap_config, dict)"},{"line_number":103,"context_line":"        self.assertIn(\u0027ldap\u0027, ldap_config)"}],"source_content_type":"text/x-python","patch_set":1,"id":"dfeb2761_13cd6065","line":100,"range":{"start_line":99,"start_character":0,"end_line":100,"end_character":21},"updated":"2017-04-05 07:25:39.000000000","message":"can be put in one line","commit_id":"191930b2ac8ae16afc0c02579ca2c2de9315cba0"},{"author":{"_account_id":23186,"name":"Felipe Monteiro","email":"felipe.carneiro.monteiro@gmail.com","username":"felipe.monteiro"},"change_message_id":"103956f080c3f293ab13875a1a8f0e4144305579","unresolved":false,"context_lines":[{"line_number":96,"context_line":"                \u0027identity\u0027, config_opt_name)[\u0027config\u0027]"},{"line_number":97,"context_line":"            self.assertIn(config_opt_name, retrieved_config_opt)"},{"line_number":98,"context_line":""},{"line_number":99,"context_line":"        ldap_config \u003d self.client.show_default_group_config(\u0027ldap\u0027)["},{"line_number":100,"context_line":"            \u0027config\u0027]"},{"line_number":101,"context_line":""},{"line_number":102,"context_line":"        self.assertIsInstance(ldap_config, dict)"},{"line_number":103,"context_line":"        self.assertIn(\u0027ldap\u0027, ldap_config)"}],"source_content_type":"text/x-python","patch_set":1,"id":"bff0334d_e623fa04","line":100,"range":{"start_line":99,"start_character":0,"end_line":100,"end_character":21},"in_reply_to":"dfeb2761_13cd6065","updated":"2017-04-05 13:53:49.000000000","message":"Done","commit_id":"191930b2ac8ae16afc0c02579ca2c2de9315cba0"},{"author":{"_account_id":20190,"name":"zhufl","email":"zhu.fanglei@zte.com.cn","username":"zhufl"},"change_message_id":"b61de7c080e4cac15966c671714b20004cabcd52","unresolved":false,"context_lines":[{"line_number":140,"context_line":"        created_config \u003d self._create_config(self.domain[\u0027id\u0027],"},{"line_number":141,"context_line":"                                             self.custom_config)"},{"line_number":142,"context_line":""},{"line_number":143,"context_line":"        new_config \u003d copy.deepcopy(created_config)"},{"line_number":144,"context_line":"        new_config[\u0027ldap\u0027][\u0027url\u0027] \u003d data_utils.rand_url()"},{"line_number":145,"context_line":""},{"line_number":146,"context_line":"        updated_config \u003d self.client.update_domain_config("}],"source_content_type":"text/x-python","patch_set":1,"id":"dfeb2761_f37b1c25","line":143,"range":{"start_line":143,"start_character":8,"end_line":143,"end_character":50},"updated":"2017-04-05 07:25:39.000000000","message":"I wonder why this?","commit_id":"191930b2ac8ae16afc0c02579ca2c2de9315cba0"},{"author":{"_account_id":23186,"name":"Felipe Monteiro","email":"felipe.carneiro.monteiro@gmail.com","username":"felipe.monteiro"},"change_message_id":"103956f080c3f293ab13875a1a8f0e4144305579","unresolved":false,"context_lines":[{"line_number":140,"context_line":"        created_config \u003d self._create_config(self.domain[\u0027id\u0027],"},{"line_number":141,"context_line":"                                             self.custom_config)"},{"line_number":142,"context_line":""},{"line_number":143,"context_line":"        new_config \u003d copy.deepcopy(created_config)"},{"line_number":144,"context_line":"        new_config[\u0027ldap\u0027][\u0027url\u0027] \u003d data_utils.rand_url()"},{"line_number":145,"context_line":""},{"line_number":146,"context_line":"        updated_config \u003d self.client.update_domain_config("}],"source_content_type":"text/x-python","patch_set":1,"id":"bff0334d_0627fe14","line":143,"range":{"start_line":143,"start_character":8,"end_line":143,"end_character":50},"in_reply_to":"dfeb2761_f37b1c25","updated":"2017-04-05 13:53:49.000000000","message":"Done: I removed it.","commit_id":"191930b2ac8ae16afc0c02579ca2c2de9315cba0"},{"author":{"_account_id":20190,"name":"zhufl","email":"zhu.fanglei@zte.com.cn","username":"zhufl"},"change_message_id":"b61de7c080e4cac15966c671714b20004cabcd52","unresolved":false,"context_lines":[{"line_number":175,"context_line":""},{"line_number":176,"context_line":"        # Check that updating individual configuration group options work."},{"line_number":177,"context_line":"        new_driver \u003d data_utils.rand_name(\u0027driver\u0027)"},{"line_number":178,"context_line":"        new_limit \u003d data_utils.rand_int_id(0, 100)"},{"line_number":179,"context_line":""},{"line_number":180,"context_line":"        updated_config \u003d self.client.update_domain_group_option_config("},{"line_number":181,"context_line":"            self.domain[\u0027id\u0027], \u0027identity\u0027, \u0027driver\u0027, driver\u003dnew_driver)["}],"source_content_type":"text/x-python","patch_set":1,"id":"dfeb2761_335ce4eb","line":178,"range":{"start_line":178,"start_character":8,"end_line":178,"end_character":50},"updated":"2017-04-05 07:25:39.000000000","message":"this can be removed","commit_id":"191930b2ac8ae16afc0c02579ca2c2de9315cba0"},{"author":{"_account_id":23186,"name":"Felipe Monteiro","email":"felipe.carneiro.monteiro@gmail.com","username":"felipe.monteiro"},"change_message_id":"103956f080c3f293ab13875a1a8f0e4144305579","unresolved":false,"context_lines":[{"line_number":175,"context_line":""},{"line_number":176,"context_line":"        # Check that updating individual configuration group options work."},{"line_number":177,"context_line":"        new_driver \u003d data_utils.rand_name(\u0027driver\u0027)"},{"line_number":178,"context_line":"        new_limit \u003d data_utils.rand_int_id(0, 100)"},{"line_number":179,"context_line":""},{"line_number":180,"context_line":"        updated_config \u003d self.client.update_domain_group_option_config("},{"line_number":181,"context_line":"            self.domain[\u0027id\u0027], \u0027identity\u0027, \u0027driver\u0027, driver\u003dnew_driver)["}],"source_content_type":"text/x-python","patch_set":1,"id":"bff0334d_261202b3","line":178,"range":{"start_line":178,"start_character":8,"end_line":178,"end_character":50},"in_reply_to":"dfeb2761_335ce4eb","updated":"2017-04-05 13:53:49.000000000","message":"Done","commit_id":"191930b2ac8ae16afc0c02579ca2c2de9315cba0"},{"author":{"_account_id":23185,"name":"Samantha Blanco","email":"samantha.blanco@att.com","username":"sblanco"},"change_message_id":"ac07257f7c7b62b7cec8f585a99384d0cfa8b5bd","unresolved":false,"context_lines":[{"line_number":40,"context_line":"    @classmethod"},{"line_number":41,"context_line":"    def resource_setup(cls):"},{"line_number":42,"context_line":"        super(DomainConfigurationTestJSON, cls).resource_setup()"},{"line_number":43,"context_line":"        cls.domain \u003d cls.domains_client.create_domain("},{"line_number":44,"context_line":"            name\u003ddata_utils.rand_name(\u0027domain\u0027),"},{"line_number":45,"context_line":"            description\u003ddata_utils.rand_name(\u0027domain-desc\u0027),"},{"line_number":46,"context_line":"            enabled\u003dTrue)[\u0027domain\u0027]"}],"source_content_type":"text/x-python","patch_set":2,"id":"7ffa3b31_1d0ff389","line":43,"updated":"2017-04-18 17:15:22.000000000","message":"Is there a reason you\u0027re not using create_domain from the identity base class?","commit_id":"8d2f19858a5b678cb290a7b7e5c48d702eb8df3d"},{"author":{"_account_id":23186,"name":"Felipe Monteiro","email":"felipe.carneiro.monteiro@gmail.com","username":"felipe.monteiro"},"change_message_id":"b10044640029a52a5ebf068f1db1d267cf02e789","unresolved":false,"context_lines":[{"line_number":40,"context_line":"    @classmethod"},{"line_number":41,"context_line":"    def resource_setup(cls):"},{"line_number":42,"context_line":"        super(DomainConfigurationTestJSON, cls).resource_setup()"},{"line_number":43,"context_line":"        cls.domain \u003d cls.domains_client.create_domain("},{"line_number":44,"context_line":"            name\u003ddata_utils.rand_name(\u0027domain\u0027),"},{"line_number":45,"context_line":"            description\u003ddata_utils.rand_name(\u0027domain-desc\u0027),"},{"line_number":46,"context_line":"            enabled\u003dTrue)[\u0027domain\u0027]"}],"source_content_type":"text/x-python","patch_set":2,"id":"7ffa3b31_2135e1f7","line":43,"in_reply_to":"7ffa3b31_1d0ff389","updated":"2017-04-18 22:18:23.000000000","message":"Yeah I forgot about it, I\u0027ll do that.\n\ndelete_domain in base though isn\u0027t a classmethod, so I have to use the helper below to do the deletion in resource_cleanup.","commit_id":"8d2f19858a5b678cb290a7b7e5c48d702eb8df3d"},{"author":{"_account_id":7350,"name":"Jordan Pittier","email":"jordan.pittier@gmail.com","username":"JordanP"},"change_message_id":"a5c726a792cbb9b68cbc4c5caf01bdf8480c9285","unresolved":false,"context_lines":[{"line_number":52,"context_line":"        super(DomainConfigurationTestJSON, cls).resource_cleanup()"},{"line_number":53,"context_line":""},{"line_number":54,"context_line":"    @classmethod"},{"line_number":55,"context_line":"    def _delete_domain(cls, domain_id):"},{"line_number":56,"context_line":"        cls.domains_client.update_domain(domain_id, enabled\u003dFalse)"},{"line_number":57,"context_line":"        cls.domains_client.delete_domain(domain_id)"},{"line_number":58,"context_line":""}],"source_content_type":"text/x-python","patch_set":3,"id":"7ffa3b31_3eb96c2d","line":55,"updated":"2017-04-19 12:46:13.000000000","message":"We already have 2 similar methods in Tempest code base. Let\u0027s encourage code reuse.  Reuse these methods and please don\u0027t introduce a 3rd one.","commit_id":"3b3c904795f1f3cb8be33f79b3a1472282ad5621"}],"tempest/lib/services/identity/v3/domain_configuration_client.py":[{"author":{"_account_id":1921,"name":"Andrea Frittoli","email":"andrea.frittoli@gmail.com","username":"andrea-frittoli"},"change_message_id":"1156064f3f3df8b31dcbb55e1b0fe9f27c204cf5","unresolved":false,"context_lines":[{"line_number":23,"context_line":"    def show_default_config_settings(self):"},{"line_number":24,"context_line":"        \"\"\"Show default configuration settings."},{"line_number":25,"context_line":""},{"line_number":26,"context_line":"        For a full list of available parameters, please refer to the official"},{"line_number":27,"context_line":"        API reference:"},{"line_number":28,"context_line":"        http://developer.openstack.org/api-ref/identity/v3/index.html#show-default-configuration-settings"},{"line_number":29,"context_line":"        \"\"\""}],"source_content_type":"text/x-python","patch_set":4,"id":"5ff73747_88b664d9","line":26,"range":{"start_line":26,"start_character":0,"end_line":26,"end_character":77},"updated":"2017-04-24 12:50:27.000000000","message":"I\u0027m not sure this comment is relevant here. There are no additional parameters that can be passed. The API reference part is fine.","commit_id":"94d85773650c805d329486b152f72d116c8811c9"},{"author":{"_account_id":1921,"name":"Andrea Frittoli","email":"andrea.frittoli@gmail.com","username":"andrea-frittoli"},"change_message_id":"1156064f3f3df8b31dcbb55e1b0fe9f27c204cf5","unresolved":false,"context_lines":[{"line_number":36,"context_line":"    def show_default_group_config(self, group):"},{"line_number":37,"context_line":"        \"\"\"Show default configuration for a group."},{"line_number":38,"context_line":""},{"line_number":39,"context_line":"        For a full list of available parameters, please refer to the official"},{"line_number":40,"context_line":"        API reference:"},{"line_number":41,"context_line":"        http://developer.openstack.org/api-ref/identity/v3/index.html#show-default-configuration-for-a-group"},{"line_number":42,"context_line":"        \"\"\""}],"source_content_type":"text/x-python","patch_set":4,"id":"5ff73747_e8dcc819","line":39,"range":{"start_line":39,"start_character":0,"end_line":39,"end_character":77},"updated":"2017-04-24 12:50:27.000000000","message":"ditto","commit_id":"94d85773650c805d329486b152f72d116c8811c9"},{"author":{"_account_id":1921,"name":"Andrea Frittoli","email":"andrea.frittoli@gmail.com","username":"andrea-frittoli"},"change_message_id":"1156064f3f3df8b31dcbb55e1b0fe9f27c204cf5","unresolved":false,"context_lines":[{"line_number":49,"context_line":"    def show_default_group_option(self, group, option):"},{"line_number":50,"context_line":"        \"\"\"Show default option for a group."},{"line_number":51,"context_line":""},{"line_number":52,"context_line":"        For a full list of available parameters, please refer to the official"},{"line_number":53,"context_line":"        API reference:"},{"line_number":54,"context_line":"        http://developer.openstack.org/api-ref/identity/v3/index.html#show-default-option-for-a-group"},{"line_number":55,"context_line":"        \"\"\""}],"source_content_type":"text/x-python","patch_set":4,"id":"5ff73747_a8e6c0e7","line":52,"range":{"start_line":52,"start_character":0,"end_line":52,"end_character":77},"updated":"2017-04-24 12:50:27.000000000","message":"ditto","commit_id":"94d85773650c805d329486b152f72d116c8811c9"},{"author":{"_account_id":1921,"name":"Andrea Frittoli","email":"andrea.frittoli@gmail.com","username":"andrea-frittoli"},"change_message_id":"1156064f3f3df8b31dcbb55e1b0fe9f27c204cf5","unresolved":false,"context_lines":[{"line_number":62,"context_line":"    def show_domain_group_option_config(self, domain_id, group, option):"},{"line_number":63,"context_line":"        \"\"\"Show domain group option configuration."},{"line_number":64,"context_line":""},{"line_number":65,"context_line":"        For a full list of available parameters, please refer to the official"},{"line_number":66,"context_line":"        API reference:"},{"line_number":67,"context_line":"        http://developer.openstack.org/api-ref/identity/v3/index.html#show-domain-group-option-configuration"},{"line_number":68,"context_line":"        \"\"\""}],"source_content_type":"text/x-python","patch_set":4,"id":"5ff73747_88eb04af","line":65,"range":{"start_line":65,"start_character":0,"end_line":65,"end_character":77},"updated":"2017-04-24 12:50:27.000000000","message":"ditto","commit_id":"94d85773650c805d329486b152f72d116c8811c9"},{"author":{"_account_id":1921,"name":"Andrea Frittoli","email":"andrea.frittoli@gmail.com","username":"andrea-frittoli"},"change_message_id":"1156064f3f3df8b31dcbb55e1b0fe9f27c204cf5","unresolved":false,"context_lines":[{"line_number":76,"context_line":"                                          **kwargs):"},{"line_number":77,"context_line":"        \"\"\"Update domain group option configuration."},{"line_number":78,"context_line":""},{"line_number":79,"context_line":"        For a full list of available parameters, please refer to the official"},{"line_number":80,"context_line":"        API reference:"},{"line_number":81,"context_line":"        http://developer.openstack.org/api-ref/identity/v3/index.html#update-domain-group-option-configuration"},{"line_number":82,"context_line":"        \"\"\""}],"source_content_type":"text/x-python","patch_set":4,"id":"5ff73747_e805e87b","line":79,"range":{"start_line":79,"start_character":0,"end_line":79,"end_character":77},"updated":"2017-04-24 12:50:27.000000000","message":"Here the comment looks good.","commit_id":"94d85773650c805d329486b152f72d116c8811c9"},{"author":{"_account_id":1921,"name":"Andrea Frittoli","email":"andrea.frittoli@gmail.com","username":"andrea-frittoli"},"change_message_id":"1156064f3f3df8b31dcbb55e1b0fe9f27c204cf5","unresolved":false,"context_lines":[{"line_number":89,"context_line":"    def delete_domain_group_option_config(self, domain_id, group, option):"},{"line_number":90,"context_line":"        \"\"\"Delete domain group option configuration."},{"line_number":91,"context_line":""},{"line_number":92,"context_line":"        For a full list of available parameters, please refer to the official"},{"line_number":93,"context_line":"        API reference:"},{"line_number":94,"context_line":"        http://developer.openstack.org/api-ref/identity/v3/index.html#delete-domain-group-option-configuration"},{"line_number":95,"context_line":"        \"\"\""}],"source_content_type":"text/x-python","patch_set":4,"id":"5ff73747_8804247d","line":92,"range":{"start_line":92,"start_character":0,"end_line":92,"end_character":77},"updated":"2017-04-24 12:50:27.000000000","message":"not relevant here?\n(...)","commit_id":"94d85773650c805d329486b152f72d116c8811c9"}]}