)]}'
{"tempest/test.py":[{"author":{"_account_id":5689,"name":"Masayuki Igawa","email":"masayuki@igawa.io","username":"igawa"},"change_message_id":"564055aa10eab143afecd06a67b523fc8e66a13c","unresolved":false,"context_lines":[{"line_number":650,"context_line":"        :raises AssertionError: when items is not empty"},{"line_number":651,"context_line":"        \"\"\""},{"line_number":652,"context_line":"        if msg is None:"},{"line_number":653,"context_line":"            msg \u003d \"list is not empty: %s\" % items"},{"line_number":654,"context_line":"        self.assertEqual(0, len(items), msg)"},{"line_number":655,"context_line":""},{"line_number":656,"context_line":"    def assertNotEmpty(self, items, msg\u003dNone):"}],"source_content_type":"text/x-python","patch_set":2,"id":"bff0334d_466ead95","line":653,"updated":"2017-04-08 02:03:33.000000000","message":"I feel the message should use the word - \u0027items\u0027 too to avoid user\u0027s confusion.","commit_id":"524de0a7184f53dab656652a4078b0729e3fd0da"},{"author":{"_account_id":5689,"name":"Masayuki Igawa","email":"masayuki@igawa.io","username":"igawa"},"change_message_id":"564055aa10eab143afecd06a67b523fc8e66a13c","unresolved":false,"context_lines":[{"line_number":651,"context_line":"        \"\"\""},{"line_number":652,"context_line":"        if msg is None:"},{"line_number":653,"context_line":"            msg \u003d \"list is not empty: %s\" % items"},{"line_number":654,"context_line":"        self.assertEqual(0, len(items), msg)"},{"line_number":655,"context_line":""},{"line_number":656,"context_line":"    def assertNotEmpty(self, items, msg\u003dNone):"},{"line_number":657,"context_line":"        \"\"\"Asserts whether a sequence of collection is not empty"}],"source_content_type":"text/x-python","patch_set":2,"id":"bff0334d_2669698a","line":654,"updated":"2017-04-08 02:03:33.000000000","message":"I think PEP8 recommends[1] like this\n\n self.assertTrue(items, msg)\n\nBut, this should be done in another patch. (I\u0027ll do it:)\n\n[1] https://www.python.org/dev/peps/pep-0008/#programming-recommendations\n\nFor sequences, (strings, lists, tuples), use the fact that empty sequences are false.\n\n Yes: if not seq:\n      if seq:\n \n No: if len(seq):\n     if not len(seq):","commit_id":"524de0a7184f53dab656652a4078b0729e3fd0da"},{"author":{"_account_id":5689,"name":"Masayuki Igawa","email":"masayuki@igawa.io","username":"igawa"},"change_message_id":"564055aa10eab143afecd06a67b523fc8e66a13c","unresolved":false,"context_lines":[{"line_number":661,"context_line":"        :raises AssertionError: when items is empty"},{"line_number":662,"context_line":"        \"\"\""},{"line_number":663,"context_line":"        if msg is None:"},{"line_number":664,"context_line":"            msg \u003d \"list is empty.\""},{"line_number":665,"context_line":"        self.assertGreater(len(items), 0, msg)"}],"source_content_type":"text/x-python","patch_set":2,"id":"bff0334d_060665cf","line":664,"updated":"2017-04-08 02:03:33.000000000","message":"ditto","commit_id":"524de0a7184f53dab656652a4078b0729e3fd0da"},{"author":{"_account_id":20190,"name":"zhufl","email":"zhu.fanglei@zte.com.cn","username":"zhufl"},"change_message_id":"976823121deb9f6fab155340f8f74cbf074eb767","unresolved":false,"context_lines":[{"line_number":643,"context_line":"            cred_provider, networks_client, CONF.compute.fixed_network_name)"},{"line_number":644,"context_line":""},{"line_number":645,"context_line":"    def assertEmpty(self, items, msg\u003dNone):"},{"line_number":646,"context_line":"        \"\"\"Asserts whether a sequence of collection is empty"},{"line_number":647,"context_line":""},{"line_number":648,"context_line":"        :param items: sequence or collection to be tested"},{"line_number":649,"context_line":"        :param msg: message to be passed to the AssertionError"}],"source_content_type":"text/x-python","patch_set":3,"id":"bff0334d_97617308","line":646,"range":{"start_line":646,"start_character":38,"end_line":646,"end_character":40},"updated":"2017-04-10 03:03:57.000000000","message":"or ?","commit_id":"c49cf1fb38b941f2c8168da1ef13dc9df2cb565b"},{"author":{"_account_id":1921,"name":"Andrea Frittoli","email":"andrea.frittoli@gmail.com","username":"andrea-frittoli"},"change_message_id":"302ccc05c6d7dafb92a3224e8033007dfe81d827","unresolved":false,"context_lines":[{"line_number":643,"context_line":"            cred_provider, networks_client, CONF.compute.fixed_network_name)"},{"line_number":644,"context_line":""},{"line_number":645,"context_line":"    def assertEmpty(self, items, msg\u003dNone):"},{"line_number":646,"context_line":"        \"\"\"Asserts whether a sequence of collection is empty"},{"line_number":647,"context_line":""},{"line_number":648,"context_line":"        :param items: sequence or collection to be tested"},{"line_number":649,"context_line":"        :param msg: message to be passed to the AssertionError"}],"source_content_type":"text/x-python","patch_set":3,"id":"bff0334d_e6cecf2b","line":646,"range":{"start_line":646,"start_character":38,"end_line":646,"end_character":40},"in_reply_to":"bff0334d_97617308","updated":"2017-04-10 08:27:24.000000000","message":"Done","commit_id":"c49cf1fb38b941f2c8168da1ef13dc9df2cb565b"},{"author":{"_account_id":20190,"name":"zhufl","email":"zhu.fanglei@zte.com.cn","username":"zhufl"},"change_message_id":"976823121deb9f6fab155340f8f74cbf074eb767","unresolved":false,"context_lines":[{"line_number":650,"context_line":"        :raises AssertionError: when items is not empty"},{"line_number":651,"context_line":"        \"\"\""},{"line_number":652,"context_line":"        if msg is None:"},{"line_number":653,"context_line":"            msg \u003d \"items is not empty: %s\" % items"},{"line_number":654,"context_line":"        self.assertEqual(0, len(items), msg)"},{"line_number":655,"context_line":""},{"line_number":656,"context_line":"    def assertNotEmpty(self, items, msg\u003dNone):"}],"source_content_type":"text/x-python","patch_set":3,"id":"bff0334d_d7437b6b","line":653,"range":{"start_line":653,"start_character":19,"end_line":653,"end_character":24},"updated":"2017-04-10 03:03:57.000000000","message":"\"items is not empty\" looks a bit strange, how about:\n\"sequence or collection is not empty\"?","commit_id":"c49cf1fb38b941f2c8168da1ef13dc9df2cb565b"},{"author":{"_account_id":1921,"name":"Andrea Frittoli","email":"andrea.frittoli@gmail.com","username":"andrea-frittoli"},"change_message_id":"302ccc05c6d7dafb92a3224e8033007dfe81d827","unresolved":false,"context_lines":[{"line_number":650,"context_line":"        :raises AssertionError: when items is not empty"},{"line_number":651,"context_line":"        \"\"\""},{"line_number":652,"context_line":"        if msg is None:"},{"line_number":653,"context_line":"            msg \u003d \"items is not empty: %s\" % items"},{"line_number":654,"context_line":"        self.assertEqual(0, len(items), msg)"},{"line_number":655,"context_line":""},{"line_number":656,"context_line":"    def assertNotEmpty(self, items, msg\u003dNone):"}],"source_content_type":"text/x-python","patch_set":3,"id":"bff0334d_c6d3cbd4","line":653,"range":{"start_line":653,"start_character":19,"end_line":653,"end_character":24},"in_reply_to":"bff0334d_d7437b6b","updated":"2017-04-10 08:27:24.000000000","message":"Done","commit_id":"c49cf1fb38b941f2c8168da1ef13dc9df2cb565b"},{"author":{"_account_id":20190,"name":"zhufl","email":"zhu.fanglei@zte.com.cn","username":"zhufl"},"change_message_id":"976823121deb9f6fab155340f8f74cbf074eb767","unresolved":false,"context_lines":[{"line_number":654,"context_line":"        self.assertEqual(0, len(items), msg)"},{"line_number":655,"context_line":""},{"line_number":656,"context_line":"    def assertNotEmpty(self, items, msg\u003dNone):"},{"line_number":657,"context_line":"        \"\"\"Asserts whether a sequence of collection is not empty"},{"line_number":658,"context_line":""},{"line_number":659,"context_line":"        :param items: sequence or collection to be tested"},{"line_number":660,"context_line":"        :param msg: message to be passed to the AssertionError"}],"source_content_type":"text/x-python","patch_set":3,"id":"bff0334d_577e4baf","line":657,"range":{"start_line":657,"start_character":38,"end_line":657,"end_character":40},"updated":"2017-04-10 03:03:57.000000000","message":"ditto","commit_id":"c49cf1fb38b941f2c8168da1ef13dc9df2cb565b"},{"author":{"_account_id":1921,"name":"Andrea Frittoli","email":"andrea.frittoli@gmail.com","username":"andrea-frittoli"},"change_message_id":"302ccc05c6d7dafb92a3224e8033007dfe81d827","unresolved":false,"context_lines":[{"line_number":654,"context_line":"        self.assertEqual(0, len(items), msg)"},{"line_number":655,"context_line":""},{"line_number":656,"context_line":"    def assertNotEmpty(self, items, msg\u003dNone):"},{"line_number":657,"context_line":"        \"\"\"Asserts whether a sequence of collection is not empty"},{"line_number":658,"context_line":""},{"line_number":659,"context_line":"        :param items: sequence or collection to be tested"},{"line_number":660,"context_line":"        :param msg: message to be passed to the AssertionError"}],"source_content_type":"text/x-python","patch_set":3,"id":"bff0334d_86d943f4","line":657,"range":{"start_line":657,"start_character":38,"end_line":657,"end_character":40},"in_reply_to":"bff0334d_577e4baf","updated":"2017-04-10 08:27:24.000000000","message":"Done","commit_id":"c49cf1fb38b941f2c8168da1ef13dc9df2cb565b"},{"author":{"_account_id":20190,"name":"zhufl","email":"zhu.fanglei@zte.com.cn","username":"zhufl"},"change_message_id":"976823121deb9f6fab155340f8f74cbf074eb767","unresolved":false,"context_lines":[{"line_number":661,"context_line":"        :raises AssertionError: when items is empty"},{"line_number":662,"context_line":"        \"\"\""},{"line_number":663,"context_line":"        if msg is None:"},{"line_number":664,"context_line":"            msg \u003d \"items is empty.\""},{"line_number":665,"context_line":"        self.assertGreater(len(items), 0, msg)"}],"source_content_type":"text/x-python","patch_set":3,"id":"bff0334d_b748f786","line":664,"range":{"start_line":664,"start_character":19,"end_line":664,"end_character":24},"updated":"2017-04-10 03:03:57.000000000","message":"ditto","commit_id":"c49cf1fb38b941f2c8168da1ef13dc9df2cb565b"},{"author":{"_account_id":1921,"name":"Andrea Frittoli","email":"andrea.frittoli@gmail.com","username":"andrea-frittoli"},"change_message_id":"302ccc05c6d7dafb92a3224e8033007dfe81d827","unresolved":false,"context_lines":[{"line_number":661,"context_line":"        :raises AssertionError: when items is empty"},{"line_number":662,"context_line":"        \"\"\""},{"line_number":663,"context_line":"        if msg is None:"},{"line_number":664,"context_line":"            msg \u003d \"items is empty.\""},{"line_number":665,"context_line":"        self.assertGreater(len(items), 0, msg)"}],"source_content_type":"text/x-python","patch_set":3,"id":"bff0334d_46dfbbd5","line":664,"range":{"start_line":664,"start_character":19,"end_line":664,"end_character":24},"in_reply_to":"bff0334d_b748f786","updated":"2017-04-10 08:27:24.000000000","message":"Done","commit_id":"c49cf1fb38b941f2c8168da1ef13dc9df2cb565b"}]}