)]}'
{"tempest/api/image/v1/test_image_members.py":[{"author":{"_account_id":5689,"name":"Masayuki Igawa","email":"masayuki@igawa.io","username":"igawa"},"change_message_id":"d783d46d99a770e0dd2a61c54f90dad749c5d248","unresolved":false,"context_lines":[{"line_number":54,"context_line":"                                                     self.alt_tenant_id)"},{"line_number":55,"context_line":"        body \u003d self.image_member_client.list_image_members(image_id)"},{"line_number":56,"context_line":"        members \u003d body[\u0027members\u0027]"},{"line_number":57,"context_line":"        self.assertEmpty(members, str(members))"},{"line_number":58,"context_line":"        self.assertRaises("},{"line_number":59,"context_line":"            lib_exc.NotFound, self.alt_img_cli.show_image, image_id)"}],"source_content_type":"text/x-python","patch_set":3,"id":"bff0334d_d2debe0f","line":57,"updated":"2017-04-11 06:48:32.000000000","message":"hmm, good point. But I feel this should not be removed. Because the apis(list_image_members and show_image) are different.","commit_id":"0f9ad01997f2db4bf15da08a0f40da9f7aee6495"},{"author":{"_account_id":20190,"name":"zhufl","email":"zhu.fanglei@zte.com.cn","username":"zhufl"},"change_message_id":"b95e8e59bdaae9f49fb6a913e9fbc14f9fe51f92","unresolved":false,"context_lines":[{"line_number":54,"context_line":"                                                     self.alt_tenant_id)"},{"line_number":55,"context_line":"        body \u003d self.image_member_client.list_image_members(image_id)"},{"line_number":56,"context_line":"        members \u003d body[\u0027members\u0027]"},{"line_number":57,"context_line":"        self.assertEmpty(members, str(members))"},{"line_number":58,"context_line":"        self.assertRaises("},{"line_number":59,"context_line":"            lib_exc.NotFound, self.alt_img_cli.show_image, image_id)"}],"source_content_type":"text/x-python","patch_set":3,"id":"bff0334d_6b05ea13","line":57,"range":{"start_line":57,"start_character":34,"end_line":57,"end_character":46},"updated":"2017-04-10 08:01:34.000000000","message":"this seems can be removed","commit_id":"0f9ad01997f2db4bf15da08a0f40da9f7aee6495"},{"author":{"_account_id":8556,"name":"Ghanshyam Maan","display_name":"Ghanshyam Maan","email":"gmaan.os14@gmail.com","username":"ghanshyam"},"change_message_id":"a67cadce654c6ea94beb8508fb2dd6251273b505","unresolved":false,"context_lines":[{"line_number":54,"context_line":"                                                     self.alt_tenant_id)"},{"line_number":55,"context_line":"        body \u003d self.image_member_client.list_image_members(image_id)"},{"line_number":56,"context_line":"        members \u003d body[\u0027members\u0027]"},{"line_number":57,"context_line":"        self.assertEmpty(members, str(members))"},{"line_number":58,"context_line":"        self.assertRaises("},{"line_number":59,"context_line":"            lib_exc.NotFound, self.alt_img_cli.show_image, image_id)"}],"source_content_type":"text/x-python","patch_set":3,"id":"bff0334d_db713646","line":57,"in_reply_to":"bff0334d_92cef62a","updated":"2017-04-11 10:24:11.000000000","message":"yes, we can remove str(members) as this was used as error message in old case which now not needed as assertEmpty error message itself provide member list.","commit_id":"0f9ad01997f2db4bf15da08a0f40da9f7aee6495"},{"author":{"_account_id":20190,"name":"zhufl","email":"zhu.fanglei@zte.com.cn","username":"zhufl"},"change_message_id":"eac9104562e5e59b3e6077bdd5e83cbb46aaafcf","unresolved":false,"context_lines":[{"line_number":54,"context_line":"                                                     self.alt_tenant_id)"},{"line_number":55,"context_line":"        body \u003d self.image_member_client.list_image_members(image_id)"},{"line_number":56,"context_line":"        members \u003d body[\u0027members\u0027]"},{"line_number":57,"context_line":"        self.assertEmpty(members, str(members))"},{"line_number":58,"context_line":"        self.assertRaises("},{"line_number":59,"context_line":"            lib_exc.NotFound, self.alt_img_cli.show_image, image_id)"}],"source_content_type":"text/x-python","patch_set":3,"id":"bff0334d_92cef62a","line":57,"in_reply_to":"bff0334d_d2debe0f","updated":"2017-04-11 07:01:19.000000000","message":"if removed, the error info is something like:\n    list is not empty: [\u002711\u0027, \u002722\u0027]\n\nif not removed, the error info is something like:\n    [\u002711\u0027, \u002722\u0027]\n\nin other words, to remove it will get better error info displaying.","commit_id":"0f9ad01997f2db4bf15da08a0f40da9f7aee6495"},{"author":{"_account_id":5689,"name":"Masayuki Igawa","email":"masayuki@igawa.io","username":"igawa"},"change_message_id":"9ee2827d65afd7ba4c974314b3ee103f58e30ca1","unresolved":false,"context_lines":[{"line_number":54,"context_line":"                                                     self.alt_tenant_id)"},{"line_number":55,"context_line":"        body \u003d self.image_member_client.list_image_members(image_id)"},{"line_number":56,"context_line":"        members \u003d body[\u0027members\u0027]"},{"line_number":57,"context_line":"        self.assertEmpty(members, str(members))"},{"line_number":58,"context_line":"        self.assertRaises("},{"line_number":59,"context_line":"            lib_exc.NotFound, self.alt_img_cli.show_image, image_id)"}],"source_content_type":"text/x-python","patch_set":3,"id":"bff0334d_7d6c539b","line":57,"in_reply_to":"bff0334d_db713646","updated":"2017-04-11 15:45:36.000000000","message":"Ah, thanks, I misunderstood. (I was thinking to remove the assertEmpty()...) yeah, indeed. It\u0027s better to remove str(members).","commit_id":"0f9ad01997f2db4bf15da08a0f40da9f7aee6495"}],"tempest/test.py":[{"author":{"_account_id":20190,"name":"zhufl","email":"zhu.fanglei@zte.com.cn","username":"zhufl"},"change_message_id":"f4b25967f29fabd70052fe5b2114ab6bf483ec0d","unresolved":false,"context_lines":[{"line_number":645,"context_line":"    def assertEmpty(self, list, msg\u003dNone):"},{"line_number":646,"context_line":"        if msg is None:"},{"line_number":647,"context_line":"            msg \u003d \"list is not empty: %s\" % list"},{"line_number":648,"context_line":"        self.assertEmpty(list, msg)"},{"line_number":649,"context_line":""},{"line_number":650,"context_line":"    def assertNotEmpty(self, list, msg\u003dNone):"},{"line_number":651,"context_line":"        if msg is None:"}],"source_content_type":"text/x-python","patch_set":2,"id":"bff0334d_50f1b194","line":648,"range":{"start_line":648,"start_character":13,"end_line":648,"end_character":24},"updated":"2017-04-10 06:42:15.000000000","message":"I guess you don\u0027t mean to do this?","commit_id":"301a4f60920eba85e3e6d1f841cc408f4c607520"},{"author":{"_account_id":5689,"name":"Masayuki Igawa","email":"masayuki@igawa.io","username":"igawa"},"change_message_id":"0ad9d1efedaa10270533428628f85e35d1e605d7","unresolved":false,"context_lines":[{"line_number":645,"context_line":"    def assertEmpty(self, list, msg\u003dNone):"},{"line_number":646,"context_line":"        if msg is None:"},{"line_number":647,"context_line":"            msg \u003d \"list is not empty: %s\" % list"},{"line_number":648,"context_line":"        self.assertEmpty(list, msg)"},{"line_number":649,"context_line":""},{"line_number":650,"context_line":"    def assertNotEmpty(self, list, msg\u003dNone):"},{"line_number":651,"context_line":"        if msg is None:"}],"source_content_type":"text/x-python","patch_set":2,"id":"bff0334d_0bf77e61","line":648,"range":{"start_line":648,"start_character":13,"end_line":648,"end_character":24},"in_reply_to":"bff0334d_4b71060c","updated":"2017-04-10 07:47:14.000000000","message":"err, I was thinking to leave this in this patch. I think it\u0027s controversial thing and it\u0027s a bit different topic of this patch.","commit_id":"301a4f60920eba85e3e6d1f841cc408f4c607520"},{"author":{"_account_id":5689,"name":"Masayuki Igawa","email":"masayuki@igawa.io","username":"igawa"},"change_message_id":"de7c8cfdad7ff4b856ff4feae8de37d536fc2014","unresolved":false,"context_lines":[{"line_number":645,"context_line":"    def assertEmpty(self, list, msg\u003dNone):"},{"line_number":646,"context_line":"        if msg is None:"},{"line_number":647,"context_line":"            msg \u003d \"list is not empty: %s\" % list"},{"line_number":648,"context_line":"        self.assertEmpty(list, msg)"},{"line_number":649,"context_line":""},{"line_number":650,"context_line":"    def assertNotEmpty(self, list, msg\u003dNone):"},{"line_number":651,"context_line":"        if msg is None:"}],"source_content_type":"text/x-python","patch_set":2,"id":"bff0334d_4b71060c","line":648,"range":{"start_line":648,"start_character":13,"end_line":648,"end_character":24},"in_reply_to":"bff0334d_50f1b194","updated":"2017-04-10 07:43:58.000000000","message":"thanks, oops, I\u0027ll fix this... :(","commit_id":"301a4f60920eba85e3e6d1f841cc408f4c607520"}]}