)]}'
{"/COMMIT_MSG":[{"author":{"_account_id":5689,"name":"Masayuki Igawa","email":"masayuki@igawa.io","username":"igawa"},"change_message_id":"497e3bd28d5223059738cd39cc01f205e126e786","unresolved":false,"context_lines":[{"line_number":10,"context_line":"only depend on tempest.lib and config."},{"line_number":11,"context_line":""},{"line_number":12,"context_line":"InvalidServiceTag is in the exceptions module."},{"line_number":13,"context_line":"It cannot be moved in tempest.lib.exceptions since it has no meaning"},{"line_number":14,"context_line":"in there, so moving it to test.py directly."},{"line_number":15,"context_line":""},{"line_number":16,"context_line":"Change-Id: I969fb45a44ce08c176d64dfe1c58d75215eacdf5"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":3,"id":"bff0334d_d09d6f0a","line":13,"updated":"2017-04-12 06:40:15.000000000","message":"So, I don\u0027t understand here. Why does it have no meaning in tempest.lib.exceptions? I was thinking the reason is that the exception is used in only test.py. Is that correct?","commit_id":"b361507e2473e3d87df8017a6e9f10f64233eda0"},{"author":{"_account_id":1921,"name":"Andrea Frittoli","email":"andrea.frittoli@gmail.com","username":"andrea-frittoli"},"change_message_id":"6356e4f707d03c58ba86f3d45a0a276f48921624","unresolved":false,"context_lines":[{"line_number":10,"context_line":"only depend on tempest.lib and config."},{"line_number":11,"context_line":""},{"line_number":12,"context_line":"InvalidServiceTag is in the exceptions module."},{"line_number":13,"context_line":"It cannot be moved in tempest.lib.exceptions since it has no meaning"},{"line_number":14,"context_line":"in there, so moving it to test.py directly."},{"line_number":15,"context_line":""},{"line_number":16,"context_line":"Change-Id: I969fb45a44ce08c176d64dfe1c58d75215eacdf5"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":3,"id":"9ff52f3f_f1ecc6f4","line":13,"in_reply_to":"bff0334d_d09d6f0a","updated":"2017-04-13 10:55:45.000000000","message":"Because we would include in the library an exception that is never thrown by anything in the library, which would be awkward.","commit_id":"b361507e2473e3d87df8017a6e9f10f64233eda0"},{"author":{"_account_id":8556,"name":"Ghanshyam Maan","display_name":"Ghanshyam Maan","email":"gmaan.os14@gmail.com","username":"ghanshyam"},"change_message_id":"0a80eaee9031bce575c87d19e3b93c197e8cd1df","unresolved":false,"context_lines":[{"line_number":10,"context_line":"only depend on tempest.lib and config."},{"line_number":11,"context_line":""},{"line_number":12,"context_line":"InvalidServiceTag is in the exceptions module."},{"line_number":13,"context_line":"It cannot be moved in tempest.lib.exceptions since it has no meaning"},{"line_number":14,"context_line":"in there, so moving it to test.py directly."},{"line_number":15,"context_line":""},{"line_number":16,"context_line":"Change-Id: I969fb45a44ce08c176d64dfe1c58d75215eacdf5"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":3,"id":"bff0334d_4779a4c5","line":13,"in_reply_to":"bff0334d_d09d6f0a","updated":"2017-04-12 08:44:28.000000000","message":"if we keep \u0027service\u0027 decorator in test.py then it make sense not to keep in lib.exception.","commit_id":"b361507e2473e3d87df8017a6e9f10f64233eda0"}]}
