)]}'
{"tempest/api/identity/admin/v2/test_tokens.py":[{"author":{"_account_id":5689,"name":"Masayuki Igawa","email":"masayuki@igawa.io","username":"igawa"},"change_message_id":"b63533a65bbecdd170ec581e3b9d6739e427b2db","unresolved":false,"context_lines":[{"line_number":33,"context_line":"        # second:create a user"},{"line_number":34,"context_line":"        user \u003d self.create_test_user(name\u003duser_name,"},{"line_number":35,"context_line":"                                     password\u003duser_password,"},{"line_number":36,"context_line":"                                     tenantId\u003dtenant[\u0027id\u0027])"},{"line_number":37,"context_line":"        # then get a token for the user"},{"line_number":38,"context_line":"        body \u003d self.token_client.auth(user_name,"},{"line_number":39,"context_line":"                                      user_password,"}],"source_content_type":"text/x-python","patch_set":1,"id":"9ff52f3f_d1b782d8","line":36,"updated":"2017-04-13 10:59:24.000000000","message":"I think the original code passes email\u003d\u0027\u0027, but here doesn\u0027t. Is this intentional? I feel we should keep the values as possible. Otherwise, it\u0027s better to explain it in the commit message at least.","commit_id":"9d0194c21b4e301e40ff913612574a5f38675e1e"},{"author":{"_account_id":20190,"name":"zhufl","email":"zhu.fanglei@zte.com.cn","username":"zhufl"},"change_message_id":"292dbf0504acec3bea7cdcd60cbb9e85853d34f0","unresolved":false,"context_lines":[{"line_number":34,"context_line":"        user \u003d self.create_test_user(name\u003duser_name,"},{"line_number":35,"context_line":"                                     password\u003duser_password,"},{"line_number":36,"context_line":"                                     tenantId\u003dtenant[\u0027id\u0027],"},{"line_number":37,"context_line":"                                     email\u003d\u0027\u0027)"},{"line_number":38,"context_line":"        # then get a token for the user"},{"line_number":39,"context_line":"        body \u003d self.token_client.auth(user_name,"},{"line_number":40,"context_line":"                                      user_password,"}],"source_content_type":"text/x-python","patch_set":3,"id":"7ffa3b31_f3aa92d0","line":37,"range":{"start_line":37,"start_character":37,"end_line":37,"end_character":45},"updated":"2017-04-14 01:40:49.000000000","message":"Thanks Masayuki, I don\u0027t intend to remove it, and I agree that it should be kept in this patch even if it seems not very necessary.","commit_id":"75d51a9badb7c3fec1ce6064d3bbff4d767125ba"}],"tempest/api/identity/admin/v2/test_users.py":[{"author":{"_account_id":5689,"name":"Masayuki Igawa","email":"masayuki@igawa.io","username":"igawa"},"change_message_id":"c95708afc253ba6db1aef9f341acf9ae66177e81","unresolved":false,"context_lines":[{"line_number":130,"context_line":"        tenant \u003d self.setup_test_tenant()"},{"line_number":131,"context_line":"        user_ids \u003d list()"},{"line_number":132,"context_line":"        fetched_user_ids \u003d list()"},{"line_number":133,"context_line":"        user1 \u003d self.create_test_user(tenantId\u003dtenant[\u0027id\u0027])"},{"line_number":134,"context_line":"        user_ids.append(user1[\u0027id\u0027])"},{"line_number":135,"context_line":"        user2 \u003d self.create_test_user(tenantId\u003dtenant[\u0027id\u0027])"},{"line_number":136,"context_line":"        user_ids.append(user2[\u0027id\u0027])"}],"source_content_type":"text/x-python","patch_set":3,"id":"7ffa3b31_592604ba","line":133,"updated":"2017-04-14 07:26:24.000000000","message":"It\u0027s a bit different from original about email. But I\u0027m OK. I think the original test just wanted to set a random email. It was invalid format, though.","commit_id":"75d51a9badb7c3fec1ce6064d3bbff4d767125ba"}],"tempest/api/identity/base.py":[{"author":{"_account_id":5689,"name":"Masayuki Igawa","email":"masayuki@igawa.io","username":"igawa"},"change_message_id":"c95708afc253ba6db1aef9f341acf9ae66177e81","unresolved":false,"context_lines":[{"line_number":73,"context_line":"        if \u0027name\u0027 not in kwargs:"},{"line_number":74,"context_line":"            kwargs[\u0027name\u0027] \u003d data_utils.rand_name(\u0027test_user\u0027)"},{"line_number":75,"context_line":"        if \u0027email\u0027 not in kwargs:"},{"line_number":76,"context_line":"            kwargs[\u0027email\u0027] \u003d kwargs[\u0027name\u0027] + \u0027@testmail.tm\u0027"},{"line_number":77,"context_line":""},{"line_number":78,"context_line":"        user \u003d self.users_client.create_user(**kwargs)[\u0027user\u0027]"},{"line_number":79,"context_line":"        # Delete the user at the end of the test"}],"source_content_type":"text/x-python","patch_set":3,"id":"7ffa3b31_7921c09f","line":76,"updated":"2017-04-14 07:26:24.000000000","message":"I feel \u0027testmail.tm\u0027 is not a good testmail domain. \u0027example.com\u0027 is better here? But I think we can update this with a following patch.","commit_id":"75d51a9badb7c3fec1ce6064d3bbff4d767125ba"}]}
