)]}'
{"tempest/api/network/test_load_balancer.py":[{"author":{"_account_id":6796,"name":"Giulio Fidente","email":"gfidente@redhat.com","username":"gfidente"},"change_message_id":"a6ad2b0d5b659c102f8716284578a6c4057f0468","unresolved":false,"context_lines":[{"line_number":179,"context_line":"            if (n[\u0027id\u0027] \u003d\u003d self.health_monitor[\u0027id\u0027]):"},{"line_number":180,"context_line":"                found \u003d n[\u0027id\u0027]"},{"line_number":181,"context_line":"        msg \u003d \"health_monitors list doesn\u0027t contain created health_monitor\""},{"line_number":182,"context_line":"        self.assertIsNotNone(found, msg)"},{"line_number":183,"context_line":""},{"line_number":184,"context_line":"    @attr(type\u003d\u0027smoke\u0027)"},{"line_number":185,"context_line":"    def test_create_update_delete_health_monitor(self):"}],"source_content_type":"text/x-python","patch_set":5,"id":"AAAAS3%2F%2F2Ug%3D","line":182,"updated":"2013-09-18 09:25:35.000000000","message":"as with the other changes proposed, I\u0027d like this to be changed into an assertIn()","commit_id":"03041cbb7abeae249af6dd1b3c0d4a384f6a4146"}],"tempest/services/network/json/network_client.py":[{"author":{"_account_id":6167,"name":"Ken\u0027ichi Ohmichi","email":"ken1ohmichi@gmail.com","username":"oomichi"},"change_message_id":"6611322fee49d222dc10ede2c44b7cea88b5b1db","unresolved":false,"context_lines":[{"line_number":549,"context_line":"                \"timeout\": timeout"},{"line_number":550,"context_line":"            }"},{"line_number":551,"context_line":"        }"},{"line_number":552,"context_line":"        body \u003d json.dumps(post_body)"},{"line_number":553,"context_line":"        uri \u003d \u0027%s/lb/health_monitors\u0027 % (self.uri_prefix)"},{"line_number":554,"context_line":"        resp, body \u003d self.post(uri, headers\u003dself.headers, body\u003dbody)"},{"line_number":555,"context_line":"        body \u003d json.loads(body)"}],"source_content_type":"text/x-python","patch_set":5,"id":"AAAAS3%2F%2F3Ow%3D","line":552,"updated":"2013-09-18 02:57:54.000000000","message":"How about changing the arguments \"delay, max_retries, Type, timeout\" to \"**kwargs\" and merging line544-552 to \"body \u003d json.dumps(\"health_monitor\": kwargs)\"?\nalso the callers of create_health_monitor() should specify \"delay\n\u003d4, max_retries\u003d..\".\n\nThe above my proposal would make create_health_monitor() more flexible.\n\nThe good sample would be https://review.openstack.org/#/c/46477/ .","commit_id":"03041cbb7abeae249af6dd1b3c0d4a384f6a4146"},{"author":{"_account_id":6167,"name":"Ken\u0027ichi Ohmichi","email":"ken1ohmichi@gmail.com","username":"oomichi"},"change_message_id":"36c8fbb93e2126e12811e85362f18fc1fdc5c100","unresolved":false,"context_lines":[{"line_number":549,"context_line":"                \"timeout\": timeout"},{"line_number":550,"context_line":"            }"},{"line_number":551,"context_line":"        }"},{"line_number":552,"context_line":"        body \u003d json.dumps(post_body)"},{"line_number":553,"context_line":"        uri \u003d \u0027%s/lb/health_monitors\u0027 % (self.uri_prefix)"},{"line_number":554,"context_line":"        resp, body \u003d self.post(uri, headers\u003dself.headers, body\u003dbody)"},{"line_number":555,"context_line":"        body \u003d json.loads(body)"}],"source_content_type":"text/x-python","patch_set":5,"id":"AAAAS3%2F%2F3HY%3D","line":552,"in_reply_to":"AAAAS3%2F%2F3Hw%3D","updated":"2013-09-18 05:02:20.000000000","message":"thanks again, I see. I should study python more..","commit_id":"03041cbb7abeae249af6dd1b3c0d4a384f6a4146"},{"author":{"_account_id":8205,"name":"Mh Raies","email":"raiesmh08@gmail.com","username":"raiesmh08"},"change_message_id":"3746e605a4819a455c1d765c9c5108e3c0ffbdb6","unresolved":false,"context_lines":[{"line_number":549,"context_line":"                \"timeout\": timeout"},{"line_number":550,"context_line":"            }"},{"line_number":551,"context_line":"        }"},{"line_number":552,"context_line":"        body \u003d json.dumps(post_body)"},{"line_number":553,"context_line":"        uri \u003d \u0027%s/lb/health_monitors\u0027 % (self.uri_prefix)"},{"line_number":554,"context_line":"        resp, body \u003d self.post(uri, headers\u003dself.headers, body\u003dbody)"},{"line_number":555,"context_line":"        body \u003d json.loads(body)"}],"source_content_type":"text/x-python","patch_set":5,"id":"AAAAS3%2F%2F3Hw%3D","line":552,"in_reply_to":"AAAAS3%2F%2F3Is%3D","updated":"2013-09-18 04:57:50.000000000","message":"actually \"type\" is a python keyword. so I had to use \"Type\". If I were using \"type\" instead then there will be error as interpreter will recognise it as a keyword argument.","commit_id":"03041cbb7abeae249af6dd1b3c0d4a384f6a4146"},{"author":{"_account_id":6167,"name":"Ken\u0027ichi Ohmichi","email":"ken1ohmichi@gmail.com","username":"oomichi"},"change_message_id":"8ed7ff66bd524b725ebad3b2370e5e19c151e0da","unresolved":false,"context_lines":[{"line_number":549,"context_line":"                \"timeout\": timeout"},{"line_number":550,"context_line":"            }"},{"line_number":551,"context_line":"        }"},{"line_number":552,"context_line":"        body \u003d json.dumps(post_body)"},{"line_number":553,"context_line":"        uri \u003d \u0027%s/lb/health_monitors\u0027 % (self.uri_prefix)"},{"line_number":554,"context_line":"        resp, body \u003d self.post(uri, headers\u003dself.headers, body\u003dbody)"},{"line_number":555,"context_line":"        body \u003d json.loads(body)"}],"source_content_type":"text/x-python","patch_set":5,"id":"AAAAS3%2F%2F3Is%3D","line":552,"in_reply_to":"AAAAS3%2F%2F3JY%3D","updated":"2013-09-18 04:53:34.000000000","message":"Thanks for your explanation, I see.\n\nand one more thing, why don\u0027t you change the argument \"Type\" to \"type\"? The argument only is different from the parameter name.","commit_id":"03041cbb7abeae249af6dd1b3c0d4a384f6a4146"},{"author":{"_account_id":8205,"name":"Mh Raies","email":"raiesmh08@gmail.com","username":"raiesmh08"},"change_message_id":"9d7b052d379228bd679099462316bfced213fb48","unresolved":false,"context_lines":[{"line_number":549,"context_line":"                \"timeout\": timeout"},{"line_number":550,"context_line":"            }"},{"line_number":551,"context_line":"        }"},{"line_number":552,"context_line":"        body \u003d json.dumps(post_body)"},{"line_number":553,"context_line":"        uri \u003d \u0027%s/lb/health_monitors\u0027 % (self.uri_prefix)"},{"line_number":554,"context_line":"        resp, body \u003d self.post(uri, headers\u003dself.headers, body\u003dbody)"},{"line_number":555,"context_line":"        body \u003d json.loads(body)"}],"source_content_type":"text/x-python","patch_set":5,"id":"AAAAS3%2F%2F3JY%3D","line":552,"in_reply_to":"AAAAS3%2F%2F3Ow%3D","updated":"2013-09-18 04:45:12.000000000","message":"all mentioned parameters are required parameters.\nIf they were optional, taking them as kwargs is reasonable.\nBut these are required parameter so my method is at right.","commit_id":"03041cbb7abeae249af6dd1b3c0d4a384f6a4146"}],"tempest/services/network/xml/network_client.py":[{"author":{"_account_id":6167,"name":"Ken\u0027ichi Ohmichi","email":"ken1ohmichi@gmail.com","username":"oomichi"},"change_message_id":"6611322fee49d222dc10ede2c44b7cea88b5b1db","unresolved":false,"context_lines":[{"line_number":388,"context_line":"        post_body.append(p2)"},{"line_number":389,"context_line":"        post_body.append(p3)"},{"line_number":390,"context_line":"        post_body.append(p4)"},{"line_number":391,"context_line":"        resp, body \u003d self.post(uri, str(Document(post_body)), self.headers)"},{"line_number":392,"context_line":"        body \u003d _root_tag_fetcher_and_xml_to_json_parse(body)"},{"line_number":393,"context_line":"        return resp, body"},{"line_number":394,"context_line":""}],"source_content_type":"text/x-python","patch_set":5,"id":"AAAAS3%2F%2F3Os%3D","line":391,"updated":"2013-09-18 02:57:54.000000000","message":"the same point as json/network_client.py.","commit_id":"03041cbb7abeae249af6dd1b3c0d4a384f6a4146"},{"author":{"_account_id":8205,"name":"Mh Raies","email":"raiesmh08@gmail.com","username":"raiesmh08"},"change_message_id":"9d7b052d379228bd679099462316bfced213fb48","unresolved":false,"context_lines":[{"line_number":388,"context_line":"        post_body.append(p2)"},{"line_number":389,"context_line":"        post_body.append(p3)"},{"line_number":390,"context_line":"        post_body.append(p4)"},{"line_number":391,"context_line":"        resp, body \u003d self.post(uri, str(Document(post_body)), self.headers)"},{"line_number":392,"context_line":"        body \u003d _root_tag_fetcher_and_xml_to_json_parse(body)"},{"line_number":393,"context_line":"        return resp, body"},{"line_number":394,"context_line":""}],"source_content_type":"text/x-python","patch_set":5,"id":"AAAAS3%2F%2F3JU%3D","line":391,"in_reply_to":"AAAAS3%2F%2F3Os%3D","updated":"2013-09-18 04:45:12.000000000","message":"the same point as json/network_client.py.","commit_id":"03041cbb7abeae249af6dd1b3c0d4a384f6a4146"}]}