)]}'
{"tempest/api/volume/test_volumes_negative.py":[{"author":{"_account_id":5689,"name":"Masayuki Igawa","email":"masayuki@igawa.io","username":"igawa"},"change_message_id":"f24b7684ee5f813979a28fef54df1a07cfc49881","unresolved":false,"context_lines":[{"line_number":271,"context_line":"    @decorators.idempotent_id(\u00275b810c91-0ad1-47ce-aee8-615f789be78f\u0027)"},{"line_number":272,"context_line":"    @test.services(\u0027image\u0027)"},{"line_number":273,"context_line":"    def test_create_volume_from_image_with_decreasing_size(self):"},{"line_number":274,"context_line":"        image \u003d self.compute_images_client.show_image("},{"line_number":275,"context_line":"            CONF.compute.image_ref)[\u0027image\u0027]"},{"line_number":276,"context_line":"        image_alt \u003d self.compute_images_client.show_image("},{"line_number":277,"context_line":"            CONF.compute.image_ref_alt)[\u0027image\u0027]"}],"source_content_type":"text/x-python","patch_set":4,"id":"7ffa3b31_ae60f833","line":274,"updated":"2017-04-17 07:47:07.000000000","message":"hmm, The compute image api seems already deprecated[1]. So, I think we should use the image client directory.\nI don\u0027t think this is for this patch\u0027s topic, though. We should fix it in another patch.","commit_id":"dbafd8b287d0e86f2815a33a395664e75eb95959"},{"author":{"_account_id":23081,"name":"Jeremy Zhang","email":"zhangjun_inspur@163.com","username":"jeremy.zhang"},"change_message_id":"ce363e40ac4f4ff5ba090f4d11fb83952f8c3a6c","unresolved":false,"context_lines":[{"line_number":271,"context_line":"    @decorators.idempotent_id(\u00275b810c91-0ad1-47ce-aee8-615f789be78f\u0027)"},{"line_number":272,"context_line":"    @test.services(\u0027image\u0027)"},{"line_number":273,"context_line":"    def test_create_volume_from_image_with_decreasing_size(self):"},{"line_number":274,"context_line":"        image \u003d self.compute_images_client.show_image("},{"line_number":275,"context_line":"            CONF.compute.image_ref)[\u0027image\u0027]"},{"line_number":276,"context_line":"        image_alt \u003d self.compute_images_client.show_image("},{"line_number":277,"context_line":"            CONF.compute.image_ref_alt)[\u0027image\u0027]"}],"source_content_type":"text/x-python","patch_set":4,"id":"7ffa3b31_ce3a24e6","line":274,"in_reply_to":"7ffa3b31_ae60f833","updated":"2017-04-17 08:11:21.000000000","message":"I agree with your opinion.\nI have already commited a patch (https://review.openstack.org/#/c/456848/) to substitue compute image api with image native api in volume tests. \nBut Jordan thinks it is a litte too early to do the substitution.","commit_id":"dbafd8b287d0e86f2815a33a395664e75eb95959"},{"author":{"_account_id":5689,"name":"Masayuki Igawa","email":"masayuki@igawa.io","username":"igawa"},"change_message_id":"f24b7684ee5f813979a28fef54df1a07cfc49881","unresolved":false,"context_lines":[{"line_number":278,"context_line":""},{"line_number":279,"context_line":"        # Choose image with max(size or min_disk) \u003e 1G"},{"line_number":280,"context_line":"        chosen_image_id \u003d None"},{"line_number":281,"context_line":"        gb_in_bytes \u003d 1073741824"},{"line_number":282,"context_line":"        if max(image[\u0027OS-EXT-IMG-SIZE:size\u0027] / gb_in_bytes,"},{"line_number":283,"context_line":"               image[\u0027minDisk\u0027]) \u003e 1:"},{"line_number":284,"context_line":"            chosen_image_id \u003d CONF.compute.image_ref"}],"source_content_type":"text/x-python","patch_set":4,"id":"7ffa3b31_8e553c53","line":281,"updated":"2017-04-17 07:47:07.000000000","message":"yeah, but I prefer \u00271024 * 1024 * 1024\u0027 here.","commit_id":"dbafd8b287d0e86f2815a33a395664e75eb95959"},{"author":{"_account_id":23081,"name":"Jeremy Zhang","email":"zhangjun_inspur@163.com","username":"jeremy.zhang"},"change_message_id":"ce363e40ac4f4ff5ba090f4d11fb83952f8c3a6c","unresolved":false,"context_lines":[{"line_number":278,"context_line":""},{"line_number":279,"context_line":"        # Choose image with max(size or min_disk) \u003e 1G"},{"line_number":280,"context_line":"        chosen_image_id \u003d None"},{"line_number":281,"context_line":"        gb_in_bytes \u003d 1073741824"},{"line_number":282,"context_line":"        if max(image[\u0027OS-EXT-IMG-SIZE:size\u0027] / gb_in_bytes,"},{"line_number":283,"context_line":"               image[\u0027minDisk\u0027]) \u003e 1:"},{"line_number":284,"context_line":"            chosen_image_id \u003d CONF.compute.image_ref"}],"source_content_type":"text/x-python","patch_set":4,"id":"7ffa3b31_8eb1bc92","line":281,"in_reply_to":"7ffa3b31_8e553c53","updated":"2017-04-17 08:11:21.000000000","message":"yeah, 1024 * 1024 * 1024 is better.","commit_id":"dbafd8b287d0e86f2815a33a395664e75eb95959"},{"author":{"_account_id":5689,"name":"Masayuki Igawa","email":"masayuki@igawa.io","username":"igawa"},"change_message_id":"f24b7684ee5f813979a28fef54df1a07cfc49881","unresolved":false,"context_lines":[{"line_number":279,"context_line":"        # Choose image with max(size or min_disk) \u003e 1G"},{"line_number":280,"context_line":"        chosen_image_id \u003d None"},{"line_number":281,"context_line":"        gb_in_bytes \u003d 1073741824"},{"line_number":282,"context_line":"        if max(image[\u0027OS-EXT-IMG-SIZE:size\u0027] / gb_in_bytes,"},{"line_number":283,"context_line":"               image[\u0027minDisk\u0027]) \u003e 1:"},{"line_number":284,"context_line":"            chosen_image_id \u003d CONF.compute.image_ref"},{"line_number":285,"context_line":"        elif max(image_alt[\u0027OS-EXT-IMG-SIZE:size\u0027] / gb_in_bytes,"}],"source_content_type":"text/x-python","patch_set":4,"id":"7ffa3b31_6e52f069","line":282,"updated":"2017-04-17 07:47:07.000000000","message":"image_alt[\u0027OS-EXT-IMG-SIZE:size\u0027] is an integer value. So if the size is gb_in_bytes+1, the value will be 1, too. Is that your intention?","commit_id":"dbafd8b287d0e86f2815a33a395664e75eb95959"},{"author":{"_account_id":23081,"name":"Jeremy Zhang","email":"zhangjun_inspur@163.com","username":"jeremy.zhang"},"change_message_id":"ce363e40ac4f4ff5ba090f4d11fb83952f8c3a6c","unresolved":false,"context_lines":[{"line_number":279,"context_line":"        # Choose image with max(size or min_disk) \u003e 1G"},{"line_number":280,"context_line":"        chosen_image_id \u003d None"},{"line_number":281,"context_line":"        gb_in_bytes \u003d 1073741824"},{"line_number":282,"context_line":"        if max(image[\u0027OS-EXT-IMG-SIZE:size\u0027] / gb_in_bytes,"},{"line_number":283,"context_line":"               image[\u0027minDisk\u0027]) \u003e 1:"},{"line_number":284,"context_line":"            chosen_image_id \u003d CONF.compute.image_ref"},{"line_number":285,"context_line":"        elif max(image_alt[\u0027OS-EXT-IMG-SIZE:size\u0027] / gb_in_bytes,"}],"source_content_type":"text/x-python","patch_set":4,"id":"7ffa3b31_10d14a55","line":282,"in_reply_to":"7ffa3b31_6e52f069","updated":"2017-04-17 08:11:21.000000000","message":"Oops, it\u0027s my fault, I\u0027ll fix it in the next path, thanks.","commit_id":"dbafd8b287d0e86f2815a33a395664e75eb95959"},{"author":{"_account_id":5689,"name":"Masayuki Igawa","email":"masayuki@igawa.io","username":"igawa"},"change_message_id":"f24b7684ee5f813979a28fef54df1a07cfc49881","unresolved":false,"context_lines":[{"line_number":286,"context_line":"                 image_alt[\u0027minDisk\u0027]) \u003e 1:"},{"line_number":287,"context_line":"            chosen_image_id \u003d CONF.compute.image_ref_alt"},{"line_number":288,"context_line":"        else:"},{"line_number":289,"context_line":"            self.skipTest(\"No suitable image provided\")"},{"line_number":290,"context_line":""},{"line_number":291,"context_line":"        # Create volume from image with decreasing size 1G"},{"line_number":292,"context_line":"        self.assertRaises(lib_exc.BadRequest,"}],"source_content_type":"text/x-python","patch_set":4,"id":"7ffa3b31_4e4f34bd","line":289,"updated":"2017-04-17 07:47:07.000000000","message":"I feel this case should be failed because it\u0027s kind of misconfigurations.","commit_id":"dbafd8b287d0e86f2815a33a395664e75eb95959"},{"author":{"_account_id":23081,"name":"Jeremy Zhang","email":"zhangjun_inspur@163.com","username":"jeremy.zhang"},"change_message_id":"ce363e40ac4f4ff5ba090f4d11fb83952f8c3a6c","unresolved":false,"context_lines":[{"line_number":286,"context_line":"                 image_alt[\u0027minDisk\u0027]) \u003e 1:"},{"line_number":287,"context_line":"            chosen_image_id \u003d CONF.compute.image_ref_alt"},{"line_number":288,"context_line":"        else:"},{"line_number":289,"context_line":"            self.skipTest(\"No suitable image provided\")"},{"line_number":290,"context_line":""},{"line_number":291,"context_line":"        # Create volume from image with decreasing size 1G"},{"line_number":292,"context_line":"        self.assertRaises(lib_exc.BadRequest,"}],"source_content_type":"text/x-python","patch_set":4,"id":"7ffa3b31_10f82ae3","line":289,"in_reply_to":"7ffa3b31_4e4f34bd","updated":"2017-04-17 08:11:21.000000000","message":"1G is minimal size for creating volume, if the size of images provided (image_ref, image_ref_alt) and the min disk of images are both less than 1G, this negative tests cannot be done, so it should be skipped for no suitable images provided.","commit_id":"dbafd8b287d0e86f2815a33a395664e75eb95959"},{"author":{"_account_id":20190,"name":"zhufl","email":"zhu.fanglei@zte.com.cn","username":"zhufl"},"change_message_id":"280721351294df98fd0e3c8aae175c3f8955d196","unresolved":false,"context_lines":[{"line_number":271,"context_line":"    @decorators.idempotent_id(\u00275b810c91-0ad1-47ce-aee8-615f789be78f\u0027)"},{"line_number":272,"context_line":"    @test.services(\u0027image\u0027)"},{"line_number":273,"context_line":"    def test_create_volume_from_image_with_decreasing_size(self):"},{"line_number":274,"context_line":"        image \u003d self.compute_images_client.show_image("},{"line_number":275,"context_line":"            CONF.compute.image_ref)[\u0027image\u0027]"},{"line_number":276,"context_line":"        image_alt \u003d self.compute_images_client.show_image("},{"line_number":277,"context_line":"            CONF.compute.image_ref_alt)[\u0027image\u0027]"},{"line_number":278,"context_line":""},{"line_number":279,"context_line":"        # Choose image with max(size, min_disk) \u003e 1G"},{"line_number":280,"context_line":"        chosen_image_id \u003d None"},{"line_number":281,"context_line":"        gb_in_bytes \u003d 1024 * 1024 * 1024"},{"line_number":282,"context_line":"        if max(image[\u0027OS-EXT-IMG-SIZE:size\u0027],"},{"line_number":283,"context_line":"               image[\u0027minDisk\u0027] * gb_in_bytes) \u003e gb_in_bytes:"},{"line_number":284,"context_line":"            chosen_image_id \u003d CONF.compute.image_ref"},{"line_number":285,"context_line":"        elif max(image_alt[\u0027OS-EXT-IMG-SIZE:size\u0027],"},{"line_number":286,"context_line":"                 image_alt[\u0027minDisk\u0027] * gb_in_bytes) \u003e gb_in_bytes:"},{"line_number":287,"context_line":"            chosen_image_id \u003d CONF.compute.image_ref_alt"},{"line_number":288,"context_line":"        else:"},{"line_number":289,"context_line":"            self.skipTest(\"No suitable image provided\")"},{"line_number":290,"context_line":""},{"line_number":291,"context_line":"        # Create volume from image with decreasing size 1G"},{"line_number":292,"context_line":"        self.assertRaises(lib_exc.BadRequest,"}],"source_content_type":"text/x-python","patch_set":5,"id":"7ffa3b31_e5ad9a9b","line":289,"range":{"start_line":274,"start_character":0,"end_line":289,"end_character":55},"updated":"2017-04-20 03:04:22.000000000","message":"+1 for Jordan, maybe you should create an image","commit_id":"5becf0281797f85b94c11a05823e3cd221e03e29"},{"author":{"_account_id":23081,"name":"Jeremy Zhang","email":"zhangjun_inspur@163.com","username":"jeremy.zhang"},"change_message_id":"5c77f4a9371188788d9c3c5fe1a2f4e3fe4dc836","unresolved":false,"context_lines":[{"line_number":271,"context_line":"    @decorators.idempotent_id(\u00275b810c91-0ad1-47ce-aee8-615f789be78f\u0027)"},{"line_number":272,"context_line":"    @test.services(\u0027image\u0027)"},{"line_number":273,"context_line":"    def test_create_volume_from_image_with_decreasing_size(self):"},{"line_number":274,"context_line":"        image \u003d self.compute_images_client.show_image("},{"line_number":275,"context_line":"            CONF.compute.image_ref)[\u0027image\u0027]"},{"line_number":276,"context_line":"        image_alt \u003d self.compute_images_client.show_image("},{"line_number":277,"context_line":"            CONF.compute.image_ref_alt)[\u0027image\u0027]"},{"line_number":278,"context_line":""},{"line_number":279,"context_line":"        # Choose image with max(size, min_disk) \u003e 1G"},{"line_number":280,"context_line":"        chosen_image_id \u003d None"},{"line_number":281,"context_line":"        gb_in_bytes \u003d 1024 * 1024 * 1024"},{"line_number":282,"context_line":"        if max(image[\u0027OS-EXT-IMG-SIZE:size\u0027],"},{"line_number":283,"context_line":"               image[\u0027minDisk\u0027] * gb_in_bytes) \u003e gb_in_bytes:"},{"line_number":284,"context_line":"            chosen_image_id \u003d CONF.compute.image_ref"},{"line_number":285,"context_line":"        elif max(image_alt[\u0027OS-EXT-IMG-SIZE:size\u0027],"},{"line_number":286,"context_line":"                 image_alt[\u0027minDisk\u0027] * gb_in_bytes) \u003e gb_in_bytes:"},{"line_number":287,"context_line":"            chosen_image_id \u003d CONF.compute.image_ref_alt"},{"line_number":288,"context_line":"        else:"},{"line_number":289,"context_line":"            self.skipTest(\"No suitable image provided\")"},{"line_number":290,"context_line":""},{"line_number":291,"context_line":"        # Create volume from image with decreasing size 1G"},{"line_number":292,"context_line":"        self.assertRaises(lib_exc.BadRequest,"}],"source_content_type":"text/x-python","patch_set":5,"id":"7ffa3b31_2b4eb396","line":289,"range":{"start_line":274,"start_character":0,"end_line":289,"end_character":55},"in_reply_to":"7ffa3b31_e5ad9a9b","updated":"2017-04-20 05:41:25.000000000","message":"Ok, I\u0027ll have a try, thanks.","commit_id":"5becf0281797f85b94c11a05823e3cd221e03e29"}]}