)]}'
{"releasenotes/notes/add-manage-snapshot-ref-config-option-67efd04897335b67.yaml":[{"author":{"_account_id":20190,"name":"zhufl","email":"zhu.fanglei@zte.com.cn","username":"zhufl"},"change_message_id":"3d8f0828fec4640a3b0fe50b4e131a08da97e42b","unresolved":false,"context_lines":[{"line_number":1,"context_line":"---"},{"line_number":2,"context_line":"features:"},{"line_number":3,"context_line":"  - |"},{"line_number":4,"context_line":"    A new config option \u0027manage_snapshot_ref\u0027 added in the volume section, to"},{"line_number":5,"context_line":"    specify snapshot ref paramter for different storage backend drivers when"},{"line_number":6,"context_line":"    managing a unmanaged snapshot. By default it is set to fit the LVM driver."}],"source_content_type":"text/x-yaml","patch_set":5,"id":"7f231b9d_58b23d96","line":4,"range":{"start_line":4,"start_character":46,"end_line":4,"end_character":51},"updated":"2017-06-13 03:20:56.000000000","message":"is added","commit_id":"9eedeac0d270eec85ebe0821e675a7a085386184"},{"author":{"_account_id":23081,"name":"Jeremy Zhang","email":"zhangjun_inspur@163.com","username":"jeremy.zhang"},"change_message_id":"55a0a93b7f78552ca68f22a3f1440ca6ede16d11","unresolved":false,"context_lines":[{"line_number":1,"context_line":"---"},{"line_number":2,"context_line":"features:"},{"line_number":3,"context_line":"  - |"},{"line_number":4,"context_line":"    A new config option \u0027manage_snapshot_ref\u0027 added in the volume section, to"},{"line_number":5,"context_line":"    specify snapshot ref paramter for different storage backend drivers when"},{"line_number":6,"context_line":"    managing a unmanaged snapshot. By default it is set to fit the LVM driver."}],"source_content_type":"text/x-yaml","patch_set":5,"id":"7f231b9d_051d79bc","line":4,"range":{"start_line":4,"start_character":46,"end_line":4,"end_character":51},"in_reply_to":"7f231b9d_58b23d96","updated":"2017-06-13 04:34:51.000000000","message":"Done","commit_id":"9eedeac0d270eec85ebe0821e675a7a085386184"},{"author":{"_account_id":20190,"name":"zhufl","email":"zhu.fanglei@zte.com.cn","username":"zhufl"},"change_message_id":"3d8f0828fec4640a3b0fe50b4e131a08da97e42b","unresolved":false,"context_lines":[{"line_number":2,"context_line":"features:"},{"line_number":3,"context_line":"  - |"},{"line_number":4,"context_line":"    A new config option \u0027manage_snapshot_ref\u0027 added in the volume section, to"},{"line_number":5,"context_line":"    specify snapshot ref paramter for different storage backend drivers when"},{"line_number":6,"context_line":"    managing a unmanaged snapshot. By default it is set to fit the LVM driver."}],"source_content_type":"text/x-yaml","patch_set":5,"id":"7f231b9d_b866f128","line":5,"range":{"start_line":5,"start_character":25,"end_line":5,"end_character":32},"updated":"2017-06-13 03:20:56.000000000","message":"parameter","commit_id":"9eedeac0d270eec85ebe0821e675a7a085386184"},{"author":{"_account_id":23081,"name":"Jeremy Zhang","email":"zhangjun_inspur@163.com","username":"jeremy.zhang"},"change_message_id":"55a0a93b7f78552ca68f22a3f1440ca6ede16d11","unresolved":false,"context_lines":[{"line_number":2,"context_line":"features:"},{"line_number":3,"context_line":"  - |"},{"line_number":4,"context_line":"    A new config option \u0027manage_snapshot_ref\u0027 added in the volume section, to"},{"line_number":5,"context_line":"    specify snapshot ref paramter for different storage backend drivers when"},{"line_number":6,"context_line":"    managing a unmanaged snapshot. By default it is set to fit the LVM driver."}],"source_content_type":"text/x-yaml","patch_set":5,"id":"7f231b9d_e5795dfc","line":5,"range":{"start_line":5,"start_character":25,"end_line":5,"end_character":32},"in_reply_to":"7f231b9d_b866f128","updated":"2017-06-13 04:34:51.000000000","message":"Done","commit_id":"9eedeac0d270eec85ebe0821e675a7a085386184"},{"author":{"_account_id":20190,"name":"zhufl","email":"zhu.fanglei@zte.com.cn","username":"zhufl"},"change_message_id":"3d8f0828fec4640a3b0fe50b4e131a08da97e42b","unresolved":false,"context_lines":[{"line_number":3,"context_line":"  - |"},{"line_number":4,"context_line":"    A new config option \u0027manage_snapshot_ref\u0027 added in the volume section, to"},{"line_number":5,"context_line":"    specify snapshot ref paramter for different storage backend drivers when"},{"line_number":6,"context_line":"    managing a unmanaged snapshot. By default it is set to fit the LVM driver."}],"source_content_type":"text/x-yaml","patch_set":5,"id":"7f231b9d_986d7506","line":6,"range":{"start_line":6,"start_character":13,"end_line":6,"end_character":14},"updated":"2017-06-13 03:20:56.000000000","message":"an","commit_id":"9eedeac0d270eec85ebe0821e675a7a085386184"},{"author":{"_account_id":23081,"name":"Jeremy Zhang","email":"zhangjun_inspur@163.com","username":"jeremy.zhang"},"change_message_id":"55a0a93b7f78552ca68f22a3f1440ca6ede16d11","unresolved":false,"context_lines":[{"line_number":3,"context_line":"  - |"},{"line_number":4,"context_line":"    A new config option \u0027manage_snapshot_ref\u0027 added in the volume section, to"},{"line_number":5,"context_line":"    specify snapshot ref paramter for different storage backend drivers when"},{"line_number":6,"context_line":"    managing a unmanaged snapshot. By default it is set to fit the LVM driver."}],"source_content_type":"text/x-yaml","patch_set":5,"id":"7f231b9d_c57c21ed","line":6,"range":{"start_line":6,"start_character":13,"end_line":6,"end_character":14},"in_reply_to":"7f231b9d_986d7506","updated":"2017-06-13 04:34:51.000000000","message":"Done","commit_id":"9eedeac0d270eec85ebe0821e675a7a085386184"}],"tempest/api/volume/admin/test_snapshot_manage.py":[{"author":{"_account_id":7350,"name":"Jordan Pittier","email":"jordan.pittier@gmail.com","username":"JordanP"},"change_message_id":"2693423f5caf722dc17cec6a412f069981540006","unresolved":false,"context_lines":[{"line_number":42,"context_line":"                                    \"configured\")"},{"line_number":43,"context_line":""},{"line_number":44,"context_line":"    @decorators.idempotent_id(\u00270132f42d-0147-4b45-8501-cc504bbf7810\u0027)"},{"line_number":45,"context_line":"    def test_unmanage_manage_snapshot(self):"},{"line_number":46,"context_line":"        # Create a volume"},{"line_number":47,"context_line":"        volume \u003d self.create_volume()"},{"line_number":48,"context_line":""}],"source_content_type":"text/x-python","patch_set":2,"id":"7ffa3b31_0d5a48f2","line":45,"updated":"2017-04-17 16:24:43.000000000","message":"I am not sure we should make this test even more LVM-specific. Tempest should be backend/driver agnostic, so making this more LVM specific is not optimal imo. If anything, we should make this test more generic.","commit_id":"c182154250f16836e3e1e61f8e814234ff588689"},{"author":{"_account_id":6167,"name":"Ken\u0027ichi Ohmichi","email":"ken1ohmichi@gmail.com","username":"oomichi"},"change_message_id":"64223102bfc93c8460f1d75384baad70fb7762ec","unresolved":false,"context_lines":[{"line_number":66,"context_line":"            \u0027volume_id\u0027: volume[\u0027id\u0027],"},{"line_number":67,"context_line":"            \u0027ref\u0027: {CONF.volume.manage_snapshot_ref[0]:"},{"line_number":68,"context_line":"                    CONF.volume.manage_snapshot_ref[1] % snapshot[\u0027id\u0027]},"},{"line_number":69,"context_line":"            \u0027name\u0027: data_utils.rand_name(self.__class__.__name__"},{"line_number":70,"context_line":"                                         + \u0027-snapshot\u0027),"},{"line_number":71,"context_line":"            \u0027description\u0027: data_utils.rand_name(self.__class__.__name__"},{"line_number":72,"context_line":"                                                + \u0027-description\u0027),"},{"line_number":73,"context_line":"            \u0027metadata\u0027: {\u0027key1\u0027: \u0027value1\u0027}"},{"line_number":74,"context_line":"        }"},{"line_number":75,"context_line":"        new_snapshot \u003d self.admin_snapshot_manage_client.manage_snapshot("},{"line_number":76,"context_line":"            **new_snapshot_ref)[\u0027snapshot\u0027]"}],"source_content_type":"text/x-python","patch_set":3,"id":"df140735_638445b2","line":73,"range":{"start_line":69,"start_character":0,"end_line":73,"end_character":42},"updated":"2017-06-07 18:46:01.000000000","message":"Why should we add these parameters(name, description, metadata) into this? I guess it would be enough to make \"ref\" more generic with a new config for the purpose.","commit_id":"ddef2b9815d0f362ac8d9f8f407a07ba4bf6519a"},{"author":{"_account_id":6167,"name":"Ken\u0027ichi Ohmichi","email":"ken1ohmichi@gmail.com","username":"oomichi"},"change_message_id":"087ee4e8eb36b307fbf756d24a092e5f3f708cb1","unresolved":false,"context_lines":[{"line_number":66,"context_line":"            \u0027volume_id\u0027: volume[\u0027id\u0027],"},{"line_number":67,"context_line":"            \u0027ref\u0027: {CONF.volume.manage_snapshot_ref[0]:"},{"line_number":68,"context_line":"                    CONF.volume.manage_snapshot_ref[1] % snapshot[\u0027id\u0027]},"},{"line_number":69,"context_line":"            \u0027name\u0027: data_utils.rand_name(self.__class__.__name__"},{"line_number":70,"context_line":"                                         + \u0027-snapshot\u0027),"},{"line_number":71,"context_line":"            \u0027description\u0027: data_utils.rand_name(self.__class__.__name__"},{"line_number":72,"context_line":"                                                + \u0027-description\u0027),"},{"line_number":73,"context_line":"            \u0027metadata\u0027: {\u0027key1\u0027: \u0027value1\u0027}"},{"line_number":74,"context_line":"        }"},{"line_number":75,"context_line":"        new_snapshot \u003d self.admin_snapshot_manage_client.manage_snapshot("},{"line_number":76,"context_line":"            **new_snapshot_ref)[\u0027snapshot\u0027]"}],"source_content_type":"text/x-python","patch_set":3,"id":"7f231b9d_2ab647db","line":73,"range":{"start_line":69,"start_character":0,"end_line":73,"end_character":42},"in_reply_to":"bf091321_62458770","updated":"2017-06-09 18:20:35.000000000","message":"It would be better to propose another patch for different purpose which make the test rich.","commit_id":"ddef2b9815d0f362ac8d9f8f407a07ba4bf6519a"},{"author":{"_account_id":23081,"name":"Jeremy Zhang","email":"zhangjun_inspur@163.com","username":"jeremy.zhang"},"change_message_id":"5fd4f37fcb7f6a6551462c9f22173343b9384cae","unresolved":false,"context_lines":[{"line_number":66,"context_line":"            \u0027volume_id\u0027: volume[\u0027id\u0027],"},{"line_number":67,"context_line":"            \u0027ref\u0027: {CONF.volume.manage_snapshot_ref[0]:"},{"line_number":68,"context_line":"                    CONF.volume.manage_snapshot_ref[1] % snapshot[\u0027id\u0027]},"},{"line_number":69,"context_line":"            \u0027name\u0027: data_utils.rand_name(self.__class__.__name__"},{"line_number":70,"context_line":"                                         + \u0027-snapshot\u0027),"},{"line_number":71,"context_line":"            \u0027description\u0027: data_utils.rand_name(self.__class__.__name__"},{"line_number":72,"context_line":"                                                + \u0027-description\u0027),"},{"line_number":73,"context_line":"            \u0027metadata\u0027: {\u0027key1\u0027: \u0027value1\u0027}"},{"line_number":74,"context_line":"        }"},{"line_number":75,"context_line":"        new_snapshot \u003d self.admin_snapshot_manage_client.manage_snapshot("},{"line_number":76,"context_line":"            **new_snapshot_ref)[\u0027snapshot\u0027]"}],"source_content_type":"text/x-python","patch_set":3,"id":"bf091321_62458770","line":73,"range":{"start_line":69,"start_character":0,"end_line":73,"end_character":42},"in_reply_to":"df140735_638445b2","updated":"2017-06-08 01:09:00.000000000","message":"Hi, Ken\u0027ichi. \nHere just add some additional parameters for managing snapshot which will be checked. Indeed they\u0027re not mandatory for managing snapshot function, But I think it make sense and rich the test.\nLooking forward your suggestions.","commit_id":"ddef2b9815d0f362ac8d9f8f407a07ba4bf6519a"},{"author":{"_account_id":6167,"name":"Ken\u0027ichi Ohmichi","email":"ken1ohmichi@gmail.com","username":"oomichi"},"change_message_id":"64223102bfc93c8460f1d75384baad70fb7762ec","unresolved":false,"context_lines":[{"line_number":86,"context_line":"        new_snapshot_info \u003d self.admin_snapshots_client.show_snapshot("},{"line_number":87,"context_line":"            new_snapshot[\u0027id\u0027])[\u0027snapshot\u0027]"},{"line_number":88,"context_line":"        self.assertEqual(new_snapshot_info[\u0027size\u0027], snapshot[\u0027size\u0027])"},{"line_number":89,"context_line":"        for key in [\u0027volume_id\u0027, \u0027name\u0027, \u0027description\u0027, \u0027metadata\u0027]:"},{"line_number":90,"context_line":"            self.assertEqual(new_snapshot_info[key], new_snapshot_ref[key])"}],"source_content_type":"text/x-python","patch_set":3,"id":"df140735_e3c175e6","line":90,"range":{"start_line":89,"start_character":0,"end_line":90,"end_character":75},"updated":"2017-06-07 18:46:01.000000000","message":"I don\u0027t think this part is not a main purpose of this patch and here makes review a little hard..","commit_id":"ddef2b9815d0f362ac8d9f8f407a07ba4bf6519a"},{"author":{"_account_id":6167,"name":"Ken\u0027ichi Ohmichi","email":"ken1ohmichi@gmail.com","username":"oomichi"},"change_message_id":"087ee4e8eb36b307fbf756d24a092e5f3f708cb1","unresolved":false,"context_lines":[{"line_number":86,"context_line":"        new_snapshot_info \u003d self.admin_snapshots_client.show_snapshot("},{"line_number":87,"context_line":"            new_snapshot[\u0027id\u0027])[\u0027snapshot\u0027]"},{"line_number":88,"context_line":"        self.assertEqual(new_snapshot_info[\u0027size\u0027], snapshot[\u0027size\u0027])"},{"line_number":89,"context_line":"        for key in [\u0027volume_id\u0027, \u0027name\u0027, \u0027description\u0027, \u0027metadata\u0027]:"},{"line_number":90,"context_line":"            self.assertEqual(new_snapshot_info[key], new_snapshot_ref[key])"}],"source_content_type":"text/x-python","patch_set":3,"id":"7f231b9d_8adc3b19","line":90,"range":{"start_line":89,"start_character":0,"end_line":90,"end_character":75},"in_reply_to":"bf091321_9527b3b7","updated":"2017-06-09 18:20:35.000000000","message":"The same here. Better to propose another patch if necessary.","commit_id":"ddef2b9815d0f362ac8d9f8f407a07ba4bf6519a"},{"author":{"_account_id":23081,"name":"Jeremy Zhang","email":"zhangjun_inspur@163.com","username":"jeremy.zhang"},"change_message_id":"5fd4f37fcb7f6a6551462c9f22173343b9384cae","unresolved":false,"context_lines":[{"line_number":86,"context_line":"        new_snapshot_info \u003d self.admin_snapshots_client.show_snapshot("},{"line_number":87,"context_line":"            new_snapshot[\u0027id\u0027])[\u0027snapshot\u0027]"},{"line_number":88,"context_line":"        self.assertEqual(new_snapshot_info[\u0027size\u0027], snapshot[\u0027size\u0027])"},{"line_number":89,"context_line":"        for key in [\u0027volume_id\u0027, \u0027name\u0027, \u0027description\u0027, \u0027metadata\u0027]:"},{"line_number":90,"context_line":"            self.assertEqual(new_snapshot_info[key], new_snapshot_ref[key])"}],"source_content_type":"text/x-python","patch_set":3,"id":"bf091321_9527b3b7","line":90,"range":{"start_line":89,"start_character":0,"end_line":90,"end_character":75},"in_reply_to":"df140735_e3c175e6","updated":"2017-06-08 01:09:00.000000000","message":"Yeah, this is mainly to verify the additional parameters provided after managing snapshot. IMO, these assertions are clear and easy to understand.","commit_id":"ddef2b9815d0f362ac8d9f8f407a07ba4bf6519a"},{"author":{"_account_id":5689,"name":"Masayuki Igawa","email":"masayuki@igawa.io","username":"igawa"},"change_message_id":"e6cd7668cde1c19b9deaeeda4d1843d1d6f696c2","unresolved":false,"context_lines":[{"line_number":38,"context_line":"            raise cls.skipException(\"Manage snapshot tests are disabled\")"},{"line_number":39,"context_line":""},{"line_number":40,"context_line":"        if len(CONF.volume.manage_snapshot_ref) !\u003d 2:"},{"line_number":41,"context_line":"            raise cls.skipException(\"Manage snapshot ref is not correctly \""},{"line_number":42,"context_line":"                                    \"configured\")"},{"line_number":43,"context_line":""},{"line_number":44,"context_line":"    @decorators.idempotent_id(\u00270132f42d-0147-4b45-8501-cc504bbf7810\u0027)"}],"source_content_type":"text/x-python","patch_set":7,"id":"7f231b9d_49169ff3","line":41,"updated":"2017-06-15 03:33:00.000000000","message":"I think this case is a misconfiguration. So, it should be failed, IMO. skipExceptions tend to be ignored.","commit_id":"ebc752b59dd3e2164807930e31b313a92bce70d5"}]}