)]}'
{"/COMMIT_MSG":[{"author":{"_account_id":6873,"name":"Matt Riedemann","email":"mriedem.os@gmail.com","username":"mriedem"},"change_message_id":"ff27c34ef7bb185628b6cf2ff246d0d658b5b988","unresolved":false,"context_lines":[{"line_number":4,"context_line":"Commit:     Matthew Treinish \u003cmtreinish@kortar.org\u003e"},{"line_number":5,"context_line":"CommitDate: 2017-04-17 17:42:03 -0400"},{"line_number":6,"context_line":""},{"line_number":7,"context_line":"Ensure we delete sheleved image"},{"line_number":8,"context_line":""},{"line_number":9,"context_line":"When running test_shelved_unshelve_server() the server shelving"},{"line_number":10,"context_line":"operation creates an image, but we never ensure that image is cleaned up"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":1,"id":"7ffa3b31_3f9883be","line":7,"range":{"start_line":7,"start_character":17,"end_line":7,"end_character":25},"updated":"2017-04-17 21:56:46.000000000","message":"oh my","commit_id":"ed8e0da7054b24fda10c4b4e073b825647b43e31"}],"tempest/api/compute/servers/test_delete_server.py":[{"author":{"_account_id":6873,"name":"Matt Riedemann","email":"mriedem.os@gmail.com","username":"mriedem"},"change_message_id":"a6c42b62deb1a77377d8c9407dd4b6ee7c50ca53","unresolved":false,"context_lines":[{"line_number":87,"context_line":"        # Delete a server while it\u0027s VM state is Shelved"},{"line_number":88,"context_line":"        server \u003d self.create_test_server(wait_until\u003d\u0027ACTIVE\u0027)"},{"line_number":89,"context_line":"        compute.shelve_server(self.client, server[\u0027id\u0027])"},{"line_number":90,"context_line":"        image_name \u003d server[\u0027name\u0027] + \u0027-shelved\u0027"},{"line_number":91,"context_line":"        images \u003d self.compute_images_client.list_images({\u0027name\u0027: image_name)"},{"line_number":92,"context_line":"        self.images.append(images[0])"},{"line_number":93,"context_line":""}],"source_content_type":"text/x-python","patch_set":2,"id":"7ffa3b31_912aae29","line":90,"range":{"start_line":90,"start_character":21,"end_line":90,"end_character":48},"updated":"2017-04-19 14:32:19.000000000","message":"Eww, this is some gross tight coupling and making a contract of what nova internals are doing when creating the shelve snapshot image. There might be a better way to identify the image but I\u0027d have to look.","commit_id":"362562d1dbbb7dded2b4820624a8ca6e874073f6"},{"author":{"_account_id":5196,"name":"Matthew Treinish","email":"mtreinish@kortar.org","username":"treinish"},"change_message_id":"252a6008a50f15e983e723637a9e5ac9a1f28f56","unresolved":false,"context_lines":[{"line_number":87,"context_line":"        # Delete a server while it\u0027s VM state is Shelved"},{"line_number":88,"context_line":"        server \u003d self.create_test_server(wait_until\u003d\u0027ACTIVE\u0027)"},{"line_number":89,"context_line":"        compute.shelve_server(self.client, server[\u0027id\u0027])"},{"line_number":90,"context_line":"        image_name \u003d server[\u0027name\u0027] + \u0027-shelved\u0027"},{"line_number":91,"context_line":"        images \u003d self.compute_images_client.list_images({\u0027name\u0027: image_name)"},{"line_number":92,"context_line":"        self.images.append(images[0])"},{"line_number":93,"context_line":""}],"source_content_type":"text/x-python","patch_set":2,"id":"7ffa3b31_f18b321c","line":90,"range":{"start_line":90,"start_character":21,"end_line":90,"end_character":48},"in_reply_to":"7ffa3b31_912aae29","updated":"2017-04-19 14:36:04.000000000","message":"yeah, I couldn\u0027t think of a better way. Fwiw, tempest is enforcing this as a contract already:\n\nhttps://github.com/openstack/tempest/blob/master/tempest/api/compute/servers/test_server_actions.py#L516-L528","commit_id":"362562d1dbbb7dded2b4820624a8ca6e874073f6"},{"author":{"_account_id":20190,"name":"zhufl","email":"zhu.fanglei@zte.com.cn","username":"zhufl"},"change_message_id":"78e6bc6f496d9601d109a9bbb246a3e8a5740fb9","unresolved":false,"context_lines":[{"line_number":88,"context_line":"        server \u003d self.create_test_server(wait_until\u003d\u0027ACTIVE\u0027)"},{"line_number":89,"context_line":"        compute.shelve_server(self.client, server[\u0027id\u0027])"},{"line_number":90,"context_line":"        image_name \u003d server[\u0027name\u0027] + \u0027-shelved\u0027"},{"line_number":91,"context_line":"        images \u003d self.compute_images_client.list_images({\u0027name\u0027: image_name)"},{"line_number":92,"context_line":"        self.images.append(images[0])"},{"line_number":93,"context_line":""},{"line_number":94,"context_line":"        self.client.delete_server(server[\u0027id\u0027])"}],"source_content_type":"text/x-python","patch_set":2,"id":"7faddb67_25ffac02","line":91,"range":{"start_line":91,"start_character":75,"end_line":91,"end_character":76},"updated":"2019-08-21 00:38:57.000000000","message":"\"}\" is missing here.","commit_id":"362562d1dbbb7dded2b4820624a8ca6e874073f6"}],"tempest/api/compute/servers/test_server_actions.py":[{"author":{"_account_id":6873,"name":"Matt Riedemann","email":"mriedem.os@gmail.com","username":"mriedem"},"change_message_id":"ff27c34ef7bb185628b6cf2ff246d0d658b5b988","unresolved":false,"context_lines":[{"line_number":523,"context_line":"        images \u003d self.compute_images_client.list_images(**params)[\u0027images\u0027]"},{"line_number":524,"context_line":"        self.assertEqual(1, len(images))"},{"line_number":525,"context_line":"        self.assertEqual(image_name, images[0][\u0027name\u0027])"},{"line_number":526,"context_line":"        self.images.append(images[0][\u0027id\u0027])"},{"line_number":527,"context_line":""},{"line_number":528,"context_line":"        self.client.unshelve_server(self.server_id)"},{"line_number":529,"context_line":"        waiters.wait_for_server_status(self.client, self.server_id, \u0027ACTIVE\u0027)"}],"source_content_type":"text/x-python","patch_set":1,"id":"7ffa3b31_1f9387a5","line":526,"updated":"2017-04-17 21:56:46.000000000","message":"Unshelve should delete the snapshot image:\n\nhttps://github.com/openstack/nova/blob/master/nova/compute/manager.py#L4498\n\nIf it\u0027s not, that might be a bug.","commit_id":"ed8e0da7054b24fda10c4b4e073b825647b43e31"}]}