)]}'
{"tempest/test.py":[{"author":{"_account_id":1921,"name":"Andrea Frittoli","email":"andrea.frittoli@gmail.com","username":"andrea-frittoli"},"change_message_id":"c84e43ff6fe619138d79f8875e7ec09debd7f1a2","unresolved":false,"context_lines":[{"line_number":329,"context_line":"                manager \u003d cls.get_client_manager("},{"line_number":330,"context_line":"                    credential_type\u003dcredentials_type)"},{"line_number":331,"context_line":"                setattr(cls, \u0027os_%s\u0027 % credentials_type, manager)"},{"line_number":332,"context_line":"                # NOTE(jordanP): Tempest should use os_primary, os_admin"},{"line_number":333,"context_line":"                # and os_alt throughout its code base but we keep the aliases"},{"line_number":334,"context_line":"                # around for a while for Tempest plugins. Aliases should be"},{"line_number":335,"context_line":"                # removed eventually."}],"source_content_type":"text/x-python","patch_set":4,"id":"7ffa3b31_19500ad4","line":332,"range":{"start_line":332,"start_character":52,"end_line":332,"end_character":62},"updated":"2017-04-19 13:19:50.000000000","message":"While I like this as it\u0027s more consistent, I wonder if we should use cls.os which is widely used and known, to reduce the size of the change.","commit_id":"bf00cc2be79cc14699d249eea0e6f6a32d9fe966"},{"author":{"_account_id":7350,"name":"Jordan Pittier","email":"jordan.pittier@gmail.com","username":"JordanP"},"change_message_id":"edf269f04b11ce5d4f05aef4ab83cf216bcb2265","unresolved":false,"context_lines":[{"line_number":329,"context_line":"                manager \u003d cls.get_client_manager("},{"line_number":330,"context_line":"                    credential_type\u003dcredentials_type)"},{"line_number":331,"context_line":"                setattr(cls, \u0027os_%s\u0027 % credentials_type, manager)"},{"line_number":332,"context_line":"                # NOTE(jordanP): Tempest should use os_primary, os_admin"},{"line_number":333,"context_line":"                # and os_alt throughout its code base but we keep the aliases"},{"line_number":334,"context_line":"                # around for a while for Tempest plugins. Aliases should be"},{"line_number":335,"context_line":"                # removed eventually."}],"source_content_type":"text/x-python","patch_set":4,"id":"7ffa3b31_5920d2b0","line":332,"range":{"start_line":332,"start_character":52,"end_line":332,"end_character":62},"in_reply_to":"7ffa3b31_19500ad4","updated":"2017-04-19 13:52:22.000000000","message":"cls.os doesn\u0027t have a lot of meaning. os is for openstack ? \n\nThis change is big, but easy to review, all I did was a couple of sed commands.","commit_id":"bf00cc2be79cc14699d249eea0e6f6a32d9fe966"}]}
