)]}'
{"tempest/test.py":[{"author":{"_account_id":6796,"name":"Giulio Fidente","email":"gfidente@redhat.com","username":"gfidente"},"change_message_id":"7fd7987e3e8672310422b267caa822c8dab81400","unresolved":false,"context_lines":[{"line_number":70,"context_line":"    def decorator(f):"},{"line_number":71,"context_line":"        for service in args:"},{"line_number":72,"context_line":"            if service in valid_service_list:"},{"line_number":73,"context_line":"                attr(type\u003dservice)(f)"},{"line_number":74,"context_line":"                return f"},{"line_number":75,"context_line":"            else:"},{"line_number":76,"context_line":"                raise exceptions.InvalidServiceTag(\u0027%s is not a valid service\u0027"}],"source_content_type":"text/x-python","patch_set":1,"id":"AAAASn%2F%2FNRM%3D","line":73,"updated":"2013-09-10 00:06:38.000000000","message":"given that you\u0027re in a for loop and attr supports lists, wouldn\u0027t it be safer to build the list of services in the if statement and run attr() only once, at the end of the loop?","commit_id":"0b9a5eca52b3eb88ac3ed566ab4eb2f478225986"},{"author":{"_account_id":5196,"name":"Matthew Treinish","email":"mtreinish@kortar.org","username":"treinish"},"change_message_id":"e87ce4d2649db6c62e64bc8261ec4f47b73648e5","unresolved":false,"context_lines":[{"line_number":70,"context_line":"    def decorator(f):"},{"line_number":71,"context_line":"        for service in args:"},{"line_number":72,"context_line":"            if service in valid_service_list:"},{"line_number":73,"context_line":"                attr(type\u003dservice)(f)"},{"line_number":74,"context_line":"                return f"},{"line_number":75,"context_line":"            else:"},{"line_number":76,"context_line":"                raise exceptions.InvalidServiceTag(\u0027%s is not a valid service\u0027"}],"source_content_type":"text/x-python","patch_set":1,"id":"AAAASn%2F%2FLi4%3D","line":73,"in_reply_to":"AAAASn%2F%2FNRM%3D","updated":"2013-09-10 14:34:22.000000000","message":"Done","commit_id":"0b9a5eca52b3eb88ac3ed566ab4eb2f478225986"}]}