)]}'
{"tempest/api/compute/volumes/test_attach_volume.py":[{"author":{"_account_id":8556,"name":"Ghanshyam Maan","display_name":"Ghanshyam Maan","email":"gmaan.os14@gmail.com","username":"ghanshyam"},"change_message_id":"02dfa93902c5582671fcd632c01e6c23d3ca1204","unresolved":false,"context_lines":[{"line_number":45,"context_line":"        cls.set_validation_resources()"},{"line_number":46,"context_line":"        super(AttachVolumeTestJSON, cls).resource_setup()"},{"line_number":47,"context_line":"        cls.device \u003d CONF.compute.volume_device_name"},{"line_number":48,"context_line":"        cls.server \u003d cls._create_server()"},{"line_number":49,"context_line":""},{"line_number":50,"context_line":"    @classmethod"},{"line_number":51,"context_line":"    def _create_server(cls):"}],"source_content_type":"text/x-python","patch_set":5,"id":"5ff73747_4a363005","line":48,"range":{"start_line":48,"start_character":0,"end_line":48,"end_character":41},"updated":"2017-05-02 10:10:49.000000000","message":"if we are making this as common server used in all tests, we should make sure this server is good state before any test start.\n\nTest case does lot of start stop operation on this server and it may be cases where test leave this server in bad state when any unexpected failure occur.\nIn that case next test also fail and hard to debug the failure.\n\nthere are 2 options.\n1. make sure the server state is active or rebuild if not in setUp. like done in https://github.com/openstack/tempest/blob/5fc2548eae225ebe84ab378a6136f1be9cb8b443/tempest/api/compute/servers/test_server_actions.py#L38\n\n2. in original code, just delete the server with addCleanup in _create_server() method.","commit_id":"9ce843253bed545f46bcfac06fd30dad85233952"},{"author":{"_account_id":8556,"name":"Ghanshyam Maan","display_name":"Ghanshyam Maan","email":"gmaan.os14@gmail.com","username":"ghanshyam"},"change_message_id":"dfc6283f31d93a7ba7d10f5d9e3fb366466f4245","unresolved":false,"context_lines":[{"line_number":109,"context_line":"            disks \u003d linux_client.get_disks()"},{"line_number":110,"context_line":"            self.assertNotIn(device_name_to_match, disks)"},{"line_number":111,"context_line":""},{"line_number":112,"context_line":"        self.client.delete_server(server[\u0027id\u0027])"},{"line_number":113,"context_line":"        waiters.wait_for_server_termination(self.client, server[\u0027id\u0027])"},{"line_number":114,"context_line":""},{"line_number":115,"context_line":"    @decorators.idempotent_id(\u00277fa563fe-f0f7-43eb-9e22-a1ece036b513\u0027)"},{"line_number":116,"context_line":"    def test_list_get_volume_attachments(self):"}],"source_content_type":"text/x-python","patch_set":6,"id":"5ff73747_65011f05","line":113,"range":{"start_line":112,"start_character":0,"end_line":113,"end_character":70},"updated":"2017-05-02 10:12:01.000000000","message":"i recommend options 2 in comment in PS5. delete server using addCleanup in _create_server() method","commit_id":"879ab74cec038abca63d27f58d333d2648949acf"},{"author":{"_account_id":15888,"name":"Zhenyu Zheng","email":"zheng.zhenyu@outlook.com","username":"Kevin_Zheng"},"change_message_id":"067f944928c3ad07e0277c9e36a96636340c4266","unresolved":false,"context_lines":[{"line_number":109,"context_line":"            disks \u003d linux_client.get_disks()"},{"line_number":110,"context_line":"            self.assertNotIn(device_name_to_match, disks)"},{"line_number":111,"context_line":""},{"line_number":112,"context_line":"        self.client.delete_server(server[\u0027id\u0027])"},{"line_number":113,"context_line":"        waiters.wait_for_server_termination(self.client, server[\u0027id\u0027])"},{"line_number":114,"context_line":""},{"line_number":115,"context_line":"    @decorators.idempotent_id(\u00277fa563fe-f0f7-43eb-9e22-a1ece036b513\u0027)"},{"line_number":116,"context_line":"    def test_list_get_volume_attachments(self):"}],"source_content_type":"text/x-python","patch_set":6,"id":"5ff73747_e3d526b9","line":113,"range":{"start_line":112,"start_character":0,"end_line":113,"end_character":70},"in_reply_to":"5ff73747_65011f05","updated":"2017-05-02 12:21:03.000000000","message":"Done","commit_id":"879ab74cec038abca63d27f58d333d2648949acf"},{"author":{"_account_id":8556,"name":"Ghanshyam Maan","display_name":"Ghanshyam Maan","email":"gmaan.os14@gmail.com","username":"ghanshyam"},"change_message_id":"8603cdb4c06d424f95123e713a93cff11d06cd2a","unresolved":false,"context_lines":[{"line_number":55,"context_line":"        # Record addresses so that we can ssh later"},{"line_number":56,"context_line":"        server[\u0027addresses\u0027] \u003d self.servers_client.list_addresses("},{"line_number":57,"context_line":"            server[\u0027id\u0027])[\u0027addresses\u0027]"},{"line_number":58,"context_line":"        self.addCleanup(self.delete_server, server[\u0027id\u0027])"},{"line_number":59,"context_line":"        return server"},{"line_number":60,"context_line":""},{"line_number":61,"context_line":"    @decorators.idempotent_id(\u002752e9045a-e90d-4c0d-9087-79d657faffff\u0027)"}],"source_content_type":"text/x-python","patch_set":7,"id":"1f013ff3_b9801d8d","line":58,"range":{"start_line":58,"start_character":0,"end_line":58,"end_character":57},"updated":"2017-05-17 02:16:04.000000000","message":"can you move this before list servers. before L55","commit_id":"4d0a7c7198f4c6c2061c1a8d54fb7eb0ec2bb9aa"},{"author":{"_account_id":15888,"name":"Zhenyu Zheng","email":"zheng.zhenyu@outlook.com","username":"Kevin_Zheng"},"change_message_id":"b126cadb22dc2ec1b0f415ea416f41b308862e72","unresolved":false,"context_lines":[{"line_number":55,"context_line":"        # Record addresses so that we can ssh later"},{"line_number":56,"context_line":"        server[\u0027addresses\u0027] \u003d self.servers_client.list_addresses("},{"line_number":57,"context_line":"            server[\u0027id\u0027])[\u0027addresses\u0027]"},{"line_number":58,"context_line":"        self.addCleanup(self.delete_server, server[\u0027id\u0027])"},{"line_number":59,"context_line":"        return server"},{"line_number":60,"context_line":""},{"line_number":61,"context_line":"    @decorators.idempotent_id(\u002752e9045a-e90d-4c0d-9087-79d657faffff\u0027)"}],"source_content_type":"text/x-python","patch_set":7,"id":"1f013ff3_623bf9ea","line":58,"range":{"start_line":58,"start_character":0,"end_line":58,"end_character":57},"in_reply_to":"1f013ff3_b9801d8d","updated":"2017-05-17 07:08:31.000000000","message":"Done","commit_id":"4d0a7c7198f4c6c2061c1a8d54fb7eb0ec2bb9aa"}]}