)]}'
{"tempest/api/identity/admin/v3/test_endpoint_groups.py":[{"author":{"_account_id":20190,"name":"zhufl","email":"zhu.fanglei@zte.com.cn","username":"zhufl"},"change_message_id":"c71c9acf5c4f452b99f04ef5e18c2f8112ebb2d1","unresolved":false,"context_lines":[{"line_number":38,"context_line":"                                               description\u003ds_description))\r"},{"line_number":39,"context_line":"        cls.service_id \u003d service_data[\u0027service\u0027][\u0027id\u0027]\r"},{"line_number":40,"context_line":"        cls.service_ids.append(cls.service_id)\r"},{"line_number":41,"context_line":"        # Create endpoints so as to use for LIST and GET test cases\r"},{"line_number":42,"context_line":"        cls.setup_endpoint_groups \u003d list()\r"},{"line_number":43,"context_line":"        name \u003d data_utils.rand_name(\u0027service_group\u0027)\r"},{"line_number":44,"context_line":"        description \u003d data_utils.rand_name(\u0027description\u0027)\r"}],"source_content_type":"text/x-python","patch_set":2,"id":"3f044301_5497e291","line":41,"range":{"start_line":41,"start_character":17,"end_line":41,"end_character":26},"updated":"2017-05-04 09:24:33.000000000","message":"endpoint group","commit_id":"c76b4403ce9003c47cecc24255a432f1319ab24f"},{"author":{"_account_id":19391,"name":"Chi Lo","email":"cl566n@att.com","username":"cl566n"},"change_message_id":"d912b787eb13bd531ee14b0a93136a1285d40eb9","unresolved":false,"context_lines":[{"line_number":38,"context_line":"                                               description\u003ds_description))\r"},{"line_number":39,"context_line":"        cls.service_id \u003d service_data[\u0027service\u0027][\u0027id\u0027]\r"},{"line_number":40,"context_line":"        cls.service_ids.append(cls.service_id)\r"},{"line_number":41,"context_line":"        # Create endpoints so as to use for LIST and GET test cases\r"},{"line_number":42,"context_line":"        cls.setup_endpoint_groups \u003d list()\r"},{"line_number":43,"context_line":"        name \u003d data_utils.rand_name(\u0027service_group\u0027)\r"},{"line_number":44,"context_line":"        description \u003d data_utils.rand_name(\u0027description\u0027)\r"}],"source_content_type":"text/x-python","patch_set":2,"id":"3f044301_ffefdead","line":41,"range":{"start_line":41,"start_character":17,"end_line":41,"end_character":26},"in_reply_to":"3f044301_5497e291","updated":"2017-05-04 16:21:14.000000000","message":"Will fix.","commit_id":"c76b4403ce9003c47cecc24255a432f1319ab24f"},{"author":{"_account_id":20190,"name":"zhufl","email":"zhu.fanglei@zte.com.cn","username":"zhufl"},"change_message_id":"c71c9acf5c4f452b99f04ef5e18c2f8112ebb2d1","unresolved":false,"context_lines":[{"line_number":65,"context_line":"\r"},{"line_number":66,"context_line":"        # Asserting LIST endpoints\r"},{"line_number":67,"context_line":"        missing_endpoints \u003d \\\r"},{"line_number":68,"context_line":"            [e for e in self.setup_endpoint_groups\r"},{"line_number":69,"context_line":"             if e[\u0027endpoint_group\u0027] not in fetched_endpoints]\r"},{"line_number":70,"context_line":"\r"},{"line_number":71,"context_line":"        self.assertEqual(0, len(missing_endpoints),\r"}],"source_content_type":"text/x-python","patch_set":2,"id":"3f044301_34f576cc","line":68,"range":{"start_line":68,"start_character":24,"end_line":68,"end_character":50},"updated":"2017-05-04 09:24:33.000000000","message":"only one item in the list, maybe at least two items is better","commit_id":"c76b4403ce9003c47cecc24255a432f1319ab24f"},{"author":{"_account_id":19391,"name":"Chi Lo","email":"cl566n@att.com","username":"cl566n"},"change_message_id":"641798a97d318c56253f0fb2d57492f1142193e9","unresolved":false,"context_lines":[{"line_number":65,"context_line":"\r"},{"line_number":66,"context_line":"        # Asserting LIST endpoints\r"},{"line_number":67,"context_line":"        missing_endpoints \u003d \\\r"},{"line_number":68,"context_line":"            [e for e in self.setup_endpoint_groups\r"},{"line_number":69,"context_line":"             if e[\u0027endpoint_group\u0027] not in fetched_endpoints]\r"},{"line_number":70,"context_line":"\r"},{"line_number":71,"context_line":"        self.assertEqual(0, len(missing_endpoints),\r"}],"source_content_type":"text/x-python","patch_set":2,"id":"3f044301_da2669b8","line":68,"range":{"start_line":68,"start_character":24,"end_line":68,"end_character":50},"in_reply_to":"3f044301_34f576cc","updated":"2017-05-04 18:49:48.000000000","message":"Will add 2 items in the setup.","commit_id":"c76b4403ce9003c47cecc24255a432f1319ab24f"},{"author":{"_account_id":20190,"name":"zhufl","email":"zhu.fanglei@zte.com.cn","username":"zhufl"},"change_message_id":"c71c9acf5c4f452b99f04ef5e18c2f8112ebb2d1","unresolved":false,"context_lines":[{"line_number":68,"context_line":"            [e for e in self.setup_endpoint_groups\r"},{"line_number":69,"context_line":"             if e[\u0027endpoint_group\u0027] not in fetched_endpoints]\r"},{"line_number":70,"context_line":"\r"},{"line_number":71,"context_line":"        self.assertEqual(0, len(missing_endpoints),\r"},{"line_number":72,"context_line":"                         \"Failed to find endpoint %s in fetched list\" %\r"},{"line_number":73,"context_line":"                         \u0027, \u0027.join(str(e) for e in missing_endpoints))\r"},{"line_number":74,"context_line":"\r"}],"source_content_type":"text/x-python","patch_set":2,"id":"3f044301_51b1348f","line":71,"range":{"start_line":71,"start_character":13,"end_line":71,"end_character":24},"updated":"2017-05-04 09:24:33.000000000","message":"assertEmpty","commit_id":"c76b4403ce9003c47cecc24255a432f1319ab24f"},{"author":{"_account_id":19391,"name":"Chi Lo","email":"cl566n@att.com","username":"cl566n"},"change_message_id":"641798a97d318c56253f0fb2d57492f1142193e9","unresolved":false,"context_lines":[{"line_number":68,"context_line":"            [e for e in self.setup_endpoint_groups\r"},{"line_number":69,"context_line":"             if e[\u0027endpoint_group\u0027] not in fetched_endpoints]\r"},{"line_number":70,"context_line":"\r"},{"line_number":71,"context_line":"        self.assertEqual(0, len(missing_endpoints),\r"},{"line_number":72,"context_line":"                         \"Failed to find endpoint %s in fetched list\" %\r"},{"line_number":73,"context_line":"                         \u0027, \u0027.join(str(e) for e in missing_endpoints))\r"},{"line_number":74,"context_line":"\r"}],"source_content_type":"text/x-python","patch_set":2,"id":"3f044301_ba55dd52","line":71,"range":{"start_line":71,"start_character":13,"end_line":71,"end_character":24},"in_reply_to":"3f044301_51b1348f","updated":"2017-05-04 18:49:48.000000000","message":"Will fix","commit_id":"c76b4403ce9003c47cecc24255a432f1319ab24f"},{"author":{"_account_id":20190,"name":"zhufl","email":"zhu.fanglei@zte.com.cn","username":"zhufl"},"change_message_id":"c71c9acf5c4f452b99f04ef5e18c2f8112ebb2d1","unresolved":false,"context_lines":[{"line_number":82,"context_line":"        endpoint_group_tuple \u003d self.client.create_endpoint_group(\r"},{"line_number":83,"context_line":"            name\u003dname,\r"},{"line_number":84,"context_line":"            description\u003ddescription,\r"},{"line_number":85,"context_line":"            filters\u003dfilters)\r"},{"line_number":86,"context_line":"\r"},{"line_number":87,"context_line":"        self.setup_endpoint_groups.append(endpoint_group_tuple)\r"},{"line_number":88,"context_line":"        endpoint_group \u003d endpoint_group_tuple[\u0027endpoint_group\u0027]\r"}],"source_content_type":"text/x-python","patch_set":2,"id":"3f044301_315c684a","line":85,"range":{"start_line":85,"start_character":12,"end_line":85,"end_character":27},"updated":"2017-05-04 09:24:33.000000000","message":"maybe to put it directly will look clearer:\n    filters\u003d{\u0027service_id\u0027: self.service_id}","commit_id":"c76b4403ce9003c47cecc24255a432f1319ab24f"},{"author":{"_account_id":19391,"name":"Chi Lo","email":"cl566n@att.com","username":"cl566n"},"change_message_id":"d912b787eb13bd531ee14b0a93136a1285d40eb9","unresolved":false,"context_lines":[{"line_number":82,"context_line":"        endpoint_group_tuple \u003d self.client.create_endpoint_group(\r"},{"line_number":83,"context_line":"            name\u003dname,\r"},{"line_number":84,"context_line":"            description\u003ddescription,\r"},{"line_number":85,"context_line":"            filters\u003dfilters)\r"},{"line_number":86,"context_line":"\r"},{"line_number":87,"context_line":"        self.setup_endpoint_groups.append(endpoint_group_tuple)\r"},{"line_number":88,"context_line":"        endpoint_group \u003d endpoint_group_tuple[\u0027endpoint_group\u0027]\r"}],"source_content_type":"text/x-python","patch_set":2,"id":"3f044301_1a35f8da","line":85,"range":{"start_line":85,"start_character":12,"end_line":85,"end_character":27},"in_reply_to":"3f044301_315c684a","updated":"2017-05-04 16:21:14.000000000","message":"I will leave this line like this.  It is more consistent with the parameter assignment.  But I will remove filter_key, filter_value.","commit_id":"c76b4403ce9003c47cecc24255a432f1319ab24f"},{"author":{"_account_id":20190,"name":"zhufl","email":"zhu.fanglei@zte.com.cn","username":"zhufl"},"change_message_id":"c71c9acf5c4f452b99f04ef5e18c2f8112ebb2d1","unresolved":false,"context_lines":[{"line_number":122,"context_line":"        # with new values\r"},{"line_number":123,"context_line":"        name \u003d data_utils.rand_name(\u0027service_group\u0027)\r"},{"line_number":124,"context_line":"        description \u003d data_utils.rand_name(\u0027description\u0027)\r"},{"line_number":125,"context_line":"        filter_key \u003d \u0027service_id\u0027\r"},{"line_number":126,"context_line":"        filter_value \u003d self.service_id\r"},{"line_number":127,"context_line":"        filters \u003d {filter_key: filter_value}\r"},{"line_number":128,"context_line":"        endpoint_group \u003d self.client.create_endpoint_group(\r"}],"source_content_type":"text/x-python","patch_set":2,"id":"3f044301_f4182e76","line":125,"range":{"start_line":125,"start_character":8,"end_line":125,"end_character":18},"updated":"2017-05-04 09:24:33.000000000","message":"this variable seems not necessary","commit_id":"c76b4403ce9003c47cecc24255a432f1319ab24f"},{"author":{"_account_id":19391,"name":"Chi Lo","email":"cl566n@att.com","username":"cl566n"},"change_message_id":"d912b787eb13bd531ee14b0a93136a1285d40eb9","unresolved":false,"context_lines":[{"line_number":122,"context_line":"        # with new values\r"},{"line_number":123,"context_line":"        name \u003d data_utils.rand_name(\u0027service_group\u0027)\r"},{"line_number":124,"context_line":"        description \u003d data_utils.rand_name(\u0027description\u0027)\r"},{"line_number":125,"context_line":"        filter_key \u003d \u0027service_id\u0027\r"},{"line_number":126,"context_line":"        filter_value \u003d self.service_id\r"},{"line_number":127,"context_line":"        filters \u003d {filter_key: filter_value}\r"},{"line_number":128,"context_line":"        endpoint_group \u003d self.client.create_endpoint_group(\r"}],"source_content_type":"text/x-python","patch_set":2,"id":"3f044301_da5f90e3","line":125,"range":{"start_line":125,"start_character":8,"end_line":125,"end_character":18},"in_reply_to":"3f044301_f4182e76","updated":"2017-05-04 16:21:14.000000000","message":"Will fix.","commit_id":"c76b4403ce9003c47cecc24255a432f1319ab24f"},{"author":{"_account_id":20190,"name":"zhufl","email":"zhu.fanglei@zte.com.cn","username":"zhufl"},"change_message_id":"c71c9acf5c4f452b99f04ef5e18c2f8112ebb2d1","unresolved":false,"context_lines":[{"line_number":145,"context_line":"        # Updating endpoint with new values\r"},{"line_number":146,"context_line":"        name2 \u003d data_utils.rand_name(\u0027service_group2\u0027)\r"},{"line_number":147,"context_line":"        description2 \u003d data_utils.rand_name(\u0027description2\u0027)\r"},{"line_number":148,"context_line":"        filter_key \u003d \u0027service_id\u0027\r"},{"line_number":149,"context_line":"        filter_value \u003d service2[\u0027id\u0027]\r"},{"line_number":150,"context_line":"        filters \u003d {filter_key: filter_value}\r"},{"line_number":151,"context_line":"        updated_endpoint_group \u003d self.client.update_endpoint_group(\r"}],"source_content_type":"text/x-python","patch_set":2,"id":"3f044301_9421eaa2","line":148,"range":{"start_line":148,"start_character":8,"end_line":148,"end_character":18},"updated":"2017-05-04 09:24:33.000000000","message":"ditto","commit_id":"c76b4403ce9003c47cecc24255a432f1319ab24f"},{"author":{"_account_id":19391,"name":"Chi Lo","email":"cl566n@att.com","username":"cl566n"},"change_message_id":"d912b787eb13bd531ee14b0a93136a1285d40eb9","unresolved":false,"context_lines":[{"line_number":145,"context_line":"        # Updating endpoint with new values\r"},{"line_number":146,"context_line":"        name2 \u003d data_utils.rand_name(\u0027service_group2\u0027)\r"},{"line_number":147,"context_line":"        description2 \u003d data_utils.rand_name(\u0027description2\u0027)\r"},{"line_number":148,"context_line":"        filter_key \u003d \u0027service_id\u0027\r"},{"line_number":149,"context_line":"        filter_value \u003d service2[\u0027id\u0027]\r"},{"line_number":150,"context_line":"        filters \u003d {filter_key: filter_value}\r"},{"line_number":151,"context_line":"        updated_endpoint_group \u003d self.client.update_endpoint_group(\r"}],"source_content_type":"text/x-python","patch_set":2,"id":"3f044301_ba64c4ba","line":148,"range":{"start_line":148,"start_character":8,"end_line":148,"end_character":18},"in_reply_to":"3f044301_9421eaa2","updated":"2017-05-04 16:21:14.000000000","message":"Will fix.","commit_id":"c76b4403ce9003c47cecc24255a432f1319ab24f"},{"author":{"_account_id":20190,"name":"zhufl","email":"zhu.fanglei@zte.com.cn","username":"zhufl"},"change_message_id":"c71c9acf5c4f452b99f04ef5e18c2f8112ebb2d1","unresolved":false,"context_lines":[{"line_number":153,"context_line":"            name\u003dname2,\r"},{"line_number":154,"context_line":"            description\u003ddescription2,\r"},{"line_number":155,"context_line":"            filters\u003dfilters)[\u0027endpoint_group\u0027]\r"},{"line_number":156,"context_line":"\r"},{"line_number":157,"context_line":"        # Asserting if the attributes of endpoint are updated\r"},{"line_number":158,"context_line":"        self.assertEqual(name2, updated_endpoint_group[\u0027name\u0027])\r"},{"line_number":159,"context_line":"        self.assertEqual(description2, updated_endpoint_group[\u0027description\u0027])\r"}],"source_content_type":"text/x-python","patch_set":2,"id":"3f044301_d475329a","line":156,"updated":"2017-05-04 09:24:33.000000000","message":"better call show_endpoint_group before assert checks","commit_id":"c76b4403ce9003c47cecc24255a432f1319ab24f"},{"author":{"_account_id":19391,"name":"Chi Lo","email":"cl566n@att.com","username":"cl566n"},"change_message_id":"d912b787eb13bd531ee14b0a93136a1285d40eb9","unresolved":false,"context_lines":[{"line_number":153,"context_line":"            name\u003dname2,\r"},{"line_number":154,"context_line":"            description\u003ddescription2,\r"},{"line_number":155,"context_line":"            filters\u003dfilters)[\u0027endpoint_group\u0027]\r"},{"line_number":156,"context_line":"\r"},{"line_number":157,"context_line":"        # Asserting if the attributes of endpoint are updated\r"},{"line_number":158,"context_line":"        self.assertEqual(name2, updated_endpoint_group[\u0027name\u0027])\r"},{"line_number":159,"context_line":"        self.assertEqual(description2, updated_endpoint_group[\u0027description\u0027])\r"}],"source_content_type":"text/x-python","patch_set":2,"id":"3f044301_5a6ca035","line":156,"in_reply_to":"3f044301_d475329a","updated":"2017-05-04 16:21:14.000000000","message":"Will fix","commit_id":"c76b4403ce9003c47cecc24255a432f1319ab24f"},{"author":{"_account_id":20190,"name":"zhufl","email":"zhu.fanglei@zte.com.cn","username":"zhufl"},"change_message_id":"c041d2b9d5c091ec61201f05086687403eec57c8","unresolved":false,"context_lines":[{"line_number":31,"context_line":"        super(EndPointGroupsTestJSON, cls).resource_setup()"},{"line_number":32,"context_line":"        cls.service_ids \u003d list()"},{"line_number":33,"context_line":"        # Create endpoint groups so as to use for LIST and GET test cases"},{"line_number":34,"context_line":"        cls.setup_endpoint_groups \u003d list()"},{"line_number":35,"context_line":"        for _ in range(2):"},{"line_number":36,"context_line":"            s_name \u003d data_utils.rand_name(\u0027service\u0027)"},{"line_number":37,"context_line":"            s_type \u003d data_utils.rand_name(\u0027type\u0027)"}],"source_content_type":"text/x-python","patch_set":5,"id":"df140735_b63166a5","line":34,"range":{"start_line":34,"start_character":12,"end_line":34,"end_character":33},"updated":"2017-06-01 00:42:47.000000000","message":"will it be better to name cls.endpoint_groups?","commit_id":"ebc44763b437876615156395c583754decda5331"},{"author":{"_account_id":19391,"name":"Chi Lo","email":"cl566n@att.com","username":"cl566n"},"change_message_id":"106089b8f4c17ee53702a19ac772b3d23c1d1e1b","unresolved":false,"context_lines":[{"line_number":31,"context_line":"        super(EndPointGroupsTestJSON, cls).resource_setup()"},{"line_number":32,"context_line":"        cls.service_ids \u003d list()"},{"line_number":33,"context_line":"        # Create endpoint groups so as to use for LIST and GET test cases"},{"line_number":34,"context_line":"        cls.setup_endpoint_groups \u003d list()"},{"line_number":35,"context_line":"        for _ in range(2):"},{"line_number":36,"context_line":"            s_name \u003d data_utils.rand_name(\u0027service\u0027)"},{"line_number":37,"context_line":"            s_type \u003d data_utils.rand_name(\u0027type\u0027)"}],"source_content_type":"text/x-python","patch_set":5,"id":"df140735_cdd1b2cf","line":34,"range":{"start_line":34,"start_character":12,"end_line":34,"end_character":33},"in_reply_to":"df140735_b63166a5","updated":"2017-06-01 15:36:08.000000000","message":"Fixed.","commit_id":"ebc44763b437876615156395c583754decda5331"},{"author":{"_account_id":20190,"name":"zhufl","email":"zhu.fanglei@zte.com.cn","username":"zhufl"},"change_message_id":"c041d2b9d5c091ec61201f05086687403eec57c8","unresolved":false,"context_lines":[{"line_number":110,"context_line":""},{"line_number":111,"context_line":"        # Check endpoint group"},{"line_number":112,"context_line":"        resp \u003d self.client.check_endpoint_group(endpoint_group[\u0027id\u0027])"},{"line_number":113,"context_line":"        self.assertEqual(200, resp.response.status)"},{"line_number":114,"context_line":""},{"line_number":115,"context_line":"        # Deleting the endpoint group created in this method"},{"line_number":116,"context_line":"        self.client.delete_endpoint_group(endpoint_group[\u0027id\u0027])"}],"source_content_type":"text/x-python","patch_set":5,"id":"df140735_0c458317","line":113,"range":{"start_line":113,"start_character":8,"end_line":113,"end_character":51},"updated":"2017-06-01 00:42:47.000000000","message":"this is not needed because the check is done in client.check_endpoint_group","commit_id":"ebc44763b437876615156395c583754decda5331"},{"author":{"_account_id":19391,"name":"Chi Lo","email":"cl566n@att.com","username":"cl566n"},"change_message_id":"106089b8f4c17ee53702a19ac772b3d23c1d1e1b","unresolved":false,"context_lines":[{"line_number":110,"context_line":""},{"line_number":111,"context_line":"        # Check endpoint group"},{"line_number":112,"context_line":"        resp \u003d self.client.check_endpoint_group(endpoint_group[\u0027id\u0027])"},{"line_number":113,"context_line":"        self.assertEqual(200, resp.response.status)"},{"line_number":114,"context_line":""},{"line_number":115,"context_line":"        # Deleting the endpoint group created in this method"},{"line_number":116,"context_line":"        self.client.delete_endpoint_group(endpoint_group[\u0027id\u0027])"}],"source_content_type":"text/x-python","patch_set":5,"id":"df140735_6dd626c6","line":113,"range":{"start_line":113,"start_character":8,"end_line":113,"end_character":51},"in_reply_to":"df140735_0c458317","updated":"2017-06-01 15:36:08.000000000","message":"Removed","commit_id":"ebc44763b437876615156395c583754decda5331"},{"author":{"_account_id":23186,"name":"Felipe Monteiro","email":"felipe.carneiro.monteiro@gmail.com","username":"felipe.monteiro"},"change_message_id":"29d38fababb17ffee2335b4eee82ccc35dbf8439","unresolved":false,"context_lines":[{"line_number":40,"context_line":"                cls.services_client.create_service(name\u003ds_name,"},{"line_number":41,"context_line":"                                                   type\u003ds_type,"},{"line_number":42,"context_line":"                                                   description\u003ds_description))"},{"line_number":43,"context_line":"            cls.service_id \u003d service_data[\u0027service\u0027][\u0027id\u0027]"},{"line_number":44,"context_line":"            cls.service_ids.append(cls.service_id)"},{"line_number":45,"context_line":"            name \u003d data_utils.rand_name(\u0027service_group\u0027)"},{"line_number":46,"context_line":"            description \u003d data_utils.rand_name(\u0027description\u0027)"}],"source_content_type":"text/x-python","patch_set":7,"id":"df140735_a7b54d34","line":43,"range":{"start_line":43,"start_character":12,"end_line":43,"end_character":26},"updated":"2017-06-02 19:50:19.000000000","message":"This should just be service_id (since cls.service_id is being overwritten through each iteration of for loop)","commit_id":"67bde84cb2ad346c6507b81837759cfc0a1b34c0"},{"author":{"_account_id":19391,"name":"Chi Lo","email":"cl566n@att.com","username":"cl566n"},"change_message_id":"b434c42cb43dcf53d5d8d38d934f09027bb442ad","unresolved":false,"context_lines":[{"line_number":40,"context_line":"                cls.services_client.create_service(name\u003ds_name,"},{"line_number":41,"context_line":"                                                   type\u003ds_type,"},{"line_number":42,"context_line":"                                                   description\u003ds_description))"},{"line_number":43,"context_line":"            cls.service_id \u003d service_data[\u0027service\u0027][\u0027id\u0027]"},{"line_number":44,"context_line":"            cls.service_ids.append(cls.service_id)"},{"line_number":45,"context_line":"            name \u003d data_utils.rand_name(\u0027service_group\u0027)"},{"line_number":46,"context_line":"            description \u003d data_utils.rand_name(\u0027description\u0027)"}],"source_content_type":"text/x-python","patch_set":7,"id":"df140735_56574059","line":43,"range":{"start_line":43,"start_character":12,"end_line":43,"end_character":26},"in_reply_to":"df140735_a7b54d34","updated":"2017-06-03 00:14:52.000000000","message":"Fixed.  Also, removed the loop to create 2 endpoint groups as the test_create_list_show_check_delete_endpoint_group() also creates one.  As a result, the endpoint group list will have more than one anyway. This satisfy previous comment that a list of more than one is desired.","commit_id":"67bde84cb2ad346c6507b81837759cfc0a1b34c0"},{"author":{"_account_id":23186,"name":"Felipe Monteiro","email":"felipe.carneiro.monteiro@gmail.com","username":"felipe.monteiro"},"change_message_id":"29d38fababb17ffee2335b4eee82ccc35dbf8439","unresolved":false,"context_lines":[{"line_number":41,"context_line":"                                                   type\u003ds_type,"},{"line_number":42,"context_line":"                                                   description\u003ds_description))"},{"line_number":43,"context_line":"            cls.service_id \u003d service_data[\u0027service\u0027][\u0027id\u0027]"},{"line_number":44,"context_line":"            cls.service_ids.append(cls.service_id)"},{"line_number":45,"context_line":"            name \u003d data_utils.rand_name(\u0027service_group\u0027)"},{"line_number":46,"context_line":"            description \u003d data_utils.rand_name(\u0027description\u0027)"},{"line_number":47,"context_line":"            filters \u003d {\u0027service_id\u0027: cls.service_id}"}],"source_content_type":"text/x-python","patch_set":7,"id":"df140735_47ef911d","line":44,"range":{"start_line":44,"start_character":35,"end_line":44,"end_character":49},"updated":"2017-06-02 19:50:19.000000000","message":"Ditto","commit_id":"67bde84cb2ad346c6507b81837759cfc0a1b34c0"},{"author":{"_account_id":19391,"name":"Chi Lo","email":"cl566n@att.com","username":"cl566n"},"change_message_id":"b434c42cb43dcf53d5d8d38d934f09027bb442ad","unresolved":false,"context_lines":[{"line_number":41,"context_line":"                                                   type\u003ds_type,"},{"line_number":42,"context_line":"                                                   description\u003ds_description))"},{"line_number":43,"context_line":"            cls.service_id \u003d service_data[\u0027service\u0027][\u0027id\u0027]"},{"line_number":44,"context_line":"            cls.service_ids.append(cls.service_id)"},{"line_number":45,"context_line":"            name \u003d data_utils.rand_name(\u0027service_group\u0027)"},{"line_number":46,"context_line":"            description \u003d data_utils.rand_name(\u0027description\u0027)"},{"line_number":47,"context_line":"            filters \u003d {\u0027service_id\u0027: cls.service_id}"}],"source_content_type":"text/x-python","patch_set":7,"id":"df140735_164d48c3","line":44,"range":{"start_line":44,"start_character":35,"end_line":44,"end_character":49},"in_reply_to":"df140735_47ef911d","updated":"2017-06-03 00:14:52.000000000","message":"Fixed","commit_id":"67bde84cb2ad346c6507b81837759cfc0a1b34c0"},{"author":{"_account_id":23186,"name":"Felipe Monteiro","email":"felipe.carneiro.monteiro@gmail.com","username":"felipe.monteiro"},"change_message_id":"29d38fababb17ffee2335b4eee82ccc35dbf8439","unresolved":false,"context_lines":[{"line_number":44,"context_line":"            cls.service_ids.append(cls.service_id)"},{"line_number":45,"context_line":"            name \u003d data_utils.rand_name(\u0027service_group\u0027)"},{"line_number":46,"context_line":"            description \u003d data_utils.rand_name(\u0027description\u0027)"},{"line_number":47,"context_line":"            filters \u003d {\u0027service_id\u0027: cls.service_id}"},{"line_number":48,"context_line":""},{"line_number":49,"context_line":"            endpoint_group \u003d cls.client.create_endpoint_group("},{"line_number":50,"context_line":"                name\u003dname,"}],"source_content_type":"text/x-python","patch_set":7,"id":"df140735_27f01dfd","line":47,"range":{"start_line":47,"start_character":37,"end_line":47,"end_character":51},"updated":"2017-06-02 19:50:19.000000000","message":"Ditto","commit_id":"67bde84cb2ad346c6507b81837759cfc0a1b34c0"},{"author":{"_account_id":19391,"name":"Chi Lo","email":"cl566n@att.com","username":"cl566n"},"change_message_id":"b434c42cb43dcf53d5d8d38d934f09027bb442ad","unresolved":false,"context_lines":[{"line_number":44,"context_line":"            cls.service_ids.append(cls.service_id)"},{"line_number":45,"context_line":"            name \u003d data_utils.rand_name(\u0027service_group\u0027)"},{"line_number":46,"context_line":"            description \u003d data_utils.rand_name(\u0027description\u0027)"},{"line_number":47,"context_line":"            filters \u003d {\u0027service_id\u0027: cls.service_id}"},{"line_number":48,"context_line":""},{"line_number":49,"context_line":"            endpoint_group \u003d cls.client.create_endpoint_group("},{"line_number":50,"context_line":"                name\u003dname,"}],"source_content_type":"text/x-python","patch_set":7,"id":"df140735_f649b4b6","line":47,"range":{"start_line":47,"start_character":37,"end_line":47,"end_character":51},"in_reply_to":"df140735_27f01dfd","updated":"2017-06-03 00:14:52.000000000","message":"Fixed","commit_id":"67bde84cb2ad346c6507b81837759cfc0a1b34c0"},{"author":{"_account_id":23186,"name":"Felipe Monteiro","email":"felipe.carneiro.monteiro@gmail.com","username":"felipe.monteiro"},"change_message_id":"29d38fababb17ffee2335b4eee82ccc35dbf8439","unresolved":false,"context_lines":[{"line_number":45,"context_line":"            name \u003d data_utils.rand_name(\u0027service_group\u0027)"},{"line_number":46,"context_line":"            description \u003d data_utils.rand_name(\u0027description\u0027)"},{"line_number":47,"context_line":"            filters \u003d {\u0027service_id\u0027: cls.service_id}"},{"line_number":48,"context_line":""},{"line_number":49,"context_line":"            endpoint_group \u003d cls.client.create_endpoint_group("},{"line_number":50,"context_line":"                name\u003dname,"},{"line_number":51,"context_line":"                description\u003ddescription,"}],"source_content_type":"text/x-python","patch_set":7,"id":"df140735_87e00928","line":48,"updated":"2017-06-02 19:50:19.000000000","message":"I think it\u0027d be better to group L45-53 together and introduce newline on L45 to group the code for creating endpoint group.","commit_id":"67bde84cb2ad346c6507b81837759cfc0a1b34c0"},{"author":{"_account_id":19391,"name":"Chi Lo","email":"cl566n@att.com","username":"cl566n"},"change_message_id":"b434c42cb43dcf53d5d8d38d934f09027bb442ad","unresolved":false,"context_lines":[{"line_number":45,"context_line":"            name \u003d data_utils.rand_name(\u0027service_group\u0027)"},{"line_number":46,"context_line":"            description \u003d data_utils.rand_name(\u0027description\u0027)"},{"line_number":47,"context_line":"            filters \u003d {\u0027service_id\u0027: cls.service_id}"},{"line_number":48,"context_line":""},{"line_number":49,"context_line":"            endpoint_group \u003d cls.client.create_endpoint_group("},{"line_number":50,"context_line":"                name\u003dname,"},{"line_number":51,"context_line":"                description\u003ddescription,"}],"source_content_type":"text/x-python","patch_set":7,"id":"df140735_96e718ad","line":48,"in_reply_to":"df140735_87e00928","updated":"2017-06-03 00:14:52.000000000","message":"Fixed. Created a helper function _create_service() as service creation is needed in multiple places.","commit_id":"67bde84cb2ad346c6507b81837759cfc0a1b34c0"},{"author":{"_account_id":23186,"name":"Felipe Monteiro","email":"felipe.carneiro.monteiro@gmail.com","username":"felipe.monteiro"},"change_message_id":"29d38fababb17ffee2335b4eee82ccc35dbf8439","unresolved":false,"context_lines":[{"line_number":60,"context_line":"            cls.services_client.delete_service(s)"},{"line_number":61,"context_line":"        super(EndPointGroupsTestJSON, cls).resource_cleanup()"},{"line_number":62,"context_line":""},{"line_number":63,"context_line":"    @decorators.idempotent_id(\u00279b5bc7af-6183-4d46-a440-cc81d547b2af\u0027)"},{"line_number":64,"context_line":"    def test_list_endpoint_groups(self):"},{"line_number":65,"context_line":"        # Get a list of endpoints"},{"line_number":66,"context_line":"        fetched_endpoints \u003d \\"},{"line_number":67,"context_line":"            self.client.list_endpoint_groups()[\u0027endpoint_groups\u0027]"},{"line_number":68,"context_line":""},{"line_number":69,"context_line":"        # Asserting LIST endpoints"},{"line_number":70,"context_line":"        missing_endpoints \u003d \\"},{"line_number":71,"context_line":"            [e for e in self.endpoint_groups"},{"line_number":72,"context_line":"             if e[\u0027endpoint_group\u0027] not in fetched_endpoints]"},{"line_number":73,"context_line":""},{"line_number":74,"context_line":"        self.assertEmpty(missing_endpoints,"},{"line_number":75,"context_line":"                         \"Failed to find endpoint %s in fetched list\" %"},{"line_number":76,"context_line":"                         \u0027, \u0027.join(str(e) for e in missing_endpoints))"},{"line_number":77,"context_line":""},{"line_number":78,"context_line":"    @decorators.idempotent_id(\u00277c69e7a1-f865-402d-a2ea-44493017315a\u0027)"},{"line_number":79,"context_line":"    def test_create_list_show_check_delete_endpoint_group(self):"}],"source_content_type":"text/x-python","patch_set":7,"id":"df140735_47343193","line":76,"range":{"start_line":63,"start_character":0,"end_line":76,"end_character":70},"updated":"2017-06-02 19:50:19.000000000","message":"I think this test can be combined with test_create_list_show_check_delete_endpoint_group below (since the test already tests list as well).","commit_id":"67bde84cb2ad346c6507b81837759cfc0a1b34c0"},{"author":{"_account_id":19391,"name":"Chi Lo","email":"cl566n@att.com","username":"cl566n"},"change_message_id":"b434c42cb43dcf53d5d8d38d934f09027bb442ad","unresolved":false,"context_lines":[{"line_number":60,"context_line":"            cls.services_client.delete_service(s)"},{"line_number":61,"context_line":"        super(EndPointGroupsTestJSON, cls).resource_cleanup()"},{"line_number":62,"context_line":""},{"line_number":63,"context_line":"    @decorators.idempotent_id(\u00279b5bc7af-6183-4d46-a440-cc81d547b2af\u0027)"},{"line_number":64,"context_line":"    def test_list_endpoint_groups(self):"},{"line_number":65,"context_line":"        # Get a list of endpoints"},{"line_number":66,"context_line":"        fetched_endpoints \u003d \\"},{"line_number":67,"context_line":"            self.client.list_endpoint_groups()[\u0027endpoint_groups\u0027]"},{"line_number":68,"context_line":""},{"line_number":69,"context_line":"        # Asserting LIST endpoints"},{"line_number":70,"context_line":"        missing_endpoints \u003d \\"},{"line_number":71,"context_line":"            [e for e in self.endpoint_groups"},{"line_number":72,"context_line":"             if e[\u0027endpoint_group\u0027] not in fetched_endpoints]"},{"line_number":73,"context_line":""},{"line_number":74,"context_line":"        self.assertEmpty(missing_endpoints,"},{"line_number":75,"context_line":"                         \"Failed to find endpoint %s in fetched list\" %"},{"line_number":76,"context_line":"                         \u0027, \u0027.join(str(e) for e in missing_endpoints))"},{"line_number":77,"context_line":""},{"line_number":78,"context_line":"    @decorators.idempotent_id(\u00277c69e7a1-f865-402d-a2ea-44493017315a\u0027)"},{"line_number":79,"context_line":"    def test_create_list_show_check_delete_endpoint_group(self):"}],"source_content_type":"text/x-python","patch_set":7,"id":"df140735_f6f77458","line":76,"range":{"start_line":63,"start_character":0,"end_line":76,"end_character":70},"in_reply_to":"df140735_47343193","updated":"2017-06-03 00:14:52.000000000","message":"Removed and combined.","commit_id":"67bde84cb2ad346c6507b81837759cfc0a1b34c0"},{"author":{"_account_id":23186,"name":"Felipe Monteiro","email":"felipe.carneiro.monteiro@gmail.com","username":"felipe.monteiro"},"change_message_id":"29d38fababb17ffee2335b4eee82ccc35dbf8439","unresolved":false,"context_lines":[{"line_number":86,"context_line":"            description\u003ddescription,"},{"line_number":87,"context_line":"            filters\u003dfilters)"},{"line_number":88,"context_line":""},{"line_number":89,"context_line":"        self.endpoint_groups.append(endpoint_group_tuple)"},{"line_number":90,"context_line":"        endpoint_group \u003d endpoint_group_tuple[\u0027endpoint_group\u0027]"},{"line_number":91,"context_line":""},{"line_number":92,"context_line":"        # Asserting created endpoint group response body"},{"line_number":93,"context_line":"        self.assertIn(\u0027id\u0027, endpoint_group)"}],"source_content_type":"text/x-python","patch_set":7,"id":"df140735_a751cddb","line":90,"range":{"start_line":89,"start_character":8,"end_line":90,"end_character":63},"updated":"2017-06-02 19:50:19.000000000","message":"I think it\u0027d be cleaner to do:\n\nendpoint_group \u003d self.client.create_endpoint_group(\n    name\u003dname,\n    description\u003ddescription,\n    filters\u003dfilters)[\u0027endpoint_group\u0027]\nself.endpoint_groups.append(endpoint_group)\n\nAnd then making the needed changes elsewhere.","commit_id":"67bde84cb2ad346c6507b81837759cfc0a1b34c0"},{"author":{"_account_id":19391,"name":"Chi Lo","email":"cl566n@att.com","username":"cl566n"},"change_message_id":"b434c42cb43dcf53d5d8d38d934f09027bb442ad","unresolved":false,"context_lines":[{"line_number":86,"context_line":"            description\u003ddescription,"},{"line_number":87,"context_line":"            filters\u003dfilters)"},{"line_number":88,"context_line":""},{"line_number":89,"context_line":"        self.endpoint_groups.append(endpoint_group_tuple)"},{"line_number":90,"context_line":"        endpoint_group \u003d endpoint_group_tuple[\u0027endpoint_group\u0027]"},{"line_number":91,"context_line":""},{"line_number":92,"context_line":"        # Asserting created endpoint group response body"},{"line_number":93,"context_line":"        self.assertIn(\u0027id\u0027, endpoint_group)"}],"source_content_type":"text/x-python","patch_set":7,"id":"df140735_d696b0f0","line":90,"range":{"start_line":89,"start_character":8,"end_line":90,"end_character":63},"in_reply_to":"df140735_a751cddb","updated":"2017-06-03 00:14:52.000000000","message":"Fixed.","commit_id":"67bde84cb2ad346c6507b81837759cfc0a1b34c0"},{"author":{"_account_id":23186,"name":"Felipe Monteiro","email":"felipe.carneiro.monteiro@gmail.com","username":"felipe.monteiro"},"change_message_id":"29d38fababb17ffee2335b4eee82ccc35dbf8439","unresolved":false,"context_lines":[{"line_number":105,"context_line":"            endpoint_group[\u0027id\u0027])[\u0027endpoint_group\u0027]"},{"line_number":106,"context_line":""},{"line_number":107,"context_line":"        # Asserting if the attributes of endpoint group are the same"},{"line_number":108,"context_line":"        self.assertEqual(self.service_id,"},{"line_number":109,"context_line":"                         fetched_endpoint[\u0027filters\u0027][\u0027service_id\u0027])"},{"line_number":110,"context_line":""},{"line_number":111,"context_line":"        # Check endpoint group"}],"source_content_type":"text/x-python","patch_set":7,"id":"df140735_8767e9b7","line":108,"updated":"2017-06-02 19:50:19.000000000","message":"I think you can also add:\n\nfor attr in (\u0027id\u0027, \u0027name\u0027, \u0027description\u0027):\n    self.assertEqual(endpoint_group[attr], fetched_endpoint[attr])","commit_id":"67bde84cb2ad346c6507b81837759cfc0a1b34c0"},{"author":{"_account_id":19391,"name":"Chi Lo","email":"cl566n@att.com","username":"cl566n"},"change_message_id":"b434c42cb43dcf53d5d8d38d934f09027bb442ad","unresolved":false,"context_lines":[{"line_number":105,"context_line":"            endpoint_group[\u0027id\u0027])[\u0027endpoint_group\u0027]"},{"line_number":106,"context_line":""},{"line_number":107,"context_line":"        # Asserting if the attributes of endpoint group are the same"},{"line_number":108,"context_line":"        self.assertEqual(self.service_id,"},{"line_number":109,"context_line":"                         fetched_endpoint[\u0027filters\u0027][\u0027service_id\u0027])"},{"line_number":110,"context_line":""},{"line_number":111,"context_line":"        # Check endpoint group"}],"source_content_type":"text/x-python","patch_set":7,"id":"df140735_b69b3c16","line":108,"in_reply_to":"df140735_8767e9b7","updated":"2017-06-03 00:14:52.000000000","message":"Added.","commit_id":"67bde84cb2ad346c6507b81837759cfc0a1b34c0"},{"author":{"_account_id":23186,"name":"Felipe Monteiro","email":"felipe.carneiro.monteiro@gmail.com","username":"felipe.monteiro"},"change_message_id":"29d38fababb17ffee2335b4eee82ccc35dbf8439","unresolved":false,"context_lines":[{"line_number":134,"context_line":"            name\u003dname,"},{"line_number":135,"context_line":"            description\u003ddescription,"},{"line_number":136,"context_line":"            filters\u003dfilters)[\u0027endpoint_group\u0027]"},{"line_number":137,"context_line":"        self.addCleanup(self.client.delete_endpoint_group,"},{"line_number":138,"context_line":"                        endpoint_group[\u0027id\u0027])"},{"line_number":139,"context_line":""},{"line_number":140,"context_line":"        # Creating service so as update endpoint group with new service ID"},{"line_number":141,"context_line":"        s_name \u003d data_utils.rand_name(\u0027service\u0027)"}],"source_content_type":"text/x-python","patch_set":7,"id":"df140735_a718ad1d","line":138,"range":{"start_line":137,"start_character":0,"end_line":138,"end_character":45},"updated":"2017-06-02 19:50:19.000000000","message":"Here you do an addCleanup but elsewhere you do self.endpoint_groups.append(endpoint_group). This is inconsistent.","commit_id":"67bde84cb2ad346c6507b81837759cfc0a1b34c0"},{"author":{"_account_id":19391,"name":"Chi Lo","email":"cl566n@att.com","username":"cl566n"},"change_message_id":"b434c42cb43dcf53d5d8d38d934f09027bb442ad","unresolved":false,"context_lines":[{"line_number":134,"context_line":"            name\u003dname,"},{"line_number":135,"context_line":"            description\u003ddescription,"},{"line_number":136,"context_line":"            filters\u003dfilters)[\u0027endpoint_group\u0027]"},{"line_number":137,"context_line":"        self.addCleanup(self.client.delete_endpoint_group,"},{"line_number":138,"context_line":"                        endpoint_group[\u0027id\u0027])"},{"line_number":139,"context_line":""},{"line_number":140,"context_line":"        # Creating service so as update endpoint group with new service ID"},{"line_number":141,"context_line":"        s_name \u003d data_utils.rand_name(\u0027service\u0027)"}],"source_content_type":"text/x-python","patch_set":7,"id":"df140735_763da4db","line":138,"range":{"start_line":137,"start_character":0,"end_line":138,"end_character":45},"in_reply_to":"df140735_a718ad1d","updated":"2017-06-03 00:14:52.000000000","message":"Changed to append()","commit_id":"67bde84cb2ad346c6507b81837759cfc0a1b34c0"},{"author":{"_account_id":23186,"name":"Felipe Monteiro","email":"felipe.carneiro.monteiro@gmail.com","username":"felipe.monteiro"},"change_message_id":"29d38fababb17ffee2335b4eee82ccc35dbf8439","unresolved":false,"context_lines":[{"line_number":159,"context_line":"            description\u003ddescription2,"},{"line_number":160,"context_line":"            filters\u003dfilters)[\u0027endpoint_group\u0027][\u0027id\u0027]"},{"line_number":161,"context_line":""},{"line_number":162,"context_line":"        # Show endpoint group"},{"line_number":163,"context_line":"        updated_endpoint_group \u003d self.client.show_endpoint_group("},{"line_number":164,"context_line":"            updated_endpoint_group_id)[\u0027endpoint_group\u0027]"},{"line_number":165,"context_line":""},{"line_number":166,"context_line":"        # Asserting if the attributes of endpoint group are updated"},{"line_number":167,"context_line":"        self.assertEqual(name2, updated_endpoint_group[\u0027name\u0027])"}],"source_content_type":"text/x-python","patch_set":7,"id":"df140735_e7a3459d","line":164,"range":{"start_line":162,"start_character":0,"end_line":164,"end_character":56},"updated":"2017-06-02 19:50:19.000000000","message":"I would remove this since you already tested show in test_create_list_show_check_delete_endpoint_group\n\nInstead, assert that the response body of updated_endpoint_group is correct by updating assertions on L167-170 below.","commit_id":"67bde84cb2ad346c6507b81837759cfc0a1b34c0"},{"author":{"_account_id":19391,"name":"Chi Lo","email":"cl566n@att.com","username":"cl566n"},"change_message_id":"b434c42cb43dcf53d5d8d38d934f09027bb442ad","unresolved":false,"context_lines":[{"line_number":159,"context_line":"            description\u003ddescription2,"},{"line_number":160,"context_line":"            filters\u003dfilters)[\u0027endpoint_group\u0027][\u0027id\u0027]"},{"line_number":161,"context_line":""},{"line_number":162,"context_line":"        # Show endpoint group"},{"line_number":163,"context_line":"        updated_endpoint_group \u003d self.client.show_endpoint_group("},{"line_number":164,"context_line":"            updated_endpoint_group_id)[\u0027endpoint_group\u0027]"},{"line_number":165,"context_line":""},{"line_number":166,"context_line":"        # Asserting if the attributes of endpoint group are updated"},{"line_number":167,"context_line":"        self.assertEqual(name2, updated_endpoint_group[\u0027name\u0027])"}],"source_content_type":"text/x-python","patch_set":7,"id":"df140735_b9532d17","line":164,"range":{"start_line":162,"start_character":0,"end_line":164,"end_character":56},"in_reply_to":"df140735_e7a3459d","updated":"2017-06-03 00:14:52.000000000","message":"Fixed","commit_id":"67bde84cb2ad346c6507b81837759cfc0a1b34c0"},{"author":{"_account_id":23186,"name":"Felipe Monteiro","email":"felipe.carneiro.monteiro@gmail.com","username":"felipe.monteiro"},"change_message_id":"8ad02767be80b6293a4c67d464d36b2f84d7bd92","unresolved":false,"context_lines":[{"line_number":122,"context_line":"        fetched_endpoints \u003d \\"},{"line_number":123,"context_line":"            self.client.list_endpoint_groups()[\u0027endpoint_groups\u0027]"},{"line_number":124,"context_line":"        fetched_endpoints_id \u003d [e[\u0027id\u0027] for e in fetched_endpoints]"},{"line_number":125,"context_line":"        self.assertNotIn(endpoint_group[\u0027id\u0027], fetched_endpoints_id)"},{"line_number":126,"context_line":""},{"line_number":127,"context_line":"    @test.attr(type\u003d\u0027smoke\u0027)"},{"line_number":128,"context_line":"    @decorators.idempotent_id(\u002751c8fc38-fa84-4e76-b5b6-6fc37770fb26\u0027)"}],"source_content_type":"text/x-python","patch_set":8,"id":"df140735_3c870bb8","line":125,"range":{"start_line":125,"start_character":47,"end_line":125,"end_character":67},"updated":"2017-06-03 03:34:00.000000000","message":"fetched_endpoint_ids","commit_id":"2e68fe35fbcf61997d93ebaf7af5e107121c9cd1"},{"author":{"_account_id":19391,"name":"Chi Lo","email":"cl566n@att.com","username":"cl566n"},"change_message_id":"5a3185e13118470181135901b8fc5fa559949c14","unresolved":false,"context_lines":[{"line_number":122,"context_line":"        fetched_endpoints \u003d \\"},{"line_number":123,"context_line":"            self.client.list_endpoint_groups()[\u0027endpoint_groups\u0027]"},{"line_number":124,"context_line":"        fetched_endpoints_id \u003d [e[\u0027id\u0027] for e in fetched_endpoints]"},{"line_number":125,"context_line":"        self.assertNotIn(endpoint_group[\u0027id\u0027], fetched_endpoints_id)"},{"line_number":126,"context_line":""},{"line_number":127,"context_line":"    @test.attr(type\u003d\u0027smoke\u0027)"},{"line_number":128,"context_line":"    @decorators.idempotent_id(\u002751c8fc38-fa84-4e76-b5b6-6fc37770fb26\u0027)"}],"source_content_type":"text/x-python","patch_set":8,"id":"df140735_ee1655a8","line":125,"range":{"start_line":125,"start_character":47,"end_line":125,"end_character":67},"in_reply_to":"df140735_3c870bb8","updated":"2017-06-05 15:11:35.000000000","message":"Renamed.","commit_id":"2e68fe35fbcf61997d93ebaf7af5e107121c9cd1"},{"author":{"_account_id":23186,"name":"Felipe Monteiro","email":"felipe.carneiro.monteiro@gmail.com","username":"felipe.monteiro"},"change_message_id":"8ad02767be80b6293a4c67d464d36b2f84d7bd92","unresolved":false,"context_lines":[{"line_number":124,"context_line":"        fetched_endpoints_id \u003d [e[\u0027id\u0027] for e in fetched_endpoints]"},{"line_number":125,"context_line":"        self.assertNotIn(endpoint_group[\u0027id\u0027], fetched_endpoints_id)"},{"line_number":126,"context_line":""},{"line_number":127,"context_line":"    @test.attr(type\u003d\u0027smoke\u0027)"},{"line_number":128,"context_line":"    @decorators.idempotent_id(\u002751c8fc38-fa84-4e76-b5b6-6fc37770fb26\u0027)"},{"line_number":129,"context_line":"    def test_update_endpoint_group(self):"},{"line_number":130,"context_line":"        # Creating an endpoint group so as to check update endpoint group"}],"source_content_type":"text/x-python","patch_set":8,"id":"df140735_5c8abfbe","line":127,"range":{"start_line":127,"start_character":4,"end_line":127,"end_character":28},"updated":"2017-06-03 03:34:00.000000000","message":"Did you mean to make this a smoke test?","commit_id":"2e68fe35fbcf61997d93ebaf7af5e107121c9cd1"},{"author":{"_account_id":19391,"name":"Chi Lo","email":"cl566n@att.com","username":"cl566n"},"change_message_id":"5a3185e13118470181135901b8fc5fa559949c14","unresolved":false,"context_lines":[{"line_number":124,"context_line":"        fetched_endpoints_id \u003d [e[\u0027id\u0027] for e in fetched_endpoints]"},{"line_number":125,"context_line":"        self.assertNotIn(endpoint_group[\u0027id\u0027], fetched_endpoints_id)"},{"line_number":126,"context_line":""},{"line_number":127,"context_line":"    @test.attr(type\u003d\u0027smoke\u0027)"},{"line_number":128,"context_line":"    @decorators.idempotent_id(\u002751c8fc38-fa84-4e76-b5b6-6fc37770fb26\u0027)"},{"line_number":129,"context_line":"    def test_update_endpoint_group(self):"},{"line_number":130,"context_line":"        # Creating an endpoint group so as to check update endpoint group"}],"source_content_type":"text/x-python","patch_set":8,"id":"df140735_4e254108","line":127,"range":{"start_line":127,"start_character":4,"end_line":127,"end_character":28},"in_reply_to":"df140735_5c8abfbe","updated":"2017-06-05 15:11:35.000000000","message":"No.  Removed.","commit_id":"2e68fe35fbcf61997d93ebaf7af5e107121c9cd1"},{"author":{"_account_id":23186,"name":"Felipe Monteiro","email":"felipe.carneiro.monteiro@gmail.com","username":"felipe.monteiro"},"change_message_id":"3914d496bea378dbae126d82faa00c2714df39e9","unresolved":false,"context_lines":[{"line_number":18,"context_line":"from tempest.lib import decorators"},{"line_number":19,"context_line":""},{"line_number":20,"context_line":""},{"line_number":21,"context_line":"class EndPointGroupsTestJSON(base.BaseIdentityV3AdminTest):"},{"line_number":22,"context_line":""},{"line_number":23,"context_line":"    @classmethod"},{"line_number":24,"context_line":"    def setup_clients(cls):"}],"source_content_type":"text/x-python","patch_set":9,"id":"df140735_574ef1c0","line":21,"range":{"start_line":21,"start_character":24,"end_line":21,"end_character":28},"updated":"2017-06-05 19:36:19.000000000","message":"Don\u0027t JSON/XML in test class names.","commit_id":"ff744daebb8b9cd22f38f26e88cc9dfc01a49a89"},{"author":{"_account_id":19391,"name":"Chi Lo","email":"cl566n@att.com","username":"cl566n"},"change_message_id":"7f381ed72f252a67024170082546e1d454eb2385","unresolved":false,"context_lines":[{"line_number":18,"context_line":"from tempest.lib import decorators"},{"line_number":19,"context_line":""},{"line_number":20,"context_line":""},{"line_number":21,"context_line":"class EndPointGroupsTestJSON(base.BaseIdentityV3AdminTest):"},{"line_number":22,"context_line":""},{"line_number":23,"context_line":"    @classmethod"},{"line_number":24,"context_line":"    def setup_clients(cls):"}],"source_content_type":"text/x-python","patch_set":9,"id":"df140735_0d2bc682","line":21,"range":{"start_line":21,"start_character":24,"end_line":21,"end_character":28},"in_reply_to":"df140735_574ef1c0","updated":"2017-06-05 19:57:45.000000000","message":"Removed \"JSON\".","commit_id":"ff744daebb8b9cd22f38f26e88cc9dfc01a49a89"}],"tempest/lib/services/identity/v3/__init__.py":[{"author":{"_account_id":23186,"name":"Felipe Monteiro","email":"felipe.carneiro.monteiro@gmail.com","username":"felipe.monteiro"},"change_message_id":"45758ea249bcf8c80dba12a92af420740b562f92","unresolved":false,"context_lines":[{"line_number":41,"context_line":"from tempest.lib.services.identity.v3.versions_client import VersionsClient"},{"line_number":42,"context_line":""},{"line_number":43,"context_line":"__all__ \u003d [\u0027CredentialsClient\u0027, \u0027DomainsClient\u0027, \u0027DomainConfigurationClient\u0027,"},{"line_number":44,"context_line":"           \u0027EndpointGroupsClient\u0027, \u0027EndPointsClient\u0027, \u0027EndPointsFilterClient\u0027,"},{"line_number":45,"context_line":"           \u0027GroupsClient\u0027, \u0027IdentityClient\u0027, \u0027InheritedRolesClient\u0027,"},{"line_number":46,"context_line":"           \u0027OAUTHConsumerClient\u0027, \u0027PoliciesClient\u0027, \u0027ProjectsClient\u0027,"},{"line_number":47,"context_line":"           \u0027RegionsClient\u0027, \u0027RoleAssignmentsClient\u0027, \u0027RolesClient\u0027,"}],"source_content_type":"text/x-python","patch_set":2,"id":"3f044301_f8893c26","line":44,"range":{"start_line":44,"start_character":12,"end_line":44,"end_character":32},"updated":"2017-05-04 13:06:51.000000000","message":"nit: \"Endpoint\" is inconsistent with \"EndPoint...\" in the other class names.","commit_id":"c76b4403ce9003c47cecc24255a432f1319ab24f"},{"author":{"_account_id":19391,"name":"Chi Lo","email":"cl566n@att.com","username":"cl566n"},"change_message_id":"780a4cf422cfe6cba3fcb707b4a17ae9919e8913","unresolved":false,"context_lines":[{"line_number":41,"context_line":"from tempest.lib.services.identity.v3.versions_client import VersionsClient"},{"line_number":42,"context_line":""},{"line_number":43,"context_line":"__all__ \u003d [\u0027CredentialsClient\u0027, \u0027DomainsClient\u0027, \u0027DomainConfigurationClient\u0027,"},{"line_number":44,"context_line":"           \u0027EndpointGroupsClient\u0027, \u0027EndPointsClient\u0027, \u0027EndPointsFilterClient\u0027,"},{"line_number":45,"context_line":"           \u0027GroupsClient\u0027, \u0027IdentityClient\u0027, \u0027InheritedRolesClient\u0027,"},{"line_number":46,"context_line":"           \u0027OAUTHConsumerClient\u0027, \u0027PoliciesClient\u0027, \u0027ProjectsClient\u0027,"},{"line_number":47,"context_line":"           \u0027RegionsClient\u0027, \u0027RoleAssignmentsClient\u0027, \u0027RolesClient\u0027,"}],"source_content_type":"text/x-python","patch_set":2,"id":"3f044301_8391a455","line":44,"range":{"start_line":44,"start_character":12,"end_line":44,"end_character":32},"in_reply_to":"3f044301_f8893c26","updated":"2017-05-04 16:24:12.000000000","message":"Will Change to EndPointGroupsClient.","commit_id":"c76b4403ce9003c47cecc24255a432f1319ab24f"},{"author":{"_account_id":23186,"name":"Felipe Monteiro","email":"felipe.carneiro.monteiro@gmail.com","username":"felipe.monteiro"},"change_message_id":"d63e0608e99dd53cfdd195022729f514259b597e","unresolved":false,"context_lines":[{"line_number":41,"context_line":"from tempest.lib.services.identity.v3.versions_client import VersionsClient"},{"line_number":42,"context_line":""},{"line_number":43,"context_line":"__all__ \u003d [\u0027CredentialsClient\u0027, \u0027DomainsClient\u0027, \u0027DomainConfigurationClient\u0027,"},{"line_number":44,"context_line":"           \u0027EndPointGroupsClient\u0027, \u0027EndPointsClient\u0027, \u0027EndPointsFilterClient\u0027,"},{"line_number":45,"context_line":"           \u0027GroupsClient\u0027, \u0027IdentityClient\u0027, \u0027InheritedRolesClient\u0027,"},{"line_number":46,"context_line":"           \u0027OAUTHConsumerClient\u0027, \u0027PoliciesClient\u0027, \u0027ProjectsClient\u0027,"},{"line_number":47,"context_line":"           \u0027RegionsClient\u0027, \u0027RoleAssignmentsClient\u0027, \u0027RolesClient\u0027,"}],"source_content_type":"text/x-python","patch_set":3,"id":"3f044301_759e4664","line":44,"range":{"start_line":44,"start_character":12,"end_line":44,"end_character":20},"updated":"2017-05-04 19:19:12.000000000","message":"nit: EndPointsGroupsClient (EndPoints with an \"s\") just like EndPointsFilterClient and EndPointsClient.","commit_id":"f787f90a3a1a3739eefbe1070184a7a79aadd34a"},{"author":{"_account_id":19391,"name":"Chi Lo","email":"cl566n@att.com","username":"cl566n"},"change_message_id":"89f472b19b8b09470e4a3ef9ab145ccb568c4710","unresolved":false,"context_lines":[{"line_number":41,"context_line":"from tempest.lib.services.identity.v3.versions_client import VersionsClient"},{"line_number":42,"context_line":""},{"line_number":43,"context_line":"__all__ \u003d [\u0027CredentialsClient\u0027, \u0027DomainsClient\u0027, \u0027DomainConfigurationClient\u0027,"},{"line_number":44,"context_line":"           \u0027EndPointGroupsClient\u0027, \u0027EndPointsClient\u0027, \u0027EndPointsFilterClient\u0027,"},{"line_number":45,"context_line":"           \u0027GroupsClient\u0027, \u0027IdentityClient\u0027, \u0027InheritedRolesClient\u0027,"},{"line_number":46,"context_line":"           \u0027OAUTHConsumerClient\u0027, \u0027PoliciesClient\u0027, \u0027ProjectsClient\u0027,"},{"line_number":47,"context_line":"           \u0027RegionsClient\u0027, \u0027RoleAssignmentsClient\u0027, \u0027RolesClient\u0027,"}],"source_content_type":"text/x-python","patch_set":3,"id":"3f044301_a7d02552","line":44,"range":{"start_line":44,"start_character":12,"end_line":44,"end_character":20},"in_reply_to":"3f044301_759e4664","updated":"2017-05-05 04:58:36.000000000","message":"I would like to keep it this way because the actual api and documentation has endpoint_groups, not endpoints_groups. The other clients does have that \"s\" after EndPoint.","commit_id":"f787f90a3a1a3739eefbe1070184a7a79aadd34a"}],"tempest/lib/services/identity/v3/endpoint_groups_client.py":[{"author":{"_account_id":20190,"name":"zhufl","email":"zhu.fanglei@zte.com.cn","username":"zhufl"},"change_message_id":"c71c9acf5c4f452b99f04ef5e18c2f8112ebb2d1","unresolved":false,"context_lines":[{"line_number":22,"context_line":"    api_version \u003d \"v3\"\r"},{"line_number":23,"context_line":"\r"},{"line_number":24,"context_line":"    def create_endpoint_group(self, **kwargs):\r"},{"line_number":25,"context_line":"        \"\"\"Create endpoint group.\"\"\"\r"},{"line_number":26,"context_line":"        post_body \u003d json.dumps({\u0027endpoint_group\u0027: kwargs})\r"},{"line_number":27,"context_line":"        resp, body \u003d self.post(\u0027OS-EP-FILTER/endpoint_groups\u0027, post_body)\r"},{"line_number":28,"context_line":"        self.expected_success(201, resp.status)\r"}],"source_content_type":"text/x-python","patch_set":2,"id":"3f044301_9127bc65","line":25,"range":{"start_line":25,"start_character":8,"end_line":25,"end_character":36},"updated":"2017-05-04 09:24:33.000000000","message":"is api ref link available?","commit_id":"c76b4403ce9003c47cecc24255a432f1319ab24f"},{"author":{"_account_id":19391,"name":"Chi Lo","email":"cl566n@att.com","username":"cl566n"},"change_message_id":"d912b787eb13bd531ee14b0a93136a1285d40eb9","unresolved":false,"context_lines":[{"line_number":22,"context_line":"    api_version \u003d \"v3\"\r"},{"line_number":23,"context_line":"\r"},{"line_number":24,"context_line":"    def create_endpoint_group(self, **kwargs):\r"},{"line_number":25,"context_line":"        \"\"\"Create endpoint group.\"\"\"\r"},{"line_number":26,"context_line":"        post_body \u003d json.dumps({\u0027endpoint_group\u0027: kwargs})\r"},{"line_number":27,"context_line":"        resp, body \u003d self.post(\u0027OS-EP-FILTER/endpoint_groups\u0027, post_body)\r"},{"line_number":28,"context_line":"        self.expected_success(201, resp.status)\r"}],"source_content_type":"text/x-python","patch_set":2,"id":"3f044301_a4b5cdf0","line":25,"range":{"start_line":25,"start_character":8,"end_line":25,"end_character":36},"in_reply_to":"3f044301_9127bc65","updated":"2017-05-04 16:21:14.000000000","message":"Api ref link is not available for endpoint \"groups\".","commit_id":"c76b4403ce9003c47cecc24255a432f1319ab24f"},{"author":{"_account_id":19391,"name":"Chi Lo","email":"cl566n@att.com","username":"cl566n"},"change_message_id":"c4bbaa81349992f6ffed6d408da72f05b50239d0","unresolved":false,"context_lines":[{"line_number":22,"context_line":"    api_version \u003d \"v3\"\r"},{"line_number":23,"context_line":"\r"},{"line_number":24,"context_line":"    def create_endpoint_group(self, **kwargs):\r"},{"line_number":25,"context_line":"        \"\"\"Create endpoint group.\"\"\"\r"},{"line_number":26,"context_line":"        post_body \u003d json.dumps({\u0027endpoint_group\u0027: kwargs})\r"},{"line_number":27,"context_line":"        resp, body \u003d self.post(\u0027OS-EP-FILTER/endpoint_groups\u0027, post_body)\r"},{"line_number":28,"context_line":"        self.expected_success(201, resp.status)\r"}],"source_content_type":"text/x-python","patch_set":2,"id":"3f044301_bb2155fe","line":25,"range":{"start_line":25,"start_character":8,"end_line":25,"end_character":36},"in_reply_to":"3f044301_a4b5cdf0","updated":"2017-05-05 05:46:38.000000000","message":"Found the ref link.  Will add.","commit_id":"c76b4403ce9003c47cecc24255a432f1319ab24f"},{"author":{"_account_id":23186,"name":"Felipe Monteiro","email":"felipe.carneiro.monteiro@gmail.com","username":"felipe.monteiro"},"change_message_id":"d63e0608e99dd53cfdd195022729f514259b597e","unresolved":false,"context_lines":[{"line_number":20,"context_line":"\r"},{"line_number":21,"context_line":"class EndPointGroupsClient(rest_client.RestClient):\r"},{"line_number":22,"context_line":"    api_version \u003d \"v3\"\r"},{"line_number":23,"context_line":"\r"},{"line_number":24,"context_line":"    def create_endpoint_group(self, **kwargs):\r"},{"line_number":25,"context_line":"        \"\"\"Create endpoint group.\"\"\"\r"},{"line_number":26,"context_line":"        post_body \u003d json.dumps({\u0027endpoint_group\u0027: kwargs})\r"}],"source_content_type":"text/x-python","patch_set":3,"id":"3f044301_15670250","line":23,"updated":"2017-05-04 19:19:12.000000000","message":"You\u0027re missing check_endpoint_group: https://developer.openstack.org/api-ref/identity/v3-ext/#check-endpoint-group","commit_id":"f787f90a3a1a3739eefbe1070184a7a79aadd34a"},{"author":{"_account_id":19391,"name":"Chi Lo","email":"cl566n@att.com","username":"cl566n"},"change_message_id":"89f472b19b8b09470e4a3ef9ab145ccb568c4710","unresolved":false,"context_lines":[{"line_number":20,"context_line":"\r"},{"line_number":21,"context_line":"class EndPointGroupsClient(rest_client.RestClient):\r"},{"line_number":22,"context_line":"    api_version \u003d \"v3\"\r"},{"line_number":23,"context_line":"\r"},{"line_number":24,"context_line":"    def create_endpoint_group(self, **kwargs):\r"},{"line_number":25,"context_line":"        \"\"\"Create endpoint group.\"\"\"\r"},{"line_number":26,"context_line":"        post_body \u003d json.dumps({\u0027endpoint_group\u0027: kwargs})\r"}],"source_content_type":"text/x-python","patch_set":3,"id":"3f044301_b8ab9b1b","line":23,"in_reply_to":"3f044301_15670250","updated":"2017-05-05 04:58:36.000000000","message":"Will add.","commit_id":"f787f90a3a1a3739eefbe1070184a7a79aadd34a"},{"author":{"_account_id":23186,"name":"Felipe Monteiro","email":"felipe.carneiro.monteiro@gmail.com","username":"felipe.monteiro"},"change_message_id":"d63e0608e99dd53cfdd195022729f514259b597e","unresolved":false,"context_lines":[{"line_number":22,"context_line":"    api_version \u003d \"v3\"\r"},{"line_number":23,"context_line":"\r"},{"line_number":24,"context_line":"    def create_endpoint_group(self, **kwargs):\r"},{"line_number":25,"context_line":"        \"\"\"Create endpoint group.\"\"\"\r"},{"line_number":26,"context_line":"        post_body \u003d json.dumps({\u0027endpoint_group\u0027: kwargs})\r"},{"line_number":27,"context_line":"        resp, body \u003d self.post(\u0027OS-EP-FILTER/endpoint_groups\u0027, post_body)\r"},{"line_number":28,"context_line":"        self.expected_success(201, resp.status)\r"}],"source_content_type":"text/x-python","patch_set":3,"id":"3f044301_b53e0e27","line":25,"range":{"start_line":25,"start_character":8,"end_line":25,"end_character":36},"updated":"2017-05-04 19:19:12.000000000","message":"The following type of docstring is better (as was suggested in PS1). It should be used to link user to docs where they can learn more about which parameters can be specified in **kwargs.\n\n\"\"\"Create endpoint group.\n\nFor a full list of available parameters, please refer to the official API reference:\nhttps://developer.openstack.org/api-ref/identity/v3-ext/#create-endpoint-group\n\"\"\"","commit_id":"f787f90a3a1a3739eefbe1070184a7a79aadd34a"},{"author":{"_account_id":19391,"name":"Chi Lo","email":"cl566n@att.com","username":"cl566n"},"change_message_id":"89f472b19b8b09470e4a3ef9ab145ccb568c4710","unresolved":false,"context_lines":[{"line_number":22,"context_line":"    api_version \u003d \"v3\"\r"},{"line_number":23,"context_line":"\r"},{"line_number":24,"context_line":"    def create_endpoint_group(self, **kwargs):\r"},{"line_number":25,"context_line":"        \"\"\"Create endpoint group.\"\"\"\r"},{"line_number":26,"context_line":"        post_body \u003d json.dumps({\u0027endpoint_group\u0027: kwargs})\r"},{"line_number":27,"context_line":"        resp, body \u003d self.post(\u0027OS-EP-FILTER/endpoint_groups\u0027, post_body)\r"},{"line_number":28,"context_line":"        self.expected_success(201, resp.status)\r"}],"source_content_type":"text/x-python","patch_set":3,"id":"3f044301_e7c06d53","line":25,"range":{"start_line":25,"start_character":8,"end_line":25,"end_character":36},"in_reply_to":"3f044301_b53e0e27","updated":"2017-05-05 04:58:36.000000000","message":"Thanks for the link.  Will add it here.","commit_id":"f787f90a3a1a3739eefbe1070184a7a79aadd34a"},{"author":{"_account_id":6167,"name":"Ken\u0027ichi Ohmichi","email":"ken1ohmichi@gmail.com","username":"oomichi"},"change_message_id":"935a98a487c6029b9a586b136d686bd0e6010fe9","unresolved":false,"context_lines":[{"line_number":18,"context_line":"from tempest.lib.common import rest_client\r"},{"line_number":19,"context_line":"\r"},{"line_number":20,"context_line":"\r"},{"line_number":21,"context_line":"class EndPointGroupsClient(rest_client.RestClient):\r"},{"line_number":22,"context_line":"    api_version \u003d \"v3\"\r"},{"line_number":23,"context_line":"\r"},{"line_number":24,"context_line":"    def create_endpoint_group(self, **kwargs):\r"}],"source_content_type":"text/x-python","patch_set":10,"id":"df140735_539a80b8","line":21,"range":{"start_line":21,"start_character":6,"end_line":21,"end_character":26},"updated":"2017-06-05 22:26:48.000000000","message":"oh, that is really nit, but it is hard to fix it later..\n\ns/EndPointGgoupsClient/EndpointGroupsClient)/\n\n -\u003e s/P/p/","commit_id":"d0ed8b00d089c37e518bcdf77420c4b5278b05f9"},{"author":{"_account_id":19391,"name":"Chi Lo","email":"cl566n@att.com","username":"cl566n"},"change_message_id":"3b50ef8f963243a19712d5123151e4d269262f54","unresolved":false,"context_lines":[{"line_number":18,"context_line":"from tempest.lib.common import rest_client\r"},{"line_number":19,"context_line":"\r"},{"line_number":20,"context_line":"\r"},{"line_number":21,"context_line":"class EndPointGroupsClient(rest_client.RestClient):\r"},{"line_number":22,"context_line":"    api_version \u003d \"v3\"\r"},{"line_number":23,"context_line":"\r"},{"line_number":24,"context_line":"    def create_endpoint_group(self, **kwargs):\r"}],"source_content_type":"text/x-python","patch_set":10,"id":"df140735_b8e4fe3c","line":21,"range":{"start_line":21,"start_character":6,"end_line":21,"end_character":26},"in_reply_to":"df140735_539a80b8","updated":"2017-06-06 15:17:04.000000000","message":"The are two existing classes \"class EndPointsFilterClient\" and \"EndPointsClient\" in endpoint_filter_client.py and endpoints_client.py respectively which have the upper case \"P\" as in Points.\n\nDoing this change will make these files inconsistent. Please confirm if you really want to change from upper case \"P\" to lower case \"p\".","commit_id":"d0ed8b00d089c37e518bcdf77420c4b5278b05f9"},{"author":{"_account_id":6167,"name":"Ken\u0027ichi Ohmichi","email":"ken1ohmichi@gmail.com","username":"oomichi"},"change_message_id":"3c579e688e0a02ea74e065bc551bd08bffc45610","unresolved":false,"context_lines":[{"line_number":18,"context_line":"from tempest.lib.common import rest_client\r"},{"line_number":19,"context_line":"\r"},{"line_number":20,"context_line":"\r"},{"line_number":21,"context_line":"class EndPointGroupsClient(rest_client.RestClient):\r"},{"line_number":22,"context_line":"    api_version \u003d \"v3\"\r"},{"line_number":23,"context_line":"\r"},{"line_number":24,"context_line":"    def create_endpoint_group(self, **kwargs):\r"}],"source_content_type":"text/x-python","patch_set":10,"id":"df140735_99293b9d","line":21,"range":{"start_line":21,"start_character":6,"end_line":21,"end_character":26},"in_reply_to":"df140735_b8e4fe3c","updated":"2017-06-06 17:08:54.000000000","message":"Oh, that is not good.. OK, it is fair enough to keep this for the consistency in endpoint_***_client modules..","commit_id":"d0ed8b00d089c37e518bcdf77420c4b5278b05f9"},{"author":{"_account_id":20190,"name":"zhufl","email":"zhu.fanglei@zte.com.cn","username":"zhufl"},"change_message_id":"5578580a7bc9706d6adfad476577d81742424384","unresolved":false,"context_lines":[{"line_number":71,"context_line":"        return rest_client.ResponseBody(resp_header, resp_body)\r"},{"line_number":72,"context_line":"\r"},{"line_number":73,"context_line":"    def list_endpoint_groups(self):\r"},{"line_number":74,"context_line":"        \"\"\"Get endpoint groups.\"\"\"\r"},{"line_number":75,"context_line":"        resp_header, resp_body \u003d self.get(\u0027OS-EP-FILTER/endpoint_groups\u0027)\r"},{"line_number":76,"context_line":"        self.expected_success(200, resp_header.status)\r"},{"line_number":77,"context_line":"        resp_body \u003d json.loads(resp_body)\r"}],"source_content_type":"text/x-python","patch_set":10,"id":"7f231b9d_04ab7475","line":74,"range":{"start_line":74,"start_character":11,"end_line":74,"end_character":14},"updated":"2017-06-20 06:19:10.000000000","message":"nit: List","commit_id":"d0ed8b00d089c37e518bcdf77420c4b5278b05f9"}],"tempest/tests/lib/services/identity/v3/test_endpoint_groups_client.py":[{"author":{"_account_id":23186,"name":"Felipe Monteiro","email":"felipe.carneiro.monteiro@gmail.com","username":"felipe.monteiro"},"change_message_id":"d63e0608e99dd53cfdd195022729f514259b597e","unresolved":false,"context_lines":[{"line_number":73,"context_line":"            \u0027tempest.lib.common.rest_client.RestClient.get\u0027,\r"},{"line_number":74,"context_line":"            self.FAKE_LIST_ENDPOINT_GROUPS,\r"},{"line_number":75,"context_line":"            bytes_body)\r"},{"line_number":76,"context_line":"\r"},{"line_number":77,"context_line":"    def test_create_endpoint_group_with_str_body(self):\r"},{"line_number":78,"context_line":"        self._test_create_endpoint_group()\r"},{"line_number":79,"context_line":"\r"}],"source_content_type":"text/x-python","patch_set":3,"id":"3f044301_d5d51abb","line":76,"updated":"2017-05-04 19:19:12.000000000","message":"Also add tests for check_endpoint_group.","commit_id":"f787f90a3a1a3739eefbe1070184a7a79aadd34a"},{"author":{"_account_id":19391,"name":"Chi Lo","email":"cl566n@att.com","username":"cl566n"},"change_message_id":"89f472b19b8b09470e4a3ef9ab145ccb568c4710","unresolved":false,"context_lines":[{"line_number":73,"context_line":"            \u0027tempest.lib.common.rest_client.RestClient.get\u0027,\r"},{"line_number":74,"context_line":"            self.FAKE_LIST_ENDPOINT_GROUPS,\r"},{"line_number":75,"context_line":"            bytes_body)\r"},{"line_number":76,"context_line":"\r"},{"line_number":77,"context_line":"    def test_create_endpoint_group_with_str_body(self):\r"},{"line_number":78,"context_line":"        self._test_create_endpoint_group()\r"},{"line_number":79,"context_line":"\r"}],"source_content_type":"text/x-python","patch_set":3,"id":"3f044301_18728fe6","line":76,"in_reply_to":"3f044301_d5d51abb","updated":"2017-05-05 04:58:36.000000000","message":"Will add.","commit_id":"f787f90a3a1a3739eefbe1070184a7a79aadd34a"}]}