)]}'
{"tempest/api/compute/servers/test_servers_negative.py":[{"author":{"_account_id":7350,"name":"Jordan Pittier","email":"jordan.pittier@gmail.com","username":"JordanP"},"change_message_id":"f67717bf7dad3f9e612c763809d414c69c323a33","unresolved":false,"context_lines":[{"line_number":49,"context_line":"        cls.client \u003d cls.servers_client"},{"line_number":50,"context_line":""},{"line_number":51,"context_line":"    @classmethod"},{"line_number":52,"context_line":"    def resource_setup(cls):"},{"line_number":53,"context_line":"        super(ServersNegativeTestJSON, cls).resource_setup()"},{"line_number":54,"context_line":"        # this is faster than doing the sync wait_util on both servers."},{"line_number":55,"context_line":"        server \u003d cls.create_test_server()"}],"source_content_type":"text/x-python","patch_set":1,"id":"1f013ff3_e7476dbc","line":52,"updated":"2017-05-13 08:50:07.000000000","message":"This changes nothing because common/compute.py, we have:\n\n        if CONF.validation.connect_method \u003d\u003d \u0027floating\u0027:\n            if wait_until is None:\n                wait_until \u003d \u0027ACTIVE\u0027","commit_id":"7eb13909d35eee32d9e29934aa770d4159ce3bdc"},{"author":{"_account_id":20190,"name":"zhufl","email":"zhu.fanglei@zte.com.cn","username":"zhufl"},"change_message_id":"74f5fa24ca7ff28a02ecd793142e766d6e1afdfd","unresolved":false,"context_lines":[{"line_number":49,"context_line":"        cls.client \u003d cls.servers_client"},{"line_number":50,"context_line":""},{"line_number":51,"context_line":"    @classmethod"},{"line_number":52,"context_line":"    def resource_setup(cls):"},{"line_number":53,"context_line":"        super(ServersNegativeTestJSON, cls).resource_setup()"},{"line_number":54,"context_line":"        # this is faster than doing the sync wait_util on both servers."},{"line_number":55,"context_line":"        server \u003d cls.create_test_server()"}],"source_content_type":"text/x-python","patch_set":1,"id":"1f013ff3_6104607c","line":52,"in_reply_to":"1f013ff3_e7476dbc","updated":"2017-05-15 05:26:45.000000000","message":"Thanks Jordan, I didn\u0027t notice this detail before. \nAnd it seems this code logic is only included in the branch where validatable\u003dTrue?","commit_id":"7eb13909d35eee32d9e29934aa770d4159ce3bdc"},{"author":{"_account_id":8556,"name":"Ghanshyam Maan","display_name":"Ghanshyam Maan","email":"gmaan.os14@gmail.com","username":"ghanshyam"},"change_message_id":"5c04e54682909c0558845f5c04a4f6db5c6783d4","unresolved":false,"context_lines":[{"line_number":55,"context_line":"        server \u003d cls.create_test_server()"},{"line_number":56,"context_line":"        cls.server_id \u003d server[\u0027id\u0027]"},{"line_number":57,"context_line":""},{"line_number":58,"context_line":"        server \u003d cls.create_test_server(wait_until\u003d\u0027ACTIVE\u0027)"},{"line_number":59,"context_line":"        cls.client.delete_server(server[\u0027id\u0027])"},{"line_number":60,"context_line":"        waiters.wait_for_server_termination(cls.client, server[\u0027id\u0027])"},{"line_number":61,"context_line":"        cls.deleted_server_id \u003d server[\u0027id\u0027]"}],"source_content_type":"text/x-python","patch_set":1,"id":"ff0f0b1f_c89b1bc7","line":58,"range":{"start_line":58,"start_character":40,"end_line":58,"end_character":59},"updated":"2017-05-19 02:37:23.000000000","message":"i prefer not to wait till ACTIVE for this as this is going to be deleted immediately. Done like in original case.","commit_id":"7eb13909d35eee32d9e29934aa770d4159ce3bdc"},{"author":{"_account_id":20190,"name":"zhufl","email":"zhu.fanglei@zte.com.cn","username":"zhufl"},"change_message_id":"fa6006109188bf3cffe0b0a5a0d8f2aafb0ec383","unresolved":false,"context_lines":[{"line_number":55,"context_line":"        server \u003d cls.create_test_server()"},{"line_number":56,"context_line":"        cls.server_id \u003d server[\u0027id\u0027]"},{"line_number":57,"context_line":""},{"line_number":58,"context_line":"        server \u003d cls.create_test_server(wait_until\u003d\u0027ACTIVE\u0027)"},{"line_number":59,"context_line":"        cls.client.delete_server(server[\u0027id\u0027])"},{"line_number":60,"context_line":"        waiters.wait_for_server_termination(cls.client, server[\u0027id\u0027])"},{"line_number":61,"context_line":"        cls.deleted_server_id \u003d server[\u0027id\u0027]"}],"source_content_type":"text/x-python","patch_set":1,"id":"ff0f0b1f_0b646de3","line":58,"range":{"start_line":58,"start_character":40,"end_line":58,"end_character":59},"in_reply_to":"ff0f0b1f_c89b1bc7","updated":"2017-05-19 03:31:55.000000000","message":"Thanks Ghanshyam, some environments are possible to fail when deleting server immediately after creating. \nBut I agree that shouldn\u0027t be common situation, so I\u0027ll modify it","commit_id":"7eb13909d35eee32d9e29934aa770d4159ce3bdc"},{"author":{"_account_id":23186,"name":"Felipe Monteiro","email":"felipe.carneiro.monteiro@gmail.com","username":"felipe.monteiro"},"change_message_id":"24c528667cddc09481ad9c71a618786284d81be8","unresolved":false,"context_lines":[{"line_number":60,"context_line":"        waiters.wait_for_server_termination(cls.client, server[\u0027id\u0027])"},{"line_number":61,"context_line":"        cls.deleted_server_id \u003d server[\u0027id\u0027]"},{"line_number":62,"context_line":""},{"line_number":63,"context_line":"        waiters.wait_for_server_status(cls.client, cls.server_id, \u0027ACTIVE\u0027)"},{"line_number":64,"context_line":""},{"line_number":65,"context_line":"    @decorators.attr(type\u003d[\u0027negative\u0027])"},{"line_number":66,"context_line":"    @decorators.idempotent_id(\u0027dbbfd247-c40c-449e-8f6c-d2aa7c7da7cf\u0027)"}],"source_content_type":"text/x-python","patch_set":1,"id":"ff0f0b1f_bcfe1b03","line":63,"range":{"start_line":63,"start_character":8,"end_line":63,"end_character":75},"updated":"2017-05-17 20:32:05.000000000","message":"Can\u0027t you just do: server \u003d cls.create_test_server(wait_until\u003d\u0027ACTIVE\u0027) on L55 and remove this?","commit_id":"7eb13909d35eee32d9e29934aa770d4159ce3bdc"},{"author":{"_account_id":20190,"name":"zhufl","email":"zhu.fanglei@zte.com.cn","username":"zhufl"},"change_message_id":"d5a92d375e2aa104de784d09ab42ccc266fbf6f7","unresolved":false,"context_lines":[{"line_number":60,"context_line":"        waiters.wait_for_server_termination(cls.client, server[\u0027id\u0027])"},{"line_number":61,"context_line":"        cls.deleted_server_id \u003d server[\u0027id\u0027]"},{"line_number":62,"context_line":""},{"line_number":63,"context_line":"        waiters.wait_for_server_status(cls.client, cls.server_id, \u0027ACTIVE\u0027)"},{"line_number":64,"context_line":""},{"line_number":65,"context_line":"    @decorators.attr(type\u003d[\u0027negative\u0027])"},{"line_number":66,"context_line":"    @decorators.idempotent_id(\u0027dbbfd247-c40c-449e-8f6c-d2aa7c7da7cf\u0027)"}],"source_content_type":"text/x-python","patch_set":1,"id":"ff0f0b1f_a5083728","line":63,"range":{"start_line":63,"start_character":8,"end_line":63,"end_character":75},"in_reply_to":"ff0f0b1f_bcfe1b03","updated":"2017-05-18 01:47:48.000000000","message":"Because this is faster than create_server-\u003ewait_active-\u003e create_server-\u003ewait_active, see comment in #L54","commit_id":"7eb13909d35eee32d9e29934aa770d4159ce3bdc"}]}