)]}'
{"/COMMIT_MSG":[{"author":{"_account_id":23186,"name":"Felipe Monteiro","email":"felipe.carneiro.monteiro@gmail.com","username":"felipe.monteiro"},"change_message_id":"8cd30e626c51d0e4b9ca9fe01caafb434067eaa6","unresolved":false,"context_lines":[{"line_number":16,"context_line":"2. delete server in RESCUE status directly without unrescue it"},{"line_number":17,"context_line":"   in resource_cleanup"},{"line_number":18,"context_line":"3. move setup of floating ip and security groups from resource_setup"},{"line_number":19,"context_line":"   to inside the testcases because they are used only onece"},{"line_number":20,"context_line":"4. change the skip condition from CONF.network.public_network_id"},{"line_number":21,"context_line":"   to CONF.network.floating_network_name"},{"line_number":22,"context_line":""}],"source_content_type":"text/x-gerrit-commit-message","patch_set":1,"id":"3f044301_1380ccbf","line":19,"range":{"start_line":19,"start_character":54,"end_line":19,"end_character":59},"updated":"2017-05-10 23:31:33.000000000","message":"once","commit_id":"d24bcfcb6a66058a1f1926ab3c7503e6165f20d5"},{"author":{"_account_id":20190,"name":"zhufl","email":"zhu.fanglei@zte.com.cn","username":"zhufl"},"change_message_id":"05c2bf053b37e34e054e61f9ae833b580b85d775","unresolved":false,"context_lines":[{"line_number":16,"context_line":"2. delete server in RESCUE status directly without unrescue it"},{"line_number":17,"context_line":"   in resource_cleanup"},{"line_number":18,"context_line":"3. move setup of floating ip and security groups from resource_setup"},{"line_number":19,"context_line":"   to inside the testcases because they are used only onece"},{"line_number":20,"context_line":"4. change the skip condition from CONF.network.public_network_id"},{"line_number":21,"context_line":"   to CONF.network.floating_network_name"},{"line_number":22,"context_line":""}],"source_content_type":"text/x-gerrit-commit-message","patch_set":1,"id":"3f044301_25e81f7a","line":19,"range":{"start_line":19,"start_character":54,"end_line":19,"end_character":59},"in_reply_to":"3f044301_1380ccbf","updated":"2017-05-11 01:58:47.000000000","message":"Thanks, done","commit_id":"d24bcfcb6a66058a1f1926ab3c7503e6165f20d5"}],"tempest/api/compute/servers/test_server_rescue.py":[{"author":{"_account_id":23186,"name":"Felipe Monteiro","email":"felipe.carneiro.monteiro@gmail.com","username":"felipe.monteiro"},"change_message_id":"8cd30e626c51d0e4b9ca9fe01caafb434067eaa6","unresolved":false,"context_lines":[{"line_number":45,"context_line":"        password \u003d data_utils.rand_password()"},{"line_number":46,"context_line":"        server \u003d cls.create_test_server(adminPass\u003dpassword,"},{"line_number":47,"context_line":"                                        wait_until\u003d\u0027ACTIVE\u0027)"},{"line_number":48,"context_line":"        cls.servers_client.rescue_server(server[\u0027id\u0027], adminPass\u003dpassword)"},{"line_number":49,"context_line":"        waiters.wait_for_server_status(cls.servers_client, server[\u0027id\u0027],"},{"line_number":50,"context_line":"                                       \u0027RESCUE\u0027)"},{"line_number":51,"context_line":"        cls.rescued_server_id \u003d server[\u0027id\u0027]"}],"source_content_type":"text/x-python","patch_set":1,"id":"3f044301_936bbc1c","line":48,"range":{"start_line":48,"start_character":54,"end_line":48,"end_character":73},"updated":"2017-05-10 23:31:33.000000000","message":"This is an optional param [0], but if it\u0027s included, why not assert that the rescued server has adminPass\u003dpassword?\n\n[0] https://developer.openstack.org/api-ref/compute/#rescue-server-rescue-action","commit_id":"d24bcfcb6a66058a1f1926ab3c7503e6165f20d5"},{"author":{"_account_id":20190,"name":"zhufl","email":"zhu.fanglei@zte.com.cn","username":"zhufl"},"change_message_id":"05c2bf053b37e34e054e61f9ae833b580b85d775","unresolved":false,"context_lines":[{"line_number":45,"context_line":"        password \u003d data_utils.rand_password()"},{"line_number":46,"context_line":"        server \u003d cls.create_test_server(adminPass\u003dpassword,"},{"line_number":47,"context_line":"                                        wait_until\u003d\u0027ACTIVE\u0027)"},{"line_number":48,"context_line":"        cls.servers_client.rescue_server(server[\u0027id\u0027], adminPass\u003dpassword)"},{"line_number":49,"context_line":"        waiters.wait_for_server_status(cls.servers_client, server[\u0027id\u0027],"},{"line_number":50,"context_line":"                                       \u0027RESCUE\u0027)"},{"line_number":51,"context_line":"        cls.rescued_server_id \u003d server[\u0027id\u0027]"}],"source_content_type":"text/x-python","patch_set":1,"id":"3f044301_c5029b3d","line":48,"range":{"start_line":48,"start_character":54,"end_line":48,"end_character":73},"in_reply_to":"3f044301_936bbc1c","updated":"2017-05-11 01:58:47.000000000","message":"Thanks, in the original code, adminPass is used in rescue_server, and here I just keep the code logic unchanged.","commit_id":"d24bcfcb6a66058a1f1926ab3c7503e6165f20d5"},{"author":{"_account_id":23186,"name":"Felipe Monteiro","email":"felipe.carneiro.monteiro@gmail.com","username":"felipe.monteiro"},"change_message_id":"8cd30e626c51d0e4b9ca9fe01caafb434067eaa6","unresolved":false,"context_lines":[{"line_number":64,"context_line":""},{"line_number":65,"context_line":"    @decorators.idempotent_id(\u00274842e0cf-e87d-4d9d-b61f-f4791da3cacc\u0027)"},{"line_number":66,"context_line":"    @testtools.skipUnless(CONF.network.floating_network_name,"},{"line_number":67,"context_line":"                          \u0027The public_network_id option must be specified.\u0027)"},{"line_number":68,"context_line":"    def test_rescued_vm_associate_dissociate_floating_ip(self):"},{"line_number":69,"context_line":"        # Association of floating IP to a rescued vm"},{"line_number":70,"context_line":"        floating_ip_body \u003d self.floating_ips_client.create_floating_ip("}],"source_content_type":"text/x-python","patch_set":1,"id":"3f044301_531c14c0","line":67,"range":{"start_line":67,"start_character":31,"end_line":67,"end_character":48},"updated":"2017-05-10 23:31:33.000000000","message":"floating_network_name","commit_id":"d24bcfcb6a66058a1f1926ab3c7503e6165f20d5"},{"author":{"_account_id":20190,"name":"zhufl","email":"zhu.fanglei@zte.com.cn","username":"zhufl"},"change_message_id":"05c2bf053b37e34e054e61f9ae833b580b85d775","unresolved":false,"context_lines":[{"line_number":64,"context_line":""},{"line_number":65,"context_line":"    @decorators.idempotent_id(\u00274842e0cf-e87d-4d9d-b61f-f4791da3cacc\u0027)"},{"line_number":66,"context_line":"    @testtools.skipUnless(CONF.network.floating_network_name,"},{"line_number":67,"context_line":"                          \u0027The public_network_id option must be specified.\u0027)"},{"line_number":68,"context_line":"    def test_rescued_vm_associate_dissociate_floating_ip(self):"},{"line_number":69,"context_line":"        # Association of floating IP to a rescued vm"},{"line_number":70,"context_line":"        floating_ip_body \u003d self.floating_ips_client.create_floating_ip("}],"source_content_type":"text/x-python","patch_set":1,"id":"3f044301_25b6df8b","line":67,"range":{"start_line":67,"start_character":31,"end_line":67,"end_character":48},"in_reply_to":"3f044301_531c14c0","updated":"2017-05-11 01:58:47.000000000","message":"Here seems exist inconsistency, but there are some other similar occurrences, so I\u0027d deal with it in other patches","commit_id":"d24bcfcb6a66058a1f1926ab3c7503e6165f20d5"}]}
