)]}'
{"tempest/api/volume/base.py":[{"author":{"_account_id":11075,"name":"Benny Kopilov","email":"bkopilov@redhat.com","username":"bkopilov"},"change_message_id":"b1e797aa0e74be95def730f26dc4eed5e3d6ff31","unresolved":false,"context_lines":[{"line_number":215,"context_line":"            try:"},{"line_number":216,"context_line":"                delete_resource(resource)"},{"line_number":217,"context_line":"            except Exception:"},{"line_number":218,"context_line":"                pass"},{"line_number":219,"context_line":"        for resource in resource_list:"},{"line_number":220,"context_line":"            try:"},{"line_number":221,"context_line":"                resource_client.wait_for_resource_deletion(resource)"}],"source_content_type":"text/x-python","patch_set":1,"id":"ff0f0b1f_dc278164","line":218,"updated":"2017-05-18 08:03:04.000000000","message":"Hi Liron , \nI think that catch exception with \"pass\" its a bad practice.\nLooks like we need to fix the pass options , it might hide problems during delete actions.","commit_id":"bf3adfbb96c16283b3ac1a6f12c22023087d3ab1"},{"author":{"_account_id":19262,"name":"Liron Kuchlani","email":"lkuchlan@redhat.com","username":"lkuchlan"},"change_message_id":"505a2db325bbca5639811365d6500c028ac1541d","unresolved":false,"context_lines":[{"line_number":215,"context_line":"            try:"},{"line_number":216,"context_line":"                delete_resource(resource)"},{"line_number":217,"context_line":"            except Exception:"},{"line_number":218,"context_line":"                pass"},{"line_number":219,"context_line":"        for resource in resource_list:"},{"line_number":220,"context_line":"            try:"},{"line_number":221,"context_line":"                resource_client.wait_for_resource_deletion(resource)"}],"source_content_type":"text/x-python","patch_set":1,"id":"ff0f0b1f_7d274c14","line":218,"in_reply_to":"ff0f0b1f_dc278164","updated":"2017-05-18 11:24:16.000000000","message":"Right, I\u0027ll use call_and_ignore_notfound_exc function\nthat ignore only NotFound exception.","commit_id":"bf3adfbb96c16283b3ac1a6f12c22023087d3ab1"},{"author":{"_account_id":6167,"name":"Ken\u0027ichi Ohmichi","email":"ken1ohmichi@gmail.com","username":"oomichi"},"change_message_id":"bb5bbb8bfa664b315c13143d408b4bf7eeba83b7","unresolved":false,"context_lines":[{"line_number":203,"context_line":"        Note: this method doesn\u0027t support volume backup deletion since backup"},{"line_number":204,"context_line":"        creation is not a class method."},{"line_number":205,"context_line":"        \"\"\""},{"line_number":206,"context_line":"        resource_name \u003d re.findall("},{"line_number":207,"context_line":"            r\u0027(Volume|Snapshot|Qos|Type)\u0027,"},{"line_number":208,"context_line":"            resource_client.__class__.__name__)[0].lower()"},{"line_number":209,"context_line":""},{"line_number":210,"context_line":"        if resource_name \u003d\u003d \u0027type\u0027:"},{"line_number":211,"context_line":"            resource_name \u003d \u0027volume_type\u0027"},{"line_number":212,"context_line":"        delete_resource \u003d getattr(resource_client, \u0027delete_\u0027 + resource_name)"},{"line_number":213,"context_line":""},{"line_number":214,"context_line":"        for resource in resource_list:"},{"line_number":215,"context_line":"            test_utils.call_and_ignore_notfound_exc(delete_resource, resource)"}],"source_content_type":"text/x-python","patch_set":3,"id":"ff0f0b1f_9152793a","line":212,"range":{"start_line":206,"start_character":0,"end_line":212,"end_character":77},"updated":"2017-05-23 19:12:57.000000000","message":"I can see the merit of this patch which reduces the code itself so much. That is good thing, but this patch adds a small magic like the above and that thing could make debugging a little difficult sometimes. I am not against this patch, but I am not so big fun to do that.","commit_id":"26141f782927f120a6b5d9b2e5409b1790ff790b"},{"author":{"_account_id":20190,"name":"zhufl","email":"zhu.fanglei@zte.com.cn","username":"zhufl"},"change_message_id":"11c82ee748f5a95b751554517d924b46c49e4986","unresolved":false,"context_lines":[{"line_number":203,"context_line":"        Note: this method doesn\u0027t support volume backup deletion since backup"},{"line_number":204,"context_line":"        creation is not a class method."},{"line_number":205,"context_line":"        \"\"\""},{"line_number":206,"context_line":"        resource_name \u003d re.findall("},{"line_number":207,"context_line":"            r\u0027(Volume|Snapshot|Qos|Type)\u0027,"},{"line_number":208,"context_line":"            resource_client.__class__.__name__)[0].lower()"},{"line_number":209,"context_line":""},{"line_number":210,"context_line":"        if resource_name \u003d\u003d \u0027type\u0027:"},{"line_number":211,"context_line":"            resource_name \u003d \u0027volume_type\u0027"},{"line_number":212,"context_line":"        delete_resource \u003d getattr(resource_client, \u0027delete_\u0027 + resource_name)"},{"line_number":213,"context_line":""},{"line_number":214,"context_line":"        for resource in resource_list:"},{"line_number":215,"context_line":"            test_utils.call_and_ignore_notfound_exc(delete_resource, resource)"}],"source_content_type":"text/x-python","patch_set":3,"id":"ff0f0b1f_4f3aea98","line":212,"range":{"start_line":206,"start_character":0,"end_line":212,"end_character":77},"in_reply_to":"ff0f0b1f_9152793a","updated":"2017-05-24 06:45:09.000000000","message":"Yea I have the same feeling.\nI am thinking whether we can add a variable like \u0027delete_method\u0027 in volume related clients,\nand then we can remove the magic things.\nThis is the similar way as https://review.openstack.org/#/c/467483/","commit_id":"26141f782927f120a6b5d9b2e5409b1790ff790b"}]}