)]}'
{"tempest/scenario/test_encrypted_cinder_volumes.py":[{"author":{"_account_id":7350,"name":"Jordan Pittier","email":"jordan.pittier@gmail.com","username":"JordanP"},"change_message_id":"2e58a3e3bae324d36769f51ca4670238de45d250","unresolved":false,"context_lines":[{"line_number":47,"context_line":"        if not CONF.compute_feature_enabled.attach_encrypted_volume:"},{"line_number":48,"context_line":"            raise cls.skipException(\u0027Encrypted volume attach is not supported\u0027)"},{"line_number":49,"context_line":""},{"line_number":50,"context_line":"    def launch_instance(self, volume\u003dNone):"},{"line_number":51,"context_line":"        keypair \u003d self.create_keypair()"},{"line_number":52,"context_line":"        if volume:"},{"line_number":53,"context_line":"            bdm \u003d {\u0027block_device_mapping_v2\u0027:"}],"source_content_type":"text/x-python","patch_set":1,"id":"ff0f0b1f_5424cfae","line":50,"updated":"2017-05-23 19:17:17.000000000","message":"This introduces coupling and duplicate some code. Look for \u0027block_device_mapping_v2\u0027 in Tempest code base and try to reuse some code.","commit_id":"fcc1a71c9860631ad015f718a0eea4c1e23ed042"},{"author":{"_account_id":10135,"name":"Lee Yarwood","display_name":"Lee Yarwood","email":"lyarwood@redhat.com","username":"lyarwood"},"change_message_id":"9b26186375a08d512be083e9dd99a42a9993ec34","unresolved":false,"context_lines":[{"line_number":47,"context_line":"        if not CONF.compute_feature_enabled.attach_encrypted_volume:"},{"line_number":48,"context_line":"            raise cls.skipException(\u0027Encrypted volume attach is not supported\u0027)"},{"line_number":49,"context_line":""},{"line_number":50,"context_line":"    def launch_instance(self, volume\u003dNone):"},{"line_number":51,"context_line":"        keypair \u003d self.create_keypair()"},{"line_number":52,"context_line":"        if volume:"},{"line_number":53,"context_line":"            bdm \u003d {\u0027block_device_mapping_v2\u0027:"}],"source_content_type":"text/x-python","patch_set":1,"id":"ff0f0b1f_692243bb","line":50,"in_reply_to":"ff0f0b1f_5424cfae","updated":"2017-05-24 12:23:39.000000000","message":"No, it does not. If anything this is removing duplicate lines from the two tests that have been added. There are also no common utility methods provided within tempest for building this dict AFAICT, happy to add them but there\u0027s nothing I can find at the moment.","commit_id":"fcc1a71c9860631ad015f718a0eea4c1e23ed042"},{"author":{"_account_id":7350,"name":"Jordan Pittier","email":"jordan.pittier@gmail.com","username":"JordanP"},"change_message_id":"2e58a3e3bae324d36769f51ca4670238de45d250","unresolved":false,"context_lines":[{"line_number":78,"context_line":"    @decorators.idempotent_id(\u00270058f45d-b65d-47e9-8080-ad39b589f564\u0027)"},{"line_number":79,"context_line":"    @decorators.attr(type\u003d\u0027slow\u0027)"},{"line_number":80,"context_line":"    @test.services(\u0027compute\u0027, \u0027volume\u0027)"},{"line_number":81,"context_line":"    def test_boot_from_encrypted_cinder_volumes_luks(self):"},{"line_number":82,"context_line":"        volume \u003d self.create_encrypted_volume(\u0027nova.volume.encryptors.\u0027"},{"line_number":83,"context_line":"                                              \u0027luks.LuksEncryptor\u0027,"},{"line_number":84,"context_line":"                                              volume_type\u003d\u0027luks\u0027)"}],"source_content_type":"text/x-python","patch_set":1,"id":"ff0f0b1f_7111255d","line":81,"updated":"2017-05-23 19:17:17.000000000","message":"These 2 tests are very specific/test a corner case. And too slow to ever be considered for running in the integrated gate.\n\nI think you should propose them in a Tempest plugin, and/or in the Cinder repo.","commit_id":"fcc1a71c9860631ad015f718a0eea4c1e23ed042"},{"author":{"_account_id":10135,"name":"Lee Yarwood","display_name":"Lee Yarwood","email":"lyarwood@redhat.com","username":"lyarwood"},"change_message_id":"9b26186375a08d512be083e9dd99a42a9993ec34","unresolved":false,"context_lines":[{"line_number":78,"context_line":"    @decorators.idempotent_id(\u00270058f45d-b65d-47e9-8080-ad39b589f564\u0027)"},{"line_number":79,"context_line":"    @decorators.attr(type\u003d\u0027slow\u0027)"},{"line_number":80,"context_line":"    @test.services(\u0027compute\u0027, \u0027volume\u0027)"},{"line_number":81,"context_line":"    def test_boot_from_encrypted_cinder_volumes_luks(self):"},{"line_number":82,"context_line":"        volume \u003d self.create_encrypted_volume(\u0027nova.volume.encryptors.\u0027"},{"line_number":83,"context_line":"                                              \u0027luks.LuksEncryptor\u0027,"},{"line_number":84,"context_line":"                                              volume_type\u003d\u0027luks\u0027)"}],"source_content_type":"text/x-python","patch_set":1,"id":"ff0f0b1f_94236ea7","line":81,"in_reply_to":"ff0f0b1f_7111255d","updated":"2017-05-24 12:23:39.000000000","message":"Honest question, is ~30 seconds considered slow?\n\nHappy to remove both of the cryptsetup tests here if that would help or remove them all entirely if they are still deemed too slow.\n\nFWIW I\u0027ve already ported this over to the Barbican plugin: \nhttps://review.openstack.org/#/c/466782/\n\nhttp://logs.openstack.org/82/466782/1/check/gate-barbican-simple-crypto-dsvm-tempest-ubuntu-xenial-nv/2e1cc68/console.html#_2017-05-22_16_19_22_748467","commit_id":"fcc1a71c9860631ad015f718a0eea4c1e23ed042"}]}