)]}'
{"tempest/api/volume/admin/test_volume_quota_classes.py":[{"author":{"_account_id":20190,"name":"zhufl","email":"zhu.fanglei@zte.com.cn","username":"zhufl"},"change_message_id":"1e06fa13b00dc6cfb7502f77c5a27c892267fa69","unresolved":false,"context_lines":[{"line_number":56,"context_line":"        body \u003d self.admin_quota_classes_client.show_quota_class_set("},{"line_number":57,"context_line":"            \u0027default\u0027)[\u0027quota_class_set\u0027]"},{"line_number":58,"context_line":""},{"line_number":59,"context_line":"        # Choose the quotas that maybe updated, temporarily excluding"},{"line_number":60,"context_line":"        # the quotas of specified volume types."},{"line_number":61,"context_line":"        update_kwargs \u003d {}"},{"line_number":62,"context_line":"        for key in body:"},{"line_number":63,"context_line":"            if key in QUOTA_KEYS:"}],"source_content_type":"text/x-python","patch_set":3,"id":"ff0f0b1f_31d8f47d","line":60,"range":{"start_line":59,"start_character":0,"end_line":60,"end_character":47},"updated":"2017-05-26 02:46:47.000000000","message":"This is a bit misleading, how about:\n# to include only specified quota keys, to avoid the conflict that \n# other testcases may update volume type quotas in concurrency running","commit_id":"6d2246aa073c46a2afa8baae78f787974b09dd7e"},{"author":{"_account_id":23081,"name":"Jeremy Zhang","email":"zhangjun_inspur@163.com","username":"jeremy.zhang"},"change_message_id":"d1f759efd63451da4fa88f6c4bc20b5d89e47dd6","unresolved":false,"context_lines":[{"line_number":56,"context_line":"        body \u003d self.admin_quota_classes_client.show_quota_class_set("},{"line_number":57,"context_line":"            \u0027default\u0027)[\u0027quota_class_set\u0027]"},{"line_number":58,"context_line":""},{"line_number":59,"context_line":"        # Choose the quotas that maybe updated, temporarily excluding"},{"line_number":60,"context_line":"        # the quotas of specified volume types."},{"line_number":61,"context_line":"        update_kwargs \u003d {}"},{"line_number":62,"context_line":"        for key in body:"},{"line_number":63,"context_line":"            if key in QUOTA_KEYS:"}],"source_content_type":"text/x-python","patch_set":3,"id":"ff0f0b1f_7c0c0394","line":60,"range":{"start_line":59,"start_character":0,"end_line":60,"end_character":47},"in_reply_to":"ff0f0b1f_31d8f47d","updated":"2017-05-26 03:39:10.000000000","message":"Yeah, it\u0027s much better, thanks","commit_id":"6d2246aa073c46a2afa8baae78f787974b09dd7e"},{"author":{"_account_id":20190,"name":"zhufl","email":"zhu.fanglei@zte.com.cn","username":"zhufl"},"change_message_id":"1e06fa13b00dc6cfb7502f77c5a27c892267fa69","unresolved":false,"context_lines":[{"line_number":58,"context_line":""},{"line_number":59,"context_line":"        # Choose the quotas that maybe updated, temporarily excluding"},{"line_number":60,"context_line":"        # the quotas of specified volume types."},{"line_number":61,"context_line":"        update_kwargs \u003d {}"},{"line_number":62,"context_line":"        for key in body:"},{"line_number":63,"context_line":"            if key in QUOTA_KEYS:"},{"line_number":64,"context_line":"                update_kwargs[key] \u003d body[key]"},{"line_number":65,"context_line":""},{"line_number":66,"context_line":"        # Restore the defaults when the test is done."},{"line_number":67,"context_line":"        self.addCleanup(self._restore_default_quotas, update_kwargs.copy())"}],"source_content_type":"text/x-python","patch_set":3,"id":"ff0f0b1f_116290d9","line":64,"range":{"start_line":61,"start_character":0,"end_line":64,"end_character":46},"updated":"2017-05-26 02:46:47.000000000","message":"this may be simplified as:\n    update_kwargs \u003d {key: body[key] for key in body if key in QUOTA_KEYS}","commit_id":"6d2246aa073c46a2afa8baae78f787974b09dd7e"},{"author":{"_account_id":23081,"name":"Jeremy Zhang","email":"zhangjun_inspur@163.com","username":"jeremy.zhang"},"change_message_id":"d1f759efd63451da4fa88f6c4bc20b5d89e47dd6","unresolved":false,"context_lines":[{"line_number":58,"context_line":""},{"line_number":59,"context_line":"        # Choose the quotas that maybe updated, temporarily excluding"},{"line_number":60,"context_line":"        # the quotas of specified volume types."},{"line_number":61,"context_line":"        update_kwargs \u003d {}"},{"line_number":62,"context_line":"        for key in body:"},{"line_number":63,"context_line":"            if key in QUOTA_KEYS:"},{"line_number":64,"context_line":"                update_kwargs[key] \u003d body[key]"},{"line_number":65,"context_line":""},{"line_number":66,"context_line":"        # Restore the defaults when the test is done."},{"line_number":67,"context_line":"        self.addCleanup(self._restore_default_quotas, update_kwargs.copy())"}],"source_content_type":"text/x-python","patch_set":3,"id":"ff0f0b1f_5c113fac","line":64,"range":{"start_line":61,"start_character":0,"end_line":64,"end_character":46},"in_reply_to":"ff0f0b1f_116290d9","updated":"2017-05-26 03:39:10.000000000","message":"Done, thanks","commit_id":"6d2246aa073c46a2afa8baae78f787974b09dd7e"},{"author":{"_account_id":20190,"name":"zhufl","email":"zhu.fanglei@zte.com.cn","username":"zhufl"},"change_message_id":"1e06fa13b00dc6cfb7502f77c5a27c892267fa69","unresolved":false,"context_lines":[{"line_number":69,"context_line":"        # Increment some of the values for updating the default quota class."},{"line_number":70,"context_line":"        # For safety, only items with value \u003e\u003d 0 will be updated, and items"},{"line_number":71,"context_line":"        # with value \u003c 0 (-1 means unlimited) will be ignored."},{"line_number":72,"context_line":"        for k, v in update_kwargs.items():"},{"line_number":73,"context_line":"            if v \u003e\u003d 0:"},{"line_number":74,"context_line":"                update_kwargs[k] \u003d v + 1"},{"line_number":75,"context_line":""}],"source_content_type":"text/x-python","patch_set":3,"id":"ff0f0b1f_d1dbf81e","line":72,"range":{"start_line":72,"start_character":12,"end_line":72,"end_character":16},"updated":"2017-05-26 02:46:47.000000000","message":"this previous \"quota, default\" seems clearer","commit_id":"6d2246aa073c46a2afa8baae78f787974b09dd7e"},{"author":{"_account_id":23081,"name":"Jeremy Zhang","email":"zhangjun_inspur@163.com","username":"jeremy.zhang"},"change_message_id":"d1f759efd63451da4fa88f6c4bc20b5d89e47dd6","unresolved":false,"context_lines":[{"line_number":69,"context_line":"        # Increment some of the values for updating the default quota class."},{"line_number":70,"context_line":"        # For safety, only items with value \u003e\u003d 0 will be updated, and items"},{"line_number":71,"context_line":"        # with value \u003c 0 (-1 means unlimited) will be ignored."},{"line_number":72,"context_line":"        for k, v in update_kwargs.items():"},{"line_number":73,"context_line":"            if v \u003e\u003d 0:"},{"line_number":74,"context_line":"                update_kwargs[k] \u003d v + 1"},{"line_number":75,"context_line":""}],"source_content_type":"text/x-python","patch_set":3,"id":"ff0f0b1f_fc1ff3b4","line":72,"range":{"start_line":72,"start_character":12,"end_line":72,"end_character":16},"in_reply_to":"ff0f0b1f_d1dbf81e","updated":"2017-05-26 03:39:10.000000000","message":"Ok, the \u0027quota, default\u0027 will be kept, :)","commit_id":"6d2246aa073c46a2afa8baae78f787974b09dd7e"},{"author":{"_account_id":20190,"name":"zhufl","email":"zhu.fanglei@zte.com.cn","username":"zhufl"},"change_message_id":"0f9afb3bb14490cf53131426daf4f54049f95274","unresolved":false,"context_lines":[{"line_number":56,"context_line":"        body \u003d self.admin_quota_classes_client.show_quota_class_set("},{"line_number":57,"context_line":"            \u0027default\u0027)[\u0027quota_class_set\u0027]"},{"line_number":58,"context_line":""},{"line_number":59,"context_line":"        # Note(jeremyZ) Only include specified quota keys and volume type"},{"line_number":60,"context_line":"        # quotas, to avoid the conflict that other tests may create or update"},{"line_number":61,"context_line":"        # volume type quotas in concurrency running."},{"line_number":62,"context_line":"        update_kwargs \u003d {key: body[key] for key in body if key in QUOTA_KEYS}"},{"line_number":63,"context_line":""}],"source_content_type":"text/x-python","patch_set":4,"id":"ff0f0b1f_4f5bbc53","line":60,"range":{"start_line":59,"start_character":58,"end_line":60,"end_character":16},"updated":"2017-05-26 07:31:20.000000000","message":"here no volume type quotas is included, instead they are included in #L76","commit_id":"43bab4a5a9fcdde3413a8e07670843ac15cd5150"},{"author":{"_account_id":23081,"name":"Jeremy Zhang","email":"zhangjun_inspur@163.com","username":"jeremy.zhang"},"change_message_id":"8cb98236bfba541534a1d19b4e8af8cc5a5114f5","unresolved":false,"context_lines":[{"line_number":56,"context_line":"        body \u003d self.admin_quota_classes_client.show_quota_class_set("},{"line_number":57,"context_line":"            \u0027default\u0027)[\u0027quota_class_set\u0027]"},{"line_number":58,"context_line":""},{"line_number":59,"context_line":"        # Note(jeremyZ) Only include specified quota keys and volume type"},{"line_number":60,"context_line":"        # quotas, to avoid the conflict that other tests may create or update"},{"line_number":61,"context_line":"        # volume type quotas in concurrency running."},{"line_number":62,"context_line":"        update_kwargs \u003d {key: body[key] for key in body if key in QUOTA_KEYS}"},{"line_number":63,"context_line":""}],"source_content_type":"text/x-python","patch_set":4,"id":"ff0f0b1f_8581b34d","line":60,"range":{"start_line":59,"start_character":58,"end_line":60,"end_character":16},"in_reply_to":"ff0f0b1f_4f5bbc53","updated":"2017-05-26 08:19:44.000000000","message":"Hi, Fanglei!\nHere I means the \u0027update_kwargs\u0027 will totally include the specified quota keys \u0027QUOTA_KEYS\u0027 and new volume type\u0027s quota keys created in this test. The new created volume type in this test will not effect on the assertions, and it will be also tested.","commit_id":"43bab4a5a9fcdde3413a8e07670843ac15cd5150"},{"author":{"_account_id":20190,"name":"zhufl","email":"zhu.fanglei@zte.com.cn","username":"zhufl"},"change_message_id":"b2f95c7c1683985343c6282b0f3baa315f29ffe0","unresolved":false,"context_lines":[{"line_number":56,"context_line":"        body \u003d self.admin_quota_classes_client.show_quota_class_set("},{"line_number":57,"context_line":"            \u0027default\u0027)[\u0027quota_class_set\u0027]"},{"line_number":58,"context_line":""},{"line_number":59,"context_line":"        # Note(jeremyZ) Only include specified quota keys and volume type"},{"line_number":60,"context_line":"        # quotas, to avoid the conflict that other tests may create or update"},{"line_number":61,"context_line":"        # volume type quotas in concurrency running."},{"line_number":62,"context_line":"        update_kwargs \u003d {key: body[key] for key in body if key in QUOTA_KEYS}"},{"line_number":63,"context_line":""}],"source_content_type":"text/x-python","patch_set":4,"id":"ff0f0b1f_25c8a772","line":60,"range":{"start_line":59,"start_character":58,"end_line":60,"end_character":16},"in_reply_to":"ff0f0b1f_8581b34d","updated":"2017-05-26 08:26:53.000000000","message":"Heh I absolutely know what do you mean, and I am just afraid others would be a bit confused after a long time","commit_id":"43bab4a5a9fcdde3413a8e07670843ac15cd5150"},{"author":{"_account_id":8556,"name":"Ghanshyam Maan","display_name":"Ghanshyam Maan","email":"gmaan.os14@gmail.com","username":"ghanshyam"},"change_message_id":"9d808ee97360eeba24324689d1e20cc04b6c13dc","unresolved":false,"context_lines":[{"line_number":72,"context_line":"                update_kwargs[quota] \u003d default + 1"},{"line_number":73,"context_line":""},{"line_number":74,"context_line":"        # Create a volume type for updating default quotas class."},{"line_number":75,"context_line":"        volume_type_name \u003d self.create_volume_type()[\u0027name\u0027]"},{"line_number":76,"context_line":"        for key in [\u0027volumes\u0027, \u0027snapshots\u0027, \u0027gigabytes\u0027]:"},{"line_number":77,"context_line":"            update_kwargs[\u0027%s_%s\u0027 % (key, volume_type_name)] \u003d \\"},{"line_number":78,"context_line":"                random.randint(1, 10)"}],"source_content_type":"text/x-python","patch_set":4,"id":"ff0f0b1f_af0c9894","line":75,"range":{"start_line":75,"start_character":0,"end_line":75,"end_character":60},"updated":"2017-05-26 07:25:32.000000000","message":"ok to check with volume type quota too.","commit_id":"43bab4a5a9fcdde3413a8e07670843ac15cd5150"}]}