)]}'
{"tempest/lib/common/rest_client.py":[{"author":{"_account_id":6167,"name":"Ken\u0027ichi Ohmichi","email":"ken1ohmichi@gmail.com","username":"oomichi"},"change_message_id":"c388edf913e37145ba794be8bf05d4be452f8ba1","unresolved":false,"context_lines":[{"line_number":871,"context_line":"                raise exceptions.TimeoutException(message)"},{"line_number":872,"context_line":"            time.sleep(self.build_interval)"},{"line_number":873,"context_line":""},{"line_number":874,"context_line":"    show_method \u003d None"},{"line_number":875,"context_line":""},{"line_number":876,"context_line":"    def is_resource_deleted(self, id):"},{"line_number":877,"context_line":"        \"\"\"Subclasses can override with specific deletion detection.\"\"\""}],"source_content_type":"text/x-python","patch_set":1,"id":"ff0f0b1f_79d460e9","line":874,"range":{"start_line":874,"start_character":4,"end_line":874,"end_character":15},"updated":"2017-05-24 05:30:18.000000000","message":"it would be better to name resource_existence_check_method or something for understanding how to use the method in is_resource_deleted.\nIn addition, docstring should be necessary for this global.","commit_id":"0a8179646ccf7f5ed9aa419106323bd37a65047e"},{"author":{"_account_id":5689,"name":"Masayuki Igawa","email":"masayuki@igawa.io","username":"igawa"},"change_message_id":"b5ec82425affa30b0d8111fd129881814fca6683","unresolved":false,"context_lines":[{"line_number":871,"context_line":"                raise exceptions.TimeoutException(message)"},{"line_number":872,"context_line":"            time.sleep(self.build_interval)"},{"line_number":873,"context_line":""},{"line_number":874,"context_line":"    show_method \u003d None"},{"line_number":875,"context_line":""},{"line_number":876,"context_line":"    def is_resource_deleted(self, id):"},{"line_number":877,"context_line":"        \"\"\"Subclasses can override with specific deletion detection.\"\"\""}],"source_content_type":"text/x-python","patch_set":1,"id":"ff0f0b1f_19132468","line":874,"range":{"start_line":874,"start_character":4,"end_line":874,"end_character":15},"in_reply_to":"ff0f0b1f_79d460e9","updated":"2017-05-24 05:55:19.000000000","message":"sure, will do","commit_id":"0a8179646ccf7f5ed9aa419106323bd37a65047e"},{"author":{"_account_id":20190,"name":"zhufl","email":"zhu.fanglei@zte.com.cn","username":"zhufl"},"change_message_id":"6134c8edb88c5e9784163e3fa3d9d9b9fc14783b","unresolved":false,"context_lines":[{"line_number":882,"context_line":""},{"line_number":883,"context_line":"        try:"},{"line_number":884,"context_line":"            body \u003d self.show_method(id)"},{"line_number":885,"context_line":"            if not body:"},{"line_number":886,"context_line":"                return True"},{"line_number":887,"context_line":"        except exceptions.NotFound:"},{"line_number":888,"context_line":"            return True"},{"line_number":889,"context_line":"        return False"}],"source_content_type":"text/x-python","patch_set":1,"id":"ff0f0b1f_999174f4","line":886,"range":{"start_line":885,"start_character":0,"end_line":886,"end_character":27},"updated":"2017-05-24 05:44:13.000000000","message":"In current code this is used only in few clients such as EncryptionTypesClient, and I am not sure whether it\nis always right for other clients, so, will it be better to remove this here and leave it for subclasses?","commit_id":"0a8179646ccf7f5ed9aa419106323bd37a65047e"},{"author":{"_account_id":5689,"name":"Masayuki Igawa","email":"masayuki@igawa.io","username":"igawa"},"change_message_id":"b5ec82425affa30b0d8111fd129881814fca6683","unresolved":false,"context_lines":[{"line_number":882,"context_line":""},{"line_number":883,"context_line":"        try:"},{"line_number":884,"context_line":"            body \u003d self.show_method(id)"},{"line_number":885,"context_line":"            if not body:"},{"line_number":886,"context_line":"                return True"},{"line_number":887,"context_line":"        except exceptions.NotFound:"},{"line_number":888,"context_line":"            return True"},{"line_number":889,"context_line":"        return False"}],"source_content_type":"text/x-python","patch_set":1,"id":"ff0f0b1f_9c496261","line":886,"range":{"start_line":885,"start_character":0,"end_line":886,"end_character":27},"in_reply_to":"ff0f0b1f_999174f4","updated":"2017-05-24 05:55:19.000000000","message":"yeah, I believed if the show_method() returns empty/None, the resource should be nothing. Because the *show* method should return something.\n\nBut, I\u0027m fine with leaving it, just in case.","commit_id":"0a8179646ccf7f5ed9aa419106323bd37a65047e"},{"author":{"_account_id":23630,"name":"Tovin Seven","email":"tovin07@gmail.com","username":"tovin07"},"change_message_id":"f98aa58cf9988846152622c7768666d1799eeaad","unresolved":false,"context_lines":[{"line_number":871,"context_line":"                raise exceptions.TimeoutException(message)"},{"line_number":872,"context_line":"            time.sleep(self.build_interval)"},{"line_number":873,"context_line":""},{"line_number":874,"context_line":"    \"\"\"A method which gets a resource of specified id"},{"line_number":875,"context_line":""},{"line_number":876,"context_line":"    If you don\u0027t override this variable, you need to override the"},{"line_number":877,"context_line":"    `is_resource_deleted` method to use `wait_for_resource_deletion` method."},{"line_number":878,"context_line":"    \"\"\""},{"line_number":879,"context_line":"    show_resource_method \u003d None"},{"line_number":880,"context_line":""},{"line_number":881,"context_line":"    def is_resource_deleted(self, id):"}],"source_content_type":"text/x-python","patch_set":3,"id":"df140735_0ae6d945","line":878,"range":{"start_line":874,"start_character":0,"end_line":878,"end_character":7},"updated":"2017-05-29 08:31:01.000000000","message":"This is so confused.\nMulti-lines comment or docstring for a method?\nJust use # symbol for multi-lines comment","commit_id":"1db4ab341896917d6f54aa61b1e095428434970e"},{"author":{"_account_id":6167,"name":"Ken\u0027ichi Ohmichi","email":"ken1ohmichi@gmail.com","username":"oomichi"},"change_message_id":"254b3eb9fdf2c85dcffe3d38d39871ddf7410dcb","unresolved":false,"context_lines":[{"line_number":876,"context_line":"    If you don\u0027t override this variable, you need to override the"},{"line_number":877,"context_line":"    `is_resource_deleted` method to use `wait_for_resource_deletion` method."},{"line_number":878,"context_line":"    \"\"\""},{"line_number":879,"context_line":"    show_resource_method \u003d None"},{"line_number":880,"context_line":""},{"line_number":881,"context_line":"    def is_resource_deleted(self, id):"},{"line_number":882,"context_line":"        \"\"\"Subclasses can override with specific deletion detection.\"\"\""}],"source_content_type":"text/x-python","patch_set":3,"id":"df140735_8002a1b3","line":879,"range":{"start_line":879,"start_character":4,"end_line":879,"end_character":24},"updated":"2017-05-30 20:01:36.000000000","message":"The reason why I suggested resource_existence_check_method as the name is that HEAD method also can be used for this case and GET method(show_...) is not a single option here.\n\nIn addition, it would be better to mention here the method should raise NotFound for is_resource_deleted() implementation.","commit_id":"1db4ab341896917d6f54aa61b1e095428434970e"}],"tempest/lib/services/volume/v1/qos_client.py":[{"author":{"_account_id":20190,"name":"zhufl","email":"zhu.fanglei@zte.com.cn","username":"zhufl"},"change_message_id":"546757452a26c1640df4fdee220e9dd0b0d0cc2f","unresolved":false,"context_lines":[{"line_number":26,"context_line":"    api_version \u003d \"v1\""},{"line_number":27,"context_line":""},{"line_number":28,"context_line":"    @property"},{"line_number":29,"context_line":"    def resource_type(self):"},{"line_number":30,"context_line":"        \"\"\"Returns the primary type of resource this client works with.\"\"\""},{"line_number":31,"context_line":"        return \u0027qos\u0027"},{"line_number":32,"context_line":""}],"source_content_type":"text/x-python","patch_set":3,"id":"df140735_262a7f7e","line":29,"range":{"start_line":29,"start_character":4,"end_line":29,"end_character":28},"updated":"2017-06-02 01:39:33.000000000","message":"Most clients have resource_type defined, and, it seems we can use it to get the method name of getting and deleting\n(\"show_\" + resource_type, \"delete_\" + resource_type), so we won\u0027t need to define show_resource_method or delete_resource_method.\n\nThere may be some clients whose resource_type is not correct for assembling method name(e.g., SnapshotsClient), but we can fix it.","commit_id":"1db4ab341896917d6f54aa61b1e095428434970e"}]}