)]}'
{"tempest/api/volume/test_volumes_clone.py":[{"author":{"_account_id":5689,"name":"Masayuki Igawa","email":"masayuki@igawa.io","username":"igawa"},"change_message_id":"ff1eaa57a5778219c4cd20c84516a9f8bb62cb8d","unresolved":false,"context_lines":[{"line_number":30,"context_line":"        if not CONF.volume_feature_enabled.clone:"},{"line_number":31,"context_line":"            raise cls.skipException(\"Cinder volume clones are disabled\")"},{"line_number":32,"context_line":""},{"line_number":33,"context_line":"    def volume_clone_verification(self, source_volume, cloned_volume,"},{"line_number":34,"context_line":"                                  bootable\u003d\u0027false\u0027, extra_size\u003d0):"},{"line_number":35,"context_line":""},{"line_number":36,"context_line":"        cloned_vol_details \u003d self.volumes_client.show_volume("}],"source_content_type":"text/x-python","patch_set":2,"id":"3f1d235d_47c5dc5a","line":33,"updated":"2017-07-10 05:19:29.000000000","message":"I think this is a private method. So why not make this name \u0027_volume_clone_verification\u0027? Do you have a plan to make this public?","commit_id":"306e4be06d3e755c200a407faa7d567d76a597c1"},{"author":{"_account_id":19262,"name":"Liron Kuchlani","email":"lkuchlan@redhat.com","username":"lkuchlan"},"change_message_id":"1ca524701552305134ceb086d49f7cc40368064a","unresolved":false,"context_lines":[{"line_number":30,"context_line":"        if not CONF.volume_feature_enabled.clone:"},{"line_number":31,"context_line":"            raise cls.skipException(\"Cinder volume clones are disabled\")"},{"line_number":32,"context_line":""},{"line_number":33,"context_line":"    def volume_clone_verification(self, source_volume, cloned_volume,"},{"line_number":34,"context_line":"                                  bootable\u003d\u0027false\u0027, extra_size\u003d0):"},{"line_number":35,"context_line":""},{"line_number":36,"context_line":"        cloned_vol_details \u003d self.volumes_client.show_volume("}],"source_content_type":"text/x-python","patch_set":2,"id":"3f1d235d_b8e84a7c","line":33,"in_reply_to":"3f1d235d_47c5dc5a","updated":"2017-07-10 09:46:21.000000000","message":"Thanks I updated it to private method","commit_id":"306e4be06d3e755c200a407faa7d567d76a597c1"},{"author":{"_account_id":5689,"name":"Masayuki Igawa","email":"masayuki@igawa.io","username":"igawa"},"change_message_id":"ff1eaa57a5778219c4cd20c84516a9f8bb62cb8d","unresolved":false,"context_lines":[{"line_number":53,"context_line":"        dst_vol \u003d self.create_volume(source_volid\u003dsrc_vol[\u0027id\u0027],"},{"line_number":54,"context_line":"                                     size\u003dsrc_size + 1)"},{"line_number":55,"context_line":""},{"line_number":56,"context_line":"        self.volume_clone_verification(src_vol, dst_vol, extra_size\u003d1)"},{"line_number":57,"context_line":""},{"line_number":58,"context_line":"    @decorators.idempotent_id(\u0027cbbcd7c6-5a6c-481a-97ac-ca55ab715d16\u0027)"},{"line_number":59,"context_line":"    @test.services(\u0027image\u0027)"}],"source_content_type":"text/x-python","patch_set":2,"id":"3f1d235d_27a0a0a5","line":56,"updated":"2017-07-10 05:19:29.000000000","message":"I think this is a kind of a refactoring. So it\u0027s good to split the patch.","commit_id":"306e4be06d3e755c200a407faa7d567d76a597c1"},{"author":{"_account_id":19262,"name":"Liron Kuchlani","email":"lkuchlan@redhat.com","username":"lkuchlan"},"change_message_id":"1ca524701552305134ceb086d49f7cc40368064a","unresolved":false,"context_lines":[{"line_number":53,"context_line":"        dst_vol \u003d self.create_volume(source_volid\u003dsrc_vol[\u0027id\u0027],"},{"line_number":54,"context_line":"                                     size\u003dsrc_size + 1)"},{"line_number":55,"context_line":""},{"line_number":56,"context_line":"        self.volume_clone_verification(src_vol, dst_vol, extra_size\u003d1)"},{"line_number":57,"context_line":""},{"line_number":58,"context_line":"    @decorators.idempotent_id(\u0027cbbcd7c6-5a6c-481a-97ac-ca55ab715d16\u0027)"},{"line_number":59,"context_line":"    @test.services(\u0027image\u0027)"}],"source_content_type":"text/x-python","patch_set":2,"id":"3f1d235d_d8c1c6e6","line":56,"in_reply_to":"3f1d235d_27a0a0a5","updated":"2017-07-10 09:46:21.000000000","message":"Ok, I split it to separate patches","commit_id":"306e4be06d3e755c200a407faa7d567d76a597c1"},{"author":{"_account_id":5689,"name":"Masayuki Igawa","email":"masayuki@igawa.io","username":"igawa"},"change_message_id":"ff1eaa57a5778219c4cd20c84516a9f8bb62cb8d","unresolved":false,"context_lines":[{"line_number":65,"context_line":"        # Create a volume from the bootable volume"},{"line_number":66,"context_line":"        cloned_vol \u003d self.create_volume(source_volid\u003dsrc_vol[\u0027id\u0027])"},{"line_number":67,"context_line":""},{"line_number":68,"context_line":"        self.volume_clone_verification(src_vol, cloned_vol, bootable\u003d\u0027true\u0027)"},{"line_number":69,"context_line":""},{"line_number":70,"context_line":"    @decorators.idempotent_id(\u0027bbf1132a-226a-424d-9812-a9385cc50a32\u0027)"},{"line_number":71,"context_line":"    @test.services(\u0027compute\u0027)"}],"source_content_type":"text/x-python","patch_set":2,"id":"3f1d235d_07a5a4b5","line":68,"updated":"2017-07-10 05:19:29.000000000","message":"same here","commit_id":"306e4be06d3e755c200a407faa7d567d76a597c1"},{"author":{"_account_id":19262,"name":"Liron Kuchlani","email":"lkuchlan@redhat.com","username":"lkuchlan"},"change_message_id":"1ca524701552305134ceb086d49f7cc40368064a","unresolved":false,"context_lines":[{"line_number":65,"context_line":"        # Create a volume from the bootable volume"},{"line_number":66,"context_line":"        cloned_vol \u003d self.create_volume(source_volid\u003dsrc_vol[\u0027id\u0027])"},{"line_number":67,"context_line":""},{"line_number":68,"context_line":"        self.volume_clone_verification(src_vol, cloned_vol, bootable\u003d\u0027true\u0027)"},{"line_number":69,"context_line":""},{"line_number":70,"context_line":"    @decorators.idempotent_id(\u0027bbf1132a-226a-424d-9812-a9385cc50a32\u0027)"},{"line_number":71,"context_line":"    @test.services(\u0027compute\u0027)"}],"source_content_type":"text/x-python","patch_set":2,"id":"3f1d235d_98bb4e71","line":68,"in_reply_to":"3f1d235d_07a5a4b5","updated":"2017-07-10 09:46:21.000000000","message":"Done","commit_id":"306e4be06d3e755c200a407faa7d567d76a597c1"},{"author":{"_account_id":20190,"name":"zhufl","email":"zhu.fanglei@zte.com.cn","username":"zhufl"},"change_message_id":"b05474c97a54a8e8d28ca53a266c1fd17a1fff89","unresolved":false,"context_lines":[{"line_number":53,"context_line":"        dst_vol \u003d self.create_volume(source_volid\u003dsrc_vol[\u0027id\u0027],"},{"line_number":54,"context_line":"                                     size\u003dsrc_size + 1)"},{"line_number":55,"context_line":""},{"line_number":56,"context_line":"        self._volume_clone_verification(src_vol, dst_vol, extra_size\u003d1)"},{"line_number":57,"context_line":""},{"line_number":58,"context_line":"    @decorators.idempotent_id(\u0027cbbcd7c6-5a6c-481a-97ac-ca55ab715d16\u0027)"},{"line_number":59,"context_line":"    @test.services(\u0027image\u0027)"}],"source_content_type":"text/x-python","patch_set":7,"id":"3f1d235d_66fd2c39","line":56,"range":{"start_line":56,"start_character":13,"end_line":56,"end_character":39},"updated":"2017-07-12 05:30:13.000000000","message":"the function name is better to begin a verb, something like \u0027_verify_volume_clone\u0027","commit_id":"5a8d7baef0822967906af79e35a14f8dd838af17"},{"author":{"_account_id":19262,"name":"Liron Kuchlani","email":"lkuchlan@redhat.com","username":"lkuchlan"},"change_message_id":"22f2d51a94b2a48b730f1f4b06dca3970bfe09d4","unresolved":false,"context_lines":[{"line_number":53,"context_line":"        dst_vol \u003d self.create_volume(source_volid\u003dsrc_vol[\u0027id\u0027],"},{"line_number":54,"context_line":"                                     size\u003dsrc_size + 1)"},{"line_number":55,"context_line":""},{"line_number":56,"context_line":"        self._volume_clone_verification(src_vol, dst_vol, extra_size\u003d1)"},{"line_number":57,"context_line":""},{"line_number":58,"context_line":"    @decorators.idempotent_id(\u0027cbbcd7c6-5a6c-481a-97ac-ca55ab715d16\u0027)"},{"line_number":59,"context_line":"    @test.services(\u0027image\u0027)"}],"source_content_type":"text/x-python","patch_set":7,"id":"1f1a1f67_e7ad2a32","line":56,"range":{"start_line":56,"start_character":13,"end_line":56,"end_character":39},"in_reply_to":"3f1d235d_66fd2c39","updated":"2017-07-12 09:57:24.000000000","message":"Done","commit_id":"5a8d7baef0822967906af79e35a14f8dd838af17"}]}