)]}'
{"tempest/api/volume/test_volumes_snapshots.py":[{"author":{"_account_id":6167,"name":"Ken\u0027ichi Ohmichi","email":"ken1ohmichi@gmail.com","username":"oomichi"},"change_message_id":"28c192e85049a50167c4186d00f1b8f9edc5957a","unresolved":false,"context_lines":[{"line_number":84,"context_line":""},{"line_number":85,"context_line":"        # Assert response body for get_snapshot method"},{"line_number":86,"context_line":"        resp, updated_snapshot \u003d self.snapshots_client.get_snapshot("},{"line_number":87,"context_line":"                                                       snapshot[\u0027id\u0027])"},{"line_number":88,"context_line":"        self.assertEqual(new_s_name, updated_snapshot[\u0027name\u0027])"},{"line_number":89,"context_line":"        self.assertEqual(new_description, updated_snapshot[\u0027description\u0027])"},{"line_number":90,"context_line":""}],"source_content_type":"text/x-python","patch_set":1,"id":"AAAAS3%2F%2F7dU%3D","line":87,"updated":"2013-09-17 02:56:55.000000000","message":"I feel it is better to add \"self.assertEqual(200, resp.status)\" here.","commit_id":"d8f525ab61d70487957ff93530bb55f39855ced4"},{"author":{"_account_id":7282,"name":"Qing Xin Meng","email":"mengqxqx@cn.ibm.com","username":"mengqxqx"},"change_message_id":"7c98591e826ace3f444406b4b6ae7afb4d92f36e","unresolved":false,"context_lines":[{"line_number":84,"context_line":""},{"line_number":85,"context_line":"        # Assert response body for get_snapshot method"},{"line_number":86,"context_line":"        resp, updated_snapshot \u003d self.snapshots_client.get_snapshot("},{"line_number":87,"context_line":"                                                       snapshot[\u0027id\u0027])"},{"line_number":88,"context_line":"        self.assertEqual(new_s_name, updated_snapshot[\u0027name\u0027])"},{"line_number":89,"context_line":"        self.assertEqual(new_description, updated_snapshot[\u0027description\u0027])"},{"line_number":90,"context_line":""}],"source_content_type":"text/x-python","patch_set":1,"id":"AAAAS3%2F%2F7ZQ%3D","line":87,"in_reply_to":"AAAAS3%2F%2F7dU%3D","updated":"2013-09-17 04:22:48.000000000","message":"Done","commit_id":"d8f525ab61d70487957ff93530bb55f39855ced4"}],"tempest/services/volume/json/snapshots_client.py":[{"author":{"_account_id":6167,"name":"Ken\u0027ichi Ohmichi","email":"ken1ohmichi@gmail.com","username":"oomichi"},"change_message_id":"28c192e85049a50167c4186d00f1b8f9edc5957a","unresolved":false,"context_lines":[{"line_number":85,"context_line":"            \u0027name\u0027: name,"},{"line_number":86,"context_line":"            \u0027description\u0027: description"},{"line_number":87,"context_line":"        }"},{"line_number":88,"context_line":"        put_body \u003d json.dumps({\u0027snapshot\u0027: put_body})"},{"line_number":89,"context_line":"        resp, body \u003d self.put(\u0027snapshots/%s\u0027 % snapshot_id, put_body,"},{"line_number":90,"context_line":"                              self.headers)"},{"line_number":91,"context_line":"        body \u003d json.loads(body)"}],"source_content_type":"text/x-python","patch_set":1,"id":"AAAAS3%2F%2F7bc%3D","line":88,"updated":"2013-09-17 02:56:55.000000000","message":"line81-88: How about just \"put_body \u003d json.dumps({\u0027snapshot\u0027: kwargs})\"?\nIIUC, the server of cinder updates snapshot data by specifying data only.\n\nThere is similar change for keystone, it would be a good sample:\nhttps://review.openstack.org/#/c/46477/10/tempest/services/identity/json/identity_client.py","commit_id":"d8f525ab61d70487957ff93530bb55f39855ced4"},{"author":{"_account_id":7282,"name":"Qing Xin Meng","email":"mengqxqx@cn.ibm.com","username":"mengqxqx"},"change_message_id":"7c98591e826ace3f444406b4b6ae7afb4d92f36e","unresolved":false,"context_lines":[{"line_number":85,"context_line":"            \u0027name\u0027: name,"},{"line_number":86,"context_line":"            \u0027description\u0027: description"},{"line_number":87,"context_line":"        }"},{"line_number":88,"context_line":"        put_body \u003d json.dumps({\u0027snapshot\u0027: put_body})"},{"line_number":89,"context_line":"        resp, body \u003d self.put(\u0027snapshots/%s\u0027 % snapshot_id, put_body,"},{"line_number":90,"context_line":"                              self.headers)"},{"line_number":91,"context_line":"        body \u003d json.loads(body)"}],"source_content_type":"text/x-python","patch_set":1,"id":"AAAAS3%2F%2F7Zg%3D","line":88,"in_reply_to":"AAAAS3%2F%2F7bc%3D","updated":"2013-09-17 04:22:48.000000000","message":"Done","commit_id":"d8f525ab61d70487957ff93530bb55f39855ced4"}],"tempest/services/volume/xml/snapshots_client.py":[{"author":{"_account_id":6167,"name":"Ken\u0027ichi Ohmichi","email":"ken1ohmichi@gmail.com","username":"oomichi"},"change_message_id":"28c192e85049a50167c4186d00f1b8f9edc5957a","unresolved":false,"context_lines":[{"line_number":94,"context_line":"        \"\"\"Updates a snapshot.\"\"\""},{"line_number":95,"context_line":"        resp, body \u003d self.get_snapshot(snapshot_id)"},{"line_number":96,"context_line":"        name \u003d kwargs.get(\u0027name\u0027, body[\u0027name\u0027])"},{"line_number":97,"context_line":"        description \u003d kwargs.get(\u0027description\u0027, body[\u0027description\u0027])"},{"line_number":98,"context_line":"        put_body \u003d Element(\"snapshot\","},{"line_number":99,"context_line":"                           xmlns\u003dXMLNS,"},{"line_number":100,"context_line":"                           name\u003dname,"}],"source_content_type":"text/x-python","patch_set":1,"id":"AAAAS3%2F%2F7bQ%3D","line":97,"updated":"2013-09-17 02:56:55.000000000","message":"the same point as json/snapshots_client.py.","commit_id":"d8f525ab61d70487957ff93530bb55f39855ced4"},{"author":{"_account_id":7282,"name":"Qing Xin Meng","email":"mengqxqx@cn.ibm.com","username":"mengqxqx"},"change_message_id":"7c98591e826ace3f444406b4b6ae7afb4d92f36e","unresolved":false,"context_lines":[{"line_number":94,"context_line":"        \"\"\"Updates a snapshot.\"\"\""},{"line_number":95,"context_line":"        resp, body \u003d self.get_snapshot(snapshot_id)"},{"line_number":96,"context_line":"        name \u003d kwargs.get(\u0027name\u0027, body[\u0027name\u0027])"},{"line_number":97,"context_line":"        description \u003d kwargs.get(\u0027description\u0027, body[\u0027description\u0027])"},{"line_number":98,"context_line":"        put_body \u003d Element(\"snapshot\","},{"line_number":99,"context_line":"                           xmlns\u003dXMLNS,"},{"line_number":100,"context_line":"                           name\u003dname,"}],"source_content_type":"text/x-python","patch_set":1,"id":"AAAAS3%2F%2F7Zc%3D","line":97,"in_reply_to":"AAAAS3%2F%2F7bQ%3D","updated":"2013-09-17 04:22:48.000000000","message":"Done","commit_id":"d8f525ab61d70487957ff93530bb55f39855ced4"}]}