)]}'
{"/COMMIT_MSG":[{"author":{"_account_id":6167,"name":"Ken\u0027ichi Ohmichi","email":"ken1ohmichi@gmail.com","username":"oomichi"},"change_message_id":"0f9e2eadacc5bc1fd77dca1797dc0797be21023a","unresolved":false,"context_lines":[{"line_number":15,"context_line":""},{"line_number":16,"context_line":"And, by this commit, the generated rand name will include \"--\" such as"},{"line_number":17,"context_line":"\u0027foo--tempest-123\u0027."},{"line_number":18,"context_line":"So I will fix them in another commit."},{"line_number":19,"context_line":""},{"line_number":20,"context_line":"Change-Id: I7bb8f5bbe2346b0b0ab6e91757e20a67b9098f8a"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":1,"id":"AAAAS3%2F%2F7PQ%3D","line":18,"updated":"2013-09-17 05:25:57.000000000","message":"nit: how about deleting \"-\" or \"_\" if \"name\" includes it at the last word?","commit_id":"1b0cdb5996f3faf595ab48c9b155d3858b3196d6"},{"author":{"_account_id":5689,"name":"Masayuki Igawa","email":"masayuki@igawa.io","username":"igawa"},"change_message_id":"6e55fcf05a8952a1542a9b51ff72ca5e71ed4980","unresolved":false,"context_lines":[{"line_number":15,"context_line":""},{"line_number":16,"context_line":"And, by this commit, the generated rand name will include \"--\" such as"},{"line_number":17,"context_line":"\u0027foo--tempest-123\u0027."},{"line_number":18,"context_line":"So I will fix them in another commit."},{"line_number":19,"context_line":""},{"line_number":20,"context_line":"Change-Id: I7bb8f5bbe2346b0b0ab6e91757e20a67b9098f8a"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":1,"id":"AAAAS3%2F%2F7FA%3D","line":18,"in_reply_to":"AAAAS3%2F%2F7PQ%3D","updated":"2013-09-17 06:18:10.000000000","message":"Thank you for your comment!\nyour suggestion is good at this time.\nBut I think many developers of Tempest may continue to use rand_name(\"foo-\") idiom. So I\u0027d like to remove \u0027-\u0027 suffix from all rand_name() of tempest tests.\nAnd I\u0027d like to keep my patch simple as much as possible.\n\nBut I did \"grep rand_name( |wc -l\", the result count is 396!. So It\u0027s too hard work to fix them. I\u0027ll consider more...","commit_id":"1b0cdb5996f3faf595ab48c9b155d3858b3196d6"}],"tempest/common/utils/data_utils.py":[{"author":{"_account_id":6167,"name":"Ken\u0027ichi Ohmichi","email":"ken1ohmichi@gmail.com","username":"oomichi"},"change_message_id":"d744e11bd7817eeab6afe4c56b2bfe3242839cbd","unresolved":false,"context_lines":[{"line_number":24,"context_line":""},{"line_number":25,"context_line":""},{"line_number":26,"context_line":"def rand_name(name\u003d\u0027test\u0027):"},{"line_number":27,"context_line":"    return name + \"-tempest-\" + str(random.randint(1, 0x7fffffff))"},{"line_number":28,"context_line":""},{"line_number":29,"context_line":""},{"line_number":30,"context_line":"def rand_int_id(start\u003d0, end\u003d0x7fffffff):"}],"source_content_type":"text/x-python","patch_set":2,"id":"AAAAS3%2F%2F5X8%3D","line":27,"updated":"2013-09-17 14:43:38.000000000","message":"How about just changing the argument \"name\u003d\u0027test\u0027\" to \"name\u003d\u0027tempest-\u0027\"? and we should not specify the argument in non-special cases in the future.\n\nNow resource names(\"flavor-\", \"instance-\", etc.) are specified as the argument of rand_name() at many places, but we can know resource types, which are added by Tempest, easily because of executing \"nova ***-list\"/\"cinder ***-list\"/etc commands.","commit_id":"f5e8aaf4eb9010803a064b96be2e75915f82793a"},{"author":{"_account_id":6167,"name":"Ken\u0027ichi Ohmichi","email":"ken1ohmichi@gmail.com","username":"oomichi"},"change_message_id":"53f44136688c5c7a97648b3632c260b88433fdda","unresolved":false,"context_lines":[{"line_number":24,"context_line":""},{"line_number":25,"context_line":""},{"line_number":26,"context_line":"def rand_name(name\u003d\u0027test\u0027):"},{"line_number":27,"context_line":"    return name + \"-tempest-\" + str(random.randint(1, 0x7fffffff))"},{"line_number":28,"context_line":""},{"line_number":29,"context_line":""},{"line_number":30,"context_line":"def rand_int_id(start\u003d0, end\u003d0x7fffffff):"}],"source_content_type":"text/x-python","patch_set":2,"id":"AAAAS3%2F%2F2hg%3D","line":27,"in_reply_to":"AAAAS3%2F%2F5Q4%3D","updated":"2013-09-18 08:31:05.000000000","message":"Your idea is reasonable, thanks for the explanation.","commit_id":"f5e8aaf4eb9010803a064b96be2e75915f82793a"},{"author":{"_account_id":5689,"name":"Masayuki Igawa","email":"masayuki@igawa.io","username":"igawa"},"change_message_id":"e056aaf89ff352389beda9bea2c62a2c1a9d6034","unresolved":false,"context_lines":[{"line_number":24,"context_line":""},{"line_number":25,"context_line":""},{"line_number":26,"context_line":"def rand_name(name\u003d\u0027test\u0027):"},{"line_number":27,"context_line":"    return name + \"-tempest-\" + str(random.randint(1, 0x7fffffff))"},{"line_number":28,"context_line":""},{"line_number":29,"context_line":""},{"line_number":30,"context_line":"def rand_int_id(start\u003d0, end\u003d0x7fffffff):"}],"source_content_type":"text/x-python","patch_set":2,"id":"AAAAS3%2F%2F5Q4%3D","line":27,"in_reply_to":"AAAAS3%2F%2F5X8%3D","updated":"2013-09-17 15:12:11.000000000","message":"Hmm, I think the resource names are meaningful for debug.\nFor example, when we look at logs, the resource name may help to find where we want to know.\nAnd, if changing from \"name\u003d\u0027test\u0027\" to \"name\u003d\u0027tempest-\u0027\", we cannot distinguish the resource from tempest or not when we specify the name argument.\nmake sense?","commit_id":"f5e8aaf4eb9010803a064b96be2e75915f82793a"}]}