)]}'
{"tempest/scenario/test_network_basic_ops.py":[{"author":{"_account_id":1192,"name":"David Kranz","email":"dkranz@redhat.com","username":"david-kranz"},"change_message_id":"38ec7d4594b399fd96b559dba4ee6b36e3fb4e0a","unresolved":false,"context_lines":[{"line_number":239,"context_line":""},{"line_number":240,"context_line":"    def _test_boot_and_remote_ping_instance(self, network):"},{"line_number":241,"context_line":"        server \u003d self._create_server(rand_name(\u0027server-smoke-alt\u0027), network)"},{"line_number":242,"context_line":"        for _net_name, ip_addresses in server.networks.iteritems():"},{"line_number":243,"context_line":"            target_ip_address \u003d ip_addresses[0]"},{"line_number":244,"context_line":"        # The target login is assumed to have been configured for"},{"line_number":245,"context_line":"        # key-based authentication by cloud-init."}],"source_content_type":"text/x-python","patch_set":2,"id":"AAAAS3%2F%2F0Ac%3D","line":242,"updated":"2013-09-18 19:56:11.000000000","message":"Assuming this code is correct and the intent is to grap an address from the \"last\" one in the list of networks, it would help to have a comment as to why this was the right thing. I don\u0027t have a lot of knowledge about neutron details.\nI\u0027m also OK with some one else with more knowledge giving +2.","commit_id":"9fa9ca0eecaeaa8f7bbcbf7600a5a5946904f7ed"},{"author":{"_account_id":261,"name":"Salvatore Orlando","email":"salv.orlando@gmail.com","username":"salvatore-orlando"},"change_message_id":"3e8a6461c6e32b2fa926e6bb81c36265fd98dbe0","unresolved":false,"context_lines":[{"line_number":239,"context_line":""},{"line_number":240,"context_line":"    def _test_boot_and_remote_ping_instance(self, network):"},{"line_number":241,"context_line":"        server \u003d self._create_server(rand_name(\u0027server-smoke-alt\u0027), network)"},{"line_number":242,"context_line":"        for _net_name, ip_addresses in server.networks.iteritems():"},{"line_number":243,"context_line":"            target_ip_address \u003d ip_addresses[0]"},{"line_number":244,"context_line":"        # The target login is assumed to have been configured for"},{"line_number":245,"context_line":"        # key-based authentication by cloud-init."}],"source_content_type":"text/x-python","patch_set":2,"id":"AAAAS3%2F%2Fzn8%3D","line":242,"in_reply_to":"AAAAS3%2F%2F0Ac%3D","updated":"2013-09-18 21:54:24.000000000","message":"This server has been built with a single network, so the code is safe - as it picks the correct address.\nI agree the code could be refactored in a way that makes this self-evident, and I will therefore proceed to do that.","commit_id":"9fa9ca0eecaeaa8f7bbcbf7600a5a5946904f7ed"},{"author":{"_account_id":5803,"name":"Attila Fazekas","email":"afazekas@redhat.com","username":"afazekas"},"change_message_id":"240d981e4ec90d2b8d107660f8cab1b85d5adc5e","unresolved":false,"context_lines":[{"line_number":256,"context_line":"                        return True"},{"line_number":257,"context_line":"                    except (exceptions.SSHExecCommandFailed,"},{"line_number":258,"context_line":"                            exceptions.TimeoutException):"},{"line_number":259,"context_line":"                        return False"},{"line_number":260,"context_line":""},{"line_number":261,"context_line":"                tempest.test.call_until_true("},{"line_number":262,"context_line":"                    remote_ping,"}],"source_content_type":"text/x-python","patch_set":5,"id":"AAAATH%2F%2FgC4%3D","line":259,"updated":"2013-10-15 11:19:00.000000000","message":"Why do you catch the TimeoutException and ignoring it?","commit_id":"d5a4c64505335236c245c3fa63f0e5d271ec415f"},{"author":{"_account_id":5803,"name":"Attila Fazekas","email":"afazekas@redhat.com","username":"afazekas"},"change_message_id":"240d981e4ec90d2b8d107660f8cab1b85d5adc5e","unresolved":false,"context_lines":[{"line_number":260,"context_line":""},{"line_number":261,"context_line":"                tempest.test.call_until_true("},{"line_number":262,"context_line":"                    remote_ping,"},{"line_number":263,"context_line":"                    self.config.compute.ping_timeout, 1)"},{"line_number":264,"context_line":"                # Even if there are other floating ips, stop here"},{"line_number":265,"context_line":"                return"},{"line_number":266,"context_line":""}],"source_content_type":"text/x-python","patch_set":5,"id":"AAAATH%2F%2FgCw%3D","line":263,"updated":"2013-10-15 11:19:00.000000000","message":"We will not have too mutch clue about the last exception in this way.","commit_id":"d5a4c64505335236c245c3fa63f0e5d271ec415f"},{"author":{"_account_id":8576,"name":"Yair Fried","email":"yfried@redhat.com","username":"yfried"},"change_message_id":"96b47b628d7d255ea273e6b2d68d636394b0e063","unresolved":false,"context_lines":[{"line_number":269,"context_line":"        # configured in this module, from the VM which has been"},{"line_number":270,"context_line":"        # spawned for validating public connectivity."},{"line_number":271,"context_line":"        dhcp_ports \u003d self.network_client.list_ports("},{"line_number":272,"context_line":"            device_owner\u003d\u0027network:dhcp\u0027, network_id\u003dself.networks[0][\u0027id\u0027])"},{"line_number":273,"context_line":"        # Expect only a single DHCP port per network"},{"line_number":274,"context_line":"        self.assertEqual(1, len(dhcp_ports[\u0027ports\u0027]))"},{"line_number":275,"context_line":"        dhcp_port \u003d dhcp_ports[\u0027ports\u0027][0]"}],"source_content_type":"text/x-python","patch_set":5,"id":"AAAATn%2F%2BswI%3D","line":272,"updated":"2013-11-21 11:46:00.000000000","message":"please consider also testing against \u0027network:router\u0027, since L3-agent could be on a different node than compute/dhcp-agent and this seems like a great place to test for it.","commit_id":"d5a4c64505335236c245c3fa63f0e5d271ec415f"},{"author":{"_account_id":8576,"name":"Yair Fried","email":"yfried@redhat.com","username":"yfried"},"change_message_id":"96b47b628d7d255ea273e6b2d68d636394b0e063","unresolved":false,"context_lines":[{"line_number":280,"context_line":"    def _check_tenant_network_connectivity(self):"},{"line_number":281,"context_line":"        if self.config.network.tenant_networks_reachable:"},{"line_number":282,"context_line":"            self._check_tenant_network_connectivity_direct()"},{"line_number":283,"context_line":"        else:"},{"line_number":284,"context_line":"            self._check_tenant_network_connectivity_indirect()"},{"line_number":285,"context_line":""},{"line_number":286,"context_line":"    def _assign_floating_ips(self):"}],"source_content_type":"text/x-python","patch_set":5,"id":"AAAATn%2F%2Bsvo%3D","line":283,"updated":"2013-11-21 11:46:00.000000000","message":"maybe we should preform this test (pinging network ports) anyway (even if tenant network is reachable) to make sure VM can access network services from its compute node?\n\nin case tenant network is reachable - ssh directly to fixed_ip and preform test.","commit_id":"d5a4c64505335236c245c3fa63f0e5d271ec415f"}]}