)]}'
{"tempest/api/compute/servers/test_server_metadata.py":[{"author":{"_account_id":6167,"name":"Ken\u0027ichi Ohmichi","email":"ken1ohmichi@gmail.com","username":"oomichi"},"change_message_id":"9cbfeea2ee081c2e7a234b9a9a961420b913964a","unresolved":false,"context_lines":[{"line_number":238,"context_line":""},{"line_number":239,"context_line":"    @attr(type\u003d[\u0027negative\u0027, \u0027gate\u0027])"},{"line_number":240,"context_line":"    def test_update_all_metadata_field_not_included(self):"},{"line_number":241,"context_line":"        # Raise a bad request error for blank key."},{"line_number":242,"context_line":"        # set_server_metadata will replace all metadata with new value"},{"line_number":243,"context_line":"        meta \u003d {\u0027meta1\u0027: \u0027data1\u0027}"},{"line_number":244,"context_line":"        self.assertRaises(exceptions.BadRequest,"}],"source_content_type":"text/x-python","patch_set":1,"id":"AAAAS3%2F%2F5Vs%3D","line":241,"updated":"2013-09-17 15:00:16.000000000","message":"s/for blank key/due to non metadata field/ or something.","commit_id":"fd13a7ee5a0394d5e10b89fc4c67bb4b7ce64fb4"},{"author":{"_account_id":5292,"name":"Christopher Yeoh","email":"cbkyeoh@gmail.com","username":"cyeoh-0"},"change_message_id":"04c698863f04ffdd05ec7f55c4431e210a0ac1a3","unresolved":false,"context_lines":[{"line_number":238,"context_line":""},{"line_number":239,"context_line":"    @attr(type\u003d[\u0027negative\u0027, \u0027gate\u0027])"},{"line_number":240,"context_line":"    def test_update_all_metadata_field_not_included(self):"},{"line_number":241,"context_line":"        # Raise a bad request error for blank key."},{"line_number":242,"context_line":"        # set_server_metadata will replace all metadata with new value"},{"line_number":243,"context_line":"        meta \u003d {\u0027meta1\u0027: \u0027data1\u0027}"},{"line_number":244,"context_line":"        self.assertRaises(exceptions.BadRequest,"}],"source_content_type":"text/x-python","patch_set":1,"id":"AAAAS3%2F%2F3PU%3D","line":241,"in_reply_to":"AAAAS3%2F%2F5Vs%3D","updated":"2013-09-18 02:44:28.000000000","message":"oops, cut and paste bug - will fix.","commit_id":"fd13a7ee5a0394d5e10b89fc4c67bb4b7ce64fb4"},{"author":{"_account_id":6167,"name":"Ken\u0027ichi Ohmichi","email":"ken1ohmichi@gmail.com","username":"oomichi"},"change_message_id":"9cbfeea2ee081c2e7a234b9a9a961420b913964a","unresolved":false,"context_lines":[{"line_number":240,"context_line":"    def test_update_all_metadata_field_not_included(self):"},{"line_number":241,"context_line":"        # Raise a bad request error for blank key."},{"line_number":242,"context_line":"        # set_server_metadata will replace all metadata with new value"},{"line_number":243,"context_line":"        meta \u003d {\u0027meta1\u0027: \u0027data1\u0027}"},{"line_number":244,"context_line":"        self.assertRaises(exceptions.BadRequest,"},{"line_number":245,"context_line":"                          self.client.set_server_metadata,"},{"line_number":246,"context_line":"                          self.server_id, meta\u003dmeta, no_metadata_field\u003dTrue)"}],"source_content_type":"text/x-python","patch_set":1,"id":"AAAAS3%2F%2F5UA%3D","line":243,"updated":"2013-09-17 15:00:16.000000000","message":"Is it enough to change here to just \"meta \u003d {}\" without client changes?","commit_id":"fd13a7ee5a0394d5e10b89fc4c67bb4b7ce64fb4"},{"author":{"_account_id":5292,"name":"Christopher Yeoh","email":"cbkyeoh@gmail.com","username":"cyeoh-0"},"change_message_id":"511e575e483c473fdb477d68f57f6490dcf837f8","unresolved":false,"context_lines":[{"line_number":240,"context_line":"    def test_update_all_metadata_field_not_included(self):"},{"line_number":241,"context_line":"        # Raise a bad request error for blank key."},{"line_number":242,"context_line":"        # set_server_metadata will replace all metadata with new value"},{"line_number":243,"context_line":"        meta \u003d {\u0027meta1\u0027: \u0027data1\u0027}"},{"line_number":244,"context_line":"        self.assertRaises(exceptions.BadRequest,"},{"line_number":245,"context_line":"                          self.client.set_server_metadata,"},{"line_number":246,"context_line":"                          self.server_id, meta\u003dmeta, no_metadata_field\u003dTrue)"}],"source_content_type":"text/x-python","patch_set":1,"id":"AAAAS3%2F%2FzJg%3D","line":243,"in_reply_to":"AAAAS3%2F%2F3Nk%3D","updated":"2013-09-19 05:18:05.000000000","message":"I considered that, but I thought that someone may want to write a negative test with the set_server_metadata call where the body is:\n\n{\u0027metadata\u0027: None}\n\nso ended up adding the extra parameter instead. I do agree its a bit ugly, but if we want to leave the flexibility to test all the different invalid data forms I don\u0027t think we really have a choice.","commit_id":"fd13a7ee5a0394d5e10b89fc4c67bb4b7ce64fb4"},{"author":{"_account_id":6167,"name":"Ken\u0027ichi Ohmichi","email":"ken1ohmichi@gmail.com","username":"oomichi"},"change_message_id":"f067f672a53ab308eb1b0d244c778821873a71a4","unresolved":false,"context_lines":[{"line_number":240,"context_line":"    def test_update_all_metadata_field_not_included(self):"},{"line_number":241,"context_line":"        # Raise a bad request error for blank key."},{"line_number":242,"context_line":"        # set_server_metadata will replace all metadata with new value"},{"line_number":243,"context_line":"        meta \u003d {\u0027meta1\u0027: \u0027data1\u0027}"},{"line_number":244,"context_line":"        self.assertRaises(exceptions.BadRequest,"},{"line_number":245,"context_line":"                          self.client.set_server_metadata,"},{"line_number":246,"context_line":"                          self.server_id, meta\u003dmeta, no_metadata_field\u003dTrue)"}],"source_content_type":"text/x-python","patch_set":1,"id":"AAAAS3%2F%2F3Nk%3D","line":243,"in_reply_to":"AAAAS3%2F%2F3PQ%3D","updated":"2013-09-18 03:13:32.000000000","message":"thanks for your explanation, I see.\n\nI confused a little by \"meta \u003d {\u0027meta1\u0027: \u0027data1\u0027}\" against the purpose of this test. so how about changing line243 to \"meta \u003d None\"?\nset_server_metadata() would make \u0027post_body \u003d \"\"\u0027 if meta is None without adding a new argument.","commit_id":"fd13a7ee5a0394d5e10b89fc4c67bb4b7ce64fb4"},{"author":{"_account_id":5292,"name":"Christopher Yeoh","email":"cbkyeoh@gmail.com","username":"cyeoh-0"},"change_message_id":"04c698863f04ffdd05ec7f55c4431e210a0ac1a3","unresolved":false,"context_lines":[{"line_number":240,"context_line":"    def test_update_all_metadata_field_not_included(self):"},{"line_number":241,"context_line":"        # Raise a bad request error for blank key."},{"line_number":242,"context_line":"        # set_server_metadata will replace all metadata with new value"},{"line_number":243,"context_line":"        meta \u003d {\u0027meta1\u0027: \u0027data1\u0027}"},{"line_number":244,"context_line":"        self.assertRaises(exceptions.BadRequest,"},{"line_number":245,"context_line":"                          self.client.set_server_metadata,"},{"line_number":246,"context_line":"                          self.server_id, meta\u003dmeta, no_metadata_field\u003dTrue)"}],"source_content_type":"text/x-python","patch_set":1,"id":"AAAAS3%2F%2F3PQ%3D","line":243,"in_reply_to":"AAAAS3%2F%2F5UA%3D","updated":"2013-09-18 02:44:28.000000000","message":"No, I don\u0027t think it is enough. Because the body will end up being:\n\n{ metadata: {} } \n\nwhich is treated quite differently by the implementation than not having a metadata field at all in the body. Both are going to fail, it will exercise different code paths though.","commit_id":"fd13a7ee5a0394d5e10b89fc4c67bb4b7ce64fb4"},{"author":{"_account_id":6167,"name":"Ken\u0027ichi Ohmichi","email":"ken1ohmichi@gmail.com","username":"oomichi"},"change_message_id":"6857310b6304b72d274c9e45da52c866bcd8379c","unresolved":false,"context_lines":[{"line_number":240,"context_line":"    def test_update_all_metadata_field_not_included(self):"},{"line_number":241,"context_line":"        # Raise a bad request error for blank key."},{"line_number":242,"context_line":"        # set_server_metadata will replace all metadata with new value"},{"line_number":243,"context_line":"        meta \u003d {\u0027meta1\u0027: \u0027data1\u0027}"},{"line_number":244,"context_line":"        self.assertRaises(exceptions.BadRequest,"},{"line_number":245,"context_line":"                          self.client.set_server_metadata,"},{"line_number":246,"context_line":"                          self.server_id, meta\u003dmeta, no_metadata_field\u003dTrue)"}],"source_content_type":"text/x-python","patch_set":1,"id":"AAAAS3%2F%2Fy64%3D","line":243,"in_reply_to":"AAAAS3%2F%2FzJg%3D","updated":"2013-09-19 05:30:44.000000000","message":"I agree with you now. Current change is already nice :)","commit_id":"fd13a7ee5a0394d5e10b89fc4c67bb4b7ce64fb4"}],"tempest/services/compute/json/servers_client.py":[{"author":{"_account_id":2750,"name":"Sean Dague","email":"sean@dague.net","username":"sdague"},"change_message_id":"06da85964426f37d067681338f833dd1e7ee4208","unresolved":false,"context_lines":[{"line_number":236,"context_line":"        body \u003d json.loads(body)"},{"line_number":237,"context_line":"        return resp, body[\u0027metadata\u0027]"},{"line_number":238,"context_line":""},{"line_number":239,"context_line":"    def set_server_metadata(self, server_id, meta, no_metadata_field\u003dFalse):"},{"line_number":240,"context_line":"        if no_metadata_field:"},{"line_number":241,"context_line":"            post_body \u003d \"\""},{"line_number":242,"context_line":"        else:"}],"source_content_type":"text/x-python","patch_set":3,"id":"AAAAS3%2F%2FhHY%3D","line":239,"updated":"2013-09-25 11:19:58.000000000","message":"is meta\u003dNone valid? I wonder if we actually need the extra field or could overload meta here.","commit_id":"d0b52e726bea5127ddfd1d1d846be826db64b234"},{"author":{"_account_id":5292,"name":"Christopher Yeoh","email":"cbkyeoh@gmail.com","username":"cyeoh-0"},"change_message_id":"3f5eb410e71e111a19172921d47eb949526596d8","unresolved":false,"context_lines":[{"line_number":236,"context_line":"        body \u003d json.loads(body)"},{"line_number":237,"context_line":"        return resp, body[\u0027metadata\u0027]"},{"line_number":238,"context_line":""},{"line_number":239,"context_line":"    def set_server_metadata(self, server_id, meta, no_metadata_field\u003dFalse):"},{"line_number":240,"context_line":"        if no_metadata_field:"},{"line_number":241,"context_line":"            post_body \u003d \"\""},{"line_number":242,"context_line":"        else:"}],"source_content_type":"text/x-python","patch_set":3,"id":"AAAAS3%2F%2FgqI%3D","line":239,"in_reply_to":"AAAAS3%2F%2FhHY%3D","updated":"2013-09-25 13:51:39.000000000","message":"I thought of doing it that way at first, but I think the function could be used to check that the server is handling {\u0027metadata\u0027: None} correctly as well, especially since in practice its a different part of code which handles that sort of failure.","commit_id":"d0b52e726bea5127ddfd1d1d846be826db64b234"}]}