)]}'
{"/COMMIT_MSG":[{"author":{"_account_id":23186,"name":"Felipe Monteiro","email":"felipe.carneiro.monteiro@gmail.com","username":"felipe.monteiro"},"change_message_id":"2c3b57af8a879beb4ccc5113975f88dfa5a9b1d0","unresolved":false,"context_lines":[{"line_number":27,"context_line":"    @mock.patch.object(services_client, \u0027urllib\u0027)"},{"line_number":28,"context_line":"    def test_list_services_with_params(self, mock_urllib):"},{"line_number":29,"context_line":"        self._test_list_services(type\u003d\u0027fake-type\u0027)"},{"line_number":30,"context_line":"        mock_urllib.urlencode.assert_called_once_with("},{"line_number":31,"context_line":"            services?type\u003d\u0027fake-type\u0027)"},{"line_number":32,"context_line":""},{"line_number":33,"context_line":"which would be a more isolated change (meaning that a change"},{"line_number":34,"context_line":"to check_service_client_function is not absolutely required"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":3,"id":"df140735_d6bfd05e","line":31,"range":{"start_line":30,"start_character":8,"end_line":31,"end_character":38},"updated":"2017-06-03 00:01:04.000000000","message":"This would actually be:\n\nmock_urllib.urlencode.assert_called_once_with(\n    {\u0027type\u0027: \u0027fake-type\u0027})\n\nwhich implies that you\u0027re only asserting that urllib.urlencode was called...NOT that self.get is called with the right URL.\n\nSo this alternative solution is not as good as the one outlined by this commit.","commit_id":"2a22fba9f6d27e9daedb99067d91974e3dfbe669"},{"author":{"_account_id":5689,"name":"Masayuki Igawa","email":"masayuki@igawa.io","username":"igawa"},"change_message_id":"25068200608077978bc15b043d021f175868dc2f","unresolved":false,"context_lines":[{"line_number":36,"context_line":"nothing to assert that self.get, for example, is actually called with"},{"line_number":37,"context_line":"the right URL."},{"line_number":38,"context_line":""},{"line_number":39,"context_line":"[0] https://review.openstack.org/#/c/469454/"},{"line_number":40,"context_line":""},{"line_number":41,"context_line":"Change-Id: Ib066add5ff09bd3b32b293833ed6b7a3d5b43955"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":4,"id":"df140735_10aad583","line":39,"updated":"2017-06-05 08:29:38.000000000","message":"I prefer a change-id to the url here. Because we can see the patch when offline.","commit_id":"5d553dfcbe5f9bfb773f80ff4e70b01f3f86a3a1"}],"tempest/tests/lib/services/base.py":[{"author":{"_account_id":5803,"name":"Attila Fazekas","email":"afazekas@redhat.com","username":"afazekas"},"change_message_id":"69d4624d5c69679fa06b19fbc5c2a0e3ac5ff0d2","unresolved":false,"context_lines":[{"line_number":45,"context_line":"               function."},{"line_number":46,"context_line":"        :param headers: Expected headers returned by the service client"},{"line_number":47,"context_line":"               function."},{"line_number":48,"context_line":"        :param mock_args: List/dict/value of expected args/kwargs called by"},{"line_number":49,"context_line":"               function2mock. For example:"},{"line_number":50,"context_line":"               * If mock_args\u003d[\u0027foo\u0027] then ``assert_called_once_with(\u0027foo\u0027)``"},{"line_number":51,"context_line":"                 is called."}],"source_content_type":"text/x-python","patch_set":6,"id":"df140735_5e49255e","line":48,"updated":"2017-06-07 13:15:57.000000000","message":"I am not big fan of using isinstance on concrete class,\nusually abc mate classes are better in following the duck typing ideology.","commit_id":"a4dadd3fb39f859f3a1837e7b1a52a2b59e0e579"}]}