)]}'
{"/COMMIT_MSG":[{"author":{"_account_id":5689,"name":"Masayuki Igawa","email":"masayuki@igawa.io","username":"igawa"},"change_message_id":"2a85bee008223867faff9b3c3f7a4192a0a34102","unresolved":false,"context_lines":[{"line_number":8,"context_line":""},{"line_number":9,"context_line":"This patch is to replace assertEqual([True|False], A) with"},{"line_number":10,"context_line":"assert[True|False](A), which the latter is more straightforward and"},{"line_number":11,"context_line":"easier to understand."},{"line_number":12,"context_line":""},{"line_number":13,"context_line":"Change-Id: I318ca534be67bb8e1641e7733e8ea717d86c3b0f"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":1,"id":"df140735_6706da54","line":11,"updated":"2017-06-06 02:43:42.000000000","message":"I think we should take deliberate action here.\nBecause assertTrue|False(A) is not equal to assertEqual(True|False, A)[1]. (\u0027assertEqual(a, b)\u0027 checks that \u0027a \u003d\u003d b\u0027, but \u0027assertTrue(x)\u0027 checks that \u0027bool(x) is True\u0027.) \nFor example, if the value is str(\u0027True\u0027), assertEqual(True, str(\u0027True\u0027)) fails which is good, imo. But assertTrue(str(\u0027True\u0027)) succeeds. Moreover, by assertTrue(), \u0027foo\u0027, \u0027bar\u0027, 1,2,3... also succeed.\n\nI think tempest needs to check rest response values, so, we should not change the asserts easily. If we change these, I think we need to validate with response schemas. (But now, we have them only in compute and volume, right?)\n\n[1] https://docs.python.org/3/library/unittest.html#unittest.TestCase.debug","commit_id":"92608ca09c68832100a6c163d87214e0a293ce4f"}],"tempest/api/identity/admin/v2/test_users.py":[{"author":{"_account_id":5689,"name":"Masayuki Igawa","email":"masayuki@igawa.io","username":"igawa"},"change_message_id":"2a85bee008223867faff9b3c3f7a4192a0a34102","unresolved":false,"context_lines":[{"line_number":48,"context_line":"                                     email\u003dself.alt_email,"},{"line_number":49,"context_line":"                                     enabled\u003dFalse)"},{"line_number":50,"context_line":"        self.assertEqual(name, user[\u0027name\u0027])"},{"line_number":51,"context_line":"        self.assertFalse(user[\u0027enabled\u0027])"},{"line_number":52,"context_line":"        self.assertEqual(self.alt_email, user[\u0027email\u0027])"},{"line_number":53,"context_line":""},{"line_number":54,"context_line":"    @decorators.idempotent_id(\u002739d05857-e8a5-4ed4-ba83-0b52d3ab97ee\u0027)"}],"source_content_type":"text/x-python","patch_set":1,"id":"df140735_47019637","line":51,"updated":"2017-06-06 02:43:42.000000000","message":"In this case, user[\u0027enable\u0027] should be a bool value False. But this code allows 0, \u0027\u0027, [], etc. Is this your intentional?","commit_id":"92608ca09c68832100a6c163d87214e0a293ce4f"}],"tempest/api/object_storage/test_account_services.py":[{"author":{"_account_id":5689,"name":"Masayuki Igawa","email":"masayuki@igawa.io","username":"igawa"},"change_message_id":"2a85bee008223867faff9b3c3f7a4192a0a34102","unresolved":false,"context_lines":[{"line_number":249,"context_line":"            params\u003dparams)"},{"line_number":250,"context_line":"        self.assertHeaders(resp, \u0027Account\u0027, \u0027GET\u0027)"},{"line_number":251,"context_line":"        for container in container_list:"},{"line_number":252,"context_line":"            self.assertTrue(container.decode(\u0027utf-8\u0027).startswith(prefix))"},{"line_number":253,"context_line":""},{"line_number":254,"context_line":"    @decorators.idempotent_id(\u0027b1811cff-d1ed-4c15-a52e-efd8de41cf34\u0027)"},{"line_number":255,"context_line":"    def test_list_containers_reverse_order(self):"}],"source_content_type":"text/x-python","patch_set":1,"id":"df140735_27fc623c","line":252,"updated":"2017-06-06 02:43:42.000000000","message":"yeah, this change is fine for me.","commit_id":"92608ca09c68832100a6c163d87214e0a293ce4f"}]}