)]}'
{"tempest/common/validation_resources.py":[{"author":{"_account_id":12024,"name":"Tong Liu","email":"tongl@vmware.com","username":"tong101"},"change_message_id":"0afba5d63c8b90b6219a116294eac0751902551b","unresolved":false,"context_lines":[{"line_number":80,"context_line":"            validation_data[\u0027security_group\u0027] \u003d \\"},{"line_number":81,"context_line":"                create_ssh_security_group(os, add_rule)"},{"line_number":82,"context_line":"        if validation_resources[\u0027floating_ip\u0027]:"},{"line_number":83,"context_line":"            if CONF.service_available.neutron:"},{"line_number":84,"context_line":"                validation_data.update("},{"line_number":85,"context_line":"                    os.floating_ips_client.create_floatingip("},{"line_number":86,"context_line":"                        floating_network_id\u003dCONF.network.public_network_id))"}],"source_content_type":"text/x-python","patch_set":1,"id":"df140735_d301f006","line":83,"updated":"2017-06-05 22:15:34.000000000","message":"maybe we can do this?\n\n floating_client \u003d os.floating_ips_client if \\ \n    CONF.service_available.neutron else os.compute_floating_ips_client","commit_id":"a80b16155619bbd979ef97b793e19aad86df8e33"},{"author":{"_account_id":6873,"name":"Matt Riedemann","email":"mriedem.os@gmail.com","username":"mriedem"},"change_message_id":"f01f5478653a13a9297048df86dec072f033f7bd","unresolved":false,"context_lines":[{"line_number":80,"context_line":"            validation_data[\u0027security_group\u0027] \u003d \\"},{"line_number":81,"context_line":"                create_ssh_security_group(os, add_rule)"},{"line_number":82,"context_line":"        if validation_resources[\u0027floating_ip\u0027]:"},{"line_number":83,"context_line":"            if CONF.service_available.neutron:"},{"line_number":84,"context_line":"                validation_data.update("},{"line_number":85,"context_line":"                    os.floating_ips_client.create_floatingip("},{"line_number":86,"context_line":"                        floating_network_id\u003dCONF.network.public_network_id))"}],"source_content_type":"text/x-python","patch_set":1,"id":"df140735_538040f5","line":83,"in_reply_to":"df140735_d301f006","updated":"2017-06-05 22:44:29.000000000","message":"The method to call is still different, and the response is different, so it\u0027s simpler to just completely separate these.","commit_id":"a80b16155619bbd979ef97b793e19aad86df8e33"},{"author":{"_account_id":6873,"name":"Matt Riedemann","email":"mriedem.os@gmail.com","username":"mriedem"},"change_message_id":"1123d9c0d2dd678c6ab3a26e739af4489531e9f0","unresolved":false,"context_lines":[{"line_number":87,"context_line":"                # like a compute API POST /os-floating-ips response, so we need"},{"line_number":88,"context_line":"                # to mangle it a bit for a Neutron response with different"},{"line_number":89,"context_line":"                # fields."},{"line_number":90,"context_line":"                validation_data[\u0027floating_ip\u0027].update(floatingip[\u0027floatingip\u0027])"},{"line_number":91,"context_line":"                validation_data[\u0027floating_ip\u0027][\u0027ip\u0027] \u003d ("},{"line_number":92,"context_line":"                    floatingip[\u0027floatingip\u0027][\u0027floating_ip_address\u0027])"},{"line_number":93,"context_line":"            else:"}],"source_content_type":"text/x-python","patch_set":2,"id":"df140735_c1d7d64a","line":90,"range":{"start_line":90,"start_character":16,"end_line":90,"end_character":46},"updated":"2017-06-06 00:07:22.000000000","message":"Oh oops, wrong dict:\n\nhttp://logs.openstack.org/16/471116/2/check/gate-tempest-dsvm-neutron-full-ubuntu-xenial/78d834a/console.html#_2017-06-05_23_08_03_609432\n\nEasy fix.","commit_id":"07e437b03101b585e44b2c25236c0f9c6b995703"}]}