)]}'
{"tempest/api/volume/admin/test_volume_quotas.py":[{"author":{"_account_id":5689,"name":"Masayuki Igawa","email":"masayuki@igawa.io","username":"igawa"},"change_message_id":"5d5b47415d65c3e7815fb6c0ec925fcde4825212","unresolved":false,"context_lines":[{"line_number":18,"context_line":"from tempest.lib.common.utils import data_utils"},{"line_number":19,"context_line":"from tempest.lib import decorators"},{"line_number":20,"context_line":""},{"line_number":21,"context_line":"QUOTA_KEYS \u003d [\u0027gigabytes\u0027, \u0027snapshots\u0027, \u0027volumes\u0027, \u0027backups\u0027]"},{"line_number":22,"context_line":"QUOTA_USAGE_KEYS \u003d [\u0027reserved\u0027, \u0027limit\u0027, \u0027in_use\u0027]"},{"line_number":23,"context_line":""},{"line_number":24,"context_line":""}],"source_content_type":"text/x-python","patch_set":1,"id":"7f231b9d_3047bf20","line":21,"updated":"2017-06-12 05:34:31.000000000","message":"Probably, did you want to update here too?","commit_id":"dc75b9b7d004e5292127e559bfd5eb9a33f7c42d"},{"author":{"_account_id":19262,"name":"Liron Kuchlani","email":"lkuchlan@redhat.com","username":"lkuchlan"},"change_message_id":"7e405d2a1e650f55969f6597c2d7dd2a6b288aa9","unresolved":false,"context_lines":[{"line_number":18,"context_line":"from tempest.lib.common.utils import data_utils"},{"line_number":19,"context_line":"from tempest.lib import decorators"},{"line_number":20,"context_line":""},{"line_number":21,"context_line":"QUOTA_KEYS \u003d [\u0027gigabytes\u0027, \u0027snapshots\u0027, \u0027volumes\u0027, \u0027backups\u0027]"},{"line_number":22,"context_line":"QUOTA_USAGE_KEYS \u003d [\u0027reserved\u0027, \u0027limit\u0027, \u0027in_use\u0027]"},{"line_number":23,"context_line":""},{"line_number":24,"context_line":""}],"source_content_type":"text/x-python","patch_set":1,"id":"7f231b9d_ddb543f0","line":21,"in_reply_to":"7f231b9d_3047bf20","updated":"2017-06-12 07:37:24.000000000","message":"Thanks, done","commit_id":"dc75b9b7d004e5292127e559bfd5eb9a33f7c42d"},{"author":{"_account_id":5689,"name":"Masayuki Igawa","email":"masayuki@igawa.io","username":"igawa"},"change_message_id":"5d5b47415d65c3e7815fb6c0ec925fcde4825212","unresolved":false,"context_lines":[{"line_number":68,"context_line":"                         \u0027snapshots\u0027: 11,"},{"line_number":69,"context_line":"                         \u0027backups\u0027: 11,"},{"line_number":70,"context_line":"                         \u0027backup_gigabytes\u0027: 1009,"},{"line_number":71,"context_line":"                         \u0027per_volume_gigabytes\u0027: 11}"},{"line_number":72,"context_line":""},{"line_number":73,"context_line":"        # Update limits for all quota resources"},{"line_number":74,"context_line":"        quota_set \u003d self.admin_quotas_client.update_quota_set("}],"source_content_type":"text/x-python","patch_set":1,"id":"7f231b9d_1054c3c9","line":71,"updated":"2017-06-12 05:34:31.000000000","message":"How do we know the latest quota_set parameters? Where can I get the information? I\u0027m not sure these are enough or not.","commit_id":"dc75b9b7d004e5292127e559bfd5eb9a33f7c42d"},{"author":{"_account_id":20190,"name":"zhufl","email":"zhu.fanglei@zte.com.cn","username":"zhufl"},"change_message_id":"d04e8a8bbe92dce27e3eb5d4ab88b8e13cf1f004","unresolved":false,"context_lines":[{"line_number":68,"context_line":"                         \u0027snapshots\u0027: 11,"},{"line_number":69,"context_line":"                         \u0027backups\u0027: 11,"},{"line_number":70,"context_line":"                         \u0027backup_gigabytes\u0027: 1009,"},{"line_number":71,"context_line":"                         \u0027per_volume_gigabytes\u0027: 11}"},{"line_number":72,"context_line":""},{"line_number":73,"context_line":"        # Update limits for all quota resources"},{"line_number":74,"context_line":"        quota_set \u003d self.admin_quotas_client.update_quota_set("}],"source_content_type":"text/x-python","patch_set":1,"id":"7f231b9d_5a9ed963","line":71,"range":{"start_line":71,"start_character":49,"end_line":71,"end_character":51},"updated":"2017-06-12 07:21:37.000000000","message":"nit: maybe set to 1009 will look more reasonable","commit_id":"dc75b9b7d004e5292127e559bfd5eb9a33f7c42d"},{"author":{"_account_id":20190,"name":"zhufl","email":"zhu.fanglei@zte.com.cn","username":"zhufl"},"change_message_id":"d04e8a8bbe92dce27e3eb5d4ab88b8e13cf1f004","unresolved":false,"context_lines":[{"line_number":68,"context_line":"                         \u0027snapshots\u0027: 11,"},{"line_number":69,"context_line":"                         \u0027backups\u0027: 11,"},{"line_number":70,"context_line":"                         \u0027backup_gigabytes\u0027: 1009,"},{"line_number":71,"context_line":"                         \u0027per_volume_gigabytes\u0027: 11}"},{"line_number":72,"context_line":""},{"line_number":73,"context_line":"        # Update limits for all quota resources"},{"line_number":74,"context_line":"        quota_set \u003d self.admin_quotas_client.update_quota_set("}],"source_content_type":"text/x-python","patch_set":1,"id":"7f231b9d_3aa9dd7a","line":71,"in_reply_to":"7f231b9d_1054c3c9","updated":"2017-06-12 07:21:37.000000000","message":"Yeah I don\u0027t see the doc either.\nAnd only from the cinder code it seems now the args are enough.\nhttps://github.com/openstack/cinder/blob/6a53247e0563256574eeaae0404ea4ee166876c9/cinder/quota.py#L1136","commit_id":"dc75b9b7d004e5292127e559bfd5eb9a33f7c42d"},{"author":{"_account_id":19262,"name":"Liron Kuchlani","email":"lkuchlan@redhat.com","username":"lkuchlan"},"change_message_id":"7e405d2a1e650f55969f6597c2d7dd2a6b288aa9","unresolved":false,"context_lines":[{"line_number":68,"context_line":"                         \u0027snapshots\u0027: 11,"},{"line_number":69,"context_line":"                         \u0027backups\u0027: 11,"},{"line_number":70,"context_line":"                         \u0027backup_gigabytes\u0027: 1009,"},{"line_number":71,"context_line":"                         \u0027per_volume_gigabytes\u0027: 11}"},{"line_number":72,"context_line":""},{"line_number":73,"context_line":"        # Update limits for all quota resources"},{"line_number":74,"context_line":"        quota_set \u003d self.admin_quotas_client.update_quota_set("}],"source_content_type":"text/x-python","patch_set":1,"id":"7f231b9d_7dc86f54","line":71,"in_reply_to":"7f231b9d_3aa9dd7a","updated":"2017-06-12 07:37:24.000000000","message":"Right, there isn\u0027t doc for those parameters, probably we should open a bug. I got the information from cinder code.","commit_id":"dc75b9b7d004e5292127e559bfd5eb9a33f7c42d"},{"author":{"_account_id":19262,"name":"Liron Kuchlani","email":"lkuchlan@redhat.com","username":"lkuchlan"},"change_message_id":"7e405d2a1e650f55969f6597c2d7dd2a6b288aa9","unresolved":false,"context_lines":[{"line_number":68,"context_line":"                         \u0027snapshots\u0027: 11,"},{"line_number":69,"context_line":"                         \u0027backups\u0027: 11,"},{"line_number":70,"context_line":"                         \u0027backup_gigabytes\u0027: 1009,"},{"line_number":71,"context_line":"                         \u0027per_volume_gigabytes\u0027: 11}"},{"line_number":72,"context_line":""},{"line_number":73,"context_line":"        # Update limits for all quota resources"},{"line_number":74,"context_line":"        quota_set \u003d self.admin_quotas_client.update_quota_set("}],"source_content_type":"text/x-python","patch_set":1,"id":"7f231b9d_1da17baa","line":71,"range":{"start_line":71,"start_character":49,"end_line":71,"end_character":51},"in_reply_to":"7f231b9d_5a9ed963","updated":"2017-06-12 07:37:24.000000000","message":"Done","commit_id":"dc75b9b7d004e5292127e559bfd5eb9a33f7c42d"},{"author":{"_account_id":5689,"name":"Masayuki Igawa","email":"masayuki@igawa.io","username":"igawa"},"change_message_id":"52fdb66b069517f08dcb65b146d8c7e9c1717846","unresolved":false,"context_lines":[{"line_number":19,"context_line":"from tempest.lib import decorators"},{"line_number":20,"context_line":""},{"line_number":21,"context_line":"QUOTA_KEYS \u003d [\u0027gigabytes\u0027, \u0027snapshots\u0027, \u0027volumes\u0027, \u0027backups\u0027,"},{"line_number":22,"context_line":"              \u0027backup_gigabytes\u0027, \u0027per_volume_gigabytes\u0027]"},{"line_number":23,"context_line":"QUOTA_USAGE_KEYS \u003d [\u0027reserved\u0027, \u0027limit\u0027, \u0027in_use\u0027]"},{"line_number":24,"context_line":""},{"line_number":25,"context_line":""}],"source_content_type":"text/x-python","patch_set":2,"id":"3f4b6375_6d3142a3","line":22,"updated":"2017-10-26 02:40:32.000000000","message":"According to the v2 api document[1], both of the parameters (backup_gigabytes and per_volume_gigabytes) don\u0027t exist. On the other hand, v3 doc[2] has both of them. So, I was thinking these parameter are for v3 only. (But probably, I\u0027m wrong).\nSo, my opinion here is, it should be mentioned about the lack or bug of the documentation in the commit message at least.\n\n[1] https://developer.openstack.org/api-ref/block-storage/v2/index.html#update-quotas\n[2] https://developer.openstack.org/api-ref/block-storage/v3/index.html?highlight\u003dbackup_gigabytes#update-quotas-for-a-project","commit_id":"748cc2ee6d28b47921e6aafc1eb3accb3d73b99c"},{"author":{"_account_id":6167,"name":"Ken\u0027ichi Ohmichi","email":"ken1ohmichi@gmail.com","username":"oomichi"},"change_message_id":"9962eda426c99638de518162b8a4839a0cfcc18e","unresolved":false,"context_lines":[{"line_number":19,"context_line":"from tempest.lib import decorators"},{"line_number":20,"context_line":""},{"line_number":21,"context_line":"QUOTA_KEYS \u003d [\u0027gigabytes\u0027, \u0027snapshots\u0027, \u0027volumes\u0027, \u0027backups\u0027,"},{"line_number":22,"context_line":"              \u0027backup_gigabytes\u0027, \u0027per_volume_gigabytes\u0027]"},{"line_number":23,"context_line":"QUOTA_USAGE_KEYS \u003d [\u0027reserved\u0027, \u0027limit\u0027, \u0027in_use\u0027]"},{"line_number":24,"context_line":""},{"line_number":25,"context_line":""}],"source_content_type":"text/x-python","patch_set":2,"id":"3f4b6375_22536219","line":22,"updated":"2017-10-25 17:04:25.000000000","message":"backup_gigabytes has been implemented since Idd24ad2e8a5507bf18e90bd5fad59a4af1c158c6 Aug 2 2014.\n\nper_volume_gigabytes has since Ieb5c087ca7a33d22342470ea790a0c979a6244ea May 27 2015.\n\nSo I think they should be stable, and LGTM","commit_id":"748cc2ee6d28b47921e6aafc1eb3accb3d73b99c"},{"author":{"_account_id":19262,"name":"Liron Kuchlani","email":"lkuchlan@redhat.com","username":"lkuchlan"},"change_message_id":"0b3cfb4eefaf4664f7f81ca1e0b00f048016a990","unresolved":false,"context_lines":[{"line_number":19,"context_line":"from tempest.lib import decorators"},{"line_number":20,"context_line":""},{"line_number":21,"context_line":"QUOTA_KEYS \u003d [\u0027gigabytes\u0027, \u0027snapshots\u0027, \u0027volumes\u0027, \u0027backups\u0027,"},{"line_number":22,"context_line":"              \u0027backup_gigabytes\u0027, \u0027per_volume_gigabytes\u0027]"},{"line_number":23,"context_line":"QUOTA_USAGE_KEYS \u003d [\u0027reserved\u0027, \u0027limit\u0027, \u0027in_use\u0027]"},{"line_number":24,"context_line":""},{"line_number":25,"context_line":""}],"source_content_type":"text/x-python","patch_set":2,"id":"3f4b6375_a23ce0e0","line":22,"in_reply_to":"3f4b6375_6d3142a3","updated":"2017-10-26 07:51:35.000000000","message":"Done","commit_id":"748cc2ee6d28b47921e6aafc1eb3accb3d73b99c"}]}