)]}'
{"/COMMIT_MSG":[{"author":{"_account_id":5689,"name":"Masayuki Igawa","email":"masayuki@igawa.io","username":"igawa"},"change_message_id":"f31f1bf339a977349b3e99e68b820ab5ce76d31f","unresolved":false,"context_lines":[{"line_number":11,"context_line":"sh ./tools/tools/tempest-plugin-sanity.sh or"},{"line_number":12,"context_line":"tox -e plugin-sanity-check will invoke the same."},{"line_number":13,"context_line":""},{"line_number":14,"context_line":"Depends-on: I4528a23ca4933fdb7a3168f8dc99bbf0497ae5cc"},{"line_number":15,"context_line":""},{"line_number":16,"context_line":"Change-Id: If42561bfc1d6dcffbb6537634d7769ef90fab21d"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":13,"id":"3f1d235d_aba1e8ab","line":14,"updated":"2017-07-03 07:39:11.000000000","message":"No, I just meant you could add a dependency with just git like this instruction[1]. Because this the patch is also in tempest. And the patch was already merged. So you can remove this now.\n\n[1] https://docs.openstack.org/infra/manual/developers.html#adding-a-dependency","commit_id":"ff02f52171e01a3febbe2aba48f6e439bb089f54"},{"author":{"_account_id":12393,"name":"chandan kumar","display_name":"Chandan Kumar","email":"chkumar@redhat.com","username":"chkumar246"},"change_message_id":"4f47d38c6e0b536d7aa159acf057de0600d5201a","unresolved":false,"context_lines":[{"line_number":11,"context_line":"sh ./tools/tools/tempest-plugin-sanity.sh or"},{"line_number":12,"context_line":"tox -e plugin-sanity-check will invoke the same."},{"line_number":13,"context_line":""},{"line_number":14,"context_line":"Depends-on: I4528a23ca4933fdb7a3168f8dc99bbf0497ae5cc"},{"line_number":15,"context_line":""},{"line_number":16,"context_line":"Change-Id: If42561bfc1d6dcffbb6537634d7769ef90fab21d"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":13,"id":"3f1d235d_2b3f1826","line":14,"in_reply_to":"3f1d235d_aba1e8ab","updated":"2017-07-03 07:45:50.000000000","message":"Done","commit_id":"ff02f52171e01a3febbe2aba48f6e439bb089f54"}],"tools/tempest-plugin-sanity.sh":[{"author":{"_account_id":1921,"name":"Andrea Frittoli","email":"andrea.frittoli@gmail.com","username":"andrea-frittoli"},"change_message_id":"cf2829dd5d1f92a40525d5374712b1f53b42da81","unresolved":false,"context_lines":[{"line_number":15,"context_line":"#    License for the specific language governing permissions and limitations"},{"line_number":16,"context_line":"#    under the License."},{"line_number":17,"context_line":""},{"line_number":18,"context_line":"# This script is intended to check the sanity of tempest plugins with tempest."},{"line_number":19,"context_line":"# What it does:"},{"line_number":20,"context_line":"# * Creates the virtualenv"},{"line_number":21,"context_line":"# * Install tempest"}],"source_content_type":"text/x-sh","patch_set":6,"id":"7f231b9d_ad65c347","line":18,"range":{"start_line":18,"start_character":34,"end_line":18,"end_character":78},"updated":"2017-06-20 08:34:18.000000000","message":"NIT that tempest plugin against against tempest master","commit_id":"c3f711fc636534985748eec180a31a9d9626ad7b"},{"author":{"_account_id":12393,"name":"chandan kumar","display_name":"Chandan Kumar","email":"chkumar@redhat.com","username":"chkumar246"},"change_message_id":"e10bc9a6cd6c6dc48b8eaf8544462a36290a3c30","unresolved":false,"context_lines":[{"line_number":15,"context_line":"#    License for the specific language governing permissions and limitations"},{"line_number":16,"context_line":"#    under the License."},{"line_number":17,"context_line":""},{"line_number":18,"context_line":"# This script is intended to check the sanity of tempest plugins with tempest."},{"line_number":19,"context_line":"# What it does:"},{"line_number":20,"context_line":"# * Creates the virtualenv"},{"line_number":21,"context_line":"# * Install tempest"}],"source_content_type":"text/x-sh","patch_set":6,"id":"5f201791_f7515364","line":18,"range":{"start_line":18,"start_character":34,"end_line":18,"end_character":78},"in_reply_to":"7f231b9d_ad65c347","updated":"2017-06-20 18:28:21.000000000","message":"Done","commit_id":"c3f711fc636534985748eec180a31a9d9626ad7b"},{"author":{"_account_id":1921,"name":"Andrea Frittoli","email":"andrea.frittoli@gmail.com","username":"andrea-frittoli"},"change_message_id":"cf2829dd5d1f92a40525d5374712b1f53b42da81","unresolved":false,"context_lines":[{"line_number":21,"context_line":"# * Install tempest"},{"line_number":22,"context_line":"# * Retrive the project lists having tempest plugin if project name is"},{"line_number":23,"context_line":"#   given."},{"line_number":24,"context_line":"# * Clone the Project"},{"line_number":25,"context_line":"# * Install the Project and also installs dependencies from"},{"line_number":26,"context_line":"#   test-requirements.txt."},{"line_number":27,"context_line":"# * Create Tempest workspace"}],"source_content_type":"text/x-sh","patch_set":6,"id":"7f231b9d_8d820700","line":24,"range":{"start_line":24,"start_character":4,"end_line":24,"end_character":21},"updated":"2017-06-20 08:34:18.000000000","message":"NIT: I would say: \"for each project in the list...\"","commit_id":"c3f711fc636534985748eec180a31a9d9626ad7b"},{"author":{"_account_id":1921,"name":"Andrea Frittoli","email":"andrea.frittoli@gmail.com","username":"andrea-frittoli"},"change_message_id":"cf2829dd5d1f92a40525d5374712b1f53b42da81","unresolved":false,"context_lines":[{"line_number":29,"context_line":"# * List tempest plugins tests"},{"line_number":30,"context_line":"# * Uninstall the project and its dependencies"},{"line_number":31,"context_line":"# * Again Install tempest"},{"line_number":32,"context_line":"# * Again repeat the step from clonning project"},{"line_number":33,"context_line":"#"},{"line_number":34,"context_line":"# If one of the step fails, The script will exit with failure."},{"line_number":35,"context_line":""}],"source_content_type":"text/x-sh","patch_set":6,"id":"7f231b9d_6dae8b99","line":32,"range":{"start_line":32,"start_character":31,"end_line":32,"end_character":39},"updated":"2017-06-20 08:34:18.000000000","message":"cloning","commit_id":"c3f711fc636534985748eec180a31a9d9626ad7b"},{"author":{"_account_id":12393,"name":"chandan kumar","display_name":"Chandan Kumar","email":"chkumar@redhat.com","username":"chkumar246"},"change_message_id":"e10bc9a6cd6c6dc48b8eaf8544462a36290a3c30","unresolved":false,"context_lines":[{"line_number":29,"context_line":"# * List tempest plugins tests"},{"line_number":30,"context_line":"# * Uninstall the project and its dependencies"},{"line_number":31,"context_line":"# * Again Install tempest"},{"line_number":32,"context_line":"# * Again repeat the step from clonning project"},{"line_number":33,"context_line":"#"},{"line_number":34,"context_line":"# If one of the step fails, The script will exit with failure."},{"line_number":35,"context_line":""}],"source_content_type":"text/x-sh","patch_set":6,"id":"5f201791_d7e3f7a3","line":32,"range":{"start_line":32,"start_character":31,"end_line":32,"end_character":39},"in_reply_to":"7f231b9d_6dae8b99","updated":"2017-06-20 18:28:21.000000000","message":"Done","commit_id":"c3f711fc636534985748eec180a31a9d9626ad7b"},{"author":{"_account_id":1921,"name":"Andrea Frittoli","email":"andrea.frittoli@gmail.com","username":"andrea-frittoli"},"change_message_id":"cf2829dd5d1f92a40525d5374712b1f53b42da81","unresolved":false,"context_lines":[{"line_number":106,"context_line":"for project in $PROJECT_LIST; do"},{"line_number":107,"context_line":"    # Remove blacklisted tempest plugins"},{"line_number":108,"context_line":"    if ! [[ `echo $BLACKLIST | grep -c $project ` -gt 0 ]]; then"},{"line_number":109,"context_line":"        clone_project $project"},{"line_number":110,"context_line":"        install_project $project"},{"line_number":111,"context_line":"        tempest_sanity $project"},{"line_number":112,"context_line":"        uninstall_project $project"},{"line_number":113,"context_line":"        # Removing project might removed installed tempest also"},{"line_number":114,"context_line":"        # so installing it again"},{"line_number":115,"context_line":"        $TVENV pip install ."}],"source_content_type":"text/x-sh","patch_set":6,"id":"7f231b9d_2dad3331","line":112,"range":{"start_line":109,"start_character":0,"end_line":112,"end_character":34},"updated":"2017-06-20 08:34:18.000000000","message":"I think it would be good to wrap this in one function, so we can do something like:\n\ncheck_project $project \u0026\u0026 log_pass $project || log_fail $project\n\nOtherwise the failure in a project will stop the test from running which may hide further failures.","commit_id":"c3f711fc636534985748eec180a31a9d9626ad7b"},{"author":{"_account_id":12393,"name":"chandan kumar","display_name":"Chandan Kumar","email":"chkumar@redhat.com","username":"chkumar246"},"change_message_id":"e10bc9a6cd6c6dc48b8eaf8544462a36290a3c30","unresolved":false,"context_lines":[{"line_number":106,"context_line":"for project in $PROJECT_LIST; do"},{"line_number":107,"context_line":"    # Remove blacklisted tempest plugins"},{"line_number":108,"context_line":"    if ! [[ `echo $BLACKLIST | grep -c $project ` -gt 0 ]]; then"},{"line_number":109,"context_line":"        clone_project $project"},{"line_number":110,"context_line":"        install_project $project"},{"line_number":111,"context_line":"        tempest_sanity $project"},{"line_number":112,"context_line":"        uninstall_project $project"},{"line_number":113,"context_line":"        # Removing project might removed installed tempest also"},{"line_number":114,"context_line":"        # so installing it again"},{"line_number":115,"context_line":"        $TVENV pip install ."}],"source_content_type":"text/x-sh","patch_set":6,"id":"5f201791_b77cfbb5","line":112,"range":{"start_line":109,"start_character":0,"end_line":112,"end_character":34},"in_reply_to":"7f231b9d_2dad3331","updated":"2017-06-20 18:28:21.000000000","message":"I wrapped the above step in a function. But i am not getting how to check for this check_project $project \u0026\u0026 log_pass $project || log_fail $project part.","commit_id":"c3f711fc636534985748eec180a31a9d9626ad7b"},{"author":{"_account_id":5689,"name":"Masayuki Igawa","email":"masayuki@igawa.io","username":"igawa"},"change_message_id":"84e679270646b663c0c797821056659a2ad8b5fe","unresolved":false,"context_lines":[{"line_number":112,"context_line":"    uninstall_project \"$1\""},{"line_number":113,"context_line":"    # Removing project might removed installed tempest also"},{"line_number":114,"context_line":"    # so installing it again."},{"line_number":115,"context_line":"    $TVENV pip install ."},{"line_number":116,"context_line":"}"},{"line_number":117,"context_line":""},{"line_number":118,"context_line":"# Perform sanity on all tempest plugin projects"}],"source_content_type":"text/x-sh","patch_set":8,"id":"5f201791_aa4b1757","line":115,"updated":"2017-06-23 05:55:58.000000000","message":"Probably, you can change like this\n\n clone_project \"$1\" \u0026\u0026 install_project \"$1\" \u0026\u0026 .... \u0026\u0026 $TVENV pip install . \u0026\u0026 return 0\n return 1\n\n(Yeah, this is ugly, so, you can make this more beautiful :)","commit_id":"d3f2edddcda10ea28afbe81cd5836b119423e9ed"},{"author":{"_account_id":12393,"name":"chandan kumar","display_name":"Chandan Kumar","email":"chkumar@redhat.com","username":"chkumar246"},"change_message_id":"ed5009c22ff0388409e3eaffff06194d4c9f445d","unresolved":false,"context_lines":[{"line_number":112,"context_line":"    uninstall_project \"$1\""},{"line_number":113,"context_line":"    # Removing project might removed installed tempest also"},{"line_number":114,"context_line":"    # so installing it again."},{"line_number":115,"context_line":"    $TVENV pip install ."},{"line_number":116,"context_line":"}"},{"line_number":117,"context_line":""},{"line_number":118,"context_line":"# Perform sanity on all tempest plugin projects"}],"source_content_type":"text/x-sh","patch_set":8,"id":"5f201791_6ff183cd","line":115,"in_reply_to":"5f201791_aa4b1757","updated":"2017-06-23 13:48:57.000000000","message":"Done","commit_id":"d3f2edddcda10ea28afbe81cd5836b119423e9ed"},{"author":{"_account_id":5689,"name":"Masayuki Igawa","email":"masayuki@igawa.io","username":"igawa"},"change_message_id":"84e679270646b663c0c797821056659a2ad8b5fe","unresolved":false,"context_lines":[{"line_number":119,"context_line":"for project in $PROJECT_LIST; do"},{"line_number":120,"context_line":"    # Remove blacklisted tempest plugins"},{"line_number":121,"context_line":"    if ! [[ `echo $BLACKLIST | grep -c $project ` -gt 0 ]]; then"},{"line_number":122,"context_line":"        plugin_sanity_check $project"},{"line_number":123,"context_line":"    fi"},{"line_number":124,"context_line":"done"}],"source_content_type":"text/x-sh","patch_set":8,"id":"5f201791_aa6437e5","line":122,"range":{"start_line":122,"start_character":8,"end_line":122,"end_character":36},"updated":"2017-06-23 05:55:58.000000000","message":"And like this?\n\n plugin_sanity_check $project \u0026\u0026 log_pass $project || log_fail $project","commit_id":"d3f2edddcda10ea28afbe81cd5836b119423e9ed"},{"author":{"_account_id":12393,"name":"chandan kumar","display_name":"Chandan Kumar","email":"chkumar@redhat.com","username":"chkumar246"},"change_message_id":"ed5009c22ff0388409e3eaffff06194d4c9f445d","unresolved":false,"context_lines":[{"line_number":119,"context_line":"for project in $PROJECT_LIST; do"},{"line_number":120,"context_line":"    # Remove blacklisted tempest plugins"},{"line_number":121,"context_line":"    if ! [[ `echo $BLACKLIST | grep -c $project ` -gt 0 ]]; then"},{"line_number":122,"context_line":"        plugin_sanity_check $project"},{"line_number":123,"context_line":"    fi"},{"line_number":124,"context_line":"done"}],"source_content_type":"text/x-sh","patch_set":8,"id":"5f201791_4fec87f2","line":122,"range":{"start_line":122,"start_character":8,"end_line":122,"end_character":36},"in_reply_to":"5f201791_aa6437e5","updated":"2017-06-23 13:48:57.000000000","message":"Done","commit_id":"d3f2edddcda10ea28afbe81cd5836b119423e9ed"},{"author":{"_account_id":5689,"name":"Masayuki Igawa","email":"masayuki@igawa.io","username":"igawa"},"change_message_id":"559b597b2237854a1a9f73513424458348572bf8","unresolved":false,"context_lines":[{"line_number":89,"context_line":"    $TVENV tempest list-plugins"},{"line_number":90,"context_line":"    $TVENV tempest run -l"},{"line_number":91,"context_line":"    # Delete tempest workspace"},{"line_number":92,"context_line":"    rm -fr $SANITY_DIR/tempest_sanity ~/.tempest"},{"line_number":93,"context_line":"    cd $SANITY_DIR"},{"line_number":94,"context_line":"}"},{"line_number":95,"context_line":""}],"source_content_type":"text/x-sh","patch_set":9,"id":"5f201791_d9ade59b","line":92,"updated":"2017-06-26 07:54:07.000000000","message":"Why do we need to remove ~/.tempest? I think we shouldn\u0027t remove this because this is a default directory of tempest command.","commit_id":"602b15a484ffe1f2fad59f2012290ebe8071472b"},{"author":{"_account_id":12393,"name":"chandan kumar","display_name":"Chandan Kumar","email":"chkumar@redhat.com","username":"chkumar246"},"change_message_id":"14b9f63f34f96946fca6b1e3a1a122c20112f900","unresolved":false,"context_lines":[{"line_number":89,"context_line":"    $TVENV tempest list-plugins"},{"line_number":90,"context_line":"    $TVENV tempest run -l"},{"line_number":91,"context_line":"    # Delete tempest workspace"},{"line_number":92,"context_line":"    rm -fr $SANITY_DIR/tempest_sanity ~/.tempest"},{"line_number":93,"context_line":"    cd $SANITY_DIR"},{"line_number":94,"context_line":"}"},{"line_number":95,"context_line":""}],"source_content_type":"text/x-sh","patch_set":9,"id":"5f201791_b0f8f37a","line":92,"in_reply_to":"5f201791_5c1c1e77","updated":"2017-06-26 13:07:19.000000000","message":"Done","commit_id":"602b15a484ffe1f2fad59f2012290ebe8071472b"},{"author":{"_account_id":5196,"name":"Matthew Treinish","email":"mtreinish@kortar.org","username":"treinish"},"change_message_id":"2666f8cd1f88bfe3c29d6f837a5a356a3dc0d428","unresolved":false,"context_lines":[{"line_number":89,"context_line":"    $TVENV tempest list-plugins"},{"line_number":90,"context_line":"    $TVENV tempest run -l"},{"line_number":91,"context_line":"    # Delete tempest workspace"},{"line_number":92,"context_line":"    rm -fr $SANITY_DIR/tempest_sanity ~/.tempest"},{"line_number":93,"context_line":"    cd $SANITY_DIR"},{"line_number":94,"context_line":"}"},{"line_number":95,"context_line":""}],"source_content_type":"text/x-sh","patch_set":9,"id":"5f201791_5c1c1e77","line":92,"in_reply_to":"5f201791_bc57b758","updated":"2017-06-26 11:40:42.000000000","message":"This seems kinda brute force, if you\u0027re dealing with tempest workspaces you should use the workspace command to remove them:\n\nhttps://docs.openstack.org/developer/tempest/workspace.html\n\nMasayuki is correct there could be other stuff in .tempest outside of this script just manually deleting everything is probably not the best idea.","commit_id":"602b15a484ffe1f2fad59f2012290ebe8071472b"},{"author":{"_account_id":12393,"name":"chandan kumar","display_name":"Chandan Kumar","email":"chkumar@redhat.com","username":"chkumar246"},"change_message_id":"690490287055c92c7d618b7574d41e8d1c3932c1","unresolved":false,"context_lines":[{"line_number":89,"context_line":"    $TVENV tempest list-plugins"},{"line_number":90,"context_line":"    $TVENV tempest run -l"},{"line_number":91,"context_line":"    # Delete tempest workspace"},{"line_number":92,"context_line":"    rm -fr $SANITY_DIR/tempest_sanity ~/.tempest"},{"line_number":93,"context_line":"    cd $SANITY_DIR"},{"line_number":94,"context_line":"}"},{"line_number":95,"context_line":""}],"source_content_type":"text/x-sh","patch_set":9,"id":"5f201791_bc57b758","line":92,"in_reply_to":"5f201791_d9ade59b","updated":"2017-06-26 08:36:30.000000000","message":"~/.tempest contains the workspace information, if we donot remove this directory it will give error while again running tempest init: \"Directory you are trying to initialize already exists and is not empty,\" and the CI will fail and exist from there and for other projects, it will not perform the operation, So we are removing it.","commit_id":"602b15a484ffe1f2fad59f2012290ebe8071472b"},{"author":{"_account_id":5803,"name":"Attila Fazekas","email":"afazekas@redhat.com","username":"afazekas"},"change_message_id":"c2ce19a7519b5da142f19b3a74a2189964996d06","unresolved":false,"context_lines":[{"line_number":68,"context_line":"SANITY_DIR\u003d$(pwd)"},{"line_number":69,"context_line":"virtualenv $SANITY_DIR/.venv"},{"line_number":70,"context_line":"export TVENV\u003d\"$SANITY_DIR/tools/with_venv.sh\""},{"line_number":71,"context_line":"cd $SANITY_DIR"},{"line_number":72,"context_line":""},{"line_number":73,"context_line":"# Install tempest in a venv"},{"line_number":74,"context_line":"$TVENV pip install ."}],"source_content_type":"text/x-sh","patch_set":14,"id":"3f1d235d_382f5340","line":71,"updated":"2017-07-03 20:41:03.000000000","message":"\"$SANITY_DIR\"","commit_id":"bba42762687c1899ec926f4ca83a83269224989b"},{"author":{"_account_id":12393,"name":"chandan kumar","display_name":"Chandan Kumar","email":"chkumar@redhat.com","username":"chkumar246"},"change_message_id":"be6980e3a053b7d6815c70acbd7eea8f31740fe4","unresolved":false,"context_lines":[{"line_number":68,"context_line":"SANITY_DIR\u003d$(pwd)"},{"line_number":69,"context_line":"virtualenv $SANITY_DIR/.venv"},{"line_number":70,"context_line":"export TVENV\u003d\"$SANITY_DIR/tools/with_venv.sh\""},{"line_number":71,"context_line":"cd $SANITY_DIR"},{"line_number":72,"context_line":""},{"line_number":73,"context_line":"# Install tempest in a venv"},{"line_number":74,"context_line":"$TVENV pip install ."}],"source_content_type":"text/x-sh","patch_set":14,"id":"3f1d235d_dc996c6e","line":71,"in_reply_to":"3f1d235d_382f5340","updated":"2017-07-04 05:30:03.000000000","message":"Done","commit_id":"bba42762687c1899ec926f4ca83a83269224989b"},{"author":{"_account_id":5689,"name":"Masayuki Igawa","email":"masayuki@igawa.io","username":"igawa"},"change_message_id":"194c398d839fab32196bb6003f33409a194f089f","unresolved":false,"context_lines":[{"line_number":70,"context_line":"cd \"$SANITY_DIR\""},{"line_number":71,"context_line":""},{"line_number":72,"context_line":"# Install tempest in a venv"},{"line_number":73,"context_line":"$TVENV pip install ."},{"line_number":74,"context_line":""},{"line_number":75,"context_line":"# Function to install project"},{"line_number":76,"context_line":"function install_project() {"}],"source_content_type":"text/x-sh","patch_set":17,"id":"3f1d235d_85113e55","line":73,"updated":"2017-07-05 02:04:22.000000000","message":"I think this doesn\u0027t work when $TVENV contains white spaces. So, we probably need to quote $TVENV, too if we really need to care about that.\n\nI did a tiny test for this like below..\n\n $ SANITY_DIR\u003d$(pwd)                                                                                    $ echo $SANITY_DIR\n /home/masayuki/tmp/foo bar\n $ export TVENV\u003d\"$SANITY_DIR/tools/with_venv.sh\"\n $ echo $TVENV\n /home/masayuki/tmp/foo bar/tools/with_venv.sh\n $ $TVENV ls\n bash: /home/masayuki/tmp/foo: No such file or directory","commit_id":"f1e7c7b306652b03f5f1e3e2c65244bf2a9d2020"},{"author":{"_account_id":1921,"name":"Andrea Frittoli","email":"andrea.frittoli@gmail.com","username":"andrea-frittoli"},"change_message_id":"458fdb5012fff6582330e631d7331372b2f9ab38","unresolved":false,"context_lines":[{"line_number":107,"context_line":"function plugin_sanity_check() {"},{"line_number":108,"context_line":"    if  clone_project \"$1\"  \u0026\u0026  install_project \"$1\"  \u0026\u0026  tempest_sanity \"$1\" \\"},{"line_number":109,"context_line":"        \u0026\u0026  uninstall_project \"$1\"  \u0026\u0026  \"$TVENV\" pip install . ; then"},{"line_number":110,"context_line":"        return 0"},{"line_number":111,"context_line":"    else"},{"line_number":112,"context_line":"        return 1"},{"line_number":113,"context_line":"    fi"},{"line_number":114,"context_line":"}"},{"line_number":115,"context_line":""},{"line_number":116,"context_line":"# Log status"}],"source_content_type":"text/x-sh","patch_set":18,"id":"3f1d235d_a4ac009f","line":113,"range":{"start_line":110,"start_character":0,"end_line":113,"end_character":6},"updated":"2017-07-06 11:22:47.000000000","message":"I think this part is redundant. If any of the steps failed then the function returns the failed return code anyways","commit_id":"b09c556d233116145e9071f0eef85b03d3d662e3"},{"author":{"_account_id":12393,"name":"chandan kumar","display_name":"Chandan Kumar","email":"chkumar@redhat.com","username":"chkumar246"},"change_message_id":"1aa07224bb94f5d36e9b85bf5146feab3d17c2d5","unresolved":false,"context_lines":[{"line_number":107,"context_line":"function plugin_sanity_check() {"},{"line_number":108,"context_line":"    if  clone_project \"$1\"  \u0026\u0026  install_project \"$1\"  \u0026\u0026  tempest_sanity \"$1\" \\"},{"line_number":109,"context_line":"        \u0026\u0026  uninstall_project \"$1\"  \u0026\u0026  \"$TVENV\" pip install . ; then"},{"line_number":110,"context_line":"        return 0"},{"line_number":111,"context_line":"    else"},{"line_number":112,"context_line":"        return 1"},{"line_number":113,"context_line":"    fi"},{"line_number":114,"context_line":"}"},{"line_number":115,"context_line":""},{"line_number":116,"context_line":"# Log status"}],"source_content_type":"text/x-sh","patch_set":18,"id":"3f1d235d_1316544a","line":113,"range":{"start_line":110,"start_character":0,"end_line":113,"end_character":6},"in_reply_to":"3f1d235d_a4ac009f","updated":"2017-07-06 13:10:07.000000000","message":"Yes, Correct. I am removing this part.","commit_id":"b09c556d233116145e9071f0eef85b03d3d662e3"},{"author":{"_account_id":1921,"name":"Andrea Frittoli","email":"andrea.frittoli@gmail.com","username":"andrea-frittoli"},"change_message_id":"458fdb5012fff6582330e631d7331372b2f9ab38","unresolved":false,"context_lines":[{"line_number":120,"context_line":"for project in $PROJECT_LIST; do"},{"line_number":121,"context_line":"    # Remove blacklisted tempest plugins"},{"line_number":122,"context_line":"    if ! [[ `echo $BLACKLIST | grep -c $project ` -gt 0 ]]; then"},{"line_number":123,"context_line":"        plugin_sanity_check $project \u0026\u0026 log_pass+\u003d\", $project\" || \\"},{"line_number":124,"context_line":"        log_fail+\u003d\", $project\""},{"line_number":125,"context_line":"    fi"},{"line_number":126,"context_line":"done"},{"line_number":127,"context_line":""}],"source_content_type":"text/x-sh","patch_set":18,"id":"3f1d235d_24d470e8","line":124,"range":{"start_line":123,"start_character":37,"end_line":124,"end_character":30},"updated":"2017-07-06 11:22:47.000000000","message":"I\u0027m not sure this is very helpful for debugging. In case A, B, C pass and D, E fail the output will look like:\n\n, A, B, C\n, E, F","commit_id":"b09c556d233116145e9071f0eef85b03d3d662e3"},{"author":{"_account_id":12393,"name":"chandan kumar","display_name":"Chandan Kumar","email":"chkumar@redhat.com","username":"chkumar246"},"change_message_id":"1aa07224bb94f5d36e9b85bf5146feab3d17c2d5","unresolved":false,"context_lines":[{"line_number":120,"context_line":"for project in $PROJECT_LIST; do"},{"line_number":121,"context_line":"    # Remove blacklisted tempest plugins"},{"line_number":122,"context_line":"    if ! [[ `echo $BLACKLIST | grep -c $project ` -gt 0 ]]; then"},{"line_number":123,"context_line":"        plugin_sanity_check $project \u0026\u0026 log_pass+\u003d\", $project\" || \\"},{"line_number":124,"context_line":"        log_fail+\u003d\", $project\""},{"line_number":125,"context_line":"    fi"},{"line_number":126,"context_line":"done"},{"line_number":127,"context_line":""}],"source_content_type":"text/x-sh","patch_set":18,"id":"3f1d235d_d37b3c89","line":124,"range":{"start_line":123,"start_character":37,"end_line":124,"end_character":30},"in_reply_to":"3f1d235d_24d470e8","updated":"2017-07-06 13:10:07.000000000","message":"I am improving the wording for the same. here is the output for the modified change: https://paste.fedoraproject.org/paste/S1a7EdKvKA6a6gES~LtNoA","commit_id":"b09c556d233116145e9071f0eef85b03d3d662e3"},{"author":{"_account_id":1921,"name":"Andrea Frittoli","email":"andrea.frittoli@gmail.com","username":"andrea-frittoli"},"change_message_id":"458fdb5012fff6582330e631d7331372b2f9ab38","unresolved":false,"context_lines":[{"line_number":127,"context_line":""},{"line_number":128,"context_line":"# Print Status"},{"line_number":129,"context_line":"echo $log_pass"},{"line_number":130,"context_line":"echo $log_fail"}],"source_content_type":"text/x-sh","patch_set":18,"id":"3f1d235d_844104ac","line":130,"updated":"2017-07-06 11:22:47.000000000","message":"The return code is not represented here. If any of the test fails, the test job invoking this script will still see a zero return code and pass.","commit_id":"b09c556d233116145e9071f0eef85b03d3d662e3"},{"author":{"_account_id":12393,"name":"chandan kumar","display_name":"Chandan Kumar","email":"chkumar@redhat.com","username":"chkumar246"},"change_message_id":"1aa07224bb94f5d36e9b85bf5146feab3d17c2d5","unresolved":false,"context_lines":[{"line_number":127,"context_line":""},{"line_number":128,"context_line":"# Print Status"},{"line_number":129,"context_line":"echo $log_pass"},{"line_number":130,"context_line":"echo $log_fail"}],"source_content_type":"text/x-sh","patch_set":18,"id":"3f1d235d_53672cea","line":130,"in_reply_to":"3f1d235d_844104ac","updated":"2017-07-06 13:10:07.000000000","message":"Removing this part also, as +x is used so every step will be visible in console output.","commit_id":"b09c556d233116145e9071f0eef85b03d3d662e3"},{"author":{"_account_id":5803,"name":"Attila Fazekas","email":"afazekas@redhat.com","username":"afazekas"},"change_message_id":"a60918677425ba74d67ab2d704655b0d0971bdb5","unresolved":false,"context_lines":[{"line_number":45,"context_line":"set -ex"},{"line_number":46,"context_line":""},{"line_number":47,"context_line":"# retrieve a list of projects having tempest plugins"},{"line_number":48,"context_line":"#PROJECT_LIST\u003d\"$(python tools/generate-tempest-plugins-list.py)\""},{"line_number":49,"context_line":"PROJECT_LIST\u003d\"manila foobar\""},{"line_number":50,"context_line":"# List of projects having tempest plugin stale or unmaintained from long time"},{"line_number":51,"context_line":"BLACKLIST\u003d\"trio2o\""}],"source_content_type":"text/x-sh","patch_set":19,"id":"3f1d235d_50733481","line":48,"updated":"2017-07-10 23:31:41.000000000","message":"Commneted executable code is confusing.","commit_id":"8f5e9aca2f635302ee0f3149316bfc9b34d29d55"},{"author":{"_account_id":5803,"name":"Attila Fazekas","email":"afazekas@redhat.com","username":"afazekas"},"change_message_id":"a60918677425ba74d67ab2d704655b0d0971bdb5","unresolved":false,"context_lines":[{"line_number":46,"context_line":""},{"line_number":47,"context_line":"# retrieve a list of projects having tempest plugins"},{"line_number":48,"context_line":"#PROJECT_LIST\u003d\"$(python tools/generate-tempest-plugins-list.py)\""},{"line_number":49,"context_line":"PROJECT_LIST\u003d\"manila foobar\""},{"line_number":50,"context_line":"# List of projects having tempest plugin stale or unmaintained from long time"},{"line_number":51,"context_line":"BLACKLIST\u003d\"trio2o\""},{"line_number":52,"context_line":""}],"source_content_type":"text/x-sh","patch_set":19,"id":"3f1d235d_306e7896","line":49,"updated":"2017-07-10 23:31:41.000000000","message":"This variable is never readed","commit_id":"8f5e9aca2f635302ee0f3149316bfc9b34d29d55"},{"author":{"_account_id":12393,"name":"chandan kumar","display_name":"Chandan Kumar","email":"chkumar@redhat.com","username":"chkumar246"},"change_message_id":"ea22453303b86cc90240bb4e7ea14fc2f2e444a0","unresolved":false,"context_lines":[{"line_number":46,"context_line":""},{"line_number":47,"context_line":"# retrieve a list of projects having tempest plugins"},{"line_number":48,"context_line":"#PROJECT_LIST\u003d\"$(python tools/generate-tempest-plugins-list.py)\""},{"line_number":49,"context_line":"PROJECT_LIST\u003d\"manila foobar\""},{"line_number":50,"context_line":"# List of projects having tempest plugin stale or unmaintained from long time"},{"line_number":51,"context_line":"BLACKLIST\u003d\"trio2o\""},{"line_number":52,"context_line":""}],"source_content_type":"text/x-sh","patch_set":19,"id":"3f1d235d_111b7e1b","line":49,"in_reply_to":"3f1d235d_306e7896","updated":"2017-07-11 02:55:56.000000000","message":"sorry it got left due to testing data fixed in new patchset, thanks for catching it.","commit_id":"8f5e9aca2f635302ee0f3149316bfc9b34d29d55"}],"tox.ini":[{"author":{"_account_id":1921,"name":"Andrea Frittoli","email":"andrea.frittoli@gmail.com","username":"andrea-frittoli"},"change_message_id":"cf2829dd5d1f92a40525d5374712b1f53b42da81","unresolved":false,"context_lines":[{"line_number":186,"context_line":"deps \u003d bindep"},{"line_number":187,"context_line":"commands \u003d bindep test"},{"line_number":188,"context_line":""},{"line_number":189,"context_line":"[testenv:sanity]"},{"line_number":190,"context_line":"# perform tempest plugin sanity"},{"line_number":191,"context_line":"whitelist_externals \u003d bash"},{"line_number":192,"context_line":"commands \u003d"}],"source_content_type":"text/x-properties","patch_set":6,"id":"7f231b9d_ed54db23","line":189,"range":{"start_line":189,"start_character":9,"end_line":189,"end_character":15},"updated":"2017-06-20 08:34:18.000000000","message":"maybe plugin-sanity-check?","commit_id":"c3f711fc636534985748eec180a31a9d9626ad7b"},{"author":{"_account_id":12393,"name":"chandan kumar","display_name":"Chandan Kumar","email":"chkumar@redhat.com","username":"chkumar246"},"change_message_id":"e10bc9a6cd6c6dc48b8eaf8544462a36290a3c30","unresolved":false,"context_lines":[{"line_number":186,"context_line":"deps \u003d bindep"},{"line_number":187,"context_line":"commands \u003d bindep test"},{"line_number":188,"context_line":""},{"line_number":189,"context_line":"[testenv:sanity]"},{"line_number":190,"context_line":"# perform tempest plugin sanity"},{"line_number":191,"context_line":"whitelist_externals \u003d bash"},{"line_number":192,"context_line":"commands \u003d"}],"source_content_type":"text/x-properties","patch_set":6,"id":"5f201791_f73a7332","line":189,"range":{"start_line":189,"start_character":9,"end_line":189,"end_character":15},"in_reply_to":"7f231b9d_ed54db23","updated":"2017-06-20 18:28:21.000000000","message":"Done","commit_id":"c3f711fc636534985748eec180a31a9d9626ad7b"}]}