)]}'
{"tempest/tests/lib/services/network/test_quotas_client.py":[{"author":{"_account_id":5689,"name":"Masayuki Igawa","email":"masayuki@igawa.io","username":"igawa"},"change_message_id":"101181b7fc71622baca8cdcef0d9f2136cb902b0","unresolved":false,"context_lines":[{"line_number":103,"context_line":"        self._test_reset_quotas()"},{"line_number":104,"context_line":""},{"line_number":105,"context_line":"    def test_reset_quotas_with_bytes_body(self):"},{"line_number":106,"context_line":"        self._test_reset_quotas(bytes_body\u003dTrue)"}],"source_content_type":"text/x-python","patch_set":6,"id":"7f231b9d_f67155e0","line":106,"updated":"2017-06-20 01:50:49.000000000","message":"I think this is not useful because reset_quotas doesn\u0027t have body.","commit_id":"7103ba5aa9873420a27f0fae654465251221f8bc"},{"author":{"_account_id":23186,"name":"Felipe Monteiro","email":"felipe.carneiro.monteiro@gmail.com","username":"felipe.monteiro"},"change_message_id":"e70642add4c13b1d44a2fdb085b2ad41f98f08a0","unresolved":false,"context_lines":[{"line_number":54,"context_line":"            bytes_body,"},{"line_number":55,"context_line":"            200)"},{"line_number":56,"context_line":""},{"line_number":57,"context_line":"    def _test_show_quotas(self, bytes_body\u003dFalse):"},{"line_number":58,"context_line":"        self.check_service_client_function("},{"line_number":59,"context_line":"            self.quotas_client.show_quotas,"},{"line_number":60,"context_line":"            \"tempest.lib.common.rest_client.RestClient.get\","}],"source_content_type":"text/x-python","patch_set":8,"id":"5f201791_eff5fd84","line":57,"range":{"start_line":57,"start_character":8,"end_line":57,"end_character":25},"updated":"2017-06-20 15:51:25.000000000","message":"This should be _test_show_quota","commit_id":"b6acf327cb4d4830ad9e43fdbece651a913bffe3"},{"author":{"_account_id":23186,"name":"Felipe Monteiro","email":"felipe.carneiro.monteiro@gmail.com","username":"felipe.monteiro"},"change_message_id":"e70642add4c13b1d44a2fdb085b2ad41f98f08a0","unresolved":false,"context_lines":[{"line_number":58,"context_line":"        self.check_service_client_function("},{"line_number":59,"context_line":"            self.quotas_client.show_quotas,"},{"line_number":60,"context_line":"            \"tempest.lib.common.rest_client.RestClient.get\","},{"line_number":61,"context_line":"            self.FAKE_QUOTAS,"},{"line_number":62,"context_line":"            bytes_body,"},{"line_number":63,"context_line":"            200,"},{"line_number":64,"context_line":"            tenant_id\u003dself.FAKE_QUOTA_TENANT_ID)"}],"source_content_type":"text/x-python","patch_set":8,"id":"5f201791_cff2419b","line":61,"range":{"start_line":61,"start_character":17,"end_line":61,"end_character":28},"updated":"2017-06-20 15:51:25.000000000","message":"Returns an object, not a list.","commit_id":"b6acf327cb4d4830ad9e43fdbece651a913bffe3"},{"author":{"_account_id":23186,"name":"Felipe Monteiro","email":"felipe.carneiro.monteiro@gmail.com","username":"felipe.monteiro"},"change_message_id":"e70642add4c13b1d44a2fdb085b2ad41f98f08a0","unresolved":false,"context_lines":[{"line_number":63,"context_line":"            200,"},{"line_number":64,"context_line":"            tenant_id\u003dself.FAKE_QUOTA_TENANT_ID)"},{"line_number":65,"context_line":""},{"line_number":66,"context_line":"    def _test_update_quotas(self, bytes_body\u003dFalse):"},{"line_number":67,"context_line":"        self.check_service_client_function("},{"line_number":68,"context_line":"            self.quotas_client.update_quotas,"},{"line_number":69,"context_line":"            \"tempest.lib.common.rest_client.RestClient.put\","}],"source_content_type":"text/x-python","patch_set":8,"id":"5f201791_0f3ef928","line":66,"range":{"start_line":66,"start_character":8,"end_line":66,"end_character":27},"updated":"2017-06-20 15:51:25.000000000","message":"_test_update_quota","commit_id":"b6acf327cb4d4830ad9e43fdbece651a913bffe3"},{"author":{"_account_id":23186,"name":"Felipe Monteiro","email":"felipe.carneiro.monteiro@gmail.com","username":"felipe.monteiro"},"change_message_id":"e70642add4c13b1d44a2fdb085b2ad41f98f08a0","unresolved":false,"context_lines":[{"line_number":67,"context_line":"        self.check_service_client_function("},{"line_number":68,"context_line":"            self.quotas_client.update_quotas,"},{"line_number":69,"context_line":"            \"tempest.lib.common.rest_client.RestClient.put\","},{"line_number":70,"context_line":"            self.FAKE_QUOTAS,"},{"line_number":71,"context_line":"            bytes_body,"},{"line_number":72,"context_line":"            200,"},{"line_number":73,"context_line":"            tenant_id\u003dself.FAKE_QUOTA_TENANT_ID)"}],"source_content_type":"text/x-python","patch_set":8,"id":"5f201791_af44a5b8","line":70,"range":{"start_line":70,"start_character":17,"end_line":70,"end_character":28},"updated":"2017-06-20 15:51:25.000000000","message":"See above.","commit_id":"b6acf327cb4d4830ad9e43fdbece651a913bffe3"},{"author":{"_account_id":23186,"name":"Felipe Monteiro","email":"felipe.carneiro.monteiro@gmail.com","username":"felipe.monteiro"},"change_message_id":"e70642add4c13b1d44a2fdb085b2ad41f98f08a0","unresolved":false,"context_lines":[{"line_number":72,"context_line":"            200,"},{"line_number":73,"context_line":"            tenant_id\u003dself.FAKE_QUOTA_TENANT_ID)"},{"line_number":74,"context_line":""},{"line_number":75,"context_line":"    def test_reset_quotas(self):"},{"line_number":76,"context_line":"        self.check_service_client_function("},{"line_number":77,"context_line":"            self.quotas_client.reset_quotas,"},{"line_number":78,"context_line":"            \"tempest.lib.common.rest_client.RestClient.delete\","}],"source_content_type":"text/x-python","patch_set":8,"id":"5f201791_6f18cdd2","line":75,"range":{"start_line":75,"start_character":8,"end_line":75,"end_character":25},"updated":"2017-06-20 15:51:25.000000000","message":"test_reset_quota","commit_id":"b6acf327cb4d4830ad9e43fdbece651a913bffe3"},{"author":{"_account_id":23186,"name":"Felipe Monteiro","email":"felipe.carneiro.monteiro@gmail.com","username":"felipe.monteiro"},"change_message_id":"e70642add4c13b1d44a2fdb085b2ad41f98f08a0","unresolved":false,"context_lines":[{"line_number":86,"context_line":"    def test_list_quotas_with_bytes_body(self):"},{"line_number":87,"context_line":"        self._test_list_quotas(bytes_body\u003dTrue)"},{"line_number":88,"context_line":""},{"line_number":89,"context_line":"    def test_show_quotas_with_str_body(self):"},{"line_number":90,"context_line":"        self._test_show_quotas()"},{"line_number":91,"context_line":""},{"line_number":92,"context_line":"    def test_show_quotas_with_bytes_body(self):"}],"source_content_type":"text/x-python","patch_set":8,"id":"5f201791_8f78c9f8","line":89,"range":{"start_line":89,"start_character":8,"end_line":89,"end_character":38},"updated":"2017-06-20 15:51:25.000000000","message":"This one and all the others that should be singular (i.e. test_show_quota_...) should be changed.","commit_id":"b6acf327cb4d4830ad9e43fdbece651a913bffe3"},{"author":{"_account_id":5689,"name":"Masayuki Igawa","email":"masayuki@igawa.io","username":"igawa"},"change_message_id":"c26a3c7aef02c7c5fb1124711b6eee3d03aedcaf","unresolved":false,"context_lines":[{"line_number":86,"context_line":"    def test_list_quotas_with_bytes_body(self):"},{"line_number":87,"context_line":"        self._test_list_quotas(bytes_body\u003dTrue)"},{"line_number":88,"context_line":""},{"line_number":89,"context_line":"    def test_show_quotas_with_str_body(self):"},{"line_number":90,"context_line":"        self._test_show_quotas()"},{"line_number":91,"context_line":""},{"line_number":92,"context_line":"    def test_show_quotas_with_bytes_body(self):"}],"source_content_type":"text/x-python","patch_set":8,"id":"5f201791_9d8eb52c","line":89,"updated":"2017-06-21 03:20:18.000000000","message":"Why are these should be changed to singular? I think the method names in QuotasClient are all plurals.","commit_id":"b6acf327cb4d4830ad9e43fdbece651a913bffe3"},{"author":{"_account_id":5689,"name":"Masayuki Igawa","email":"masayuki@igawa.io","username":"igawa"},"change_message_id":"36d93c94534f9c3e0d2b2c5a47d98ea72dbeaf45","unresolved":false,"context_lines":[{"line_number":86,"context_line":"    def test_list_quotas_with_bytes_body(self):"},{"line_number":87,"context_line":"        self._test_list_quotas(bytes_body\u003dTrue)"},{"line_number":88,"context_line":""},{"line_number":89,"context_line":"    def test_show_quotas_with_str_body(self):"},{"line_number":90,"context_line":"        self._test_show_quotas()"},{"line_number":91,"context_line":""},{"line_number":92,"context_line":"    def test_show_quotas_with_bytes_body(self):"}],"source_content_type":"text/x-python","patch_set":8,"id":"5f201791_3f0530c3","line":89,"in_reply_to":"5f201791_0c6a747f","updated":"2017-06-22 05:44:21.000000000","message":"heh, OK sure.\n\nI wrote a wrong English sentence.., btw.(\"Why are these should be..\"???? :-p)","commit_id":"b6acf327cb4d4830ad9e43fdbece651a913bffe3"},{"author":{"_account_id":23186,"name":"Felipe Monteiro","email":"felipe.carneiro.monteiro@gmail.com","username":"felipe.monteiro"},"change_message_id":"0536d1e39fb4755bc6b5f37369eb18999c989bca","unresolved":false,"context_lines":[{"line_number":86,"context_line":"    def test_list_quotas_with_bytes_body(self):"},{"line_number":87,"context_line":"        self._test_list_quotas(bytes_body\u003dTrue)"},{"line_number":88,"context_line":""},{"line_number":89,"context_line":"    def test_show_quotas_with_str_body(self):"},{"line_number":90,"context_line":"        self._test_show_quotas()"},{"line_number":91,"context_line":""},{"line_number":92,"context_line":"    def test_show_quotas_with_bytes_body(self):"}],"source_content_type":"text/x-python","patch_set":8,"id":"5f201791_0c6a747f","line":89,"in_reply_to":"5f201791_9d8eb52c","updated":"2017-06-21 05:22:46.000000000","message":"My mistake: I was going off the Neutron API documentation which uses singular for update, create, etc. and plural for list. And I deduced (wrongly) that it was a copy/paste error because L70 uses self.FAKE_QUOTAS rather than self.FAKE_QUOTA (e.g.) -- I should\u0027ve checked Tempest client first.","commit_id":"b6acf327cb4d4830ad9e43fdbece651a913bffe3"},{"author":{"_account_id":23186,"name":"Felipe Monteiro","email":"felipe.carneiro.monteiro@gmail.com","username":"felipe.monteiro"},"change_message_id":"9b84a08086b5b4b5822bb01936e1d5129e21ac25","unresolved":false,"context_lines":[{"line_number":70,"context_line":"            {\"quota\": self.FAKE_QUOTAS[\"quotas\"][0]},"},{"line_number":71,"context_line":"            bytes_body,"},{"line_number":72,"context_line":"            200,"},{"line_number":73,"context_line":"            tenant_id\u003dself.FAKE_QUOTA_TENANT_ID)"},{"line_number":74,"context_line":""},{"line_number":75,"context_line":"    def test_reset_quota(self):"},{"line_number":76,"context_line":"        self.check_service_client_function("}],"source_content_type":"text/x-python","patch_set":9,"id":"5f201791_2873e682","line":73,"updated":"2017-06-20 20:18:22.000000000","message":"It\u0027d be nice if something is actually updated here, but looking at the docs all the params are optional so I guess this is legal.","commit_id":"212f702c618248153509d3982b0fcc8e74c6c80c"}]}