)]}'
{"tempest/tests/lib/services/network/test_networks_client.py":[{"author":{"_account_id":23186,"name":"Felipe Monteiro","email":"felipe.carneiro.monteiro@gmail.com","username":"felipe.monteiro"},"change_message_id":"544d65fa672cf4180eeb3889f87aee2e133ea3e5","unresolved":false,"context_lines":[{"line_number":116,"context_line":"            {\"network\": self.FAKE_NETWORKS[\"networks\"][0]},"},{"line_number":117,"context_line":"            bytes_body,"},{"line_number":118,"context_line":"            201,"},{"line_number":119,"context_line":"            network\u003dself.FAKE_NETWORK1)"},{"line_number":120,"context_line":""},{"line_number":121,"context_line":"    def _test_create_bulk_networks(self, bytes_body\u003dFalse):"},{"line_number":122,"context_line":"        self.check_service_client_function("}],"source_content_type":"text/x-python","patch_set":4,"id":"5f201791_6b6ab8b3","line":119,"range":{"start_line":119,"start_character":12,"end_line":119,"end_character":38},"updated":"2017-06-22 15:43:13.000000000","message":"**self.FAKE_NETWORK1\n\nThe way it is now will produce a request body of {\u0027network\u0027: {\u0027network\u0027: ...}} which isn\u0027t correct.\n\nhttps://github.com/openstack/tempest/blob/master/tempest/lib/services/network/networks_client.py#L26","commit_id":"e526cce871faf2f6201ce7e655510a6bd7e38211"},{"author":{"_account_id":23186,"name":"Felipe Monteiro","email":"felipe.carneiro.monteiro@gmail.com","username":"felipe.monteiro"},"change_message_id":"72a61afe4ce6f2e6cd01aeb15862348ce134286b","unresolved":false,"context_lines":[{"line_number":196,"context_line":"            status\u003d204,"},{"line_number":197,"context_line":"            network_id\u003dself.FAKE_NETWORK_ID)"},{"line_number":198,"context_line":""},{"line_number":199,"context_line":"    def test_list_dhcp_agents_on_hosting_network(self):"},{"line_number":200,"context_line":"        self.check_service_client_function("},{"line_number":201,"context_line":"            self.networks_client.list_dhcp_agents_on_hosting_network,"},{"line_number":202,"context_line":"            \"tempest.lib.common.rest_client.RestClient.get\","}],"source_content_type":"text/x-python","patch_set":6,"id":"5f201791_1885b25a","line":199,"range":{"start_line":199,"start_character":8,"end_line":199,"end_character":48},"updated":"2017-06-23 18:36:30.000000000","message":"This should start with an underscore and take bytes_body argument since it has a response body. Then add 2 tests for str_body and bytes_body. test_delete_network doesn\u0027t take bytes_body arg because it has no response body.","commit_id":"3e7c2d33a50729330afaf354e747ebe4f4bdd527"},{"author":{"_account_id":5689,"name":"Masayuki Igawa","email":"masayuki@igawa.io","username":"igawa"},"change_message_id":"ad7a91c3af73cb84543ae27a13467a4faff58639","unresolved":false,"context_lines":[{"line_number":239,"context_line":"        self._test_list_dhcp_agents_on_hosting_network()"},{"line_number":240,"context_line":""},{"line_number":241,"context_line":"    def test_list_dhcp_agents_on_hosting_network_with_bytes_body(self):"},{"line_number":242,"context_line":"        self._test_list_dhcp_agents_on_hosting_network(bytes_body\u003dTrue)"}],"source_content_type":"text/x-python","patch_set":8,"id":"5f201791_516e2a2f","line":242,"updated":"2017-06-27 07:21:58.000000000","message":"list_dhcp_agents_on_hosting_network() doesn\u0027t have body, so, I think we don\u0027t need bytes_body\u003dTrue test case. And we can make the test like test_delete_network().","commit_id":"4c96eef902ae77e4e4541f7504027fec5292b3dd"},{"author":{"_account_id":8556,"name":"Ghanshyam Maan","display_name":"Ghanshyam Maan","email":"gmaan.os14@gmail.com","username":"ghanshyam"},"change_message_id":"aab1e07491b5c94f4f2cb4722c5b645b6bd51b04","unresolved":false,"context_lines":[{"line_number":239,"context_line":"        self._test_list_dhcp_agents_on_hosting_network()"},{"line_number":240,"context_line":""},{"line_number":241,"context_line":"    def test_list_dhcp_agents_on_hosting_network_with_bytes_body(self):"},{"line_number":242,"context_line":"        self._test_list_dhcp_agents_on_hosting_network(bytes_body\u003dTrue)"}],"source_content_type":"text/x-python","patch_set":8,"id":"ff82abbf_5c5db5e7","line":242,"in_reply_to":"5f201791_4f2e6cfb","updated":"2017-11-30 14:02:37.000000000","message":"yea it has response body\n\n- http://logs.openstack.org/75/515375/5/check/legacy-tempest-dsvm-py35/2c506e0/logs/tempest.txt.gz#_2017-11-21_05_41_03_384","commit_id":"4c96eef902ae77e4e4541f7504027fec5292b3dd"},{"author":{"_account_id":23186,"name":"Felipe Monteiro","email":"felipe.carneiro.monteiro@gmail.com","username":"felipe.monteiro"},"change_message_id":"851b9ffe55d087e9dd1d61e31a051e63a0991d39","unresolved":false,"context_lines":[{"line_number":239,"context_line":"        self._test_list_dhcp_agents_on_hosting_network()"},{"line_number":240,"context_line":""},{"line_number":241,"context_line":"    def test_list_dhcp_agents_on_hosting_network_with_bytes_body(self):"},{"line_number":242,"context_line":"        self._test_list_dhcp_agents_on_hosting_network(bytes_body\u003dTrue)"}],"source_content_type":"text/x-python","patch_set":8,"id":"5f201791_4f2e6cfb","line":242,"in_reply_to":"5f201791_516e2a2f","updated":"2017-06-27 15:53:40.000000000","message":"When I run (using default public network):\n\ncurl -g -i -X GET http://127.0.0.1:9696/v2.0/networks/80515c45-651f-4f9a-b82b-2ca8a7301a8d/dhcp-agents -H \"User-Agent: python-neutronclient\" -H \"Accept: application/json\" -H \"X-Auth-Token: $TOKEN\"\n\nI get FAKE_DHCP_AGENTS. This is the same endpoint as \"\u0027/networks/%s/dhcp-agents\u0027 % network_id\" in list_dhcp_agents_on_hosting_network in networks_client.","commit_id":"4c96eef902ae77e4e4541f7504027fec5292b3dd"}]}