)]}'
{"tempest/api/volume/test_volumes_list.py":[{"author":{"_account_id":5292,"name":"Christopher Yeoh","email":"cbkyeoh@gmail.com","username":"cyeoh-0"},"change_message_id":"baf00e92b02b81d56b867ad6cc9f7d60afdc329e","unresolved":false,"context_lines":[{"line_number":131,"context_line":"        resp, fetched_list \u003d self.client.list_volumes(params)"},{"line_number":132,"context_line":"        self.assertEqual(200, resp.status)"},{"line_number":133,"context_line":"        for volume in fetched_list:"},{"line_number":134,"context_line":"            self.assertEqual(\u0027available\u0027, volume[\u0027status\u0027])"},{"line_number":135,"context_line":""},{"line_number":136,"context_line":"    @attr(type\u003d\u0027gate\u0027)"},{"line_number":137,"context_line":"    def test_volumes_list_details_by_status(self):"}],"source_content_type":"text/x-python","patch_set":1,"id":"AAAAS3%2F%2Fuyg%3D","line":134,"updated":"2013-09-20 12:55:59.000000000","message":"All 3 volumes should be in the available state so maybe also check that all of them created in setupClass are present?","commit_id":"4806ec7a153f037696945694dd73f4c4f249acdc"},{"author":{"_account_id":7139,"name":"Zhi Kun Liu","username":"zhikunliu","inactive":true},"change_message_id":"b00a6a035adf13a7b30a49a93b2e143a2e993a31","unresolved":false,"context_lines":[{"line_number":131,"context_line":"        resp, fetched_list \u003d self.client.list_volumes(params)"},{"line_number":132,"context_line":"        self.assertEqual(200, resp.status)"},{"line_number":133,"context_line":"        for volume in fetched_list:"},{"line_number":134,"context_line":"            self.assertEqual(\u0027available\u0027, volume[\u0027status\u0027])"},{"line_number":135,"context_line":""},{"line_number":136,"context_line":"    @attr(type\u003d\u0027gate\u0027)"},{"line_number":137,"context_line":"    def test_volumes_list_details_by_status(self):"}],"source_content_type":"text/x-python","patch_set":1,"id":"AAAAS3%2F%2FqhY%3D","line":134,"in_reply_to":"AAAAS3%2F%2Fuyg%3D","updated":"2013-09-23 05:21:37.000000000","message":"Thank you, Christopher! I\u0027ll fix it in next patch set.","commit_id":"4806ec7a153f037696945694dd73f4c4f249acdc"},{"author":{"_account_id":5292,"name":"Christopher Yeoh","email":"cbkyeoh@gmail.com","username":"cyeoh-0"},"change_message_id":"baf00e92b02b81d56b867ad6cc9f7d60afdc329e","unresolved":false,"context_lines":[{"line_number":139,"context_line":"        resp, fetched_list \u003d self.client.list_volumes_with_detail(params)"},{"line_number":140,"context_line":"        self.assertEqual(200, resp.status)"},{"line_number":141,"context_line":"        for volume in fetched_list:"},{"line_number":142,"context_line":"            self.assertEqual(\u0027available\u0027, volume[\u0027status\u0027])"},{"line_number":143,"context_line":""},{"line_number":144,"context_line":"    @attr(type\u003d\u0027gate\u0027)"},{"line_number":145,"context_line":"    def test_volumes_list_by_availability_zone(self):"}],"source_content_type":"text/x-python","patch_set":1,"id":"AAAAS3%2F%2Fuyc%3D","line":142,"updated":"2013-09-20 12:55:59.000000000","message":"Same comment as above","commit_id":"4806ec7a153f037696945694dd73f4c4f249acdc"},{"author":{"_account_id":5292,"name":"Christopher Yeoh","email":"cbkyeoh@gmail.com","username":"cyeoh-0"},"change_message_id":"baf00e92b02b81d56b867ad6cc9f7d60afdc329e","unresolved":false,"context_lines":[{"line_number":149,"context_line":"        resp, fetched_list \u003d self.client.list_volumes(params)"},{"line_number":150,"context_line":"        self.assertEqual(200, resp.status)"},{"line_number":151,"context_line":"        for volume in fetched_list:"},{"line_number":152,"context_line":"            self.assertEqual(zone, volume[\u0027availability_zone\u0027])"},{"line_number":153,"context_line":""},{"line_number":154,"context_line":"    @attr(type\u003d\u0027gate\u0027)"},{"line_number":155,"context_line":"    def test_volumes_list_details_by_availability_zone(self):"}],"source_content_type":"text/x-python","patch_set":1,"id":"AAAAS3%2F%2FuyQ%3D","line":152,"updated":"2013-09-20 12:55:59.000000000","message":"I think they should also all be in the same availability zone shouldn\u0027t they and so can also check that they all exist here.","commit_id":"4806ec7a153f037696945694dd73f4c4f249acdc"},{"author":{"_account_id":6796,"name":"Giulio Fidente","email":"gfidente@redhat.com","username":"gfidente"},"change_message_id":"c11497732c0b514cea87132a6f4ad0e7d07f8969","unresolved":false,"context_lines":[{"line_number":106,"context_line":"    @attr(type\u003d\u0027gate\u0027)"},{"line_number":107,"context_line":"    def test_volume_list_by_name(self):"},{"line_number":108,"context_line":"        resp, fetched_list \u003d self.client.list_volumes()"},{"line_number":109,"context_line":"        volume \u003d fetched_list[0]"},{"line_number":110,"context_line":"        params \u003d {\u0027display_name\u0027: volume[\u0027display_name\u0027]}"},{"line_number":111,"context_line":"        resp, fetched_vol \u003d self.client.list_volumes(params)"},{"line_number":112,"context_line":"        self.assertEqual(200, resp.status)"}],"source_content_type":"text/x-python","patch_set":2,"id":"AAAAS3%2F%2FkUo%3D","line":109,"updated":"2013-09-24 15:49:37.000000000","message":"maybe you can get this by picking a random form self.volume_list ?","commit_id":"675787a409512adf789bbd51992b55f40b92a3a6"},{"author":{"_account_id":7139,"name":"Zhi Kun Liu","username":"zhikunliu","inactive":true},"change_message_id":"2f99a6ec558e3b845d6388efd63fc9edccaf4e41","unresolved":false,"context_lines":[{"line_number":106,"context_line":"    @attr(type\u003d\u0027gate\u0027)"},{"line_number":107,"context_line":"    def test_volume_list_by_name(self):"},{"line_number":108,"context_line":"        resp, fetched_list \u003d self.client.list_volumes()"},{"line_number":109,"context_line":"        volume \u003d fetched_list[0]"},{"line_number":110,"context_line":"        params \u003d {\u0027display_name\u0027: volume[\u0027display_name\u0027]}"},{"line_number":111,"context_line":"        resp, fetched_vol \u003d self.client.list_volumes(params)"},{"line_number":112,"context_line":"        self.assertEqual(200, resp.status)"}],"source_content_type":"text/x-python","patch_set":2,"id":"AAAAS3%2F%2Fh%2FU%3D","line":109,"in_reply_to":"AAAAS3%2F%2FkUo%3D","updated":"2013-09-25 06:11:23.000000000","message":"Giulio, good suggestion!  I\u0027ll fix it in next patch set","commit_id":"675787a409512adf789bbd51992b55f40b92a3a6"},{"author":{"_account_id":6796,"name":"Giulio Fidente","email":"gfidente@redhat.com","username":"gfidente"},"change_message_id":"c11497732c0b514cea87132a6f4ad0e7d07f8969","unresolved":false,"context_lines":[{"line_number":117,"context_line":"    @attr(type\u003d\u0027gate\u0027)"},{"line_number":118,"context_line":"    def test_volume_list_details_by_name(self):"},{"line_number":119,"context_line":"        resp, fetched_list \u003d self.client.list_volumes()"},{"line_number":120,"context_line":"        volume \u003d fetched_list[0]"},{"line_number":121,"context_line":"        params \u003d {\u0027display_name\u0027: volume[\u0027display_name\u0027]}"},{"line_number":122,"context_line":"        resp, fetched_vol \u003d self.client.list_volumes_with_detail(params)"},{"line_number":123,"context_line":"        self.assertEqual(200, resp.status)"}],"source_content_type":"text/x-python","patch_set":2,"id":"AAAAS3%2F%2FkUk%3D","line":120,"updated":"2013-09-24 15:49:37.000000000","message":"maybe you can get this by picking a random form self.volume_list ?","commit_id":"675787a409512adf789bbd51992b55f40b92a3a6"},{"author":{"_account_id":6796,"name":"Giulio Fidente","email":"gfidente@redhat.com","username":"gfidente"},"change_message_id":"c11497732c0b514cea87132a6f4ad0e7d07f8969","unresolved":false,"context_lines":[{"line_number":146,"context_line":"    @attr(type\u003d\u0027gate\u0027)"},{"line_number":147,"context_line":"    def test_volumes_list_by_availability_zone(self):"},{"line_number":148,"context_line":"        resp, fetched_list \u003d self.client.list_volumes()"},{"line_number":149,"context_line":"        zone \u003d fetched_list[0][\u0027availability_zone\u0027]"},{"line_number":150,"context_line":"        params \u003d {\u0027availability_zone\u0027: zone}"},{"line_number":151,"context_line":"        resp, fetched_list \u003d self.client.list_volumes(params)"},{"line_number":152,"context_line":"        self.assertEqual(200, resp.status)"}],"source_content_type":"text/x-python","patch_set":2,"id":"AAAAS3%2F%2FkTs%3D","line":149,"updated":"2013-09-24 15:49:37.000000000","message":"maybe you can get this by picking a random form self.volume_list ?","commit_id":"675787a409512adf789bbd51992b55f40b92a3a6"},{"author":{"_account_id":6796,"name":"Giulio Fidente","email":"gfidente@redhat.com","username":"gfidente"},"change_message_id":"c11497732c0b514cea87132a6f4ad0e7d07f8969","unresolved":false,"context_lines":[{"line_number":157,"context_line":"    @attr(type\u003d\u0027gate\u0027)"},{"line_number":158,"context_line":"    def test_volumes_list_details_by_availability_zone(self):"},{"line_number":159,"context_line":"        resp, fetched_list \u003d self.client.list_volumes()"},{"line_number":160,"context_line":"        zone \u003d fetched_list[0][\u0027availability_zone\u0027]"},{"line_number":161,"context_line":"        params \u003d {\u0027availability_zone\u0027: zone}"},{"line_number":162,"context_line":"        resp, fetched_list \u003d self.client.list_volumes_with_detail(params)"},{"line_number":163,"context_line":"        self.assertEqual(200, resp.status)"}],"source_content_type":"text/x-python","patch_set":2,"id":"AAAAS3%2F%2FkTo%3D","line":160,"updated":"2013-09-24 15:49:37.000000000","message":"maybe you can get this by picking a random form self.volume_list ?","commit_id":"675787a409512adf789bbd51992b55f40b92a3a6"},{"author":{"_account_id":6796,"name":"Giulio Fidente","email":"gfidente@redhat.com","username":"gfidente"},"change_message_id":"8aeb421cdfbc3c7591f77903383b5ebae9740595","unresolved":false,"context_lines":[{"line_number":1,"context_line":"# vim: tabstop\u003d4 shiftwidth\u003d4 softtabstop\u003d4"},{"line_number":2,"context_line":""},{"line_number":3,"context_line":"# Copyright 2012 OpenStack Foundation"},{"line_number":4,"context_line":"# All Rights Reserved."},{"line_number":5,"context_line":"#"},{"line_number":6,"context_line":"#    Licensed under the Apache License, Version 2.0 (the \"License\"); you may"}],"source_content_type":"text/x-python","patch_set":3,"id":"AAAAS3%2F%2FhKA%3D","line":3,"updated":"2013-09-25 11:03:53.000000000","message":"if anyone asks for further changes, either remove completely the two copyright lines OR update it with the current year","commit_id":"10a2094b7eb6f67b4d5e0d5613f17ec589dce57c"},{"author":{"_account_id":7139,"name":"Zhi Kun Liu","username":"zhikunliu","inactive":true},"change_message_id":"0c36096e3581ab6af289ca906e5290f475751ac0","unresolved":false,"context_lines":[{"line_number":1,"context_line":"# vim: tabstop\u003d4 shiftwidth\u003d4 softtabstop\u003d4"},{"line_number":2,"context_line":""},{"line_number":3,"context_line":"# Copyright 2012 OpenStack Foundation"},{"line_number":4,"context_line":"# All Rights Reserved."},{"line_number":5,"context_line":"#"},{"line_number":6,"context_line":"#    Licensed under the Apache License, Version 2.0 (the \"License\"); you may"}],"source_content_type":"text/x-python","patch_set":3,"id":"AAAAS3%2F%2FZSo%3D","line":3,"in_reply_to":"AAAAS3%2F%2FhKA%3D","updated":"2013-09-27 15:32:06.000000000","message":"Done","commit_id":"10a2094b7eb6f67b4d5e0d5613f17ec589dce57c"},{"author":{"_account_id":5803,"name":"Attila Fazekas","email":"afazekas@redhat.com","username":"afazekas"},"change_message_id":"31120ad52a2e8f62ddac19097d9f08d3e088b724","unresolved":false,"context_lines":[{"line_number":110,"context_line":"        params \u003d {\u0027display_name\u0027: volume[\u0027display_name\u0027]}"},{"line_number":111,"context_line":"        resp, fetched_vol \u003d self.client.list_volumes(params)"},{"line_number":112,"context_line":"        self.assertEqual(200, resp.status)"},{"line_number":113,"context_line":"        self.assertEqual(1, len(fetched_vol))"},{"line_number":114,"context_line":"        self.assertEqual(fetched_vol[0][\u0027display_name\u0027],"},{"line_number":115,"context_line":"                         volume[\u0027display_name\u0027])"},{"line_number":116,"context_line":""}],"source_content_type":"text/x-python","patch_set":3,"id":"AAAAS3%2F%2FdKI%3D","line":113,"updated":"2013-09-26 12:53:14.000000000","message":"This method can have 3th argument,\nstr(fetched_vol) as 3th (msg) argument would be nice.","commit_id":"10a2094b7eb6f67b4d5e0d5613f17ec589dce57c"},{"author":{"_account_id":7139,"name":"Zhi Kun Liu","username":"zhikunliu","inactive":true},"change_message_id":"0c36096e3581ab6af289ca906e5290f475751ac0","unresolved":false,"context_lines":[{"line_number":110,"context_line":"        params \u003d {\u0027display_name\u0027: volume[\u0027display_name\u0027]}"},{"line_number":111,"context_line":"        resp, fetched_vol \u003d self.client.list_volumes(params)"},{"line_number":112,"context_line":"        self.assertEqual(200, resp.status)"},{"line_number":113,"context_line":"        self.assertEqual(1, len(fetched_vol))"},{"line_number":114,"context_line":"        self.assertEqual(fetched_vol[0][\u0027display_name\u0027],"},{"line_number":115,"context_line":"                         volume[\u0027display_name\u0027])"},{"line_number":116,"context_line":""}],"source_content_type":"text/x-python","patch_set":3,"id":"AAAAS3%2F%2FZSk%3D","line":113,"in_reply_to":"AAAAS3%2F%2FdKI%3D","updated":"2013-09-27 15:32:06.000000000","message":"Done","commit_id":"10a2094b7eb6f67b4d5e0d5613f17ec589dce57c"},{"author":{"_account_id":5292,"name":"Christopher Yeoh","email":"cbkyeoh@gmail.com","username":"cyeoh-0"},"change_message_id":"b653740cb9894615eb57c100d7fa2475a1023140","unresolved":false,"context_lines":[{"line_number":1,"context_line":"# vim: tabstop\u003d4 shiftwidth\u003d4 softtabstop\u003d4"},{"line_number":2,"context_line":""},{"line_number":3,"context_line":"# Copyright 2012 OpenStack Foundation"},{"line_number":4,"context_line":"# All Rights Reserved."},{"line_number":5,"context_line":"#"},{"line_number":6,"context_line":"#    Licensed under the Apache License, Version 2.0 (the \"License\"); you may"},{"line_number":7,"context_line":"#    not use this file except in compliance with the License. You may obtain"}],"source_content_type":"text/x-python","patch_set":4,"id":"AAAAS3%2F%2FKPQ%3D","side":"PARENT","line":4,"updated":"2013-10-03 08:03:02.000000000","message":"I don\u0027t think you should be removing copyright headers","commit_id":"fcbca588044aacdd8cc227c60377eac5feae0a74"}]}