)]}'
{"releasenotes/notes/move-volume-v3-base_client-to-volume-1edbz0f207c3b283.yaml":[{"author":{"_account_id":5689,"name":"Masayuki Igawa","email":"masayuki@igawa.io","username":"igawa"},"change_message_id":"0d7b926862ef8a5d5a9d8a7c71d52ab6a4601460","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":5,"id":"5f201791_e29aa1c3","line":9,"updated":"2017-06-21 07:09:40.000000000","message":"I think a deprecations or upgrade note should be added too.","commit_id":"ae9e5cad0788e9c1e59fb5862e60ff09338c996b"},{"author":{"_account_id":20190,"name":"zhufl","email":"zhu.fanglei@zte.com.cn","username":"zhufl"},"change_message_id":"a89bbbfd22052f60fc8d343511643e5de0e92eef","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":5,"id":"5f201791_22fd393a","line":9,"in_reply_to":"5f201791_e29aa1c3","updated":"2017-06-21 07:36:02.000000000","message":"Thanks, good point, done","commit_id":"ae9e5cad0788e9c1e59fb5862e60ff09338c996b"},{"author":{"_account_id":8556,"name":"Ghanshyam Maan","display_name":"Ghanshyam Maan","email":"gmaan.os14@gmail.com","username":"ghanshyam"},"change_message_id":"50acb043865011406000b0cc2ca5ff95ae07290d","unresolved":false,"context_lines":[{"line_number":1,"context_line":"features:"},{"line_number":2,"context_line":"  - |"},{"line_number":3,"context_line":"    Move base_client from volume.v3 to volume, so if we want"},{"line_number":4,"context_line":"    to add new interfaces based on a v2 client, we can make"},{"line_number":5,"context_line":"    that v2 client inherit from volume.base_client.BaseClient"},{"line_number":6,"context_line":"    to get microversion support, and then to make the new v3"}],"source_content_type":"text/x-yaml","patch_set":9,"id":"3f1d235d_67da1818","line":3,"range":{"start_line":3,"start_character":39,"end_line":3,"end_character":45},"updated":"2017-06-30 10:45:48.000000000","message":"``tempest.lib.services.volume``","commit_id":"40164bfcea5042d581a44cc2a787d2239286cc3c"},{"author":{"_account_id":8556,"name":"Ghanshyam Maan","display_name":"Ghanshyam Maan","email":"gmaan.os14@gmail.com","username":"ghanshyam"},"change_message_id":"50acb043865011406000b0cc2ca5ff95ae07290d","unresolved":false,"context_lines":[{"line_number":1,"context_line":"features:"},{"line_number":2,"context_line":"  - |"},{"line_number":3,"context_line":"    Move base_client from volume.v3 to volume, so if we want"},{"line_number":4,"context_line":"    to add new interfaces based on a v2 client, we can make"},{"line_number":5,"context_line":"    that v2 client inherit from volume.base_client.BaseClient"},{"line_number":6,"context_line":"    to get microversion support, and then to make the new v3"}],"source_content_type":"text/x-yaml","patch_set":9,"id":"3f1d235d_c7eb2cae","line":3,"range":{"start_line":3,"start_character":26,"end_line":3,"end_character":35},"updated":"2017-06-30 10:45:48.000000000","message":"let\u0027s put full path with ``literal``\n\n``tempest.lib.services.volume.v3``","commit_id":"40164bfcea5042d581a44cc2a787d2239286cc3c"},{"author":{"_account_id":20190,"name":"zhufl","email":"zhu.fanglei@zte.com.cn","username":"zhufl"},"change_message_id":"7134b056cf460f4d0257005641f768696a30a6d8","unresolved":false,"context_lines":[{"line_number":1,"context_line":"features:"},{"line_number":2,"context_line":"  - |"},{"line_number":3,"context_line":"    Move base_client from volume.v3 to volume, so if we want"},{"line_number":4,"context_line":"    to add new interfaces based on a v2 client, we can make"},{"line_number":5,"context_line":"    that v2 client inherit from volume.base_client.BaseClient"},{"line_number":6,"context_line":"    to get microversion support, and then to make the new v3"}],"source_content_type":"text/x-yaml","patch_set":9,"id":"3f1d235d_83b856c8","line":3,"range":{"start_line":3,"start_character":26,"end_line":3,"end_character":35},"in_reply_to":"3f1d235d_c7eb2cae","updated":"2017-07-03 05:41:27.000000000","message":"Done","commit_id":"40164bfcea5042d581a44cc2a787d2239286cc3c"},{"author":{"_account_id":8556,"name":"Ghanshyam Maan","display_name":"Ghanshyam Maan","email":"gmaan.os14@gmail.com","username":"ghanshyam"},"change_message_id":"50acb043865011406000b0cc2ca5ff95ae07290d","unresolved":false,"context_lines":[{"line_number":8,"context_line":"    inheritance."},{"line_number":9,"context_line":"deprecations:"},{"line_number":10,"context_line":"  - |"},{"line_number":11,"context_line":"    Deprecate class BaseClient from volume.v3.base_client and move"},{"line_number":12,"context_line":"    it to volume.base_client."},{"line_number":13,"context_line":""}],"source_content_type":"text/x-yaml","patch_set":9,"id":"3f1d235d_a7cb9051","line":12,"range":{"start_line":11,"start_character":4,"end_line":12,"end_character":29},"updated":"2017-06-30 10:45:48.000000000","message":"can we add below lines also for more clarity on which import patch is moved\n\n``tempest.lib.services.volume.v3.base_client.BaseClient`` (new ``tempest.lib.services.volume.base_client.BaseClient``)","commit_id":"40164bfcea5042d581a44cc2a787d2239286cc3c"},{"author":{"_account_id":20190,"name":"zhufl","email":"zhu.fanglei@zte.com.cn","username":"zhufl"},"change_message_id":"7134b056cf460f4d0257005641f768696a30a6d8","unresolved":false,"context_lines":[{"line_number":8,"context_line":"    inheritance."},{"line_number":9,"context_line":"deprecations:"},{"line_number":10,"context_line":"  - |"},{"line_number":11,"context_line":"    Deprecate class BaseClient from volume.v3.base_client and move"},{"line_number":12,"context_line":"    it to volume.base_client."},{"line_number":13,"context_line":""}],"source_content_type":"text/x-yaml","patch_set":9,"id":"3f1d235d_63bbfac3","line":12,"range":{"start_line":11,"start_character":4,"end_line":12,"end_character":29},"in_reply_to":"3f1d235d_a7cb9051","updated":"2017-07-03 05:41:27.000000000","message":"Done","commit_id":"40164bfcea5042d581a44cc2a787d2239286cc3c"}],"tempest/lib/services/volume/v3/__init__.py":[{"author":{"_account_id":8556,"name":"Ghanshyam Maan","display_name":"Ghanshyam Maan","email":"gmaan.os14@gmail.com","username":"ghanshyam"},"change_message_id":"50acb043865011406000b0cc2ca5ff95ae07290d","unresolved":false,"context_lines":[{"line_number":19,"context_line":"from tempest.lib.services.volume.v3.versions_client import VersionsClient"},{"line_number":20,"context_line":"from tempest.lib.services.volume.v3.volumes_client import VolumesClient"},{"line_number":21,"context_line":""},{"line_number":22,"context_line":"__all__ \u003d [\u0027BaseClient\u0027, \u0027GroupsClient\u0027, \u0027GroupTypesClient\u0027,"},{"line_number":23,"context_line":"           \u0027MessagesClient\u0027, \u0027VersionsClient\u0027, \u0027VolumesClient\u0027]"}],"source_content_type":"text/x-python","patch_set":9,"id":"3f1d235d_b04a9a52","side":"PARENT","line":22,"range":{"start_line":22,"start_character":12,"end_line":22,"end_character":23},"updated":"2017-06-30 10:45:48.000000000","message":"this removal break stable interface. user cannot do like- \n\nfrom tempest.lib.services.volume.v3 import BaseClient\n\nlet is be here till v3.base_client is there","commit_id":"09f926310b5444c7a6969befcb6699e5a62bc8af"},{"author":{"_account_id":20190,"name":"zhufl","email":"zhu.fanglei@zte.com.cn","username":"zhufl"},"change_message_id":"7134b056cf460f4d0257005641f768696a30a6d8","unresolved":false,"context_lines":[{"line_number":19,"context_line":"from tempest.lib.services.volume.v3.versions_client import VersionsClient"},{"line_number":20,"context_line":"from tempest.lib.services.volume.v3.volumes_client import VolumesClient"},{"line_number":21,"context_line":""},{"line_number":22,"context_line":"__all__ \u003d [\u0027BaseClient\u0027, \u0027GroupsClient\u0027, \u0027GroupTypesClient\u0027,"},{"line_number":23,"context_line":"           \u0027MessagesClient\u0027, \u0027VersionsClient\u0027, \u0027VolumesClient\u0027]"}],"source_content_type":"text/x-python","patch_set":9,"id":"3f1d235d_03cc4668","side":"PARENT","line":22,"range":{"start_line":22,"start_character":12,"end_line":22,"end_character":23},"in_reply_to":"3f1d235d_b04a9a52","updated":"2017-07-03 05:41:27.000000000","message":"Done","commit_id":"09f926310b5444c7a6969befcb6699e5a62bc8af"}],"tempest/lib/services/volume/v3/base_client.py":[{"author":{"_account_id":5689,"name":"Masayuki Igawa","email":"masayuki@igawa.io","username":"igawa"},"change_message_id":"0d7b926862ef8a5d5a9d8a7c71d52ab6a4601460","unresolved":false,"context_lines":[{"line_number":29,"context_line":"    LOG \u003d logging.getLogger(__name__)"},{"line_number":30,"context_line":""},{"line_number":31,"context_line":"    def _warn(self):"},{"line_number":32,"context_line":"        self.LOG.warning(\"%s class was moved from volume.v3.base_client \""},{"line_number":33,"context_line":"                         \"to volume.base_client\", self.__class__.__name__)"},{"line_number":34,"context_line":""},{"line_number":35,"context_line":"    def __init__(self, *args, **kwargs):"},{"line_number":36,"context_line":"        self._warn()"}],"source_content_type":"text/x-python","patch_set":5,"id":"5f201791_6212115b","line":33,"range":{"start_line":32,"start_character":26,"end_line":33,"end_character":47},"updated":"2017-06-21 07:09:40.000000000","message":"How about like this warning message here?\n\n %s class was deprecated and moved from volume.v3.....","commit_id":"ae9e5cad0788e9c1e59fb5862e60ff09338c996b"},{"author":{"_account_id":20190,"name":"zhufl","email":"zhu.fanglei@zte.com.cn","username":"zhufl"},"change_message_id":"a89bbbfd22052f60fc8d343511643e5de0e92eef","unresolved":false,"context_lines":[{"line_number":29,"context_line":"    LOG \u003d logging.getLogger(__name__)"},{"line_number":30,"context_line":""},{"line_number":31,"context_line":"    def _warn(self):"},{"line_number":32,"context_line":"        self.LOG.warning(\"%s class was moved from volume.v3.base_client \""},{"line_number":33,"context_line":"                         \"to volume.base_client\", self.__class__.__name__)"},{"line_number":34,"context_line":""},{"line_number":35,"context_line":"    def __init__(self, *args, **kwargs):"},{"line_number":36,"context_line":"        self._warn()"}],"source_content_type":"text/x-python","patch_set":5,"id":"5f201791_e294e1ea","line":33,"range":{"start_line":32,"start_character":26,"end_line":33,"end_character":47},"in_reply_to":"5f201791_6212115b","updated":"2017-06-21 07:36:02.000000000","message":"Done","commit_id":"ae9e5cad0788e9c1e59fb5862e60ff09338c996b"},{"author":{"_account_id":23186,"name":"Felipe Monteiro","email":"felipe.carneiro.monteiro@gmail.com","username":"felipe.monteiro"},"change_message_id":"5602361321387cede74f13d2d78f58a11354f45d","unresolved":false,"context_lines":[{"line_number":26,"context_line":"    api_version \u003d \u0027v3\u0027"},{"line_number":27,"context_line":"    api_microversion_header_name \u003d \u0027Openstack-Api-Version\u0027"},{"line_number":28,"context_line":""},{"line_number":29,"context_line":"    LOG \u003d logging.getLogger(__name__)"},{"line_number":30,"context_line":""},{"line_number":31,"context_line":"    def _warn(self):"},{"line_number":32,"context_line":"        self.LOG.warning("}],"source_content_type":"text/x-python","patch_set":6,"id":"5f201791_52f9d04a","line":29,"range":{"start_line":29,"start_character":4,"end_line":29,"end_character":37},"updated":"2017-06-23 14:38:29.000000000","message":"nit: Usually this is located where VOLUME_MICROVERSION is above. Looks strange here.","commit_id":"7a3e67cdd5b762a3c6f8de932f7fd1b239640ace"},{"author":{"_account_id":20190,"name":"zhufl","email":"zhu.fanglei@zte.com.cn","username":"zhufl"},"change_message_id":"182efed6f79f64b3df2bb5be9abffa43784099e6","unresolved":false,"context_lines":[{"line_number":26,"context_line":"    api_version \u003d \u0027v3\u0027"},{"line_number":27,"context_line":"    api_microversion_header_name \u003d \u0027Openstack-Api-Version\u0027"},{"line_number":28,"context_line":""},{"line_number":29,"context_line":"    LOG \u003d logging.getLogger(__name__)"},{"line_number":30,"context_line":""},{"line_number":31,"context_line":"    def _warn(self):"},{"line_number":32,"context_line":"        self.LOG.warning("}],"source_content_type":"text/x-python","patch_set":6,"id":"5f201791_c754e500","line":29,"range":{"start_line":29,"start_character":4,"end_line":29,"end_character":37},"in_reply_to":"5f201791_52f9d04a","updated":"2017-06-26 00:59:54.000000000","message":"Yes it is, and here I just copied from https://github.com/openstack/tempest/blob/29fbb70ce04bf67e2471d4ddc873c603698e9d4c/tempest/lib/services/identity/v3/token_client.py#L191,\nand because this file will finally be deleted so I didn\u0027t modify it just to keep the consistency:)","commit_id":"7a3e67cdd5b762a3c6f8de932f7fd1b239640ace"},{"author":{"_account_id":5689,"name":"Masayuki Igawa","email":"masayuki@igawa.io","username":"igawa"},"change_message_id":"fa1e53f47b5a9c517643b45e66605c1e375770a2","unresolved":false,"context_lines":[{"line_number":28,"context_line":""},{"line_number":29,"context_line":"    LOG \u003d logging.getLogger(__name__)"},{"line_number":30,"context_line":""},{"line_number":31,"context_line":"    def _warn(self):"},{"line_number":32,"context_line":"        self.LOG.warning("},{"line_number":33,"context_line":"            \"%s class was deprecated and moved from volume.v3.base_client \""},{"line_number":34,"context_line":"            \"to volume.base_client\", self.__class__.__name__)"}],"source_content_type":"text/x-python","patch_set":6,"id":"5f201791_4a8ec32e","line":31,"updated":"2017-06-23 06:13:43.000000000","message":"I\u0027m not sure why you make this method. I think this warning can be inline.","commit_id":"7a3e67cdd5b762a3c6f8de932f7fd1b239640ace"},{"author":{"_account_id":20190,"name":"zhufl","email":"zhu.fanglei@zte.com.cn","username":"zhufl"},"change_message_id":"dba6eccdc7816849c284b6e988a8274ffb2dcb2d","unresolved":false,"context_lines":[{"line_number":28,"context_line":""},{"line_number":29,"context_line":"    LOG \u003d logging.getLogger(__name__)"},{"line_number":30,"context_line":""},{"line_number":31,"context_line":"    def _warn(self):"},{"line_number":32,"context_line":"        self.LOG.warning("},{"line_number":33,"context_line":"            \"%s class was deprecated and moved from volume.v3.base_client \""},{"line_number":34,"context_line":"            \"to volume.base_client\", self.__class__.__name__)"}],"source_content_type":"text/x-python","patch_set":6,"id":"5f201791_8a03bb0f","line":31,"in_reply_to":"5f201791_4a8ec32e","updated":"2017-06-23 06:38:26.000000000","message":"I blindly copied it from TokenClientJSON:)\nhttps://github.com/openstack/tempest/blob/29fbb70ce04bf67e2471d4ddc873c603698e9d4c/tempest/lib/services/identity/v3/token_client.py#L193","commit_id":"7a3e67cdd5b762a3c6f8de932f7fd1b239640ace"},{"author":{"_account_id":5689,"name":"Masayuki Igawa","email":"masayuki@igawa.io","username":"igawa"},"change_message_id":"2981dd4e49918f6bc3874c8e8bf53fabe5d0e8fa","unresolved":false,"context_lines":[{"line_number":23,"context_line":"VOLUME_MICROVERSION \u003d None"},{"line_number":24,"context_line":""},{"line_number":25,"context_line":""},{"line_number":26,"context_line":"class BaseClient(rest_client.RestClient):"},{"line_number":27,"context_line":"    \"\"\"Base class to handle Cinder v3 client microversion support.\"\"\""},{"line_number":28,"context_line":"    api_version \u003d \u0027v3\u0027"},{"line_number":29,"context_line":"    api_microversion_header_name \u003d \u0027Openstack-Api-Version\u0027"}],"source_content_type":"text/x-python","patch_set":8,"id":"3f1d235d_0c9a6b13","line":26,"updated":"2017-06-30 02:08:36.000000000","message":"Just a question, why can\u0027t this class inherit tempest.lib.services.volume.base_client.BaseClient?","commit_id":"4a90b66540cb137208bb5a26a83b504141282df3"},{"author":{"_account_id":20190,"name":"zhufl","email":"zhu.fanglei@zte.com.cn","username":"zhufl"},"change_message_id":"0dc885dda36b51d957e9be02f11914920b0c791b","unresolved":false,"context_lines":[{"line_number":23,"context_line":"VOLUME_MICROVERSION \u003d None"},{"line_number":24,"context_line":""},{"line_number":25,"context_line":""},{"line_number":26,"context_line":"class BaseClient(rest_client.RestClient):"},{"line_number":27,"context_line":"    \"\"\"Base class to handle Cinder v3 client microversion support.\"\"\""},{"line_number":28,"context_line":"    api_version \u003d \u0027v3\u0027"},{"line_number":29,"context_line":"    api_microversion_header_name \u003d \u0027Openstack-Api-Version\u0027"}],"source_content_type":"text/x-python","patch_set":8,"id":"3f1d235d_47183c1c","line":26,"in_reply_to":"3f1d235d_0c9a6b13","updated":"2017-06-30 02:37:13.000000000","message":"Thanks, good point!","commit_id":"4a90b66540cb137208bb5a26a83b504141282df3"},{"author":{"_account_id":8556,"name":"Ghanshyam Maan","display_name":"Ghanshyam Maan","email":"gmaan.os14@gmail.com","username":"ghanshyam"},"change_message_id":"50acb043865011406000b0cc2ca5ff95ae07290d","unresolved":false,"context_lines":[{"line_number":27,"context_line":"    api_version \u003d \u0027v3\u0027"},{"line_number":28,"context_line":""},{"line_number":29,"context_line":"    def __init__(self, *args, **kwargs):"},{"line_number":30,"context_line":"        self.LOG.warning("},{"line_number":31,"context_line":"            \"%s class was deprecated and moved from volume.v3.base_client \""},{"line_number":32,"context_line":"            \"to volume.base_client\", self.__class__.__name__)"},{"line_number":33,"context_line":"        super(BaseClient, self).__init__(*args, **kwargs)"}],"source_content_type":"text/x-python","patch_set":9,"id":"3f1d235d_702e4244","line":33,"range":{"start_line":30,"start_character":0,"end_line":33,"end_character":57},"updated":"2017-06-30 10:45:48.000000000","message":"i like to use debtcollector moveclass here\nhttps://docs.openstack.org/developer/debtcollector/examples.html#moving-a-class","commit_id":"40164bfcea5042d581a44cc2a787d2239286cc3c"},{"author":{"_account_id":20190,"name":"zhufl","email":"zhu.fanglei@zte.com.cn","username":"zhufl"},"change_message_id":"7134b056cf460f4d0257005641f768696a30a6d8","unresolved":false,"context_lines":[{"line_number":27,"context_line":"    api_version \u003d \u0027v3\u0027"},{"line_number":28,"context_line":""},{"line_number":29,"context_line":"    def __init__(self, *args, **kwargs):"},{"line_number":30,"context_line":"        self.LOG.warning("},{"line_number":31,"context_line":"            \"%s class was deprecated and moved from volume.v3.base_client \""},{"line_number":32,"context_line":"            \"to volume.base_client\", self.__class__.__name__)"},{"line_number":33,"context_line":"        super(BaseClient, self).__init__(*args, **kwargs)"}],"source_content_type":"text/x-python","patch_set":9,"id":"3f1d235d_e3c6ea49","line":33,"range":{"start_line":30,"start_character":0,"end_line":33,"end_character":57},"in_reply_to":"3f1d235d_702e4244","updated":"2017-07-03 05:41:27.000000000","message":"Done","commit_id":"40164bfcea5042d581a44cc2a787d2239286cc3c"},{"author":{"_account_id":8556,"name":"Ghanshyam Maan","display_name":"Ghanshyam Maan","email":"gmaan.os14@gmail.com","username":"ghanshyam"},"change_message_id":"b37da9607c3c96c2e46708d7f1ba855df0485a47","unresolved":false,"context_lines":[{"line_number":18,"context_line":"from tempest.lib.services.volume import base_client"},{"line_number":19,"context_line":""},{"line_number":20,"context_line":""},{"line_number":21,"context_line":"BaseClient \u003d moves.moved_class(base_client.BaseClient, \u0027BaseClient\u0027, __name__)"},{"line_number":22,"context_line":"BaseClient.api_version \u003d \u0027v3\u0027"}],"source_content_type":"text/x-python","patch_set":10,"id":"3f1d235d_3f4ef996","line":21,"range":{"start_line":21,"start_character":0,"end_line":21,"end_character":78},"updated":"2017-07-05 00:46:53.000000000","message":"can we add version and removal version like-\nBaseClient \u003d moves.moved_class(base_client.BaseClient, \u0027BaseClient\u0027, __name__,\n                               version\u003d\"Pike\", removal_version\u003d\u0027?\u0027)\n\n\nso we can get much better warnging like below-\nDeprecationWarning: Class \u0027tempest.lib.services.volume.v3.base_client.BaseClient\u0027 has moved to \u0027tempest.lib.services.volume.base_client.BaseClient\u0027 in version \u0027Pike\u0027 and will be removed in a future version","commit_id":"93a43330a2b24917d1abd476723c64ca96e14041"},{"author":{"_account_id":20190,"name":"zhufl","email":"zhu.fanglei@zte.com.cn","username":"zhufl"},"change_message_id":"5e5471cdc3d82412202ae4f97a795151120f8cb6","unresolved":false,"context_lines":[{"line_number":18,"context_line":"from tempest.lib.services.volume import base_client"},{"line_number":19,"context_line":""},{"line_number":20,"context_line":""},{"line_number":21,"context_line":"BaseClient \u003d moves.moved_class(base_client.BaseClient, \u0027BaseClient\u0027, __name__)"},{"line_number":22,"context_line":"BaseClient.api_version \u003d \u0027v3\u0027"}],"source_content_type":"text/x-python","patch_set":10,"id":"3f1d235d_2a011906","line":21,"range":{"start_line":21,"start_character":0,"end_line":21,"end_character":78},"in_reply_to":"3f1d235d_3f4ef996","updated":"2017-07-05 00:52:11.000000000","message":"sure, it\u0027s better, done","commit_id":"93a43330a2b24917d1abd476723c64ca96e14041"}]}