)]}'
{"tempest/common/compute.py":[{"author":{"_account_id":5689,"name":"Masayuki Igawa","email":"masayuki@igawa.io","username":"igawa"},"change_message_id":"8074c9a6dfc453fd1016c8fc1f19ef105eccc192","unresolved":false,"context_lines":[{"line_number":201,"context_line":"                        try:"},{"line_number":202,"context_line":"                            clients.servers_client.delete_server("},{"line_number":203,"context_line":"                                server[\u0027id\u0027])"},{"line_number":204,"context_line":"                            waiters.wait_for_server_termination("},{"line_number":205,"context_line":"                                clients.servers_client, server[\u0027id\u0027])"},{"line_number":206,"context_line":"                        except Exception:"},{"line_number":207,"context_line":"                            LOG.exception(\u0027Deleting server %s failed\u0027,"}],"source_content_type":"text/x-python","patch_set":1,"id":"7f231b9d_67810a4b","line":204,"updated":"2017-06-20 06:52:02.000000000","message":"Could you add a NOTE for this like you mentioned in the commit message? I think this is a bit tricky, so, adding a note is helpful to understand the intention.","commit_id":"df574652b2ac1f23fb2c65908900ef440d8601f7"},{"author":{"_account_id":8864,"name":"Artom Lifshitz","email":"notartom@gmail.com","username":"artom"},"change_message_id":"15a661d6f7ae3e33dc88b102967841e1606076a8","unresolved":false,"context_lines":[{"line_number":201,"context_line":"                        try:"},{"line_number":202,"context_line":"                            clients.servers_client.delete_server("},{"line_number":203,"context_line":"                                server[\u0027id\u0027])"},{"line_number":204,"context_line":"                            waiters.wait_for_server_termination("},{"line_number":205,"context_line":"                                clients.servers_client, server[\u0027id\u0027])"},{"line_number":206,"context_line":"                        except Exception:"},{"line_number":207,"context_line":"                            LOG.exception(\u0027Deleting server %s failed\u0027,"}],"source_content_type":"text/x-python","patch_set":1,"id":"7f231b9d_477cce1f","line":204,"in_reply_to":"7f231b9d_67810a4b","updated":"2017-06-20 07:23:22.000000000","message":"Done","commit_id":"df574652b2ac1f23fb2c65908900ef440d8601f7"},{"author":{"_account_id":5689,"name":"Masayuki Igawa","email":"masayuki@igawa.io","username":"igawa"},"change_message_id":"8074c9a6dfc453fd1016c8fc1f19ef105eccc192","unresolved":false,"context_lines":[{"line_number":202,"context_line":"                            clients.servers_client.delete_server("},{"line_number":203,"context_line":"                                server[\u0027id\u0027])"},{"line_number":204,"context_line":"                            waiters.wait_for_server_termination("},{"line_number":205,"context_line":"                                clients.servers_client, server[\u0027id\u0027])"},{"line_number":206,"context_line":"                        except Exception:"},{"line_number":207,"context_line":"                            LOG.exception(\u0027Deleting server %s failed\u0027,"},{"line_number":208,"context_line":"                                          server[\u0027id\u0027])"}],"source_content_type":"text/x-python","patch_set":1,"id":"7f231b9d_47960e97","line":205,"updated":"2017-06-20 06:52:02.000000000","message":"Can we wait for this server termination after L.208? Otherwise, we need to wait for the deletion one by one.","commit_id":"df574652b2ac1f23fb2c65908900ef440d8601f7"},{"author":{"_account_id":8864,"name":"Artom Lifshitz","email":"notartom@gmail.com","username":"artom"},"change_message_id":"15a661d6f7ae3e33dc88b102967841e1606076a8","unresolved":false,"context_lines":[{"line_number":202,"context_line":"                            clients.servers_client.delete_server("},{"line_number":203,"context_line":"                                server[\u0027id\u0027])"},{"line_number":204,"context_line":"                            waiters.wait_for_server_termination("},{"line_number":205,"context_line":"                                clients.servers_client, server[\u0027id\u0027])"},{"line_number":206,"context_line":"                        except Exception:"},{"line_number":207,"context_line":"                            LOG.exception(\u0027Deleting server %s failed\u0027,"},{"line_number":208,"context_line":"                                          server[\u0027id\u0027])"}],"source_content_type":"text/x-python","patch_set":1,"id":"7f231b9d_07c4963f","line":205,"in_reply_to":"7f231b9d_47960e97","updated":"2017-06-20 07:23:22.000000000","message":"Yep, much smarter. Done.","commit_id":"df574652b2ac1f23fb2c65908900ef440d8601f7"},{"author":{"_account_id":20190,"name":"zhufl","email":"zhu.fanglei@zte.com.cn","username":"zhufl"},"change_message_id":"1e8ee30c5f846bfc0e3e1f146cc84a180b305e2c","unresolved":false,"context_lines":[{"line_number":205,"context_line":"                            LOG.exception(\u0027Deleting server %s failed\u0027,"},{"line_number":206,"context_line":"                                          server[\u0027id\u0027])"},{"line_number":207,"context_line":"                    for server in servers:"},{"line_number":208,"context_line":"                        # NOTE(artom) If the servers have volumes attached,"},{"line_number":209,"context_line":"                        # we need to wait for them to go away before"},{"line_number":210,"context_line":"                        # proceeding with cleanup, otherwise we\u0027ll attempt"},{"line_number":211,"context_line":"                        # to detach the volumes while the server is still"},{"line_number":212,"context_line":"                        # around."},{"line_number":213,"context_line":"                        waiters.wait_for_server_termination("},{"line_number":214,"context_line":"                            clients.servers_client, server[\u0027id\u0027])"},{"line_number":215,"context_line":""}],"source_content_type":"text/x-python","patch_set":2,"id":"7f231b9d_2d68931f","line":212,"range":{"start_line":208,"start_character":0,"end_line":212,"end_character":33},"updated":"2017-06-20 08:16:27.000000000","message":"I can\u0027t imagine how volumes can be attached to server when server is creating, so can you give more detailed hints?","commit_id":"90cc59323453a9de568fcf2385cb7db4c5d451de"},{"author":{"_account_id":8864,"name":"Artom Lifshitz","email":"notartom@gmail.com","username":"artom"},"change_message_id":"4d0e887208ce63e7f6bec52da24e068c57f4db29","unresolved":false,"context_lines":[{"line_number":205,"context_line":"                            LOG.exception(\u0027Deleting server %s failed\u0027,"},{"line_number":206,"context_line":"                                          server[\u0027id\u0027])"},{"line_number":207,"context_line":"                    for server in servers:"},{"line_number":208,"context_line":"                        # NOTE(artom) If the servers have volumes attached,"},{"line_number":209,"context_line":"                        # we need to wait for them to go away before"},{"line_number":210,"context_line":"                        # proceeding with cleanup, otherwise we\u0027ll attempt"},{"line_number":211,"context_line":"                        # to detach the volumes while the server is still"},{"line_number":212,"context_line":"                        # around."},{"line_number":213,"context_line":"                        waiters.wait_for_server_termination("},{"line_number":214,"context_line":"                            clients.servers_client, server[\u0027id\u0027])"},{"line_number":215,"context_line":""}],"source_content_type":"text/x-python","patch_set":2,"id":"7f231b9d_933a2896","line":212,"range":{"start_line":208,"start_character":0,"end_line":212,"end_character":33},"in_reply_to":"7f231b9d_2d68931f","updated":"2017-06-20 09:11:18.000000000","message":"Maybe \u0027attached\u0027 is misleading - the server can be booted with volumes, and cleaning them up will fail if we don\u0027t wait for the server to go away first. I\u0027ve adjusted the wording.","commit_id":"90cc59323453a9de568fcf2385cb7db4c5d451de"},{"author":{"_account_id":20190,"name":"zhufl","email":"zhu.fanglei@zte.com.cn","username":"zhufl"},"change_message_id":"1e8ee30c5f846bfc0e3e1f146cc84a180b305e2c","unresolved":false,"context_lines":[{"line_number":210,"context_line":"                        # proceeding with cleanup, otherwise we\u0027ll attempt"},{"line_number":211,"context_line":"                        # to detach the volumes while the server is still"},{"line_number":212,"context_line":"                        # around."},{"line_number":213,"context_line":"                        waiters.wait_for_server_termination("},{"line_number":214,"context_line":"                            clients.servers_client, server[\u0027id\u0027])"},{"line_number":215,"context_line":""},{"line_number":216,"context_line":"    return body, servers"}],"source_content_type":"text/x-python","patch_set":2,"id":"7f231b9d_cd047f81","line":213,"range":{"start_line":213,"start_character":24,"end_line":213,"end_character":59},"updated":"2017-06-20 08:16:27.000000000","message":"this is better to be included in a try...except block","commit_id":"90cc59323453a9de568fcf2385cb7db4c5d451de"},{"author":{"_account_id":8864,"name":"Artom Lifshitz","email":"notartom@gmail.com","username":"artom"},"change_message_id":"4d0e887208ce63e7f6bec52da24e068c57f4db29","unresolved":false,"context_lines":[{"line_number":210,"context_line":"                        # proceeding with cleanup, otherwise we\u0027ll attempt"},{"line_number":211,"context_line":"                        # to detach the volumes while the server is still"},{"line_number":212,"context_line":"                        # around."},{"line_number":213,"context_line":"                        waiters.wait_for_server_termination("},{"line_number":214,"context_line":"                            clients.servers_client, server[\u0027id\u0027])"},{"line_number":215,"context_line":""},{"line_number":216,"context_line":"    return body, servers"}],"source_content_type":"text/x-python","patch_set":2,"id":"7f231b9d_d3eb00da","line":213,"range":{"start_line":213,"start_character":24,"end_line":213,"end_character":59},"in_reply_to":"7f231b9d_cd047f81","updated":"2017-06-20 09:11:18.000000000","message":"Done","commit_id":"90cc59323453a9de568fcf2385cb7db4c5d451de"},{"author":{"_account_id":20190,"name":"zhufl","email":"zhu.fanglei@zte.com.cn","username":"zhufl"},"change_message_id":"9ab52fcc38b1f0cd9fa4982da1bc8ece3dc4f249","unresolved":false,"context_lines":[{"line_number":205,"context_line":"                            LOG.exception(\u0027Deleting server %s failed\u0027,"},{"line_number":206,"context_line":"                                          server[\u0027id\u0027])"},{"line_number":207,"context_line":"                    for server in servers:"},{"line_number":208,"context_line":"                        # NOTE(artom) If the servers were booted with volumes,"},{"line_number":209,"context_line":"                        # we need to wait for the servers to go away before"},{"line_number":210,"context_line":"                        # proceeding with cleanup, otherwise we\u0027ll attempt to"},{"line_number":211,"context_line":"                        # delete the volumes while they\u0027re still attached to a"}],"source_content_type":"text/x-python","patch_set":3,"id":"5f201791_6c87add9","line":208,"range":{"start_line":208,"start_character":65,"end_line":208,"end_character":69},"updated":"2017-06-21 00:59:13.000000000","message":"from?","commit_id":"901f39dd57df9fbd30bf56ea7a33b8715cb8a07f"},{"author":{"_account_id":20190,"name":"zhufl","email":"zhu.fanglei@zte.com.cn","username":"zhufl"},"change_message_id":"9ab52fcc38b1f0cd9fa4982da1bc8ece3dc4f249","unresolved":false,"context_lines":[{"line_number":205,"context_line":"                            LOG.exception(\u0027Deleting server %s failed\u0027,"},{"line_number":206,"context_line":"                                          server[\u0027id\u0027])"},{"line_number":207,"context_line":"                    for server in servers:"},{"line_number":208,"context_line":"                        # NOTE(artom) If the servers were booted with volumes,"},{"line_number":209,"context_line":"                        # we need to wait for the servers to go away before"},{"line_number":210,"context_line":"                        # proceeding with cleanup, otherwise we\u0027ll attempt to"},{"line_number":211,"context_line":"                        # delete the volumes while they\u0027re still attached to a"}],"source_content_type":"text/x-python","patch_set":3,"id":"5f201791_8ce9e981","line":208,"range":{"start_line":208,"start_character":58,"end_line":208,"end_character":78},"updated":"2017-06-21 00:59:13.000000000","message":"will it be clearer to put \"booted with volumes and with delete_on_termination\u003dFalse\" ?","commit_id":"901f39dd57df9fbd30bf56ea7a33b8715cb8a07f"},{"author":{"_account_id":8864,"name":"Artom Lifshitz","email":"notartom@gmail.com","username":"artom"},"change_message_id":"28126b3713a44f938f4ecab0da15db7eb57bb1b6","unresolved":false,"context_lines":[{"line_number":205,"context_line":"                            LOG.exception(\u0027Deleting server %s failed\u0027,"},{"line_number":206,"context_line":"                                          server[\u0027id\u0027])"},{"line_number":207,"context_line":"                    for server in servers:"},{"line_number":208,"context_line":"                        # NOTE(artom) If the servers were booted with volumes,"},{"line_number":209,"context_line":"                        # we need to wait for the servers to go away before"},{"line_number":210,"context_line":"                        # proceeding with cleanup, otherwise we\u0027ll attempt to"},{"line_number":211,"context_line":"                        # delete the volumes while they\u0027re still attached to a"}],"source_content_type":"text/x-python","patch_set":3,"id":"5f201791_0c07191f","line":208,"range":{"start_line":208,"start_character":65,"end_line":208,"end_character":69},"in_reply_to":"5f201791_6c87add9","updated":"2017-06-21 01:09:10.000000000","message":"Well, it could be boot from image + a volume, for instance:\n\nnova boot --image foo --block-device bar","commit_id":"901f39dd57df9fbd30bf56ea7a33b8715cb8a07f"},{"author":{"_account_id":8864,"name":"Artom Lifshitz","email":"notartom@gmail.com","username":"artom"},"change_message_id":"28126b3713a44f938f4ecab0da15db7eb57bb1b6","unresolved":false,"context_lines":[{"line_number":205,"context_line":"                            LOG.exception(\u0027Deleting server %s failed\u0027,"},{"line_number":206,"context_line":"                                          server[\u0027id\u0027])"},{"line_number":207,"context_line":"                    for server in servers:"},{"line_number":208,"context_line":"                        # NOTE(artom) If the servers were booted with volumes,"},{"line_number":209,"context_line":"                        # we need to wait for the servers to go away before"},{"line_number":210,"context_line":"                        # proceeding with cleanup, otherwise we\u0027ll attempt to"},{"line_number":211,"context_line":"                        # delete the volumes while they\u0027re still attached to a"}],"source_content_type":"text/x-python","patch_set":3,"id":"5f201791_b7fe3203","line":208,"range":{"start_line":208,"start_character":58,"end_line":208,"end_character":78},"in_reply_to":"5f201791_8ce9e981","updated":"2017-06-21 01:09:10.000000000","message":"Done","commit_id":"901f39dd57df9fbd30bf56ea7a33b8715cb8a07f"},{"author":{"_account_id":20190,"name":"zhufl","email":"zhu.fanglei@zte.com.cn","username":"zhufl"},"change_message_id":"9ab52fcc38b1f0cd9fa4982da1bc8ece3dc4f249","unresolved":false,"context_lines":[{"line_number":208,"context_line":"                        # NOTE(artom) If the servers were booted with volumes,"},{"line_number":209,"context_line":"                        # we need to wait for the servers to go away before"},{"line_number":210,"context_line":"                        # proceeding with cleanup, otherwise we\u0027ll attempt to"},{"line_number":211,"context_line":"                        # delete the volumes while they\u0027re still attached to a"},{"line_number":212,"context_line":"                        # servers that are in the process of being deleted."},{"line_number":213,"context_line":"                        try:"},{"line_number":214,"context_line":"                            waiters.wait_for_server_termination("}],"source_content_type":"text/x-python","patch_set":3,"id":"5f201791_cc7801fa","line":211,"range":{"start_line":211,"start_character":77,"end_line":211,"end_character":78},"updated":"2017-06-21 00:59:13.000000000","message":"nit: this can be removed","commit_id":"901f39dd57df9fbd30bf56ea7a33b8715cb8a07f"},{"author":{"_account_id":8864,"name":"Artom Lifshitz","email":"notartom@gmail.com","username":"artom"},"change_message_id":"28126b3713a44f938f4ecab0da15db7eb57bb1b6","unresolved":false,"context_lines":[{"line_number":208,"context_line":"                        # NOTE(artom) If the servers were booted with volumes,"},{"line_number":209,"context_line":"                        # we need to wait for the servers to go away before"},{"line_number":210,"context_line":"                        # proceeding with cleanup, otherwise we\u0027ll attempt to"},{"line_number":211,"context_line":"                        # delete the volumes while they\u0027re still attached to a"},{"line_number":212,"context_line":"                        # servers that are in the process of being deleted."},{"line_number":213,"context_line":"                        try:"},{"line_number":214,"context_line":"                            waiters.wait_for_server_termination("}],"source_content_type":"text/x-python","patch_set":3,"id":"5f201791_f71b8a70","line":211,"range":{"start_line":211,"start_character":77,"end_line":211,"end_character":78},"in_reply_to":"5f201791_cc7801fa","updated":"2017-06-21 01:09:10.000000000","message":"Done","commit_id":"901f39dd57df9fbd30bf56ea7a33b8715cb8a07f"},{"author":{"_account_id":20190,"name":"zhufl","email":"zhu.fanglei@zte.com.cn","username":"zhufl"},"change_message_id":"956128540bb2edb438c7ea521a46e0949231183b","unresolved":false,"context_lines":[{"line_number":205,"context_line":"                            LOG.exception(\u0027Deleting server %s failed\u0027,"},{"line_number":206,"context_line":"                                          server[\u0027id\u0027])"},{"line_number":207,"context_line":"                    for server in servers:"},{"line_number":208,"context_line":"                        # NOTE(artom) If the servers were booted with volumes,"},{"line_number":209,"context_line":"                        # we need to wait for the servers to go away before"},{"line_number":210,"context_line":"                        # proceeding with cleanup, otherwise we\u0027ll attempt to"},{"line_number":211,"context_line":"                        # delete the volumes while they\u0027re still attached to a"},{"line_number":212,"context_line":"                        # servers that are in the process of being deleted."},{"line_number":213,"context_line":"                        try:"},{"line_number":214,"context_line":"                            waiters.wait_for_server_termination("},{"line_number":215,"context_line":"                                clients.servers_client, server[\u0027id\u0027])"}],"source_content_type":"text/x-python","patch_set":3,"id":"7f231b9d_5e86d7dd","line":212,"range":{"start_line":208,"start_character":23,"end_line":212,"end_character":75},"updated":"2017-06-20 09:32:09.000000000","message":"sorry I am still confused, the volume will be deleted automatically because we set \u0027delete_on_termination\u0027: True\" \nin block_device_mapping_v2, that means we needn\u0027t do the volume cleanup, so, how the situation occurs?","commit_id":"901f39dd57df9fbd30bf56ea7a33b8715cb8a07f"},{"author":{"_account_id":8864,"name":"Artom Lifshitz","email":"notartom@gmail.com","username":"artom"},"change_message_id":"b001d575e7872c115d3cd419418cc3f07b594fc7","unresolved":false,"context_lines":[{"line_number":205,"context_line":"                            LOG.exception(\u0027Deleting server %s failed\u0027,"},{"line_number":206,"context_line":"                                          server[\u0027id\u0027])"},{"line_number":207,"context_line":"                    for server in servers:"},{"line_number":208,"context_line":"                        # NOTE(artom) If the servers were booted with volumes,"},{"line_number":209,"context_line":"                        # we need to wait for the servers to go away before"},{"line_number":210,"context_line":"                        # proceeding with cleanup, otherwise we\u0027ll attempt to"},{"line_number":211,"context_line":"                        # delete the volumes while they\u0027re still attached to a"},{"line_number":212,"context_line":"                        # servers that are in the process of being deleted."},{"line_number":213,"context_line":"                        try:"},{"line_number":214,"context_line":"                            waiters.wait_for_server_termination("},{"line_number":215,"context_line":"                                clients.servers_client, server[\u0027id\u0027])"}],"source_content_type":"text/x-python","patch_set":3,"id":"7f231b9d_fe05a315","line":212,"range":{"start_line":208,"start_character":23,"end_line":212,"end_character":75},"in_reply_to":"7f231b9d_5e86d7dd","updated":"2017-06-20 09:40:42.000000000","message":"\u003e the volume will be deleted automatically because we set\n\u003e \u0027delete_on_termination\u0027: True\"\n\nFor the original device tagging test that\u0027s not set [1]. Are we sure it\u0027s set everywhere else?\n\nFor context, I hit this when working on [2] and [3]. I needed to change how validation was setup, and the first couple of times I did it wrong. So I hit the server deletion clause, and then the cleanup continued trying to remove the volumes without waiting for the server to go away.\n\n[1] https://github.com/openstack/tempest/blob/master/tempest/api/compute/servers/test_device_tagging.py#L178-L202\n[2] https://review.openstack.org/#/c/463837/\n[3] https://review.openstack.org/#/c/391947/","commit_id":"901f39dd57df9fbd30bf56ea7a33b8715cb8a07f"}]}