)]}'
{"tempest/tests/lib/services/base.py":[{"author":{"_account_id":8556,"name":"Ghanshyam Maan","display_name":"Ghanshyam Maan","email":"gmaan.os14@gmail.com","username":"ghanshyam"},"change_message_id":"f1d489628668fa7f3aca34effae545df29f89a60","unresolved":false,"context_lines":[{"line_number":36,"context_line":"            json.dumps \u003d original_func"},{"line_number":37,"context_line":"        self.addCleanup(restore_json_dumps)"},{"line_number":38,"context_line":""},{"line_number":39,"context_line":"        json.dumps \u003d functools.partial(json.dumps, sort_keys\u003dTrue)"},{"line_number":40,"context_line":""},{"line_number":41,"context_line":"    def create_response(self, body, to_utf\u003dFalse, status\u003d200, headers\u003dNone):"},{"line_number":42,"context_line":"        json_body \u003d {}"}],"source_content_type":"text/x-python","patch_set":5,"id":"5f201791_a88a0818","line":39,"range":{"start_line":39,"start_character":0,"end_line":39,"end_character":66},"updated":"2017-06-23 00:00:01.000000000","message":"why we do not pass the json.dumps value as mock_args from unit test itself?\n\nfor GET it would be simple string and i donot think it need json dump\nfor POST/PUT - it has to be dict with json.dumps\nnot sure case of list tough\n\nbut in any case, i would like to convert those args on concrete unit tests side than stubbing json lib function which can have side effect(i know you are reverting that at the end).","commit_id":"fe7b639695a3510af7852bbdbd39465a8329c271"}],"tempest/tests/lib/services/network/test_security_group_rules_client.py":[{"author":{"_account_id":5689,"name":"Masayuki Igawa","email":"masayuki@igawa.io","username":"igawa"},"change_message_id":"d9868e75eab9e0b4dadeab1ae32db82602d1a11a","unresolved":false,"context_lines":[{"line_number":84,"context_line":"                  \u0027remote_ip_prefix\u0027: None}"},{"line_number":85,"context_line":"        payload \u003d json.dumps({\"security_group_rule\": kwargs}, sort_keys\u003dTrue)"},{"line_number":86,"context_line":"        json_dumps \u003d json.dumps"},{"line_number":87,"context_line":""},{"line_number":88,"context_line":"        with mock.patch.object(network_base.json, \u0027dumps\u0027) as mock_dumps:"},{"line_number":89,"context_line":"            mock_dumps.side_effect \u003d lambda d: json_dumps(d, sort_keys\u003dTrue)"},{"line_number":90,"context_line":""}],"source_content_type":"text/x-python","patch_set":6,"id":"5f201791_3911acad","line":87,"updated":"2017-06-23 02:55:20.000000000","message":"I think it would be good to add a NOTE to understand this code around here.","commit_id":"90f04fdee730a753895d0cfaaf285a1f7f20fe83"}],"tempest/tests/lib/services/network/test_security_groups_client.py":[{"author":{"_account_id":5689,"name":"Masayuki Igawa","email":"masayuki@igawa.io","username":"igawa"},"change_message_id":"d9868e75eab9e0b4dadeab1ae32db82602d1a11a","unresolved":false,"context_lines":[{"line_number":93,"context_line":"        kwargs \u003d {\u0027name\u0027: \u0027fake-security-group-name\u0027}"},{"line_number":94,"context_line":"        payload \u003d json.dumps({\"security_group\": kwargs}, sort_keys\u003dTrue)"},{"line_number":95,"context_line":"        json_dumps \u003d json.dumps"},{"line_number":96,"context_line":""},{"line_number":97,"context_line":"        with mock.patch.object(network_base.json, \u0027dumps\u0027) as mock_dumps:"},{"line_number":98,"context_line":"            mock_dumps.side_effect \u003d lambda d: json_dumps(d, sort_keys\u003dTrue)"},{"line_number":99,"context_line":""}],"source_content_type":"text/x-python","patch_set":6,"id":"5f201791_192830e0","line":96,"updated":"2017-06-23 02:55:20.000000000","message":"ditto","commit_id":"90f04fdee730a753895d0cfaaf285a1f7f20fe83"},{"author":{"_account_id":5689,"name":"Masayuki Igawa","email":"masayuki@igawa.io","username":"igawa"},"change_message_id":"d9868e75eab9e0b4dadeab1ae32db82602d1a11a","unresolved":false,"context_lines":[{"line_number":122,"context_line":""},{"line_number":123,"context_line":"        payload \u003d json.dumps({\u0027security_group\u0027: kwargs}, sort_keys\u003dTrue)"},{"line_number":124,"context_line":"        json_dumps \u003d json.dumps"},{"line_number":125,"context_line":""},{"line_number":126,"context_line":"        with mock.patch.object(network_base.json, \u0027dumps\u0027) as mock_dumps:"},{"line_number":127,"context_line":"            mock_dumps.side_effect \u003d lambda d: json_dumps(d, sort_keys\u003dTrue)"},{"line_number":128,"context_line":""}],"source_content_type":"text/x-python","patch_set":6,"id":"5f201791_f9221401","line":125,"updated":"2017-06-23 02:55:20.000000000","message":"same here","commit_id":"90f04fdee730a753895d0cfaaf285a1f7f20fe83"}]}