)]}'
{"/COMMIT_MSG":[{"author":{"_account_id":20190,"name":"zhufl","email":"zhu.fanglei@zte.com.cn","username":"zhufl"},"change_message_id":"b3ce50f1a2aa394163a0f90db994b4b2e9d0967b","unresolved":false,"context_lines":[{"line_number":5,"context_line":"CommitDate: 2017-06-22 15:17:03 +0800"},{"line_number":6,"context_line":""},{"line_number":7,"context_line":"add test: list snapshots with param offset"},{"line_number":8,"context_line":""},{"line_number":9,"context_line":"Change-Id: Ib31978abe0127709ce1de2ef896f0ee1a045f08e"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":1,"id":"5f201791_205bcc54","line":8,"updated":"2017-06-22 08:42:10.000000000","message":"commit message body is missing","commit_id":"024791940f73ccfa88c29ac552463ac26453b9e0"},{"author":{"_account_id":5689,"name":"Masayuki Igawa","email":"masayuki@igawa.io","username":"igawa"},"change_message_id":"1edf7bf82305cc911d0bff794ca17c1a6141b3d1","unresolved":false,"context_lines":[{"line_number":7,"context_line":"add test: list snapshots with param offset"},{"line_number":8,"context_line":""},{"line_number":9,"context_line":"\u0027offset\u0027 is the number of items to skip from the marker or"},{"line_number":10,"context_line":"from the first elemenet, default 0"},{"line_number":11,"context_line":""},{"line_number":12,"context_line":"Change-Id: Ib31978abe0127709ce1de2ef896f0ee1a045f08e"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":2,"id":"5f201791_20491530","line":10,"updated":"2017-06-27 08:05:50.000000000","message":"s/elemenet/element","commit_id":"6106faf3a045acf324e75afdaadbc170966c706b"}],"tempest/api/volume/test_volumes_snapshots_list.py":[{"author":{"_account_id":20190,"name":"zhufl","email":"zhu.fanglei@zte.com.cn","username":"zhufl"},"change_message_id":"b3ce50f1a2aa394163a0f90db994b4b2e9d0967b","unresolved":false,"context_lines":[{"line_number":159,"context_line":"        # should displayed."},{"line_number":160,"context_line":"        self.assertEqual(self.snapshot_id_list[:1], fetched_list_id)"},{"line_number":161,"context_line":""},{"line_number":162,"context_line":"    def _list_snapshots_by_param_offset(self, offset, expected_elements):"},{"line_number":163,"context_line":"        \"\"\"list snapshots by offset param\"\"\""},{"line_number":164,"context_line":"        # Get snapshots list using offset parameter"},{"line_number":165,"context_line":"        fetched_snap_list \u003d self.snapshots_client.list_snapshots("}],"source_content_type":"text/x-python","patch_set":1,"id":"5f201791_63730eb3","line":162,"range":{"start_line":162,"start_character":4,"end_line":162,"end_character":39},"updated":"2017-06-22 08:42:10.000000000","message":"no need to define a function that is used only once","commit_id":"024791940f73ccfa88c29ac552463ac26453b9e0"},{"author":{"_account_id":25065,"name":"Wang Xuguang","email":"xgwang5843@fiberhome.com","username":"sisyphuswxg"},"change_message_id":"c4df095ee471e201e710157de0e351e97dc21998","unresolved":false,"context_lines":[{"line_number":159,"context_line":"        # should displayed."},{"line_number":160,"context_line":"        self.assertEqual(self.snapshot_id_list[:1], fetched_list_id)"},{"line_number":161,"context_line":""},{"line_number":162,"context_line":"    def _list_snapshots_by_param_offset(self, offset, expected_elements):"},{"line_number":163,"context_line":"        \"\"\"list snapshots by offset param\"\"\""},{"line_number":164,"context_line":"        # Get snapshots list using offset parameter"},{"line_number":165,"context_line":"        fetched_snap_list \u003d self.snapshots_client.list_snapshots("}],"source_content_type":"text/x-python","patch_set":1,"id":"5f201791_2a7147aa","line":162,"range":{"start_line":162,"start_character":4,"end_line":162,"end_character":39},"in_reply_to":"5f201791_63730eb3","updated":"2017-06-26 08:54:00.000000000","message":"thanks for your advice, the next patch has fixed it . :-)","commit_id":"024791940f73ccfa88c29ac552463ac26453b9e0"},{"author":{"_account_id":5689,"name":"Masayuki Igawa","email":"masayuki@igawa.io","username":"igawa"},"change_message_id":"1edf7bf82305cc911d0bff794ca17c1a6141b3d1","unresolved":false,"context_lines":[{"line_number":162,"context_line":"    @decorators.idempotent_id(\u0027ba96d440-17c6-4e00-b0e8-52d3bb8a51d2\u0027)"},{"line_number":163,"context_line":"    def test_snapshot_list_param_offset(self):"},{"line_number":164,"context_line":"        \"\"\"list snapshots by offset param\"\"\""},{"line_number":165,"context_line":"        params \u003d {\u0027offset\u0027: 2}"},{"line_number":166,"context_line":"        fetched_snap_list \u003d self.snapshots_client.list_snapshots("},{"line_number":167,"context_line":"            **params)[\u0027snapshots\u0027]"},{"line_number":168,"context_line":"        # Verify the list of snapshots skip offset\u003d2 from the first"}],"source_content_type":"text/x-python","patch_set":2,"id":"5f201791_005299de","line":165,"updated":"2017-06-27 08:05:50.000000000","message":"I think \u0027offset\u0027 parameter is available from v3 officially[1][2]. So, I think we shouldn\u0027t use this parameter for v2 tests. Do I miss something?\n\n[1] https://developer.openstack.org/api-ref/block-storage/v2/index.html?expanded\u003dshow-host-details-detail,list-all-hosts-detail,list-snapshots-detail#hosts-extension-os-hosts\n[2] https://developer.openstack.org/api-ref/block-storage/v3/index.html?expanded\u003dlist-snapshots-and-details-detail,list-accessible-snapshots-detail","commit_id":"6106faf3a045acf324e75afdaadbc170966c706b"},{"author":{"_account_id":5689,"name":"Masayuki Igawa","email":"masayuki@igawa.io","username":"igawa"},"change_message_id":"75e094255c04dd52ab5f338b5f3f0d201d85e803","unresolved":false,"context_lines":[{"line_number":162,"context_line":"    @decorators.idempotent_id(\u0027ba96d440-17c6-4e00-b0e8-52d3bb8a51d2\u0027)"},{"line_number":163,"context_line":"    def test_snapshot_list_param_offset(self):"},{"line_number":164,"context_line":"        \"\"\"list snapshots by offset param\"\"\""},{"line_number":165,"context_line":"        params \u003d {\u0027offset\u0027: 2}"},{"line_number":166,"context_line":"        fetched_snap_list \u003d self.snapshots_client.list_snapshots("},{"line_number":167,"context_line":"            **params)[\u0027snapshots\u0027]"},{"line_number":168,"context_line":"        # Verify the list of snapshots skip offset\u003d2 from the first"}],"source_content_type":"text/x-python","patch_set":2,"id":"3f1d235d_bd35b1dc","line":165,"updated":"2017-07-03 02:56:59.000000000","message":"yeah, I understand this works in v2. But tempest is a stable api test suite. So, I don\u0027t want to add unstable/unofficial API tests to tempest.","commit_id":"6106faf3a045acf324e75afdaadbc170966c706b"},{"author":{"_account_id":25065,"name":"Wang Xuguang","email":"xgwang5843@fiberhome.com","username":"sisyphuswxg"},"change_message_id":"710600592b85cfe0f442b043d5fd61d91dbe21f4","unresolved":false,"context_lines":[{"line_number":162,"context_line":"    @decorators.idempotent_id(\u0027ba96d440-17c6-4e00-b0e8-52d3bb8a51d2\u0027)"},{"line_number":163,"context_line":"    def test_snapshot_list_param_offset(self):"},{"line_number":164,"context_line":"        \"\"\"list snapshots by offset param\"\"\""},{"line_number":165,"context_line":"        params \u003d {\u0027offset\u0027: 2}"},{"line_number":166,"context_line":"        fetched_snap_list \u003d self.snapshots_client.list_snapshots("},{"line_number":167,"context_line":"            **params)[\u0027snapshots\u0027]"},{"line_number":168,"context_line":"        # Verify the list of snapshots skip offset\u003d2 from the first"}],"source_content_type":"text/x-python","patch_set":2,"id":"3f1d235d_1384bf5d","line":165,"in_reply_to":"5f201791_005299de","updated":"2017-06-30 07:45:14.000000000","message":"thans for your advice, and sorry for the patch 3.\nI have verified this in my devstack environment, find that cinder had supported \u0027offset\u0027 parameter from v2 in fact.\nhere is the \u0027curl\u0027 request and response, please see: http://paste.openstack.org/show/614151/\n(in this case, I have created three snapshots, when listing with param \u0027offset\u003d2\u0027, I can see only one snapshot.)","commit_id":"6106faf3a045acf324e75afdaadbc170966c706b"},{"author":{"_account_id":23186,"name":"Felipe Monteiro","email":"felipe.carneiro.monteiro@gmail.com","username":"felipe.monteiro"},"change_message_id":"3972d89629099c124746a5dd12d869c0840c0c37","unresolved":false,"context_lines":[{"line_number":167,"context_line":"            **params)[\u0027snapshots\u0027]"},{"line_number":168,"context_line":"        # Verify the list of snapshots skip offset\u003d2 from the first"},{"line_number":169,"context_line":"        # element(total 3 elements), therefore only one snapshot should display"},{"line_number":170,"context_line":"        self.assertEqual(len(fetched_snap_list), 1)"}],"source_content_type":"text/x-python","patch_set":5,"id":"3f1d235d_671e83bb","line":170,"range":{"start_line":170,"start_character":25,"end_line":170,"end_character":50},"updated":"2017-06-30 15:06:32.000000000","message":"This should be assertEqual(expected, actual) or assertEqual(1, len(fetched_snap_list))","commit_id":"cd60699d85917a54ab14995e6488acda097ea348"},{"author":{"_account_id":25065,"name":"Wang Xuguang","email":"xgwang5843@fiberhome.com","username":"sisyphuswxg"},"change_message_id":"0d68ed5cd7ea7cf46eda7e86ddb56345ad816e2e","unresolved":false,"context_lines":[{"line_number":167,"context_line":"            **params)[\u0027snapshots\u0027]"},{"line_number":168,"context_line":"        # Verify the list of snapshots skip offset\u003d2 from the first"},{"line_number":169,"context_line":"        # element(total 3 elements), therefore only one snapshot should display"},{"line_number":170,"context_line":"        self.assertEqual(len(fetched_snap_list), 1)"}],"source_content_type":"text/x-python","patch_set":5,"id":"3f1d235d_91842e0e","line":170,"range":{"start_line":170,"start_character":25,"end_line":170,"end_character":50},"in_reply_to":"3f1d235d_671e83bb","updated":"2017-07-01 02:51:40.000000000","message":"Thanks for your reviewing :-), and the next patch had fixed it.","commit_id":"cd60699d85917a54ab14995e6488acda097ea348"}]}