)]}'
{"tempest/api/compute/servers/test_server_actions.py":[{"author":{"_account_id":20190,"name":"zhufl","email":"zhu.fanglei@zte.com.cn","username":"zhufl"},"change_message_id":"c9b8b7f457302bfe8df3ffbc6e0d0ba0f54f35f9","unresolved":false,"context_lines":[{"line_number":530,"context_line":""},{"line_number":531,"context_line":"        self.client.unshelve_server(self.server_id)"},{"line_number":532,"context_line":"        waiters.wait_for_server_status(self.client, self.server_id, \u0027ACTIVE\u0027)"},{"line_number":533,"context_line":"        if CONF.image_feature_enabled.api_v1:"},{"line_number":534,"context_line":"            glance_client \u003d self.os_primary.image_client"},{"line_number":535,"context_line":"        elif CONF.image_feature_enabled.api_v2:"},{"line_number":536,"context_line":"            glance_client \u003d self.os_primary.image_client_v2"}],"source_content_type":"text/x-python","patch_set":1,"id":"5f201791_f69be76f","line":533,"range":{"start_line":533,"start_character":8,"end_line":533,"end_character":45},"updated":"2017-06-27 09:04:36.000000000","message":"why using compute_images_client before unshelve in line#527, and using glance_client after unshelve?","commit_id":"efa14f64c5baf21a596ec0b858da399f0b5ae2e6"},{"author":{"_account_id":8556,"name":"Ghanshyam Maan","display_name":"Ghanshyam Maan","email":"gmaan.os14@gmail.com","username":"ghanshyam"},"change_message_id":"94aedda1c4e871fa660f98a722c4b3b163ab8ec3","unresolved":false,"context_lines":[{"line_number":530,"context_line":""},{"line_number":531,"context_line":"        self.client.unshelve_server(self.server_id)"},{"line_number":532,"context_line":"        waiters.wait_for_server_status(self.client, self.server_id, \u0027ACTIVE\u0027)"},{"line_number":533,"context_line":"        if CONF.image_feature_enabled.api_v1:"},{"line_number":534,"context_line":"            glance_client \u003d self.os_primary.image_client"},{"line_number":535,"context_line":"        elif CONF.image_feature_enabled.api_v2:"},{"line_number":536,"context_line":"            glance_client \u003d self.os_primary.image_client_v2"}],"source_content_type":"text/x-python","patch_set":1,"id":"5f201791_b961e0ab","line":533,"range":{"start_line":533,"start_character":8,"end_line":533,"end_character":45},"in_reply_to":"5f201791_f69be76f","updated":"2017-06-27 10:16:29.000000000","message":"humm, i do not want to use compute image client now onwards but i can change the old one also as this is same tests.","commit_id":"efa14f64c5baf21a596ec0b858da399f0b5ae2e6"},{"author":{"_account_id":6167,"name":"Ken\u0027ichi Ohmichi","email":"ken1ohmichi@gmail.com","username":"oomichi"},"change_message_id":"9b5d5c2a9edd11ef6f508f2cf7863ddb19280dbc","unresolved":false,"context_lines":[{"line_number":528,"context_line":"            glance_client \u003d self.os_primary.image_client"},{"line_number":529,"context_line":"            images \u003d glance_client.list_images("},{"line_number":530,"context_line":"                detail\u003dTrue, **params)[\u0027images\u0027]"},{"line_number":531,"context_line":"        elif CONF.image_feature_enabled.api_v2:"},{"line_number":532,"context_line":"            glance_client \u003d self.os_primary.image_client_v2"},{"line_number":533,"context_line":"            images \u003d glance_client.list_images(params)[\u0027images\u0027]"},{"line_number":534,"context_line":"        else:"}],"source_content_type":"text/x-python","patch_set":2,"id":"5f201791_7b24495e","line":531,"range":{"start_line":531,"start_character":8,"end_line":531,"end_character":47},"updated":"2017-06-27 18:04:44.000000000","message":"Glance v2 API is current and the v1 is deprecated.\nSo api_v2 condition should be used on first order.","commit_id":"4b22bfaf4eb7c072e00945bdd15a944851fe1d20"},{"author":{"_account_id":23186,"name":"Felipe Monteiro","email":"felipe.carneiro.monteiro@gmail.com","username":"felipe.monteiro"},"change_message_id":"55cf36d8d2d49373c8945877969a991adfb6c223","unresolved":false,"context_lines":[{"line_number":528,"context_line":"            glance_client \u003d self.os_primary.image_client"},{"line_number":529,"context_line":"            images \u003d glance_client.list_images("},{"line_number":530,"context_line":"                detail\u003dTrue, **params)[\u0027images\u0027]"},{"line_number":531,"context_line":"        elif CONF.image_feature_enabled.api_v2:"},{"line_number":532,"context_line":"            glance_client \u003d self.os_primary.image_client_v2"},{"line_number":533,"context_line":"            images \u003d glance_client.list_images(params)[\u0027images\u0027]"},{"line_number":534,"context_line":"        else:"}],"source_content_type":"text/x-python","patch_set":2,"id":"5f201791_be33ef61","line":531,"range":{"start_line":531,"start_character":8,"end_line":531,"end_character":47},"in_reply_to":"5f201791_7b24495e","updated":"2017-06-27 18:52:00.000000000","message":"IMO this should also be fixed in another commit because doing a grep for this in Tempest it is a pattern used by many current tests. Also needs to be fixed Patrole-side.","commit_id":"4b22bfaf4eb7c072e00945bdd15a944851fe1d20"},{"author":{"_account_id":8556,"name":"Ghanshyam Maan","display_name":"Ghanshyam Maan","email":"gmaan.os14@gmail.com","username":"ghanshyam"},"change_message_id":"814cf1de57ec306fae1b41a62ba0b4aaea351e9f","unresolved":false,"context_lines":[{"line_number":528,"context_line":"            glance_client \u003d self.os_primary.image_client"},{"line_number":529,"context_line":"            images \u003d glance_client.list_images("},{"line_number":530,"context_line":"                detail\u003dTrue, **params)[\u0027images\u0027]"},{"line_number":531,"context_line":"        elif CONF.image_feature_enabled.api_v2:"},{"line_number":532,"context_line":"            glance_client \u003d self.os_primary.image_client_v2"},{"line_number":533,"context_line":"            images \u003d glance_client.list_images(params)[\u0027images\u0027]"},{"line_number":534,"context_line":"        else:"}],"source_content_type":"text/x-python","patch_set":2,"id":"5f201791_87745fd0","line":531,"range":{"start_line":531,"start_character":8,"end_line":531,"end_character":47},"in_reply_to":"5f201791_be33ef61","updated":"2017-06-27 23:54:24.000000000","message":"yea but i like to wait for v1 API to go away instead of changing the order. May be after 1 cycle we will just have v2 API testing.\n\nBut anyways i can fix here but not worth to fix in other place or in patrole.","commit_id":"4b22bfaf4eb7c072e00945bdd15a944851fe1d20"},{"author":{"_account_id":20190,"name":"zhufl","email":"zhu.fanglei@zte.com.cn","username":"zhufl"},"change_message_id":"a92f99f4d9ec3fbb0852c090fd80207d337a6041","unresolved":false,"context_lines":[{"line_number":525,"context_line":"        server \u003d self.client.show_server(self.server_id)[\u0027server\u0027]"},{"line_number":526,"context_line":"        image_name \u003d server[\u0027name\u0027] + \u0027-shelved\u0027"},{"line_number":527,"context_line":"        params \u003d {\u0027name\u0027: image_name}"},{"line_number":528,"context_line":"        if CONF.image_feature_enabled.api_v2:"},{"line_number":529,"context_line":"            glance_client \u003d self.os_primary.image_client_v2"},{"line_number":530,"context_line":"            images \u003d glance_client.list_images(params)[\u0027images\u0027]"},{"line_number":531,"context_line":"        elif CONF.image_feature_enabled.api_v1:"},{"line_number":532,"context_line":"            glance_client \u003d self.os_primary.image_client"}],"source_content_type":"text/x-python","patch_set":4,"id":"5f201791_6bfb41c0","line":529,"range":{"start_line":528,"start_character":0,"end_line":529,"end_character":59},"updated":"2017-06-28 08:21:36.000000000","message":"shall we put getting glance_client before line #L522, just as test_create_backup do?","commit_id":"66223b6716547e74bd4dea391740f04f252bc679"},{"author":{"_account_id":20190,"name":"zhufl","email":"zhu.fanglei@zte.com.cn","username":"zhufl"},"change_message_id":"d59183229d57b30116a18f0e709d6e991337b93c","unresolved":false,"context_lines":[{"line_number":525,"context_line":"        server \u003d self.client.show_server(self.server_id)[\u0027server\u0027]"},{"line_number":526,"context_line":"        image_name \u003d server[\u0027name\u0027] + \u0027-shelved\u0027"},{"line_number":527,"context_line":"        params \u003d {\u0027name\u0027: image_name}"},{"line_number":528,"context_line":"        if CONF.image_feature_enabled.api_v2:"},{"line_number":529,"context_line":"            glance_client \u003d self.os_primary.image_client_v2"},{"line_number":530,"context_line":"            images \u003d glance_client.list_images(params)[\u0027images\u0027]"},{"line_number":531,"context_line":"        elif CONF.image_feature_enabled.api_v1:"},{"line_number":532,"context_line":"            glance_client \u003d self.os_primary.image_client"}],"source_content_type":"text/x-python","patch_set":4,"id":"5f201791_1eeab1ab","line":529,"range":{"start_line":528,"start_character":0,"end_line":529,"end_character":59},"in_reply_to":"5f201791_5898411a","updated":"2017-06-29 01:31:33.000000000","message":"That\u0027s true, but I think code logic is more important than code appearance:)","commit_id":"66223b6716547e74bd4dea391740f04f252bc679"},{"author":{"_account_id":8556,"name":"Ghanshyam Maan","display_name":"Ghanshyam Maan","email":"gmaan.os14@gmail.com","username":"ghanshyam"},"change_message_id":"471591c9f23d30c6ec226b98dfe40151a4cb40be","unresolved":false,"context_lines":[{"line_number":525,"context_line":"        server \u003d self.client.show_server(self.server_id)[\u0027server\u0027]"},{"line_number":526,"context_line":"        image_name \u003d server[\u0027name\u0027] + \u0027-shelved\u0027"},{"line_number":527,"context_line":"        params \u003d {\u0027name\u0027: image_name}"},{"line_number":528,"context_line":"        if CONF.image_feature_enabled.api_v2:"},{"line_number":529,"context_line":"            glance_client \u003d self.os_primary.image_client_v2"},{"line_number":530,"context_line":"            images \u003d glance_client.list_images(params)[\u0027images\u0027]"},{"line_number":531,"context_line":"        elif CONF.image_feature_enabled.api_v1:"},{"line_number":532,"context_line":"            glance_client \u003d self.os_primary.image_client"}],"source_content_type":"text/x-python","patch_set":4,"id":"5f201791_5898411a","line":529,"range":{"start_line":528,"start_character":0,"end_line":529,"end_character":59},"in_reply_to":"5f201791_6bfb41c0","updated":"2017-06-28 23:36:42.000000000","message":"that makes 2 if else condition (1 for glance_client and 2 for list) which i want to avoid.","commit_id":"66223b6716547e74bd4dea391740f04f252bc679"},{"author":{"_account_id":5689,"name":"Masayuki Igawa","email":"masayuki@igawa.io","username":"igawa"},"change_message_id":"59666f66667638bd16614f43198558bb62e35180","unresolved":false,"context_lines":[{"line_number":526,"context_line":"        else:"},{"line_number":527,"context_line":"            raise lib_exc.InvalidConfiguration("},{"line_number":528,"context_line":"                \u0027Either api_v1 or api_v2 must be True in \u0027"},{"line_number":529,"context_line":"                \u0027[image-feature-enabled].\u0027)"},{"line_number":530,"context_line":"        compute.shelve_server(self.client, self.server_id,"},{"line_number":531,"context_line":"                              force_shelve_offload\u003dTrue)"},{"line_number":532,"context_line":""}],"source_content_type":"text/x-python","patch_set":5,"id":"3f1d235d_fbe26001","line":529,"updated":"2017-06-29 09:22:41.000000000","message":"Or we can do like this (just check the configuration),\n\n  if not (CONF.image_feature_enabled.api_v1 or CONF.image_feature_enabled.api_v2):\n    raise lib_exec.InvalidConfiguration(\u0027....\u0027)\n\nand, set the glance_client after L.536.","commit_id":"43a40654f403237bc167d7b9d2edaf5a5188f147"},{"author":{"_account_id":8556,"name":"Ghanshyam Maan","display_name":"Ghanshyam Maan","email":"gmaan.os14@gmail.com","username":"ghanshyam"},"change_message_id":"02f4d8a957ee22357e9d096b5e3a1be0dda37c36","unresolved":false,"context_lines":[{"line_number":526,"context_line":"        else:"},{"line_number":527,"context_line":"            raise lib_exc.InvalidConfiguration("},{"line_number":528,"context_line":"                \u0027Either api_v1 or api_v2 must be True in \u0027"},{"line_number":529,"context_line":"                \u0027[image-feature-enabled].\u0027)"},{"line_number":530,"context_line":"        compute.shelve_server(self.client, self.server_id,"},{"line_number":531,"context_line":"                              force_shelve_offload\u003dTrue)"},{"line_number":532,"context_line":""}],"source_content_type":"text/x-python","patch_set":5,"id":"3f1d235d_0c1f0b6d","line":529,"in_reply_to":"3f1d235d_fbe26001","updated":"2017-06-30 02:18:51.000000000","message":"humm, honestly saying i like to do all together @L536 but as review comments of failing early we have to duplicate the if else.","commit_id":"43a40654f403237bc167d7b9d2edaf5a5188f147"}]}