)]}'
{"tempest/api/compute/floating_ips/test_list_floating_ips.py":[{"author":{"_account_id":6796,"name":"Giulio Fidente","email":"gfidente@redhat.com","username":"gfidente"},"change_message_id":"70604f289bf15f756394ab49e4dfd8816e443389","unresolved":false,"context_lines":[{"line_number":98,"context_line":"        # Positive test:Should return the list of floating IP Pools"},{"line_number":99,"context_line":"        resp, body \u003d self.client.list_floating_ip_pools()"},{"line_number":100,"context_line":"        self.assertEqual(200, resp.status)"},{"line_number":101,"context_line":"        floating_ip_pools \u003d body"},{"line_number":102,"context_line":"        self.assertNotEqual(0, len(floating_ip_pools),"},{"line_number":103,"context_line":"                            \"Expected floating IP Pools. Got zero.\")"},{"line_number":104,"context_line":""}],"source_content_type":"text/x-python","patch_set":2,"id":"AAAAS3%2F%2FkXU%3D","line":101,"updated":"2013-09-24 15:40:15.000000000","message":"I know it is only a minor issue but maybe you could assign the variable name straight to the response of list_floating_ip_pools","commit_id":"4c08e2773d5a25c7bfc8e0f075b9bf15e5ec95fe"},{"author":{"_account_id":7823,"name":"Xiang Hui","email":"xianghuir@gmail.com","username":"xianghui"},"change_message_id":"0979a956f95e58992237acc116c59b2c41c9137a","unresolved":false,"context_lines":[{"line_number":98,"context_line":"        # Positive test:Should return the list of floating IP Pools"},{"line_number":99,"context_line":"        resp, body \u003d self.client.list_floating_ip_pools()"},{"line_number":100,"context_line":"        self.assertEqual(200, resp.status)"},{"line_number":101,"context_line":"        floating_ip_pools \u003d body"},{"line_number":102,"context_line":"        self.assertNotEqual(0, len(floating_ip_pools),"},{"line_number":103,"context_line":"                            \"Expected floating IP Pools. Got zero.\")"},{"line_number":104,"context_line":""}],"source_content_type":"text/x-python","patch_set":2,"id":"AAAAS3%2F%2FiaA%3D","line":101,"in_reply_to":"AAAAS3%2F%2FkXU%3D","updated":"2013-09-25 02:23:49.000000000","message":"Done, thanks.","commit_id":"4c08e2773d5a25c7bfc8e0f075b9bf15e5ec95fe"},{"author":{"_account_id":5586,"name":"Ivan-Zhu","email":"zhubo198511@gmail.com","username":"ivan-zhu"},"change_message_id":"89a70364f0e12998b382c4baaf73e5bbf08c65c8","unresolved":false,"context_lines":[{"line_number":98,"context_line":"        # Positive test:Should return the list of floating IP Pools"},{"line_number":99,"context_line":"        resp, body \u003d self.client.list_floating_ip_pools()"},{"line_number":100,"context_line":"        self.assertEqual(200, resp.status)"},{"line_number":101,"context_line":"        list_floating_ip_pools \u003d body"},{"line_number":102,"context_line":"        self.assertNotEqual(0, len(list_floating_ip_pools),"},{"line_number":103,"context_line":"                            \"Expected floating IP Pools. Got zero.\")"},{"line_number":104,"context_line":""}],"source_content_type":"text/x-python","patch_set":3,"id":"AAAAS3%2F%2FhbY%3D","line":101,"updated":"2013-09-25 09:25:37.000000000","message":"why need list_floating_ip_pools?","commit_id":"dc9bab1e05cc04840e9e430a1ac064c7904953bd"},{"author":{"_account_id":7823,"name":"Xiang Hui","email":"xianghuir@gmail.com","username":"xianghui"},"change_message_id":"86a17c15ea2fa1eaab9fd94f5523f25ce431cc09","unresolved":false,"context_lines":[{"line_number":98,"context_line":"        # Positive test:Should return the list of floating IP Pools"},{"line_number":99,"context_line":"        resp, body \u003d self.client.list_floating_ip_pools()"},{"line_number":100,"context_line":"        self.assertEqual(200, resp.status)"},{"line_number":101,"context_line":"        list_floating_ip_pools \u003d body"},{"line_number":102,"context_line":"        self.assertNotEqual(0, len(list_floating_ip_pools),"},{"line_number":103,"context_line":"                            \"Expected floating IP Pools. Got zero.\")"},{"line_number":104,"context_line":""}],"source_content_type":"text/x-python","patch_set":3,"id":"AAAAS3%2F%2FhOg%3D","line":101,"in_reply_to":"AAAAS3%2F%2FhO8%3D","updated":"2013-09-25 10:29:37.000000000","message":"Great Thanks Giulio, sorry for losing your point before. : )","commit_id":"dc9bab1e05cc04840e9e430a1ac064c7904953bd"},{"author":{"_account_id":6796,"name":"Giulio Fidente","email":"gfidente@redhat.com","username":"gfidente"},"change_message_id":"18c16331b7ff45081048b96d4593b540e3132211","unresolved":false,"context_lines":[{"line_number":98,"context_line":"        # Positive test:Should return the list of floating IP Pools"},{"line_number":99,"context_line":"        resp, body \u003d self.client.list_floating_ip_pools()"},{"line_number":100,"context_line":"        self.assertEqual(200, resp.status)"},{"line_number":101,"context_line":"        list_floating_ip_pools \u003d body"},{"line_number":102,"context_line":"        self.assertNotEqual(0, len(list_floating_ip_pools),"},{"line_number":103,"context_line":"                            \"Expected floating IP Pools. Got zero.\")"},{"line_number":104,"context_line":""}],"source_content_type":"text/x-python","patch_set":3,"id":"AAAAS3%2F%2FhO8%3D","line":101,"in_reply_to":"AAAAS3%2F%2FhPg%3D","updated":"2013-09-25 10:23:21.000000000","message":"sure that is fine, you can keep the initial naming choice for the var","commit_id":"dc9bab1e05cc04840e9e430a1ac064c7904953bd"},{"author":{"_account_id":7823,"name":"Xiang Hui","email":"xianghuir@gmail.com","username":"xianghui"},"change_message_id":"2665b05800e9bd7d076219c86ef81dfbcf28b3a8","unresolved":false,"context_lines":[{"line_number":98,"context_line":"        # Positive test:Should return the list of floating IP Pools"},{"line_number":99,"context_line":"        resp, body \u003d self.client.list_floating_ip_pools()"},{"line_number":100,"context_line":"        self.assertEqual(200, resp.status)"},{"line_number":101,"context_line":"        list_floating_ip_pools \u003d body"},{"line_number":102,"context_line":"        self.assertNotEqual(0, len(list_floating_ip_pools),"},{"line_number":103,"context_line":"                            \"Expected floating IP Pools. Got zero.\")"},{"line_number":104,"context_line":""}],"source_content_type":"text/x-python","patch_set":3,"id":"AAAAS3%2F%2FhPg%3D","line":101,"in_reply_to":"AAAAS3%2F%2FhQU%3D","updated":"2013-09-25 10:18:45.000000000","message":"Thanks Giulio, just to be sure, is it ok to replace the \"body\" with \"floating_ip_pools\" and delete \"list_floating_ip_pools\" ?\n\nJust one variable store the list of floating ip pools.","commit_id":"dc9bab1e05cc04840e9e430a1ac064c7904953bd"},{"author":{"_account_id":6796,"name":"Giulio Fidente","email":"gfidente@redhat.com","username":"gfidente"},"change_message_id":"bcd445da0ab112118cc9f25476833a9ad4e399ab","unresolved":false,"context_lines":[{"line_number":98,"context_line":"        # Positive test:Should return the list of floating IP Pools"},{"line_number":99,"context_line":"        resp, body \u003d self.client.list_floating_ip_pools()"},{"line_number":100,"context_line":"        self.assertEqual(200, resp.status)"},{"line_number":101,"context_line":"        list_floating_ip_pools \u003d body"},{"line_number":102,"context_line":"        self.assertNotEqual(0, len(list_floating_ip_pools),"},{"line_number":103,"context_line":"                            \"Expected floating IP Pools. Got zero.\")"},{"line_number":104,"context_line":""}],"source_content_type":"text/x-python","patch_set":3,"id":"AAAAS3%2F%2FhQU%3D","line":101,"in_reply_to":"AAAAS3%2F%2Fhas%3D","updated":"2013-09-25 10:13:03.000000000","message":"Xiang, sorry about not being clear myself in my first inline comment but I meant to suggest the same that Ivan is saying and it goes as follows: regardless of the variable naming choice, instead of storing the results from .list_floating_ip_pools() in \u0027body\u0027 and later reassign it into a different variable, you could use a single variable and store the results in it on line 99","commit_id":"dc9bab1e05cc04840e9e430a1ac064c7904953bd"},{"author":{"_account_id":7823,"name":"Xiang Hui","email":"xianghuir@gmail.com","username":"xianghui"},"change_message_id":"120a1a0a8d97863b73281fc5a6d80e64f7108602","unresolved":false,"context_lines":[{"line_number":98,"context_line":"        # Positive test:Should return the list of floating IP Pools"},{"line_number":99,"context_line":"        resp, body \u003d self.client.list_floating_ip_pools()"},{"line_number":100,"context_line":"        self.assertEqual(200, resp.status)"},{"line_number":101,"context_line":"        list_floating_ip_pools \u003d body"},{"line_number":102,"context_line":"        self.assertNotEqual(0, len(list_floating_ip_pools),"},{"line_number":103,"context_line":"                            \"Expected floating IP Pools. Got zero.\")"},{"line_number":104,"context_line":""}],"source_content_type":"text/x-python","patch_set":3,"id":"AAAAS3%2F%2Fhas%3D","line":101,"in_reply_to":"AAAAS3%2F%2FhbY%3D","updated":"2013-09-25 09:28:07.000000000","message":"There\u0027s an extension \"os-floating-ip-pools\" in nova, and this patch is to test it, maybe I didn\u0027t get your point?","commit_id":"dc9bab1e05cc04840e9e430a1ac064c7904953bd"}]}