)]}'
{"/COMMIT_MSG":[{"author":{"_account_id":5689,"name":"Masayuki Igawa","email":"masayuki@igawa.io","username":"igawa"},"change_message_id":"a046842c3c1f5067466dbf3296a733a460f66fba","unresolved":false,"context_lines":[{"line_number":14,"context_line":""},{"line_number":15,"context_line":"In the new (Cinder V3.27) Attach API\u0027s we instead give a more"},{"line_number":16,"context_line":"accurate response, create an attachment record and mark the"},{"line_number":17,"context_line":"volume as \u0027reserved\u0027 until the Instance is unhselved at which"},{"line_number":18,"context_line":"time we complete the connection and move the volume to \u0027in-use\u0027."},{"line_number":19,"context_line":""},{"line_number":20,"context_line":"This patch modifes the volume_status waiter slightly so that it"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":5,"id":"3f1d235d_599fae5e","line":17,"updated":"2017-07-04 04:04:34.000000000","message":"Could you update the api doc[1] to avoid confusion in the future?\n[1] https://developer.openstack.org/api-ref/block-storage/v3/index.html#volumes-volumes","commit_id":"030dd17f5e0862384dec4c0b201d66f97074c5fb"},{"author":{"_account_id":11904,"name":"Sean McGinnis","email":"sean.mcginnis@gmail.com","username":"SeanM"},"change_message_id":"9066498ffc71216196e38d7237efe30fdda91ec0","unresolved":false,"context_lines":[{"line_number":14,"context_line":""},{"line_number":15,"context_line":"In the new (Cinder V3.27) Attach API\u0027s we instead give a more"},{"line_number":16,"context_line":"accurate response, create an attachment record and mark the"},{"line_number":17,"context_line":"volume as \u0027reserved\u0027 until the Instance is unhselved at which"},{"line_number":18,"context_line":"time we complete the connection and move the volume to \u0027in-use\u0027."},{"line_number":19,"context_line":""},{"line_number":20,"context_line":"This patch modifes the volume_status waiter slightly so that it"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":5,"id":"3f1d235d_a96449e5","line":17,"range":{"start_line":17,"start_character":43,"end_line":17,"end_character":52},"updated":"2017-07-03 12:02:15.000000000","message":"unshelved","commit_id":"030dd17f5e0862384dec4c0b201d66f97074c5fb"}],"tempest/api/compute/base.py":[{"author":{"_account_id":23186,"name":"Felipe Monteiro","email":"felipe.carneiro.monteiro@gmail.com","username":"felipe.monteiro"},"change_message_id":"293b79ed97a7c0e5dc4303e7f52d900554da0240","unresolved":false,"context_lines":[{"line_number":433,"context_line":"        :param volume: The volume to attach."},{"line_number":434,"context_line":"        :param device: Optional mountpoint for the attached volume. Note that"},{"line_number":435,"context_line":"            this is not guaranteed for all hypervisors and is not recommended."},{"line_number":436,"context_line":"        :param additional_status: Optional additional status to check for."},{"line_number":437,"context_line":"            This is to handle new Cinder attach where we more accurately"},{"line_number":438,"context_line":"            use \u0027reserved\u0027 for things like attaching to a shelved server."},{"line_number":439,"context_line":"        \"\"\""}],"source_content_type":"text/x-python","patch_set":2,"id":"5f201791_75d1c82f","line":436,"range":{"start_line":436,"start_character":15,"end_line":436,"end_character":32},"updated":"2017-06-28 22:21:05.000000000","message":"check_reserved","commit_id":"7909e4a5952e181b09e03d9f772c948bd6609808"},{"author":{"_account_id":2243,"name":"John Griffith","email":"john.griffith8@gmail.com","username":"john-griffith"},"change_message_id":"63447319b0432d4548460bd80f2df7874b0a1ab6","unresolved":false,"context_lines":[{"line_number":433,"context_line":"        :param volume: The volume to attach."},{"line_number":434,"context_line":"        :param device: Optional mountpoint for the attached volume. Note that"},{"line_number":435,"context_line":"            this is not guaranteed for all hypervisors and is not recommended."},{"line_number":436,"context_line":"        :param additional_status: Optional additional status to check for."},{"line_number":437,"context_line":"            This is to handle new Cinder attach where we more accurately"},{"line_number":438,"context_line":"            use \u0027reserved\u0027 for things like attaching to a shelved server."},{"line_number":439,"context_line":"        \"\"\""}],"source_content_type":"text/x-python","patch_set":2,"id":"3f1d235d_fc5fe40b","line":436,"range":{"start_line":436,"start_character":15,"end_line":436,"end_character":32},"in_reply_to":"5f201791_75d1c82f","updated":"2017-06-29 20:18:45.000000000","message":"Done","commit_id":"7909e4a5952e181b09e03d9f772c948bd6609808"}],"tempest/common/waiters.py":[{"author":{"_account_id":20190,"name":"zhufl","email":"zhu.fanglei@zte.com.cn","username":"zhufl"},"change_message_id":"ef9cd99b40dda5fd95ea9e5eb080795ddaf712ac","unresolved":false,"context_lines":[{"line_number":179,"context_line":"    raise lib_exc.TimeoutException(message)"},{"line_number":180,"context_line":""},{"line_number":181,"context_line":""},{"line_number":182,"context_line":"def wait_for_volume_resource_status(client, resource_id, statuses):"},{"line_number":183,"context_line":"    \"\"\"Waits for a volume resource to reach a given status."},{"line_number":184,"context_line":""},{"line_number":185,"context_line":"    This function is a common function for volume, snapshot and backup"}],"source_content_type":"text/x-python","patch_set":3,"id":"3f1d235d_32ffbc02","line":182,"range":{"start_line":182,"start_character":57,"end_line":182,"end_character":65},"updated":"2017-06-30 03:09:52.000000000","message":"statuses used to be a str, like \u0027in-use\u0027, and now it is a list, like [\u0027in-use\u0027, \u0027reserved\u0027], so now we will have something like\nif \u0027in-use\u0027 in \u0027in-use\u0027\ngenerally it can also work, but I think we\u0027d better not do so, e.g., we can:\n    if not isinstance(statuses, list):\n        statuses \u003d [statuses]","commit_id":"ac30f2f9084864f0fa278bba79c34d8f75882557"},{"author":{"_account_id":2243,"name":"John Griffith","email":"john.griffith8@gmail.com","username":"john-griffith"},"change_message_id":"5019d5b162682ca2f47a9688c9f8b74931a7bd23","unresolved":false,"context_lines":[{"line_number":179,"context_line":"    raise lib_exc.TimeoutException(message)"},{"line_number":180,"context_line":""},{"line_number":181,"context_line":""},{"line_number":182,"context_line":"def wait_for_volume_resource_status(client, resource_id, statuses):"},{"line_number":183,"context_line":"    \"\"\"Waits for a volume resource to reach a given status."},{"line_number":184,"context_line":""},{"line_number":185,"context_line":"    This function is a common function for volume, snapshot and backup"}],"source_content_type":"text/x-python","patch_set":3,"id":"3f1d235d_c562e83e","line":182,"range":{"start_line":182,"start_character":57,"end_line":182,"end_character":65},"in_reply_to":"3f1d235d_32ffbc02","updated":"2017-06-30 21:05:25.000000000","message":"Done","commit_id":"ac30f2f9084864f0fa278bba79c34d8f75882557"},{"author":{"_account_id":2243,"name":"John Griffith","email":"john.griffith8@gmail.com","username":"john-griffith"},"change_message_id":"e816c7ceba8c149c78137e350039c9ed1222af48","unresolved":false,"context_lines":[{"line_number":179,"context_line":"    raise lib_exc.TimeoutException(message)"},{"line_number":180,"context_line":""},{"line_number":181,"context_line":""},{"line_number":182,"context_line":"def wait_for_volume_resource_status(client, resource_id, statuses):"},{"line_number":183,"context_line":"    \"\"\"Waits for a volume resource to reach a given status."},{"line_number":184,"context_line":""},{"line_number":185,"context_line":"    This function is a common function for volume, snapshot and backup"}],"source_content_type":"text/x-python","patch_set":3,"id":"3f1d235d_857070a7","line":182,"range":{"start_line":182,"start_character":57,"end_line":182,"end_character":65},"in_reply_to":"3f1d235d_32ffbc02","updated":"2017-06-30 20:34:59.000000000","message":"Yeah, that makes sense; I figured update all the callers, but making it handle both is even better.  I\u0027ll rework that. Thanks","commit_id":"ac30f2f9084864f0fa278bba79c34d8f75882557"},{"author":{"_account_id":20190,"name":"zhufl","email":"zhu.fanglei@zte.com.cn","username":"zhufl"},"change_message_id":"ef9cd99b40dda5fd95ea9e5eb080795ddaf712ac","unresolved":false,"context_lines":[{"line_number":180,"context_line":""},{"line_number":181,"context_line":""},{"line_number":182,"context_line":"def wait_for_volume_resource_status(client, resource_id, statuses):"},{"line_number":183,"context_line":"    \"\"\"Waits for a volume resource to reach a given status."},{"line_number":184,"context_line":""},{"line_number":185,"context_line":"    This function is a common function for volume, snapshot and backup"},{"line_number":186,"context_line":"    resources. The function extracts the name of the desired resource from"}],"source_content_type":"text/x-python","patch_set":3,"id":"3f1d235d_6721f8fb","line":183,"range":{"start_line":183,"start_character":44,"end_line":183,"end_character":58},"updated":"2017-06-30 03:09:52.000000000","message":"this is not accurate","commit_id":"ac30f2f9084864f0fa278bba79c34d8f75882557"},{"author":{"_account_id":2243,"name":"John Griffith","email":"john.griffith8@gmail.com","username":"john-griffith"},"change_message_id":"5019d5b162682ca2f47a9688c9f8b74931a7bd23","unresolved":false,"context_lines":[{"line_number":180,"context_line":""},{"line_number":181,"context_line":""},{"line_number":182,"context_line":"def wait_for_volume_resource_status(client, resource_id, statuses):"},{"line_number":183,"context_line":"    \"\"\"Waits for a volume resource to reach a given status."},{"line_number":184,"context_line":""},{"line_number":185,"context_line":"    This function is a common function for volume, snapshot and backup"},{"line_number":186,"context_line":"    resources. The function extracts the name of the desired resource from"}],"source_content_type":"text/x-python","patch_set":3,"id":"3f1d235d_a565ac47","line":183,"range":{"start_line":183,"start_character":44,"end_line":183,"end_character":58},"in_reply_to":"3f1d235d_6721f8fb","updated":"2017-06-30 21:05:25.000000000","message":"Done","commit_id":"ac30f2f9084864f0fa278bba79c34d8f75882557"}]}