)]}'
{"/COMMIT_MSG":[{"author":{"_account_id":5689,"name":"Masayuki Igawa","email":"masayuki@igawa.io","username":"igawa"},"change_message_id":"6e31081c9dedc546047fadc89b2bcc98c681c291","unresolved":false,"context_lines":[{"line_number":6,"context_line":""},{"line_number":7,"context_line":"Add response assertions and remove unused variables in volume tests"},{"line_number":8,"context_line":""},{"line_number":9,"context_line":"This patch is to add response assertions where the response body is"},{"line_number":10,"context_line":"declared but never used in some volume api tests. And also some unused"},{"line_number":11,"context_line":"variables are removed to make code clean."},{"line_number":12,"context_line":""}],"source_content_type":"text/x-gerrit-commit-message","patch_set":1,"id":"3f1d235d_1579192e","line":9,"updated":"2017-07-03 06:32:06.000000000","message":"very nit: I prefer to s/is to add/adds. It\u0027s simple enough.","commit_id":"a618ea840d6248c04fb510130d8f3ccd0e85cd02"}],"tempest/api/volume/admin/test_volume_quotas.py":[{"author":{"_account_id":23186,"name":"Felipe Monteiro","email":"felipe.carneiro.monteiro@gmail.com","username":"felipe.monteiro"},"change_message_id":"a1240977c2c9660985dafef11d5b2b9b7122229d","unresolved":false,"context_lines":[{"line_number":155,"context_line":""},{"line_number":156,"context_line":"        # Accepts a volume transfer"},{"line_number":157,"context_line":"        self.alt_transfer_client.accept_volume_transfer("},{"line_number":158,"context_line":"            transfer_id, auth_key\u003dauth_key)[\u0027transfer\u0027]"},{"line_number":159,"context_line":""},{"line_number":160,"context_line":"        # Verify volume transferred is available"},{"line_number":161,"context_line":"        waiters.wait_for_volume_resource_status("}],"source_content_type":"text/x-python","patch_set":1,"id":"3f1d235d_27364b05","side":"PARENT","line":158,"range":{"start_line":158,"start_character":43,"end_line":158,"end_character":55},"updated":"2017-06-30 15:10:18.000000000","message":"Wondering whether this really needs to be removed.","commit_id":"02d23c4734a3d1734ba2ddf4ed02bd390b6eaa76"},{"author":{"_account_id":23081,"name":"Jeremy Zhang","email":"zhangjun_inspur@163.com","username":"jeremy.zhang"},"change_message_id":"f7d85e3936a1766e59970db99ce05067035963fb","unresolved":false,"context_lines":[{"line_number":155,"context_line":""},{"line_number":156,"context_line":"        # Accepts a volume transfer"},{"line_number":157,"context_line":"        self.alt_transfer_client.accept_volume_transfer("},{"line_number":158,"context_line":"            transfer_id, auth_key\u003dauth_key)[\u0027transfer\u0027]"},{"line_number":159,"context_line":""},{"line_number":160,"context_line":"        # Verify volume transferred is available"},{"line_number":161,"context_line":"        waiters.wait_for_volume_resource_status("}],"source_content_type":"text/x-python","patch_set":1,"id":"3f1d235d_71ae3299","side":"PARENT","line":158,"range":{"start_line":158,"start_character":43,"end_line":158,"end_character":55},"in_reply_to":"3f1d235d_27364b05","updated":"2017-07-01 02:47:04.000000000","message":"Thanks, Felipe.\nThe accept_volume_transfer API will be testd in test_volume_transfer.test_create_get_list_accept_volume_transfer(), so I think this can be removed.","commit_id":"02d23c4734a3d1734ba2ddf4ed02bd390b6eaa76"}],"tempest/api/volume/test_volume_transfers.py":[{"author":{"_account_id":5689,"name":"Masayuki Igawa","email":"masayuki@igawa.io","username":"igawa"},"change_message_id":"6e31081c9dedc546047fadc89b2bcc98c681c291","unresolved":false,"context_lines":[{"line_number":59,"context_line":"        # Accept a volume transfer by alt_tenant"},{"line_number":60,"context_line":"        body \u003d self.alt_client.accept_volume_transfer("},{"line_number":61,"context_line":"            transfer_id, auth_key\u003dauth_key)[\u0027transfer\u0027]"},{"line_number":62,"context_line":"        expected_attrs \u003d [\u0027id\u0027, \u0027name\u0027, \u0027links\u0027, \u0027volume_id\u0027]"},{"line_number":63,"context_line":"        for key in expected_attrs:"},{"line_number":64,"context_line":"            self.assertIn(key, body)"},{"line_number":65,"context_line":"        waiters.wait_for_volume_resource_status(self.alt_volumes_client,"}],"source_content_type":"text/x-python","patch_set":1,"id":"3f1d235d_f577bd39","line":62,"updated":"2017-07-03 06:32:06.000000000","message":"nit: I think we can specify the list for the \u0027for\u0027 loop directly.","commit_id":"a618ea840d6248c04fb510130d8f3ccd0e85cd02"}]}
