)]}'
{"tempest/lib/services/identity/v3/roles_client.py":[{"author":{"_account_id":23186,"name":"Felipe Monteiro","email":"felipe.carneiro.monteiro@gmail.com","username":"felipe.monteiro"},"change_message_id":"983bec6f74e66b4157815d085c7e69a96a9eb2bc","unresolved":false,"context_lines":[{"line_number":230,"context_line":"        \"\"\"Check a role inference rule.\"\"\""},{"line_number":231,"context_line":"        resp, body \u003d self.head(\u0027roles/%s/implies/%s\u0027 %"},{"line_number":232,"context_line":"                               (prior_role, implies_role))"},{"line_number":233,"context_line":"        # 200 is the correct one, but until it\u0027s not get fixed"},{"line_number":234,"context_line":"        # in all supported releases 204 will be accepted as well"},{"line_number":235,"context_line":"        self.expected_success([200, 204], resp.status)"},{"line_number":236,"context_line":"        return rest_client.ResponseBody(resp)"}],"source_content_type":"text/x-python","patch_set":2,"id":"3f1d235d_709cf05c","line":233,"range":{"start_line":233,"start_character":44,"end_line":233,"end_character":56},"updated":"2017-06-30 21:41:42.000000000","message":"it\u0027s","commit_id":"bb38940f2d8eb682f79d303ca684eff3b6f6f7b5"},{"author":{"_account_id":23186,"name":"Felipe Monteiro","email":"felipe.carneiro.monteiro@gmail.com","username":"felipe.monteiro"},"change_message_id":"c855c5f40b2f7a7e569d5238219ef07e0e63a18e","unresolved":false,"context_lines":[{"line_number":231,"context_line":"        resp, body \u003d self.head(\u0027roles/%s/implies/%s\u0027 %"},{"line_number":232,"context_line":"                               (prior_role, implies_role))"},{"line_number":233,"context_line":"        # 200 is the correct one, because it must be the same as for the GET"},{"line_number":234,"context_line":"        # method, but until it\u0027s get fixed in all supported releases"},{"line_number":235,"context_line":"        # the 204 will be accepted as well"},{"line_number":236,"context_line":"        self.expected_success([200, 204], resp.status)"},{"line_number":237,"context_line":"        return rest_client.ResponseBody(resp)"}],"source_content_type":"text/x-python","patch_set":3,"id":"3f1d235d_24ff6c68","line":234,"range":{"start_line":234,"start_character":28,"end_line":234,"end_character":42},"updated":"2017-07-10 15:14:02.000000000","message":"it\u0027s fixed\n\n\"it\u0027s get fixed\" which is actually \"it is get fixed\" is not correct English because you\u0027re using 2 verbs beside each other, which is always grammatically incorrect.","commit_id":"7edc1a686ee4636657facaf97757c3e55b60e6d4"},{"author":{"_account_id":1921,"name":"Andrea Frittoli","email":"andrea.frittoli@gmail.com","username":"andrea-frittoli"},"change_message_id":"e41fc4188be277358dae97693694a6e1482a3c9f","unresolved":false,"context_lines":[{"line_number":231,"context_line":"        resp, body \u003d self.head(\u0027roles/%s/implies/%s\u0027 %"},{"line_number":232,"context_line":"                               (prior_role, implies_role))"},{"line_number":233,"context_line":"        # 200 is the correct one, because it must be the same as for the GET"},{"line_number":234,"context_line":"        # method, but until it get fixed in all supported releases"},{"line_number":235,"context_line":"        # the 204 will be accepted as well"},{"line_number":236,"context_line":"        self.expected_success([200, 204], resp.status)"},{"line_number":237,"context_line":"        return rest_client.ResponseBody(resp)"},{"line_number":238,"context_line":""}],"source_content_type":"text/x-python","patch_set":4,"id":"3f1d235d_185a704f","line":235,"range":{"start_line":234,"start_character":18,"end_line":235,"end_character":42},"updated":"2017-07-11 13:02:26.000000000","message":"The problem with this approach is that it open the door to changing the return code in a non-discoverable way.\nI.e. if keystone now starts returning 200 in some version, Tempest won\u0027t complain about this - so we\u0027ll allow a backward incompatible change to go through.\n\nThe correct way would be to have a discoverable change on keystone side, e.g. in case of microversions we would have a different test on Temepest side to enforce new new error code in the microversion.\n\nNow since the code change is done by mod_wsgi and not by keystone we have no way of controlling this. I think the only way would be for a system that runs the version of mod_wsgi that breaks this to skip this test.\n\nThis way we keep the gate consistent.\nIf we plan to use that version of mod_wsgi in the gate, we need then to fix this on keystone side first.","commit_id":"3598f6e6ed2e338bd1b25819c20c4102d96f11c4"}]}